- 20 Dec, 2019 40 commits
-
-
Peter Kotwicz authored
This CL: - Moves logic to launch WebappActivity to test rule so that it does not get run on KitKat (both of the WebappActionsNotificationTest tests are M+) - Increases the timeout for WebappActivityTestRule#waitUntilSplashHides(). Hopefully this will reduce test failures due to WebappActivityTestRule#waitUntilSplashHides() timing out BUG=1031094 Change-Id: I8cc1cec080460f74b0282fb472e471f11872df6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977188Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726936}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2fad846c0b1c..c15afe488bfa git log 2fad846c0b1c..c15afe488bfa --date=short --first-parent --format='%ad %ae %s' 2019-12-20 reed@google.com move SkClipStack::asPath into PDFUtils 2019-12-20 michaelludwig@google.com Arenas struct for GrRecordingContext Created with: gclient setdep -r src/third_party/skia@c15afe488bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I4e2d3483939660923f0f3aada15fa80d97551a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726935}
-
Sajjad Mirza authored
On Windows it is possible for the coverage tryjob to compile a target that includes clang_coverage.cc but does not instrument any files. This causes a link-time failure, as clang_coverage.cc refers to __llvm_profile_dump, but with no instrumented files the compiler will not include the profile runtime library into the target. The symbol remains unresolved. To work around this, we can force coverage instrumentation for the clang_coverage.cc file itself, thus ensuring that any target that includes it will always have the profiling runtime pulled in. Bug: 990480 Change-Id: Ia6e1f003baaac4a050eec235942aa5a5e345ec52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978036 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#726934}
-
Tommy Li authored
This adds accessibility strings, just like the Tab Switch button has. It adds two PREFIX variants for when the button is focused. It doesn't add the SUFFIX variant, because so many suggestions have the removal feature, we don't want to be constantly announcing it. There are no screenshots because this is just a accessibility TTS announcement, with no graphical representation. Bug: 1036453, 1205 Change-Id: I0c2eac9fb2ba52e9ce01afa6e3e1d45f75bc0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979286Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#726933}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f58f69f66bac..2cb76ab598e5 git log f58f69f66bac..2cb76ab598e5 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 enga@chromium.org perf_tests: Manually serialize JSON and remove dependency on jsoncpp 2019-12-20 enga@chromium.org perf_tests: Fixup perf test result printing format 2019-12-20 bryan.bernhart@intel.com Support for small resource placement for MSAA textures. Created with: gclient setdep -r src/third_party/dawn@2cb76ab598e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib858cede3b9a8bb141316b742d131f38bdbc9d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979127Reviewed-by:
-
Vitaly Buka authored
We are going to need attribute outside of blink as well. Bug: 977230 Change-Id: I5417c56a0c4b5b99211ea74b0489e52ea19a5ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974951Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#726931}
-
Pavel Yatsuk authored
BUG=1033590 TBR=gambard@chromium.org Change-Id: I62d7d7ea2a35415cb787692c6afa5c7990f5157e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965971 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726930}
-
Yue Li authored
With the Assistant launcher UI and new shelf design feature turned on, if the Assistant is triggered in tablet mode the shelf style will be changed back to "home shelf". Added an additional check in ShelfConfig for the Assistant state to handle this case. Bug: 1026727 Test: Manual Test Change-Id: Ie9ca0980583117e5b17d21fa9257f91f3ebe5647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975114 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#726929}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/flags_ui/ Fixed: 1007691 Change-Id: I467a2c4866c6bd8498b4e74bfe31a81417f8d69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978818 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726928}
-
Andreas Haas authored
There is no user of this function anymore. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I093e96cbcc584495f176f1c53592e862ada98728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976470Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3cd4926..129defb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84511652dd5d1e62576d1ed7c92ba6f9a3559d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978420Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726926}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/2b02e3287584..2c5e3d4c9d60 $ git log 2b02e3287..2c5e3d4c9 --date=short --no-merges --format='%ad %ae %s' 2019-12-12 rwkeane DNS-SD: Add HardRefresh Support 2019-12-18 jophba Fix chrome build 2019-12-18 rwkeane mDNS: Batch Announce + Goodbye Records 2019-12-18 rwkeane mDNS: Probe Skeleton 2019-12-18 rwkeane mDNS: Add NSEC record type 2019-12-17 btolsch Add receiver authentication steps 2019-12-16 btolsch Fix gmock build dep 2019-12-10 jophba Update Receiver ownership 2019-12-16 rwkeane Discovery: CastV2 Struct 2019-12-16 rwkeane mDNS: Support Truncated (TC) Bit 2019-12-12 rwkeane mDNS: Add validation on incoming query results 2019-12-12 rwkeane DNS-SD: Add support for updating registrations 2019-12-11 rwkeane mDNS: Add Querier HardRefresh Support 2019-12-11 jophba Disable fuzzing in Chrome 2019-12-11 rwkeane Discovery: mDNS + DNS-SD API Skeletons required for discovery 2019-12-10 rwkeane mDNS: Publisher Impl - Announcement Flow 2019-12-04 jophba Add ANSWER message sending to ReceiverSession 2019-12-10 jophba Revert "Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain." 2019-12-09 miu Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain. 2019-12-06 jophba Remove Json(Reader|Writer) in favor of namespace 2019-12-05 miu Cleanup platform/BUILD.gn to mirror DEPS relationships. 2019-12-05 rwkeane mDNS: Responder Bug Fix 2019-12-05 rwkeane mDNS: Publisher Impl - Registration flow 2019-12-05 rwkeane mDNS: Responder Impl 2019-12-03 jophba Add ANSWER messaging 2019-12-05 btolsch Respond to post-commit virtual connection router comments 2019-12-04 miu Clean-up: Use Alarm::ScheduleFromNow() in a few places. Created with: roll-dep src/third_party/openscreen/src Change-Id: Id4150af44a9ae0d3f21b181a6699df54f3080352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977146 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726925}
-
Dave Tapuska authored
As per updated explainer changes restrict to same frame or noopener navigations. BUG=872777 Change-Id: I8a9fca087c767afaba26bd3cade28b3bbe0cc3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979004Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726924}
-
Eugene But authored
Bug: None Change-Id: Ib48589c9afe90c933a84706fdde04fc0e53095df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977180 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726923}
-
Ken MacKay authored
Merge-With: eureka-internal/347602 Change-Id: I233a619457718182aa27efe2875a7c3f2aea102a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977747Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#726922}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie7b7b6806f5d40baa6e1a4046911169859709aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979106Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#726921}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/47e7bed70800..efb804d60cd7 git log 47e7bed70800..efb804d60cd7 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 chonggu@google.com [Telemetry] Add Fuchsia device support. Created with: gclient setdep -r src/third_party/catapult@efb804d60cd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642 Tbr: nuskos@google.com Change-Id: I2debf26ffc9dffbf9965736c745b539f70f4eeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978152Reviewed-by:
-
Stephen Chenney authored
The new Graphics.Smoothness.Latency event reports the latency of each pipeline stage, along with flags for which frame sequences are active for the frame and whether the frame missed the deadline. The Viz breakdown is reported but not the Blink breakdown because the latter duplicates data found in the Blink.UpdateTime event (and shortly the frame sequence info will be added to Blink's event, if possible). Note that the event and sampling strategy has been designed to optimize the data quality for a given data volume. The UKM dashboard will have the latency info but not the frame sequence info because aggregated frame sequence type information is not useful. The sampling strategy mirrors that of Blink.UpdateTime because both potentially generate an event on every single frame, and we want to sensibly pick an informative set of frames within the available data volume. Note that the sampling rate is tuned in coordination with the UKM team. The UKM collection request has been approved here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 852482 Change-Id: Ie636446aa5726d797625caf264071b4af1572e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974331Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#726919}
-
Daniel Murphy authored
This web platform test ensures that indexes update correctly for cursors. If an implementation creates tombstones for index updates, then this should test that those tombstones are ignored. R=jsbell@chomium.org, pwnall@chromium.org Bug: 1033996 Change-Id: I07585d9ec065b1ad4f8b720efceaca0987984869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972579 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726918}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a16932a784b6..e10a22d68021 Created with: gclient setdep -r src-internal@e10a22d68021 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034098 Tbr: jbudorick@google.com Change-Id: I120ca23d5947c45f47d5aedba9b13dea0c4a0e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726917}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1a4f570b72f..f04938adfc40 git log b1a4f570b72f..f04938adfc40 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 lalitm@google.com Merge "perfetto: allow building metrics protos in Java using Android" Created with: gclient setdep -r src/third_party/perfetto@f04938adfc40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I290b5a5defff22c3f909615d7bf5dabbfdbcad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979118Reviewed-by:
-
Matthew Denton authored
This CL modifies nss_ocsp.* to separate out the parts interfacing with NSS and the parts using URLRequest/URLRequestContext. nss_ocsp.h defines an interface, OCSPRequestSessionDelegate, which is implemented in nss_ocsp_session_url_request.*. nss_ocsp.h also defines an interface, OCSPRequestSessionDelegateFactory, to create the OCSPRequestSessionDelegate's. The usual SetURLRequestContextForNSSHttpIO (now defined in nss_ocsp_session_url_request.*) still works--but now it will create a factory instance (OCSPRequestSessionDelegateURLRequestFactory, which stores the provided URLRequestContext) that exposes CreateOCSPRequestSessionDelegate, which will hand out instances of OCSPRequestSessionDelegateURLRequest. This factory is then set as the global OCSPRequestSessionDelegateFactory using the new SetOCSPRequestSessionDelegateFactory function defined by nss_ocsp.h. This should pave the way to being able to implement an OCSPRequestSessionDelegate with URLLoader in the browser process, instead of with URLRequest in the network process. The URLLoader version will implement its own OCSPRequestSessionDelegate and OCSPRequestSessionDelegateFactory classes and a different SetURLLoaderFactoryForNSSHTTPIO can be implemented. Also implements a max size on OCSP response bodies. There should be no actual behavioral change in this CL, except for the size limit on response bodies. Bug: 1015164 Change-Id: I46814d1532c907f72cc10a8fdc6f50c24d22dd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952202Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#726915}
-
Martin Barbella authored
These are leading to startup crashes in fuzzing builds. It can be re-enabled once those are fixed or suppressed. R=inferno@chromium.org Change-Id: Ie5c8320bdabfd389fa514d71981f8d10dd6b174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978899 Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726914}
-
Aaron Krajeski authored
This change was landed and reverted https://chromium-review.googlesource.com/c/chromium/src/+/1960469 We were flushing mid-draw and this was causing problems. Flush after DidDraw instead. Change-Id: I0d40c5f823014601203c84469749314add107e58 Bug: 1016727, 1015729, 1035865, 1035865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976501 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726913}
-
Brian Sheedy authored
Updates the golden images for the VR browser fullscreen video test. AA changed slightly, causing the play and fullscreen buttons to have a few differing pixels along their edges. TBR=alcooper@chromium.org Change-Id: I01ada1870aa8e94e65c42d9adeeb1202e7d35eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978897Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726912}
-
Kristi Park authored
As of https://crrev.com/c/1975110, this will no longer be used. Bug: 1024586 Change-Id: Ibd51ef128bd1b990268b4ce803abde7c8528b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976722 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726911}
-
Manas Verma authored
Moving UnmaskDetails struct to PaymentsClient, in order to be more consistent with other payments requests structs. Also changing `base::Value fido_request_options` to `base::Optional<base::Value> fido_request_options` Bug: 949269 Change-Id: I31742d5ecfcfa611d81b9061cb06a9ceea591551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972615Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#726910}
-
Wenbin Zhang authored
[benchmarking] disabling blink_perf.canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF for mac-10.12 We're seeing infra failures on mac-10.12 on waterfall. Both build 5800 and 5808 are failed by the same issue on the following story: blink_perf.canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF We need to disable it for now to keep waterfall running. NOTRY=true Bug: chromium:1036446 Change-Id: If8b234f6bb1d82ff15a702c1f481e40e7d7c5504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979266Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#726909}
-
Saman Sami authored
TearDownDisplayAndUnregisterRootFrameSink() performs a sync call to the GPU process and in the meantime a sync call arrives from the renderer that attempts to modify the FrameSink hierarchy and we get in a bad state. Always check that the root FrameSinkId is registered before attempting to add a child. Bug: 1030618 Change-Id: Ibb58dc65ef71ce9c4af063a0d255729d6a277124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976558Reviewed-by:
-
kylechar authored
It's not used after VizDisplayCompositor launched. Bug: 936425 Change-Id: I3cc7ad28be32b253bac18b86902248dc842a6da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976907Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726907}
-
Juanmi Huertas authored
Serializer: The enums have been renamed, but they have the very same functionality. Previously the kRGBA8 was effectively handled internally in CanvasColorParams as if it was Native, and the kForceRGBA8 was being handled as kRGBA8. This CL fixes the internal behavior of CanvasColorParams without needing a forceRGBA. Bug: 1021986 Change-Id: I32517a0455f41f05113304b95bb8a7d6fd593229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947546 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
David Benjamin authored
Set _LIBCPP_DEBUG=1 in release builds in addition to in debug builds if enable_iterator_debugging is set I added an is_debug gate to be consistent with the old (system STL) enable_iterator_debugging logic, which only enabled iterator debugging when both enable_iterator_debugging is set AND config("debug") is used. I suspect this is a remnant of back when our debug build automatically enabled libstdc++'s iterator debugging. Iterator debugging has long since been made off by default and, if we ever do want to enable it, GN can make defaults for settings depend on other settings. Thus make enable_iterator_debugging do what the name suggests and simply enable iterator debugging. In particular, adding iterator debugging adds a ton of code so asking the compiler to optimize that code makes testing things a bit more tractable. (I default to release + dcheck_always_on builds for local testing these days.) Bug: 923166 Change-Id: Ib9fe5d6ec7af1af644c86089c8f58b3c47058c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977153Reviewed-by: -
John Lee authored
This CL splits up tab_strip_ui.cc into multiple files, to separate UI and Handler code and to also add a header file for the Handler to allow for unit-testing. Change-Id: I992a78b3bd1bec555ecb207eee36841b40754e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977199Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#726904}
-
Bettina authored
Log the reused password account type of the Safe Browsing requests so that we can if any UNKNOWN account types slipped in. Bug: 1035941 Change-Id: I061a80b45d2f87756092c1fcfc8827ce1009491b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976279Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#726903}
-
Peter K. Lee authored
This feature has been default enabled for at least one release. Removing disabled code path and any tests associated with that. Removed translate_ui_egtest.mm because there's only one test and it tests kLanguageSettings in disabled state only. The test for accessibility for the Languages Settings is already in language_settings_egtest.mm Bug: 1008433 Change-Id: I227bcd257741af574078ea1a37de421c5c847197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974609 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b47eb188cc52..2fad846c0b1c git log b47eb188cc52..2fad846c0b1c --date=short --first-parent --format='%ad %ae %s' 2019-12-20 reed@google.com simplify asClipRgn to not rely on pathops Created with: gclient setdep -r src/third_party/skia@2fad846c0b1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: If9610684c8318575fafe537fd7f3b24a8f76e431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979117Reviewed-by:
-
Avery Musbach authored
After [1] has modified UpdateSplitViewDragIndicatorsWindowDraggingStates such that it calls ComputeWindowDraggingState only once instead of twice, UpdateSplitViewDragIndicatorsWindowDraggingStates can be simplified and can have only two parameters instead of four. Some of the calling code can then be simplified, especially in DragWindowFromShelfController::Drag. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1977155 Bug: 961171 Change-Id: I367502b9477fc749ea18fd24b23e3603caf9afe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978688Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#726900}
-
rbpotter authored
Removing showOsSettings, and code that is behind this boolean, from the browser settings about page: - Moving channel switcher dialog, detailed build info, and update warning dialog to the OS settings - Moving tests for these elements to OS settings - Since UI for updating Chrome is no longer reachable in browser settings on Chrome OS, removing Chrome OS specific pieces of this and moving the rest behind "if not chromeos" tags. Bug: 990170 Change-Id: Ied5104f8f7732cf759cc233a29c557273b9c32a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977737Reviewed-by:
-
Caleb Rouleau authored
Bug: 1035957 Change-Id: Ia1e5ac2001c8c165d9a70545ed12456ad577d75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978874 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#726898}
-
Aran Gilman authored
Bug: 1027612 Change-Id: I41a4123acfe3cb56b52466e37777945f70f70f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976299Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#726897}
-
