- 03 Jul, 2018 4 commits
-
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iebb2dea88b6e111893de79e86854d92dcd3932f8 Reviewed-on: https://chromium-review.googlesource.com/1123114Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#572054}
-
Miguel Casas authored
The original CL was reverted because BO_USE_HW_VIDEO_DECODER is not correctly handled in ARM platforms _for protected buffers_ (i.e. allocations coming from ARC++). crrev.com/c/1117606 added support for the flag on those platforms. CQ-DEPEND:1117025 TBR=dcastagna@chromium.org (no changes) Original CL ----------------------------------------------------------- This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a comment [1] in crrev.com/c/1021675. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147 Bug: 822346, 857095 Test: simplechrome video playback on nautilus, vaapi engaged. Change-Id: I1c11a8fffa662b69049d121ccb48ebfd85097228 Reviewed-on: https://chromium-review.googlesource.com/1104394Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1117025Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#572053}
-
Devlin Cronin authored
Adjust the runtime host permissions feature to withhold any host permission requested by the extension, rather than just the <all_urls> and all-hosts style permissions. Update browser and unit tests with the new expectations. Bug: 848448 Change-Id: I7c152d7a901bcb23515b6245dce94e1eedf756d7 Reviewed-on: https://chromium-review.googlesource.com/1083415Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572052}
-
Daniel Erat authored
Make PowerManagerClient notify its observers about ScreenDimImminent D-Bus signals from powerd, and expose a new method that calls powerd's DeferScreenDim D-Bus method. Bug: 854908 Change-Id: I28db70981ad44c6073db4ef90dd94180665012af Reviewed-on: https://chromium-review.googlesource.com/1123410Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572051}
-
- 02 Jul, 2018 36 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5155d38fdcd4..ef21d7e47963 git log 5155d38fdcd4..ef21d7e47963 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 timliang@google.com implement onreadpixels for metal gpu backend 2018-07-02 senorblanco@chromium.org GrTessellator: handle three consecutive collinear edges. 2018-07-02 timliang@google.com implemented wrapped backend texture/rendertarget/textureRT for Metal gpu backend 2018-07-02 halcanary@google.com Simplify GrGLInterface::abandon 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 0977edc92270..9d19e2abf000 (4 commits) 2018-07-02 brianosman@google.com Remove sRGB config checks based on color space 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 99b01c076f47..0977edc92270 (1 commits) Created with: gclient setdep -r src/third_party/skia@ef21d7e47963 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851409 TBR=ethannicholas@chromium.org Change-Id: Ib1d63293fa9961e041a34f0bad7b4f031e34689c Reviewed-on: https://chromium-review.googlesource.com/1123279Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572050}
-
Peter Kasting authored
Bug: 848412 Test: Open lots of tabs and shrink the window width. Tabs should be able to get narrow enough that only a center strip of the favicon is visible. Change-Id: Iccfe31adb06b9c922c619ae5436b611a876b82e0 Reviewed-on: https://chromium-review.googlesource.com/1121819 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#572049}
-
Robert Liao authored
This reverts commit cb05af1b. Reason for revert: Causes a DCHECK followed by a crash. http://crbug.com/859697 Original change's description: > IdentityManager: Add APIs for querying state of refresh tokens > > This CL adds APIs to IdentityManager for obtaining the set of all > accounts with refresh tokens and querying whether the primary account > is available with a refresh token. > > The design follows that of IdentityManager's caching of the primary > account information: > - IdentityManager initializes its state with the current state of > ProfileOAuth2TokenService. > - IdentityManager updates this state in response to notifications from > PO2TS that an account's refresh token was updated/removed. > > TBR=bsazonov@chromium.org > > Bug: 806774 > Change-Id: Idc4a37a15ced2e7d32f012a50e4e0d1fdb1aecdf > Reviewed-on: https://chromium-review.googlesource.com/1098668 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571451} TBR=blundell@chromium.org,msarda@chromium.org,sdefresne@chromium.org,treib@chromium.org,bsazonov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806774, 859697 Change-Id: I636d458101a5a579202dc4683faddfc0643cb19c Reviewed-on: https://chromium-review.googlesource.com/1123119Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572048}
-
Ryan Hamilton authored
Switch a LOG(DFATAL) to a QUIC_LOG(DFATAL) in net/third_party/quic/core/congestion_control/bandwidth_sampler.cc. Merge internal change: 203004418 Change-Id: I5562cc1f625d19d96ac9fbe4e489f74edcd61f11 Reviewed-on: https://chromium-review.googlesource.com/1123300Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572047}
-
Evan Stade authored
This relands commit 5f93deb6 Mash browser frame: port hosted app support and frame colors for hosted apps. The caption buttons are provided by Ash, but we need the menu button and content settings icons to be added by Chrome (there are lots of Chrome dependencies there). Thus most changes are in the browser side frame view, as opposed to //ash/frame/. Test app: https://airhorner.com/ (app menu > Install Airhorn) TBR=msw@chromium.org,jamescook@chromium.org,tsepez@chromium.org Bug: 854704 Change-Id: I7fc4402d6df7515db3e7d7e00d70ceaf0038d779 Reviewed-on: https://chromium-review.googlesource.com/1121961Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572046}
-
Yusuf Ozuysal authored
In cases where incognito is disabled due to a policy, we should not see the incognito switch button at all for horizontal tab switcher. This is in line with having the related menu item for incognito being disabled BUG=859160 Change-Id: I6bc19ce27fedc12fc18a9f91f5a7b433c7fb6c82 Reviewed-on: https://chromium-review.googlesource.com/1123405 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#572045}
-
Mina Almasry authored
The AV sync code needs a very accurate idea of the rate of playback of the audio to function properly. The current APIs get the PTS at the 'current' time, which is vulnerable to thread de-scheduling while the value is being measured. Instead, define a new API in the audio pipeline, which atomically returns the PTS at a timestamp. Bug: None Test: Manual Change-Id: I5c4148066f8293424e7b32f8fd6b5e66ea62e4d0 Reviewed-on: https://chromium-review.googlesource.com/1121591 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#572044}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9a3cbdede42367d8295aacffda69d3965379e942 Reviewed-on: https://chromium-review.googlesource.com/1121336Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#572043}
-
Justin Donnelly authored
I'm not sure this really solves the problem of the changing layout feeling weird, but it mitigates the issue while we continue to try things out. Bug: 853355 Change-Id: Ia40f49e4f4974ddee9e036d5bfeb3340bedd7c0d Reviewed-on: https://chromium-review.googlesource.com/1123336Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#572042}
-
Becca Hughes authored
CSS env() is shipping as part of the Display Cutout launch so we should update the flag to stable. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Fim-KmT08PE/LIHNNXALBAAJ BUG=848890 Change-Id: Ia193d4cb4ca30a7575b827712df17e2ccf30a383 Reviewed-on: https://chromium-review.googlesource.com/1122852 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#572041}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8384f5d76c3..c9b520351974 Created with: gclient setdep -r src-internal@c9b520351974 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/79493568 TBR=mmoss@chromium.org Change-Id: If4fa32eef850a20949b8544fe15ea05a631b5993 Reviewed-on: https://chromium-review.googlesource.com/1123278Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572040}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/61ff9b659a5b..555b41aebe00 git log 61ff9b659a5b..555b41aebe00 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tsepez@chromium.org Use std::vector<float> in cpdf_expintfunc.cpp 2018-07-02 thestig@chromium.org Access a span properly in DetectSRGB(). 2018-07-02 thestig@chromium.org Check for more integer overflows in CJBig2_TRDProc. 2018-07-02 tsepez@chromium.org Use std::vector in one more place in cpdf_colorspace.cpp Created with: gclient setdep -r src/third_party/pdfium@555b41aebe00 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:859284 TBR=dsinclair@chromium.org Change-Id: Icfb87ce79219363726143c02e70a8076b8b73241 Reviewed-on: https://chromium-review.googlesource.com/1123083Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572039}
-
Sidney San Martín authored
This fixes the PiP window not being draggable on Mac. Bug: 849983 Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 Reviewed-on: https://chromium-review.googlesource.com/1121145 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572038}
-
Ryan Hamilton authored
to reduce code diffs. Merge internal change: 202802052 Change-Id: Ic7efef75db703a55a0fe32ab8a01453792227674 Reviewed-on: https://chromium-review.googlesource.com/1121791 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Xiaochu Liu authored
I suspect throttling is preventing CUS from updating crostini. Add this temporary VLOG to confirm this. BUG=chromium:851151 TEST=None Change-Id: I505214071b9f39c4ab3f95e96d5183667901d853 Reviewed-on: https://chromium-review.googlesource.com/1123261 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572036}
-
Zhongyi Shi authored
QUIC Connection Migration V2: always block the packet writer when HandleWriteError retruns ERR_IO_PENDING. Bug: 859259 Change-Id: I24ccedddd21f1a566b56f41bee30395a88a53a45 Reviewed-on: https://chromium-review.googlesource.com/1121592Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572035}
-
Ryan Hamilton authored
Change-Id: Icdf11167b93cad6c516ab41fca794340dbac9be8 Reviewed-on: https://chromium-review.googlesource.com/1123231 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Xi Cheng authored
Now the profiler accepts an instance of a ProfileBuilder's subclass at construction. Therefore, the profiler is agnostic of the profile representation. Samples would not be stored by the profiler but instead provided to the ProfileBuilder's subclass to do with them as it chooses. This CL also changes CallStackProfileBuilder (originally named SamplingProfileBuilder) to implement this interface and moves it to call_stack_profile_builder.{h,cc}. Unit tests are added for this new class. In stack_sampling_profiler_unittest.cc, we introduce TestProfileBuilder which implements the interface. We also removed the CallStackProfile related operations from this test the StackSamplingProfiler no longer operates on CallStackProfiles. Bug: 851163 Change-Id: Ie044b65abb085012a2c25fef7744366aec5a1103 Reviewed-on: https://chromium-review.googlesource.com/1115509Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Jun Choi authored
Add MakeCredential operation to VirtualCtap2Device. VirtualCtap2Device only supports ES256 algorithm and provides packed attestation statement during registration. Bug: 829413 Change-Id: I70782952bdbb2f9f749bb27756a84a6bd37af46d Reviewed-on: https://chromium-review.googlesource.com/1115900 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572032}
-
Kim Paulhamus authored
The check is simply for https, not secure http. Change-Id: Ic7225b9b146c1c95270d9bac81c10092aac28018 Reviewed-on: https://chromium-review.googlesource.com/1120640 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572031}
-
Fritz Koenig authored
FramebufferAttachmentParameter better describes the group of parameters. FramebufferParameter will be reused later for FramebufferParameteri parameters. BUG=680851 Change-Id: I01ffbc5783163460b5ff54d8c7d1e5de044e333a Reviewed-on: https://chromium-review.googlesource.com/1117364Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#572030}
-
Becky Zhou authored
Add android:singleLine to buttons so that the sign-in account name and email is ellipsized by character. Bug: 859153 Change-Id: Ie9916b0c640edab4a6ca1418335a6086736775d3 Reviewed-on: https://chromium-review.googlesource.com/1123219 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572029}
-
Becca Hughes authored
The media controls are using env() which is causing pages using the media controls to record UseCounter metrics for env(). This CL silences the metrics if the TreeScope when resolving the variables is a UA shadow root. BUG=855739 Change-Id: I48a17e426511021e29d6ff6d4f5e535eafbd2b24 Reviewed-on: https://chromium-review.googlesource.com/1123299 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
to kLanguageEnabledImes{,Syncable}. Now these prefs can contain ARC IMEs that are not extension-based. Bug: 856405 Change-Id: I84c1f7fc963fac51099c48a2a2265ba9fdc89626 Reviewed-on: https://chromium-review.googlesource.com/1122021 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#572027}
-
sohan authored
This adds external GpuMemoryBuffer formats to ResourceFormat, currently this helps prevent redundant/misleading usage of formats in TransferableResource. BUG=836488 Change-Id: I6d7cb07b31d2fd307de1cac15fdb305351bfaf4a Reviewed-on: https://chromium-review.googlesource.com/1101678Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Nikhil Athreya authored
Adds a GetKeyboardBrightnessPercent method to the PowerManagerClient interface. This method was added in order to track keyboard energy consumption over time so that chrome://power could approximate power usage of other devices over time. keyboard brightness change as you increase and decrease your keyboard brightness. BUG: crbug.com/851767 TEST: Call this method inside Chrome on a Chrome OS device and see the Change-Id: I35323708da1e0bcc9b4549b85ad6e2d8ad215af5 Reviewed-on: https://chromium-review.googlesource.com/1120839Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Nikhil Athreya <nathreya@google.com> Cr-Commit-Position: refs/heads/master@{#572025}
-
Peter Kasting authored
The pre-refresh use of "endcap" isn't quite as clear in refresh, where tabs appear to start suddenly at a point that turns out to be halfway through the "endcap". Instead, restrict usage of GetTabEndcapWidth() (now renamed for parallelism with GetTabEndcapWidthForPainting()) to pre-refresh. In refresh, use GetCornerRadius(), whose relationship to the tab's appearance is more clear. This adds a new GetContentsInsets() static method as well, which allows decoupling the concept of the endcap width/corner radius from "how far into the tab bounds does content start", which is what a number of callers really care about. Removing dependencies on GetMinimumInactiveTabWidth() will be useful for allowing narrower tabs. Bug: none Change-Id: Ic749c4b3f1b2c3611db0fa4966d62513367aec51 Reviewed-on: https://chromium-review.googlesource.com/1121818Reviewed-by:
-
Yutaka Hirano authored
It's needed to workaround the DISALLOW_NEW_EXCEPT_PLACEMENT_NEW annotation for ResourceResponse, which is unproductive. This CL also adds some const qualifiers to express invariants. Bug: 570946 Change-Id: I05a13178253b66267ea91652f2f32636df98cbbb Reviewed-on: https://chromium-review.googlesource.com/1122142Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572023}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d01146f1679..312466a20450 git log 4d01146f1679..312466a20450 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 buildbot@webrtc.org Roll chromium_revision c2072685..a1981d69 (571826:571936) 2018-07-02 qingsi@google.com Add ADAPTER_TYPE_ANY in AdapterType. 2018-07-02 yinwa@webrtc.org In ULP FEC fuzzer test, make sure sequence number is not the same as previous sequence number. Created with: gclient setdep -r src/third_party/webrtc@312466a20450 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:859265 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe3ca6c450a7f021ed739daea306e9fc9f395562 Reviewed-on: https://chromium-review.googlesource.com/1123079Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572022}
-
spqchan authored
Test is flaky on Nexus 5X TBR=perezju@chromium.org Bug: 859500 Change-Id: Ide9926b503a4f2b7faeaba3791694cff69b0cf81 Reviewed-on: https://chromium-review.googlesource.com/1123260 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572021}
-
Peter Kasting authored
* During tab closure, don't modify whether the favicon is centered. This prevents the favicon from appearing to slide left at the very end of tab closure. * When closing a tab, keep its left edge pinned to the right edge of the previous tab (to the degree currently possible; this goes awry when closing multiple tabs, see comments in code), instead of closing it wherever it is. * When opening or closing a tab, make the narrowest width the overlap width instead of zero. This ensures the opened/closed tab animates its bounds at the same speed as the surrounding tabs. * When opening a tab, start with its left edge at the current right edge of the previous tab, instead of the ideal right edge. This way when a tab is opened to the right of an existing tab that's shrinking to give it room, the new tab appears to expand into the available space instead of being overlapped in a strange way. * In AnimateToIdealBounds(), skip any views already animating to their updated ideal bounds. This prevents hitches and discontiguous appearance when e.g. moving the mouse out of the strip while animating. Bug: none Change-Id: I8f87c9585dda778fafc53b8f38a7a475c107059b Reviewed-on: https://chromium-review.googlesource.com/1121793 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Stuart Langley authored
Some cleanup work for chrome/browser/chromeos/drive briging it in line with recomended practices/c++ modernization. - Use ThreadChecker macros. - s/DCHECK(!callback.is_null())/DCHECK(callback)/ Ths CL introduces no logic changes. Bug: 841659 Change-Id: I5a5784d2de7d8f1be0e6240414d7c64c921d3cff Reviewed-on: https://chromium-review.googlesource.com/1122029Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#572019}
-
Stuart Langley authored
$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-equals-default,modernize-use-emplace \ -header-filter= \ -fix chrome/browser/chromeos/drive $ git cl format No logic changes in this cl. Bug: 841659 Change-Id: Ie62dcf1cf34065d88cc31dfae481fbb7fa90ef9e Reviewed-on: https://chromium-review.googlesource.com/1122017Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b56a7a2a1a62..ce3f7b384d77 git log b56a7a2a1a62..ce3f7b384d77 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 oysteine@google.com Merge "Chrome: Export needed symbols to avoid direct external dependencies on protozero files" 2018-07-02 oysteine@google.com Chrome: Export needed symbols to avoid direct external dependencies on protozero files Created with: gclient setdep -r src/third_party/perfetto@ce3f7b384d77 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:78791178 TBR=perfetto-bugs@google.com Change-Id: I9762f57d69803411eca9b5bc6095bdfb05c0f0cf Reviewed-on: https://chromium-review.googlesource.com/1123277 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572017}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Also, this CL fixes unneeded usages of |retain_user_task| flag. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I04ab3df4e85cdf28ca2585f455f79ab9336f585e Reviewed-on: https://chromium-review.googlesource.com/1114560Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d38a2da9f150..605dd3126a6c git log d38a2da9f150..605dd3126a6c --date=short --no-merges --format='%ad %ae %s' 2018-07-02 dproy@chromium.org Format typescript with git cl format --js Created with: gclient setdep -r src/third_party/depot_tools@605dd3126a6c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I62ae3a741366ec348b4cf5e897bce3fd22dbdbc5 Reviewed-on: https://chromium-review.googlesource.com/1123078Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572015}
-
