- 22 May, 2019 40 commits
-
-
Yutaka Hirano authored
It seems many tests in http/tests/fetch are slow. Let's mark the following tests as slow in a consistent manner. - body-mixin.html and variants - stream-reader.html and variants - anything in thorough/ Bug: 874695, 948065 Change-Id: I72baa66fe79fe70edc3260c64936ae56e394f666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624072 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#662122}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb90cccb7dd1..afb8d5cdaead git log bb90cccb7dd1..afb8d5cdaead --date=short --no-merges --format='%ad %ae %s' 2019-05-22 asapersson@webrtc.org Log average decoded and rendered framerate for a VideoReceiveStream. Created with: gclient setdep -r src/third_party/webrtc@afb8d5cdaead The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I496dff961a101b827bda2efbd3d24d926dc8f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662121}
-
Matt Falkenhagen authored
In some tests, the DevToolsProxy can destruct after the UI thread shuts down, so PostTaskWithTraits crashes. Use a TaskRunner instead, which safely does nothing in that case. Bug: 963702 Change-Id: I46a1647a9cfddd25ca0354fc95d4cbc4b43211a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624074Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662120}
-
Ben Wells authored
This flag is enabled by default and is no longer needed. Bug: 965864 Change-Id: I512054e73a0e17f934b00862e7d41cacc1f3bcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624067 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#662119}
-
Luciano Pacheco authored
Follow up of CL:1619584 according to JS style guide [1] private fields shouldn't have trailing _. Renamed fields: * container_ * frame_ * title_ * text_ * closeButton_ * okButton_ * cancelButton_ Renamed methods: * initDom_ * onCotainerKeyDown_ [1] - https://google.github.io/styleguide/javascriptguide.xml?showone=Naming#Naming Change-Id: I67b622a6a8f07bfd6a201f4f8bb12f2fc13ab38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621774 Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#662118}
-
Matt Falkenhagen authored
DeleteVersion() was a function called when a service worker script couldn't be read from disk. To avoid a sticky state where in-scope URLs always fail to load, we remove the registration from storage and drop the active version as a controller of any clients. However it was trying to do a clever thing and allow any in-progress register jobs for that scope to continue as normal, and also try to keep the registration intact if there was a waiting version that wasn't broken. This was causing complexity and wasn't reliable as per the TODO in the code. It also wouldn't retain any user data attached to the registration. It's simpler to ignore these edge cases and simply always remove the registration. Bug: 964201 Change-Id: I2e08bb2cd9faf7ec071bf7ae63e40540933aa462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621473 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662117}
-
A Olsen authored
If the InSessionPasswordChange policy is enabled, and we have info that a user's SAML password is going to expire soon, then show a notification when they first log in, asking them to change their password. Still TODO: some UI polish, including making these notifications more sticky (right now they can always be dismissed easily, even if the password has expired or expiry is imminent). Bug: 930109 Change-Id: Ib147ed343ea18f7ed76bf3705a64c951c8786a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617459Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662116}
-
Yi Su authored
This CL moves all security-related headers into //ios/web/security and //ios/web/public/security, and updates headers inclusions. Bug: 942244 Change-Id: I85be2bbaf91d3b2fa84abb49694b70d4546b222b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621129 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662115}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I453bec48331cdbc203f96ccd3c99168f2f1734d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616937 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662114}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb8e1b25ad71..25b2980b6b19 git log fb8e1b25ad71..25b2980b6b19 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 47741f05043a..d9c00e1d2de1 (5 commits) Created with: gclient setdep -r src/third_party/angle@25b2980b6b19 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I8489769ea88b7f7c953159c324a66edfec7d94f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623031Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 965283 Change-Id: Ia8a959a8ed2d5423231001ea59957d09652caf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624007Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662112}
-
Hans Wennborg authored
When we switched to building clang from the monorepo, libfuzzer started pulling in libcxx and libcxxabi. It makes the binary larger, and more importantly, it doesn't build successfully on the ToT bots. TBR=thakis Bug: 897796 Change-Id: Ia54595c8295a3eb1874c2deb3c190b4ac860f4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624186Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#662111}
-
Sam Zackrisson authored
This CL does not change any functionality. Bug: webrtc:9878 Change-Id: I55309aea7db79d0c42d075b852bdb6b33b1d059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619812Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662110}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8908a37777ec..ccc89eec59f4 Created with: gclient setdep -r src-internal@ccc89eec59f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:947531 TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I2eccb8dcf9ed3bc5c0c0a2ec507d8647b8ea5628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662109}
-
Vasilii Sukhanov authored
for another frame. Additionally the CL adds unit tests for the class and removes unnecessary dependency on Autofill. Bug: 954196 Change-Id: I239eadf6d94f96460cf4efa2499d144a797f9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605912Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662108}
-
David Jean authored
Force a focus event (js) which will propagate back to the suggestions mediator who will update the suggestion bar. Applied to both Cancel and using suggested password. Removed call to completion when suggesting a password, because form filling is not complete, and we want the keyboard to stay (or come back) up. Bug: 964941 Change-Id: I31900792b0c3452913cb71c31a6c89b502a0b27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620640 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#662107}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/535dc1d8e2b7..05c11164f801 git log 535dc1d8e2b7..05c11164f801 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 benjhayden@chromium.org Add butterbars to V1 pages linking to V2SPA. Created with: gclient setdep -r src/third_party/catapult@05c11164f801 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=crouleau@google.com Change-Id: I50d998719d7bda3ae8d35fbc1a0c27b6f6b8e024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622464Reviewed-by:
-
Maya Lekova authored
This CL removes the await-optimization-flag, that is no longer needed, since the feature is considered web compatible. Intent to ship discussions: https://groups.google.com/forum/#!topic/v8-users/ML7gOgK8Dsg https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/74QxqINq4g0 Bug: v8:8267, chromium:893469 Change-Id: I308d38811bfac3a55392a1e07e99ce702f57a7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617517Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#662105}
-
Victor Hugo Vianna Silva authored
We introduce an interface for mapping a favicon's icon url to page url. We implement that interface in FaviconCache using information obtained from sessions sync. Bug: 955475 Change-Id: Idc3f31c686902cd673af7e84e36509e5dbe1f4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578567 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#662104}
-
Jinsong Fan authored
According to the context, [O] should be [Q]. Bug: None Change-Id: I76656315f8f388bebb794886974cb4cc08cf0e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624145Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#662103}
-
Ting Shao authored
Add ServiceWorkerRegisterJob::IsUpdateCheckNeeded() to control whether update check is needed. Bug: 648295 Change-Id: I4778ce87562fb73742e38bc652bd07485eedf67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608832Reviewed-by:
-
Ramin Halavati authored
OffTheRecordProfileImpl::GetProfileType() returns INCOGNITO_PROFILE regardless of being called on Guest sessions or regular sessions. Clarification comment is added to the code to explain why. Bug: 947933 Change-Id: Id73b0e06fdea7cf479018e1480675aac0ab5ac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619691Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#662101}
-
Alex Danilo authored
CL:1617041 changed the positioned elements in the directory tree to allow the eject button on removable items to be positioned at the width of the left hand pane in the FilesApp in cases where the content in the left pane allows horizontal scrolling to occur. The Polymer 'paper-ripple' on the tree rows uses its ancestor positioned element to calculate the bounds for clipping the ripple effect. The result is that the new ancestor is the entire tree and so the ripple escapes the bounds of the tree row. This CL reinstates position:relative onto the tree rows which is used by the Polymer paper-ripple element to contain the extent of the ripple effect. Bug: 965382 Change-Id: I47c07ef886d056a9b72dc161197e57d1bea3c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623649 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#662100}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8ab2a78853c..17ea5f8c844e git log b8ab2a78853c..17ea5f8c844e --date=short --no-merges --format='%ad %ae %s' 2019-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e8247a574956..fb8e1b25ad71 (6 commits) 2019-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 09fbfa7a..aacbdfe8 (446 commits) 2019-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e2844fa2744..f4d2a446cc12 (2 commits) Created with: gclient setdep -r src/third_party/skia@17ea5f8c844e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Iefb01592a3b89a491767a6ce3fa2c376c22ff641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622463Reviewed-by:
-
Ilia Samsonov authored
Move all TestLauncher Iteration and retry logic to one loop. This is a setup to later move launching tasks from the delegate to the launcher. Bug: 936248,936244 Change-Id: Id1f6750bc5f7b98f44312f191bdd6ab461faa48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621349 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662098}
-
Peter E Conn authored
Launch Intents from TWA notifications were launched with the FLAG_ACTIVITY_NEW_DOCUMENT flag. This resulted in a new Android Task being created if the Uri being launched did not match the Uri used to launch any of the existing Tasks. Since launching a TWA from the Android Launcher wouldn't include a Uri, this practically meant that opening a page from the notification would launch a new instance of the TWA. Bug: 965435 Change-Id: I0921e147d777a4c6320e17284be432bf9dab868e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621168Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#662097}
-
Hirokazu Honda authored
GpuArcVideoEncodeAccelerator doesn't initialize bitstream buffer id. The random number bitstream buffer id is passed to VEA::UseOutputBitstreamBuffer() at first and later will pass some middle number as a result of bit operation. Bitstream buffer id should be initialized by 0. This also set the inital value of |input_storage_type_| to kShmem. Bug: None Test: Confirm bitstream buffer id is 0 in VEA::UseOutputBitstreamBuffer(). Change-Id: I963230439bdd66e66d02d951c1bb38bbd94def94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623618 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#662096}
-
Wei-Yin Chen (陳威尹) authored
Add unit tests before tinkering around. Bug: 965580 Change-Id: I5739216e02f2f62012cfebc0283bb5279d07d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622645Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662095}
-
Yi Su authored
This CL moves CRWWebController.loadCancelled into CRWWKNavigationHandler and creates a new method in CRWWKNavigationHandlerDelegate to get CRWWebController._isHalted. Bug: 956511 Change-Id: Ib871d562351bca341a683b93735889e90322a5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620643 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c0c7e2f85bce..18672ef9941c git log c0c7e2f85bce..18672ef9941c --date=short --no-merges --format='%ad %ae %s' 2019-05-22 shaobo.yan@intel.com Fix MSVC compilation failure because of implicit conversions Created with: gclient setdep -r src/third_party/dawn@18672ef9941c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I4aa853ac198efd68d0080a018929d0e47ddc2375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622924Reviewed-by:
-
Pâris MEULEMAN authored
This fixes at least part of the "Flakiness": CL modifying the code introduced a real bug in the test, as it should not fail automatically within |onGetTokenFailure| and it should wait for the execution to complete. I ran the tests several times, both locally and on try bots without any failure. Bug: 962976 Change-Id: Id4b88380cfdaaa31445c8ae0ed74956f54ea17d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611993 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#662092}
-
Sam McNally authored
Also, prepare to pass the myfiles directory as a mount option, but don't actually send it yet - cros-disks isn't ready for it (and won't be until after DriveFS runs as chronos) so would log the unsupported mount option. Bug: 928157 Change-Id: I2d38df787fb12b0a50a063aa445dc6c7d2e23597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623617Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#662091}
-
Anand K. Mistry authored
No longer used. BUG=None Change-Id: Ia60ebe1042df3a37653ec736490834aceeebeff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623608 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
This test seems inherently slow and may be causing timeouts on Release bots. Bug: 962831 Change-Id: I4c605cce7daff64ffb4d76d508ee3dcc972a0fef Tbr: lowell@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624013Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#662089}
-
Alex Danilo authored
This CL changes the minimum width of the directory tree to 100% to ensure the focus highlight and separator lines take up the full width of the left pane in FilesApp. As part of CL:1599817 the directory tree width was changed using min-content to allow horizontal scrolling to take place. That in turn caused the calculated width to be the width of the content and that's used to draw the highlight and separator lines. So, if the content is shorter than the width of the left pane, the highlights, etc. are shortened. This CL sets the min-width to 100% which is derived from the ancestor positioned element, that is the dialog-navigation-list which makes it the full width of the left pane. Bug: 963383 Change-Id: I09619df5bdec17b03f10fcdee70496d5a24835d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623620Reviewed-by:
-
Hans Wennborg authored
The old SVN repository is expected to get turned off eventually, and this prepares our scripts for that. It also simplifies the build a little and gets rid of our dependency on SVN. This increases the size of the Linux package slightly due to http://llvm.org/PR41956 which will be investigated. Bug: 884608, 897796 Change-Id: I272cb2516bb99a6dc4643f32c42d6e852583174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615030 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662087}
-
Mitsuru Oshima authored
Bug: 801666 Test: all test passed Change-Id: Ib4530ab789dcc423e0941a8ae4d48b16b99bf034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617912 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#662086}
-
Matt Falkenhagen authored
To simplify the task types. kInternalWorker only had two uses, one of which was experimental. Change-Id: I5199741e11da43a7c94d4f69176f301e305e7f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623613Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662085}
-
Dale Curtis authored
Even though we'd like to stop earlier if an element isn't playing, we can't know if the page is waiting for canplaythrough, so we must buffer until that point so the event fires. This is a partial revert of d71061f0's behavior. We still handle play/pause at kReadyStateHaveMetaData, but unfortunately the preroll attempt is still needed. TODO: Instead of prerolling non-playing tags past metadata, we might instead signal kReadyStateHaveFutureData upon suspend to avoid wasting resources. TODO: Clearly this behavior is missing a test. :| BUG=879406 TBR=sandersd Change-Id: I967ab2c4f8297f8f2e7f9ea91dab7e04f9b88880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623668Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662084}
-
Jan Wilken Dörrie authored
This change adds support for mutable lambdas to base::BindLambdaForTesting. Since a mutable lambda might invalidate its state after being run once, the returned Callback is a base::OnceCallback instead of a base::RepeatingCallback. Bug: 789805 Change-Id: Ie8a1ffe2f8001ca7f75a9e3626638feb11c5c9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617452 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
