- 09 Mar, 2018 40 commits
-
-
Dominic Mazzoni authored
When the caret bounds are updated in RenderWidgetHostViewAura, we need to convert from DIP to screen pixels, just like in HWNDMessageHandler. TBR=kenrb@chromium.org Bug: 812892 Change-Id: I0797c5b2ed85349b85d90ac3fe5b2e4f21775fe0 Reviewed-on: https://chromium-review.googlesource.com/956540 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542187}
-
Calder Kitagawa authored
EquivalenceMap pruning in PruneEquivalencesAndSortBySource() and Prune() can truncate Equivalence size to 0. The previous logic was parsimonious in that it avoids moving an Equivalence's start boundary if its size was shrunken to 0. However, this is problematic. For example, truncating sorted Equivalences ********** ********* ** ****** yields ********** ** | <= Empty *** Note that now intervals are no longer sorted. This was an invariant property expected by the DCHECKS(). A better solution is to revert to etiennep@'s original implementation that moves start boundary of nullified Equivalences, and e.g., get: ********** ** | <= Empty *** Change-Id: I9b5d08cba88867ffff1df5592b91980136e2b331 Reviewed-on: https://chromium-review.googlesource.com/957202 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542186}
-
kristipark authored
Mac: Fix flaky NTP browser test where the expected NTP url changes depending on network connectivity If chrome://newtab/ maps to a remote url, it fails to load in a browser_test environment and instead redirects to the local NTP, which changes the url associated with WebContents. The NTP check in the app controller should be replaced once crbug.com/624410 is fixed. Bug: 817328 Change-Id: If17b93d3cafa194cfa5f433d3a422108a5181394 Reviewed-on: https://chromium-review.googlesource.com/954418 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542185}
-
Scott Violet authored
Using 'dispatch' is mildly confusing given the class doesn't really handle dispatch. BUG=none TEST=none Change-Id: I20f858d924d0a68efb2e449fd0ab3140ef5ffa54 Reviewed-on: https://chromium-review.googlesource.com/956496 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#542184}
-
Ahmed Fakhry authored
- Adjust the alignment of the avatar icon in Touchable Chrome to follow the specs. - Draw a circular 1px stroke around the avatar with the same color as that of the tab separator stroke. - Refactor and gather some common code. BUG=805267 Change-Id: I2be3181232cd43724f71b899de7905869b003360 Reviewed-on: https://chromium-review.googlesource.com/956809 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542183}
-
Jared Saul authored
Update waterfall testing config to remove AutofillUpstreamSendDetectedValues and AutofillGooglePayBranding field trials, as both are launched to 100% and enabled at ToT Change-Id: I1fa15d595bd0d593611f25d1edbbed7c0412b2f0 Reviewed-on: https://chromium-review.googlesource.com/956100Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#542182}
-
Ryan Landay authored
I have a series of CLs in progress to allow StackLayout to support more than two tab stacks. This CL contains easy generalizations (e.g. adding loops) of existing logic that currently assumes there will always be exactly two tab stacks. Updating the geometry logic is more involved, so I will do that in a separate CL. Bug: 648314 Change-Id: I8613cdd5ec345dfa868d992575c5d8d560ca5b04 Reviewed-on: https://chromium-review.googlesource.com/940570Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#542181}
-
Mark Pilgrim authored
update to https://chromium-review.googlesource.com/c/chromium/src/+/884063 Bug: 773295 Change-Id: Iba3ea07f19034bf9a1ea2c75876cac5d28297486 Reviewed-on: https://chromium-review.googlesource.com/956291Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542180}
-
David Reveman authored
Monitor the root window instead of the aura env to determine when frame sink holder must be cleaned up. It's too late to cleanup the holder when aura is being shutdown. Bug: 814908 Test: Close chrome while fast ink view is visible. Change-Id: Ia807c9469d791e4d8d4973711cf904592bc05471 Reviewed-on: https://chromium-review.googlesource.com/957222Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542179}
-
yiyix authored
Added the missing unit to metrics in Compositing.SurfaceAggregator.SurfaceDrawQuad.*. Bug: 814909 Change-Id: Id140c4ddf3cdfc606de6373c586273f7d3a9f144 Reviewed-on: https://chromium-review.googlesource.com/956885Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#542178}
-
Alex Moshchuk authored
The test recently starting timing out on the bots, most likely because it was taking too long. It might've become too slow after r529904 added more code to it (coverage for downloads). This CL breaks up the latter addition into its own test. Bug: 806684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183 Reviewed-on: https://chromium-review.googlesource.com/944570 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542177}
-
Elly Fong-Jones authored
3dfddc05 changed this interface but did not update the MacViews implementation. TBR=aleventhal@chromium.org Bug: None Change-Id: Ic71d4160b6ffe3b09cfcfafc9de9b175974a2054 Reviewed-on: https://chromium-review.googlesource.com/956844Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542176}
-
Yury Khmel authored
This shares rule that force ToS not to be shown Bug: b/74258485 Test: Manually Change-Id: I1f15e9a6edfc238cc03f6d086c5bd519eabb0bc3 Reviewed-on: https://chromium-review.googlesource.com/951979 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542175}
-
https://pdfium.googlesource.com/pdfium.git/+log/5a7e330ef5e0..3baef5c6daf5 $ git log 5a7e330ef..3baef5c6d --date=short --no-merges --format='%ad %ae %s' 2018-03-09 dsinclair Remove unused methods from CPDF_DefaultAppearance Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4dedb94b6a909cc2e752696e426e98163081524e Reviewed-on: https://chromium-review.googlesource.com/956691Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542174}
-
Chong Zhang authored
This CL: 1. Replaced |URLRequestInterceptor| usages with |embedded_test_server()| as the former is not supported in NetworkService. 2. Introduced |DownloadManager::Observer::OnDownloadDropped()| which is called when the download manager intercepted a download navigation but didn't create a download item. 3. Removed the following test cases from the filter: -DevToolsDownloadContentTest.MultiDownload -DevToolsDownloadContentTest.DefaultDownload -DevToolsDownloadContentTest.ResetDownloadState -DevToolsDownloadContentTest.DownloadCancelled -DevToolsDownloadContentTest.DeniedDownload -DevToolsDownloadContentTest.DefaultDownloadHeadless -DevToolsDownloadContentTest.SingleDownload Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9da96982ea8b5d0b4848f438a1f3a5bd8418dd72 Reviewed-on: https://chromium-review.googlesource.com/956560Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#542173}
-
Friedrich Horschig authored
The added function |waitForView| repeatedly checks all views in a group until either a view was found that matches the given matcher. If this doesn't happen within a certain time or multiple views are matched, it fails the test. This simplifies UI tests by: - reducing flakiness, e.g. introduced due to animations - removing the need for sleeps or other timers. - reducing code duplication due to providing a central implementation Upcoming CLs that would benefit greatly from this: https://crrev.com/c/951588 and https://crrev.com/c/951764 Change-Id: Ibb6a0dcd2eb688467c4af1eaa82341f84e7e8bc6 Reviewed-on: https://chromium-review.googlesource.com/951688 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542172}
-
Takuto Ikuta authored
The builder currently uses -j50, but it sometimes takes time on compile steps. https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable This CL increases -j from 50 to 150 for faster culprit CL detection by reducing compile step time. Change-Id: I035035e14d7a7192434a433f4d3c874b21c25def Reviewed-on: https://chromium-review.googlesource.com/954647 Commit-Queue: Shuotao Gao <stgao@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542171}
-
Lily Houghton authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/857421 NOPRESUBMIT=true TBR=boliu@chromium.org,mmenke@chromium.org,gene@chromium.org,halliwell@chromium.org,stevenjb@chromium.org,dougarnett@chromium.org,peter@chromium.org,sky@chromium.org,skyostil@chromium.org,eugenebut@chromium.org Bug: 613637 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6deaf5c511a2e5d9867c5d65715550881af8d010 Reviewed-on: https://chromium-review.googlesource.com/941901 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542170}
-
Gustav Sennton authored
We need some way for either side (android support library + chromium) of the webview support library to tell what features the other side of the support library supports. We do this by passing a list of integers across the boundary. These integers will each represent a feature (which will be defined in a class in the boundary interface package). Add a single feature to the list of features to support (visual state callback). Bug: 740082 Change-Id: I791af590cb846d536d01d63649ab6cfffe558ee9 Reviewed-on: https://chromium-review.googlesource.com/941805 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542169}
-
Geoff Lang authored
This matches the previous bots. BUG=811828 BUG=811794 BUG=811791 BUG=811823 BUG=811871 BUG=811830 BUG=812108 BUG=811867 BUG=811817 BUG=811800 BUG=811826 BUG=811833 BUG=811805 BUG=811824 BUG=811793 BUG=811868 BUG=811783 BUG=811818 BUG=811788 BUG=811784 TBR=jbudorick@chormium.org Change-Id: I665422d47731ab4a5379395be60f63a1dc92881f Reviewed-on: https://chromium-review.googlesource.com/957204Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542168}
-
Avi Drissman authored
It knows them already, and the case where it doesn’t doesn’t matter for this and we already plan on fixing it. BUG=718570 Change-Id: Ic9cc32a265cff867459ce031699c453fcbe7baf0 Reviewed-on: https://chromium-review.googlesource.com/956283Reviewed-by:
-
Chris Nardi authored
We assumed that the file separator would be dependent on the filesystem in the WPT manifest (so '\' on Windows), but the manifest always uses '/', no matter what the platform. Change this code to always split on '/'. This change also fixes a bug where WPT tests would not run under virtual test suites on Windows. Bug: 796424 Change-Id: Iea7466bc1208f9c8fd9938688c31029917944f77 Reviewed-on: https://chromium-review.googlesource.com/956662 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#542166}
-
Scott Violet authored
Prior to this a client could only be embeded once. This is because Embed() takes a WindowTreeClient and a pipe can only be used once (well, you could remove the pipe and supply it to embed again, but that effectively cancels the first embedding). This is the following sequence: 1. Client A requests a token from the server. 2. Client A hands the token to client B using some other mechanism. 3. Client B calls EmbedUsingToken with the token from client A. 4. The server notifies Client A it has a new embed point. BUG=none TEST=covered by tests Change-Id: I45ce155a759ae070a34897e515ca3fe0414d0167 Reviewed-on: https://chromium-review.googlesource.com/952092Reviewed-by:
-
wutao authored
We want to measure the latency between a key event to the time of the presentation of next UI frame. However, we do not save the time stamp in ui::Accelerator. This cl saves the time stamp information when ui::Accelerator is created from KeyEvent. Bug: 817116 Test: AcceleratorTest and AcceleratorStructTraitsTest Change-Id: If4812a491e16371cf32adae8d7074232dc3c05d8 Reviewed-on: https://chromium-review.googlesource.com/956526Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542164}
-
Ted Choc authored
BUG=817567 Change-Id: Ic9c599df1b2e3245b1d480cea29271c8d0f673a8 Reviewed-on: https://chromium-review.googlesource.com/956253Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#542163}
-
Tom Sepez authored
Controlled by --enable-features=PdfIsolation, default is off. Stricter than required (full origin, not eTLD+1). Add pdf_extension_test for multiple domains. A subsequent patch may attempt to apply this to secure origins only. Bug: 809614 Change-Id: Ic38c2c5074c7723210e38a754b930fb152c031b7 Reviewed-on: https://chromium-review.googlesource.com/953979Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2a27a19. With Chromium commits locally applied on WPT: 946e66a2 "Add http-state cookie tests from abart/http-state github repository" 61d26e9d "[PE] Add "image/apng" to supported image MIME types" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13522 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables TBR=foolip No-Export: true Change-Id: I09d96b1eb5f2c972c5aba12e1b0181564064ad24 Reviewed-on: https://chromium-review.googlesource.com/957128 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542161}
-
Daniel Erat authored
Update PowerManagerClient to listen for the new ScreenBrightnessChanged D-Bus signal emitted by powerd, which contains a protobuf and replaces the earlier BrightnessChanged signal. Also update Chrome to decode protobufs from KeyboardBrightnessChanged signals. Bug: 811138 Change-Id: If313801aa516850d904540736a2dee63bac7d6e7 Reviewed-on: https://chromium-review.googlesource.com/952578 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542160}
-
mrefaat authored
update comment in it returns a shallow copy of the configuration. WKWebViewConfigurationProvider: :GetWebViewConfiguration to indicate that Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I85286fec068683ebe923e53d3e39b7d852abf281 Reviewed-on: https://chromium-review.googlesource.com/956693Reviewed-by:
-
prasadv authored
Change-Id: Ic2443109057207e8c31f3747b92f3457cd68998c Reviewed-on: https://chromium-review.googlesource.com/956701Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Prasad Vuppalapu <prasadv@chromium.org> Cr-Commit-Position: refs/heads/master@{#542158}
-
Charles Harrison authored
Currently we copy hosts + other state for every outgoing request to the UI thread before doing per-WebContents aggregation there. This can involve a lot of copying of data around. This CL adds some initial per-frame aggregation beforehand to reduce this. Also, we add a browsertest for this functionality, since none previously existed. Bug: 813445 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I33438bdd5d4cab9caf3fcd07419fef3f7153935e Reviewed-on: https://chromium-review.googlesource.com/951743Reviewed-by:
-
John Abd-El-Malek authored
Bug: 706030 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I82f817cae6477e2e2bcbb44f266ae0956e55182a Reviewed-on: https://chromium-review.googlesource.com/956091Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542156}
-
Jose Dapena Paz authored
-Wcomment gives too many false positives in the case a backslash ended comment line is followed by a new line of comments: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61638 Bug: 819294 Change-Id: I3c809aa7ce9f232775b58d153d45d81ad27880e4 Reviewed-on: https://chromium-review.googlesource.com/944409Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#542155}
-
Patrick Monette authored
Bug: 819790 Change-Id: Ib5b1031bf23c211199693abcf614e0b9934214fb Reviewed-on: https://chromium-review.googlesource.com/952202Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#542154}
-
Stephen Chenney authored
The code that set the size of the container for the fallback image is using the missing image's style's width and height, setting it directly on the replaced container. But the style's sizes are zoomed while the replaced container style should be pre-zoom. Fix it. R=pdr@chromium.org BUG=813417 Change-Id: I230f45442dfbd5936e820633bcf85f387a0a82fb Reviewed-on: https://chromium-review.googlesource.com/956502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#542153}
-
Mohamed Heikal authored
Some resources listed in R.java start with a 0x01 prefix/package id. These resources should not have their package id rewritten when in webview mode. Change-Id: If3957c4bf2b5e34b5ceeb7589f7ca4e960cdd43f Reviewed-on: https://chromium-review.googlesource.com/952097Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542152}
-
rbpotter authored
Custom margins text boxes were incorrectly not accepting decimal inputs, due to a regression in delimiter value computation. Fix regression and add test. Bug: 819806 Change-Id: I73093bbd0193e388cfc29b92f5397e0b73a9f23d Reviewed-on: https://chromium-review.googlesource.com/954711 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#542151}
-
Hongchan Choi authored
This reverts commit a6bf420a. Reason for revert: Compilation error. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FAndroid_CFI%2F185%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout TBR=cjgrant Original change's description: > VR: Add initial UI sound support > > This change wires up button hover and click sounds, and adds them to the > asset structure. > > BUG=812026 > R=tiborg > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Iccf113e74663201c62aa220c7e134990369fd755 > Reviewed-on: https://chromium-review.googlesource.com/953962 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542109} TBR=vollick@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I76dc098547a55502b8d38a96320a55e48132ed05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812026 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955827Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542150}
-
Hongchan Choi authored
This reverts commit 83931b97. Reason for revert: Compilation failure https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/185 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I99aab2f842e064e34ff92cc29501aedc05164b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955828Reviewed-by:
-
Miguel Casas authored
This reverts commit e330bcb6. Reason for revert: typo forced using EGL VaapiPictures, bad! Original change's description: > vaapi: split VaapiDrmPicture into common and ozone/egl parts > > This CL splits VaapiDrmPicture into a common part named > VaapiPictureNativePixmap, and two subclasses, namely: > - VaapiPictureNativePixmapOzone, containing the current > #if defined(USE_OZONE) sandwiched parts, and > - VaapiPixtureNativePixmapEgl with the other parts. > > So the class tree should look like: > > +-----------------+ > | VaapiPicture | > +-----------------+ > ^ ^ > | +----+ > +--------------+ +------------------+ > | VaapiPicture | | VaapiPictureTFP | > | NativePixmap | | (existing on ToT)| > +--------------+ +------------------+ > ^ > +---------------+ > | | > +-------+ +-------+ > | VPNP | | VPNP | > | Ozone | | Egl | > +-------+ +-------+ > > The point here is to reduce the amount of if-defs to one single > point, the VaapiPictureFactory. > > BUILD.gn is changed to reflect that VaapiDrmPicture is > egl-specific (see bug, |use_egl| definition in [1]), while > VaapiDrmPictureOzone is |use_ozone| [2] specific. Note > that |use_egl| can coexist with |use_x11| [3]. > > This CL just moves code around, no new code introduced in > either vaapi_picture*.cc. > > [1] https://cs.chromium.org/chromium/src/ui/gl/features.gni?q=ui/gl/features.gni&sq=package:chromium&dr&l=16 > [2] https://cs.chromium.org/chromium/src/build/config/ui.gni?q=build/config/ui.gni&sq=package:chromium&dr&l=26 > [3] https://cs.chromium.org/chromium/src/build/config/ui.gni?type=cs&sq=package:chromium&l=47 > > Bug: 785201 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I67f6f4d994322ef7f23a8ed255405963a4be0152 > Reviewed-on: https://chromium-review.googlesource.com/951928 > Reviewed-by: Julien Isorce <julien.isorce@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542107} TBR=posciak@chromium.org,kcwu@chromium.org,mcasas@chromium.org,chcunningham@chromium.org,acourbot@chromium.org,julien.isorce@chromium.org Change-Id: If5103a891bcf6f758feea44cc514503457f00fbc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785201 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/957322Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#542148}
-
