- 30 Jun, 2020 40 commits
-
-
Parastoo Geranmayeh authored
This reverts commit b7a33c21. Reason for revert: possibly causing crbug/1100914 Original change's description: > [WebLayer] Reuse Chrome's InfoBarWrapper.java > > This CL eliminates //weblayer's copy of chrome's InfoBarWrapper.java in > favor of directly using the latter now that it has been componentized. > There were no substantive changes introduced in //weblayer and no > behavioral changes. > > Bug: 1099169 > Change-Id: Ie9cc819f17ce30bb66085cb05040ce11696725ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270554 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783894} TBR=blundell@chromium.org,cduvall@chromium.org Change-Id: I5f0fbec56bae167ccfb54ca9d9fd4b5f3fdf25ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276312Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#783980}
-
Clark DuVall authored
A couple changes need to be made to support using the Mirror protocol in WebLayer: - a new "source" attribute is added to the header, which can identify if the request is coming from Chrome or WebLayer. - a force_account_consistency param is added to AppendOrRemoveMirrorRequestHeader, so we can make sure the header is added even when the gaia ID is not available. This is important because WebLayer may need to enable account consistency for signed out users. Bug: 1054160 Change-Id: I4f4306a77b360212561e03e7e813809075dc2b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274958 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#783979}
-
Stephan Hartmann authored
Bug: 819294 Change-Id: Iae844f8b6cf6bba879cb320c95ebf88f65e1385f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273161Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#783978}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8e0ed04ad9663f3faac8eb6e0029dd0cac0432a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783977}
-
Brett Kilty authored
Add support for internal builds of non-standard android similar to is_android_things, but not including changes specific to that platform build. For use mainly in internal but also to generalize a few non-internal current uses. Bug: n/a Test: build, initial use in internal Change-Id: I17099b61a34f020142008f25d5df05d68f653c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275368 Auto-Submit: Brett Kilty <brettk@google.com> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#783976}
-
Francois Doray authored
With this CL, ObserverListThreadSafe::AddObserver DCHECKs instead of doing nothing when invoked from a context where SequencedTaskRunnerHandle is not set. A DCHECK ensures that the developer will notice the problem. The constructor of MemoryPressureListener is modified to skip calling ObserverListThreadSafe::AddObserver when invoked from a context where SequencedTaskRunnerHandle is not set. This is equivalent to the old behavior, where the call to ObserverListThreadSafe::AddObserver did nothing in that context. In a separate CLs, MemoryPressureListener will be modify to DCHECK if constructed in a context where SequencedTaskRunnerHandle is not set. Bug: 1063868 Change-Id: I06c8ead393cd3a86208922eaa68068a10a0cb2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135866Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#783975}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/90f1d6ab5865..8f4251a70801 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2297 from ben-clayton/fpic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I9d01b534e189546dc481a2c07655d451af18c492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276160Reviewed-by:
-
Brandon Goddard authored
This CL adds an enumerated histogram for tracking changes to overlay settings for CSS Grid in the devtools. corresponding devtools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2261233 Change-Id: If65de5ecb6638ee54edd1e25a4a708e7ba9577df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261137 Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#783973}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 This patches list all the potential accesses to be checked and reported. The CrossOriginOpenerPolicyReporter is preparing itself to install all the CoopAccessMonitor to the renderer(s), but It doesn't send them for now. To write a meaningful patch, this will need accesses to COOP-Report-Only headers and the virtual browsing context group. Explainer [WIP]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md Specification [WIP]: https://github.com/whatwg/html/pull/5518 Tests [WIP]: https://wpt.fyi/results/html/cross-origin-opener-policy/access-reporting Doc [WIP]: https://docs.google.com/document/d/1H8Be0w27fKPXKqyuJj9oEqIJEjB9Rw5AP3x-w-Fx2Zg/edit?usp=sharing Bug: chromium:1090273 Change-Id: I5d4c613a671f99ba15b4b174431d8d3ddeaa44c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264294Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#783972}
-
Steven Bennetts authored
Currently debugd provides network-devices, network-services, and network-status entries in feedback reports. This CL replaces those entries with network_devices and network_services to address the following issues: * Less redundancy (network-status is a superset of the others and relies on Shill specific C++ code in debugd that we would like to deprecate). * Smarter PII filtering for 'Name' and 'Address' fields * Proper PII filtering of UIData * IPConfigs information embedded in network_services. Currently it only exists in network-status which we want to deprecate. * Change the format of network_{devices|services} to JSON for easier parsing in tools (e.g. Shill Log Processor). This CL also updates the fake shill manager client to update the Manager.Services property as well (which only includes visible services). Bug: 967800 Change-Id: I3d4b7ba287ce02ddda6da4a4984396c2754a208d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229330Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783971}
-
Shengfa Lin authored
Disable base::Bind/base::Callback with no {Once,Repeating} for //chrome/app This CL follows up chromium:1007634 to prevent regression by removing chrome/app in _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK list Bug: 1007646 Change-Id: I1d771495a2988ccd75f2877cdfedb85974753f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273618 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#783970}
-
Steven Bingler authored
Convert the static class EnterpriseInfo into a singleton. Add unit tests. Bug: 1085168, 1099271 Change-Id: Ia073bcea30ba84e5453e3bbae2079a71f495c119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272866 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783969}
-
Francois Doray authored
This CL adds SimTests that run actual Javascript code to ensure that intensive timer throttling works as expected. Bug: 1075553 Change-Id: I6276f23bc8094a209905bfdf3c1bf1817e2716e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254082 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Oliver Li <olivierli@google.com> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#783968}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40fe30407ee7b50d28142d1eb36a92dd60937714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275349Reviewed-by:
-
Guillaume Jenkins authored
Moves ReportUploader and its unit tests to components/enterprise so it can be reused by iOS code. Bug: 1091921 Change-Id: I425c587a45c8f25d12c16303a2731b6ac53ad158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274582Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#783966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76c4224b..d55c3eec Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I35273a4b369c4de93f7b27a9455e85e81840c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274489Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783965}
-
ckitagawa authored
import os was missing from the update_bad_message_reasons.py script. As a result, the script couldn't be run. This CL also re-runs the script to update enums.xml to match the expected output. Bug: 1100896 Change-Id: Ie68ace96de6201505cf81adf6bdb52672699b53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275485Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#783964}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/15131138169a..62f7f26355fd 2020-06-30 treehugger-gerrit@google.com Merge "tp: add script to serialize test python/textproto traces" 2020-06-30 treehugger-gerrit@google.com Merge "TraceProcessor: Add binary RPC interface" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36fb455c0dba690bb17fb6aa24c2bcd8b242870a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276156Reviewed-by:
-
Miriam Polzer authored
In order to restore the enrollment state after rollback, the oobe flow needs to execute the enrollment screen. Currently, this is not happening because the fact that a rollback took place is not read from the oobe configuration. Reading the correct flag is added in two places: To recover the enrollment and to restart chrome afterwards in order to get the device policies. Bug: 1093928 Change-Id: Ib463dae4b1ac29e7f2ab870ae3b839f2018e11e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273159Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#783962}
-
Steven Bennetts authored
This is a straightforward substitution of C++ code, it does not migrate the ONC property. Bug: 1099902 Change-Id: I02d0585f67ddfca2e313f1eed159a87be05a970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270999Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
kylechar authored
SkiaCopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame has been flaky since https://crrev.com/c/2256225 landed. This change made it so that CopyOutputResults were serialized on worker threads, which breaks the ordering the test expects. Switch to using the test main thread to run the result callbacks to remove data race on |dummy_ran|. Bug: 1100421 Change-Id: Id19df859ed6af48cce85c16689122fa33e171184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274257 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783960}
-
Charlie Hu authored
Add flags for the work of renaming Feature Policy as Permissions Policy The rename discussion was at https://github.com/w3c/webappsec-feature-policy/issues/359. The PR that made the actual changes was https://github.com/w3c/webappsec-feature-policy/pull/379 committed as https://github.com/w3c/webappsec-feature-policy/commit/14898d1f7029fc3776413244f0852f2541fa8305. Enable this in Chrome with --enable-features=PermissionsPolicyHeader Bug: 1095641 Change-Id: Iccb6114bfeddb219e2cfe1a788d530dbcd8ba179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246870Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#783959}
-
Greg Daniel authored
This removes the need to set kNone for the backend access on each flush as well as add some uses of the default flush() call instead of passing in empty GrFlushInfo. Change-Id: I65717f8f7b5d51d6a6c18f9a3e548b5b335bda49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276171Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#783958}
-
Adrian Taylor authored
A previous commit did part of the job; this finishes it. Bug: 899208 Change-Id: I174cc64515be0dc01ea17da45915386a4ecdf88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274462Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#783957}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98a51fde05e8..a52834d8184b 2020-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d8b1aa1c3830 to 7c1434b8ea35 (19 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I86e9081a4d0da65c66208fe22eca2d628185950e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276153Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 0807627a. Reason for revert: Test failing on device. See crbug.com/1100917. Original change's description: > Re-enable GaiaAuthFetcherIOSNSURLSessionBridgeTest tests > > This CL updates the tests in GaiaAuthFetcherIOSNSURLSessionBridgeTest > suite to wait for the the NSURLDataTask to be resumed before continuing. > > Bug: 1065349 > Change-Id: I347069235fd86c51454cf705f733b5219e69151b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273058 > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783899} TBR=msarda@chromium.org,jlebel@chromium.org Change-Id: Ic0fae81dba5ec032c73a59552ac900e8f9f34b07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275960Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#783955}
-
Yi Gu authored
This patch applies the same check in WorkletAnimation as in Animation to avoid null-deref read. Bug: 1100031 Change-Id: I92e0fc0638316be4793ce04c20c0d69bf393e379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271076 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#783954}
-
Steven Bingler authored
Test that callbacks receive the correct results and that multiple are all serviced, get the same result, and that re-entrancy is handled. Bug: 1085168 Change-Id: I0ef8926f3d62e0f6c35006083b88cab98f36f9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274797 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#783953}
-
Oleh Lamzin authored
This reverts commit 5285df13. Reason for revert: bug was fixed in crrev.com/c/2273059 Original change's description: > sheriff: disable TelemetryExtensionIntegrationTest.TelemetryExtension in asan > > Bug: 1098764 > Change-Id: Id95c564487b698154fa09e1067ac345bae268680 > Tbr: bsep@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264453 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781873} TBR=ellyjones@chromium.org,bsep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098764 Change-Id: Ib344e0ecd9b452b7f9192fb3524476979b1012f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274394Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#783952}
-
Saurabh Nijhara authored
Update screen and update required screen are using the same key string for different message Ids related to cellular prompt which leads to one overriding the other. Bug: 1100420 Change-Id: I579ec62e49969a78af2b6aed2c2757d8511cf3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273142Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54c234edfb33..55d3cca75729 2020-06-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id7e2e720aded0e5ab2e268849076a78a7ae05932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276010Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593409816-92edd033b1e5d338943cabae4c1b1e83a09bcc8a.profdata to chrome-win64-master-1593496775-0ea9a3b4c746de291f2e1d9684ad233ef06add08.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic3549fe352cd4ca8393ed656fe2089f806035b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275992Reviewed-by:
-
Xida Chen authored
This Cl converts base::closure to base::RepeatingClosure. With this CL, there is no more base::callback, or base::closure, or base::bind in this folder. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: Ic2e4305e2182c93cff34ef70e2b23275b0774b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273479 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Colin Blundell authored
When WebLayer initially brought in confirm infobars for use with popup blocking, we had to fork //chrome's ConfirmInfoBar implementation due to the underlying Android InfoBar implementation being forked. WebLayer is now reusing the underlying implementation and can hence reuse the now-componentized ConfirmInfoBar implementation as well. There is no behavioral change in this CL, as the only forking introduced in //weblayer was in confirm_infobar_android.cc and was simply to adapt to the //weblayer embedding environment (now handled via injection of parameters into the componentized confirm_infobar.cc). Bug: 1099169 Change-Id: I05012e1ff3f9e4088def79427a5da76f1e208ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273138 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#783947}
-
nancylingwang@google.com authored
Replace extensions::ExtensionsClient::ScriptingWhitelist with ScriptingAllowlist. Replace extensions::ExtensionsClient::SetScriptingWhitelist with SetScriptingAllowlist Replace extensions::switches::kWhitelistedExtensionID with extensions::switches::kAllowlistedExtensionID FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html BUG=1097644 Change-Id: I90b952f8b771bf60feb26f86499e606271e01383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269822Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783946}
-
Javier Ernesto Flores Robles authored
Uses a UIView instead of a UILayoutGuide to layout the text. This allows the scroll view's content size to be correctly arranged. Adds some vertical space to allow some space for the top margin. Removes unneeded compression resistance. Renames kInsetValue to kVerticalInsetValue. Bug: 1099364 Change-Id: If43525f930a71677554d54e7d8649ab796c64ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266904 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Olivier Robin authored
Bug: None Change-Id: Ibb166bee234bc70517d0624ab56fbe2da71d8a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273230 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#783944}
-
nancylingwang@google.com authored
FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html This CL replaces blacklist with blocklist for the extensions/browser/extensions/api directory only, and it doesn't include other directories. There will be some follow up CLs to change it for other directories, e.g.: chrome/browser/extensions extensions Bug: 1097644 Change-Id: I459140d2d69a79dba1a3267ce56e8931897b9daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269388Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783943}
-
Rainhard Findling authored
* Test that each possible CCT status results in the corresponding safety check child status and display string. * Test that CCT being enterprise managed is handled correctly. Bug: 1087263 Change-Id: I84d93408800cb4fbe8d138578c586a0ae89dbfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249980Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#783942}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/359d16da1108..95c250c24769 2020-06-30 robertphillips@google.com Downgrade GpuGMs to only receiving a GrRecordingContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I1f823ab6035642c87d88ad0566d58222a2795837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276152Reviewed-by:
-
