- 28 Feb, 2015 34 commits
-
-
dpranke authored
The bots still use 'cpu_arch' to set the architecture, and the build file was keying off of build_cpu_arch to determine whether or not to enable NaCl, so things were failing. Updating the the code to 'current_cpu' fixes the problem correctly. TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/964003002 Cr-Commit-Position: refs/heads/master@{#318585}
-
mmenke authored
This was inspired by jank in the RDH method that calls the function, but will almost certainly have no effect on the jank. Also switch to using a range loop in GetLoadState as well. BUG=455952 Review URL: https://codereview.chromium.org/966943005 Cr-Commit-Position: refs/heads/master@{#318584}
-
pkasting authored
remaining instrumentation of non-janky functions. BUG=455884,462811,462812,462813,462815 TEST=none TBR=mmenke Review URL: https://codereview.chromium.org/964013002 Cr-Commit-Position: refs/heads/master@{#318583}
-
estade authored
TODO: apply the same logic (as well as the suggestion hiding logic) to addresses BUG=459741 Review URL: https://codereview.chromium.org/964643003 Cr-Commit-Position: refs/heads/master@{#318582}
-
eroman authored
Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/966593002/) Reason for revert: May have caused FontRenderParamsTest failures on Linux debug bots. Original issue's description: > SK_DEBUG when DCHECK_ALWAYS_ON > > BUG= > > Committed: https://crrev.com/879405ae813ae4a9bcbd7684d3551420d4980383 > Cr-Commit-Position: refs/heads/master@{#318557} TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/965113002 Cr-Commit-Position: refs/heads/master@{#318581}
-
scottmg authored
Sorts sources blocks as part of gn format. This ended up being more complicated than I expected because of the subtlety of header comments, and because no other formatting reorders expressions at the moment. But, there seems to be quite a lot of unsorted lists per below, so I guess it's a good thing to have. Application to tree at https://codereview.chromium.org/960413003. R=brettw@chromium.org BUG=348474, 456014 Review URL: https://codereview.chromium.org/962003002 Cr-Commit-Position: refs/heads/master@{#318580}
-
kelvinp authored
Summary of changes: 1. Fix a bug in identity.js that breaks first run scenario of the v2 app, Previously, we are resetting the deferred object (the list of listeners) when auth is failed even when interactive is set to false, which always happened on first runs. At a result, when auth is completed, the listeners are not notified. This CL only clears the deferred object after it has notified its listeners. 2. Fix a missing parameter in session_connector_impl.js that causes It2Me to fail to connect. 3. Changes it2me_browser_test.js to match the changes in the identity API. BUG=462708 TEST=Browser test passes on swarming bots. https://chromium-swarm.appspot.com/user/task/25e6711d0deacc10 NOTRY=true Review URL: https://codereview.chromium.org/968463003 Cr-Commit-Position: refs/heads/master@{#318579}
-
mek authored
This CL changes every place a MessagePort is transferred between process to properly propagate the send_messages_as_values flag, as well as makes it possible for NavigatorConnectContext to set this flag when setting up a new connection. This is part of a series of changes: [1/5] Blink side changes in https://codereview.chromium.org/924983002/ that expose a needed v8 context [2/5] https://codereview.chromium.org/921013002/ allow MessagePort to send messages as values [3/5] This CL [4/5] https://codereview.chromium.org/938403005/ which uses this for navigator.connect services and adds infrastructure for layout tests [5/5] https://codereview.chromium.org/940423004/ adds layout tests to blink to test these new features BUG=426458 Review URL: https://codereview.chromium.org/944443003 Cr-Commit-Position: refs/heads/master@{#318578}
-
tommi authored
WebRTC 8509:8540 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/976aecb..a22bcca Libjingle 8510:8539 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/e574ba0..b87b283 TBR=magjed@chromium.org Review URL: https://codereview.chromium.org/962403002 Cr-Commit-Position: refs/heads/master@{#318577}
-
dfalcantara authored
It is possible to have one DocumentActivity create a Tab and add its ID to the DocumentTabModel, but get interrupted (somehow) before the Tab Entry is added to the DocumentTabModel. This results in getCount() returning the correct number of Tabs that exist but fail to have any information about the new Tab, resulting in getTabAt() returning |null|. We should instead keep the ID list and the Entry list be as in sync as possible, adding the Entry directly to the DocumentTabModel as soon as we let the DocumentTabModel know about the Tab's existence. Add new methods to tie the addTabId and updateEntry functions together via addTab, deprecate the old ones, and assert that we should never get into a bad state. Deprecated methods will be culled when the downstream patch lands. BUG=457427 Review URL: https://codereview.chromium.org/969443003 Cr-Commit-Position: refs/heads/master@{#318576}
-
http://crbug.com/447208rmcilroy authored
BUG=447208 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/962313003 Cr-Commit-Position: refs/heads/master@{#318575}
-
scottmg authored
Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
-
estade authored
```------- Show Autofill/Wallet options only when signed in. Before this patch, you could still see the options if you signed into a whitelisted account (setting the sync experiment preference) and then signed out of the account. BUG=none R=brettw@chromium.org ``` ------- Review URL: https://codereview.chromium.org/961773003 Cr-Commit-Position: refs/heads/master@{#318573}
-
estade authored
On the first 401 Unauthorized, invalidate the oauth token and try again. If there is more than one 401 Unauthorized in a row, we're probably borked, so don't keep retrying. BUG=none Review URL: https://codereview.chromium.org/966943004 Cr-Commit-Position: refs/heads/master@{#318572}
-
xiaolingbao authored
BUG=462407 Review URL: https://codereview.chromium.org/962013002 Cr-Commit-Position: refs/heads/master@{#318571}
-
prasadv authored
Perf try jobs running on Win x64 bisect bots should build and run tests on x64 binaries. BUG=462639 Review URL: https://codereview.chromium.org/961193002 Cr-Commit-Position: refs/heads/master@{#318570}
-
sbc authored
When running ppapi_simple-based application in sel_ldr we almost never want to use nacl_io so don't initialize it by default. This makes it easier for application build on ppapi_simple to run both under and Chrome and sel_ldr. Review URL: https://codereview.chromium.org/964983002 Cr-Commit-Position: refs/heads/master@{#318569}
-
jbudorick authored
BUG=462239 Review URL: https://codereview.chromium.org/963643002 Cr-Commit-Position: refs/heads/master@{#318568}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6c51e22..748e82f TBR=hclam@chromium.org,alancutter@chromium.org Review URL: https://codereview.chromium.org/970433002 Cr-Commit-Position: refs/heads/master@{#318567}
-
zea authored
Wallet was not receiving invalidation previously because the Android side did not know to register the type. This fixes that. BUG=none Review URL: https://codereview.chromium.org/967673002 Cr-Commit-Position: refs/heads/master@{#318566}
-
newt authored
Review URL: https://codereview.chromium.org/965913003 Cr-Commit-Position: refs/heads/master@{#318565}
-
jeremyim authored
We interchangeably used probe and canary throughout the Data Reduction Proxy component; neither is very descriptive about what is taking place. SecureProxyCheck is sufficiently descriptive but succinct. BUG=460299 Review URL: https://codereview.chromium.org/961983002 Cr-Commit-Position: refs/heads/master@{#318564}
-
robliao authored
BUG=461137 Review URL: https://codereview.chromium.org/948933005 Cr-Commit-Position: refs/heads/master@{#318563}
-
erikchen authored
This class is a common base class for all Telemetry exceptions. BUG=460625 Review URL: https://codereview.chromium.org/962283002 Cr-Commit-Position: refs/heads/master@{#318562}
-
maxbogue authored
My recent refactor (http://crrev.com/879533004) modified AndroidSyncSettings to only read the account when it changed, but did not correctly initialize the account on startup. BUG=462658,462618 Review URL: https://codereview.chromium.org/965043003 Cr-Commit-Position: refs/heads/master@{#318561}
-
ananta authored
This is only available on Windows 8+ because the media foundation API which exposes the device manager to be pased to the decoder MFCreateDXGIDeviceManager only exists on Windows 8+. Changes in this patch are mostly around using DX11 or D3D wherever needed. These are as below:- 1. In the initialization code path where we use D3D or DX11 based on whether we are on Windows 8+ and ANGLE and the decoder say they support DX11. 2. The output frame processing code where we extract the DX11 texture and copy it out to ANGLE. One change here is that DX11 does not provide an automatic way for format conversion for textures. The decoder outputs YUV12 textures and ANGLE expects RGB. We can achieve this by setting a shader for conversion. That seemed like too much work. Thankfully there is a video processor media foundation transform on Windows which does the conversion for us on the GPU. We use this object to convert the output frame and copy it out to ANGLE. 3. We pass the GL context to the decoder to enable us to query ANGLE to see if it is using D3D or DX11. BUG=456418 Review URL: https://codereview.chromium.org/922003002 Cr-Commit-Position: refs/heads/master@{#318560}
-
posciak authored
Don't send frames with show_frame syntax element set to false to display. BUG=chrome-os-partner:35953 TEST=video playback, vdatest Review URL: https://codereview.chromium.org/963053002 Cr-Commit-Position: refs/heads/master@{#318559}
-
creis authored
BUG=461494 TEST=Crash report should show that --site-per-process flag is present. Review URL: https://codereview.chromium.org/959303003 Cr-Commit-Position: refs/heads/master@{#318558}
-
mtklein authored
BUG= Review URL: https://codereview.chromium.org/966593002 Cr-Commit-Position: refs/heads/master@{#318557}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27a38796..627ffe9a Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/965873003 Cr-Commit-Position: refs/heads/master@{#318556}
-
rch authored
Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows. BUG=442392 Review URL: https://codereview.chromium.org/938003003 Cr-Commit-Position: refs/heads/master@{#318555}
-
rockot authored
This applies the same approach as r318190 to clean up stale generated java when any mojom dependencies have changed in gyp targets using mojom_bindings_generator_explicit.gypi. BUG=461622 R=jamesr@chromium.org Review URL: https://codereview.chromium.org/963773002 Cr-Commit-Position: refs/heads/master@{#318554}
-
timav authored
Implemented stub FindChrome() on android that does nothing and returns false. BUG=462434 Review URL: https://codereview.chromium.org/965653002 Cr-Commit-Position: refs/heads/master@{#318553}
-
anthonyvd authored
Some of the tests weren't properly instantiating a PrefService. It's now being done in the ExtensionServiceTestBase class and its subclasses were modified where needed. BUG=461484 Review URL: https://codereview.chromium.org/965803003 Cr-Commit-Position: refs/heads/master@{#318552}
-
- 27 Feb, 2015 6 commits
-
-
danakj authored
The ui browser compositor should use onecopy for implside painting, as we have enabled that for all platforms that use ui::Compositor. The image texture target should also match the one used in the renderer compositor. So have the ui::Compositor query it from the ContextFactory and move the code that makes the decision out from RenderProcessHostImpl to a shared location. R=piman@chromium.org, reveman BUG=314185 Review URL: https://codereview.chromium.org/963223002 Cr-Commit-Position: refs/heads/master@{#318551}
-
avayvod authored
Added PresentationSession Mojo interface with its client implementation, PresentationSessionDispatcher. Depends on the Blink change: https://codereview.chromium.org/935103002 BUG=459005 Review URL: https://codereview.chromium.org/935083002 Cr-Commit-Position: refs/heads/master@{#318550}
-
danakj authored
This makes aura_demo output show up. R=piman@chromium.org BUG=462739 Review URL: https://codereview.chromium.org/963903002 Cr-Commit-Position: refs/heads/master@{#318549}
-
chrome://interstitialsfahl authored
BUG=452218 TEST=Go to chrome://interstitials and click on "Clock is ahead" or "Clock is behind". The shown interstitial displays the clock error message instead of the common certificate warning. Review URL: https://codereview.chromium.org/940543003 Cr-Commit-Position: refs/heads/master@{#318548}
-
estade authored
on desktop, as it is on mobile. BUG=none Review URL: https://codereview.chromium.org/957523002 Cr-Commit-Position: refs/heads/master@{#318547}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/4f569be..394ce76 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=reed@google.com Review URL: https://codereview.chromium.org/961373002 Cr-Commit-Position: refs/heads/master@{#318546}
-