GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ea6ed3c31..722374e

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/903163002

Cr-Commit-Position: refs/heads/master@{#315092}

Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/903013002/)

Reason for revert:
Broke the build

Original issue's description:
> Landing Recent QUIC Changes.
>
> Making the (deprecation-in-progress) congestion field write only.
>
> This is a bit of a hack because technically it's "required" for
> QUIC_VERSION_23 but as all the internal servers and all of chrome builds
> picking up this change consider the field optional despite the version,
> it should just Work (TM).
>
> I was hoping to stop sending the congestion fields for v24 clients but
> that is not safe until the internal server fleet doesn't consider it a
> required field for negotiated()=true.  Bah.
>
> No longer reading the (deprecated) congestion fields for QUIC.
>
> Merge internal change: 85158634
> https://codereview.chromium.org/898233003/
>
> Improving junk packet handling for QUIC by ignoring packets with client
> port 0.
>
> Merge internal change: 85067984
> https://codereview.chromium.org/885713009/
>
> Removing deprecated flag FLAGS_quic_use_initial_rtt_for_stats.
>
> Merge internal change: 84999682
> https://codereview.chromium.org/883393008/
>
> Adding more error logging for failed QUIC writes.
>
> Merge internal change: 84989992
> https://codereview.chromium.org/898243002/
>
> Further cleanup to QuicAckNotifier and QuicAckNotifierManager.
> No functional change.
>
> Merge internal change: 84784925
> https://codereview.chromium.org/880403006/
>
> Remove an unneeded hash_set from QuicAckNotifierManager.
> No change in behavior.
>
> Merge internal change: 84637544
> https://codereview.chromium.org/872403007/
>
> Minor cleanup and optimization of QuicConnection::IsConnectionClose.
>
> Merge internal change: 84624803
> https://codereview.chromium.org/903973002/
>
> Rename QuicAckNotifier's AddSequenceNumber to OnSerializedPacket.
> No functional change.
>
> Merge internal change: 84624660
> https://codereview.chromium.org/867293004/
>
> R=rch@chromium.org
>
> Committed: https://crrev.com/ff331b65e0aef293ed6f1d0954b83ae17cc66d28
> Cr-Commit-Position: refs/heads/master@{#315086}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/908623002

Cr-Commit-Position: refs/heads/master@{#315091}

It doesn't need to run in Chrome's browser_tests.

BUG=388893
TEST=browser_tests and extensions_browsertests for Bluetooth*

Review URL: https://codereview.chromium.org/902213002

Cr-Commit-Position: refs/heads/master@{#315090}

NSWindowFullScreenButton is a 10.7 addition and calling
-standardWindowButton: with it on 10.6 results in log
spam of the form:

"unrecognized button type 7"

BUG=none

Review URL: https://codereview.chromium.org/905803002

Cr-Commit-Position: refs/heads/master@{#315089}

This is a re-land of https://codereview.chromium.org/862113005/

This CL introduces JNI plumbing for one method of the FakeServer's
verification API. One test (testUploadTypedUrl) has been added to use
the API; it types a URL on the client and verifies that the URL was
sent to the server.

BUG=NONE

Review URL: https://codereview.chromium.org/884073005

Cr-Commit-Position: refs/heads/master@{#315088}

The number of times the current received packet had a lower sequence number
than the previously received packet sequence number, and the size of the
current packet is larger than the size of the previous packet.

Review URL: https://codereview.chromium.org/905593002

Cr-Commit-Position: refs/heads/master@{#315087}

Making the (deprecation-in-progress) congestion field write only.

This is a bit of a hack because technically it's "required" for
QUIC_VERSION_23 but as all the internal servers and all of chrome builds
picking up this change consider the field optional despite the version,
it should just Work (TM).

I was hoping to stop sending the congestion fields for v24 clients but
that is not safe until the internal server fleet doesn't consider it a
required field for negotiated()=true.  Bah.

No longer reading the (deprecated) congestion fields for QUIC.

Merge internal change: 85158634
https://codereview.chromium.org/898233003/

Improving junk packet handling for QUIC by ignoring packets with client
port 0.

Merge internal change: 85067984
https://codereview.chromium.org/885713009/

Removing deprecated flag FLAGS_quic_use_initial_rtt_for_stats.

Merge internal change: 84999682
https://codereview.chromium.org/883393008/

Adding more error logging for failed QUIC writes.

Merge internal change: 84989992
https://codereview.chromium.org/898243002/

Further cleanup to QuicAckNotifier and QuicAckNotifierManager.
No functional change.

Merge internal change: 84784925
https://codereview.chromium.org/880403006/

Remove an unneeded hash_set from QuicAckNotifierManager.
No change in behavior.

Merge internal change: 84637544
https://codereview.chromium.org/872403007/

Minor cleanup and optimization of QuicConnection::IsConnectionClose.

Merge internal change: 84624803
https://codereview.chromium.org/903973002/

Rename QuicAckNotifier's AddSequenceNumber to OnSerializedPacket.
No functional change.

Merge internal change: 84624660
https://codereview.chromium.org/867293004/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/903013002

Cr-Commit-Position: refs/heads/master@{#315086}

Switch Chrome on Android to use libc++ instead of stlport. WebView AOSP
builds will continue to use stlport for the time being.

Note that this change is exploratory, and likely to be reverted before
branch point (ensuring WebView and Chrome remain in lockstep with
respect to standard library dependencies).

BUG=427718
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/835633003

Cr-Commit-Position: refs/heads/master@{#315085}

CloudPolicyClient previously only allowed a single outstanding request at once,
and issuing a new request would cause the previous request to silently fail.
This behavior made sense for policy fetches, but not for other types of
out-of-band requests (status uploads, certificate uploads, etc).

CloudPolicyClient now allows multiple requests at once, and differentiates
between policy-fetch/registration related requests and out-of-band requests.

BUG=452563

Review URL: https://codereview.chromium.org/885653007

Cr-Commit-Position: refs/heads/master@{#315084}

BUG=417463
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/908613002

Cr-Commit-Position: refs/heads/master@{#315083}

BUG=none

Review URL: https://codereview.chromium.org/888643004

Cr-Commit-Position: refs/heads/master@{#315082}

These measure the time taken in response to ExtensionService ready signaling. These are the 2 heaviest observers of ready.

BUG=453073

Review URL: https://codereview.chromium.org/874643003

Cr-Commit-Position: refs/heads/master@{#315081}

This cl contains the base code plus a "simple" hello world example test.

BUG=453679

Review URL: https://codereview.chromium.org/890773003

Cr-Commit-Position: refs/heads/master@{#315080}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/902973002

Cr-Commit-Position: refs/heads/master@{#315079}

The latest <paper-toggle-button> matches the Material Design spec. The
MD-Settings page will make use of this button in a follow-up CL.

Since paper-toggle-button isn't currently used in Chromium there shouldn't
be any side effects for this change.

R=rsadam@chromium.org

Review URL: https://codereview.chromium.org/899383002

Cr-Commit-Position: refs/heads/master@{#315078}

Review URL: https://codereview.chromium.org/884903003

Cr-Commit-Position: refs/heads/master@{#315077}

Code is not used after we Chrome stopped generation of EMF inside render.

Review URL: https://codereview.chromium.org/900683004

Cr-Commit-Position: refs/heads/master@{#315076}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7e38934..ea6ed3c31

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/894373003

Cr-Commit-Position: refs/heads/master@{#315075}

BUG=455999
TEST=Chrome does not crash when changing selected printer in print
preview opened in an incognito window

Review URL: https://codereview.chromium.org/903123002

Cr-Commit-Position: refs/heads/master@{#315074}

BUG=398997

Review URL: https://codereview.chromium.org/885783008

Cr-Commit-Position: refs/heads/master@{#315073}

BUG=None
TEST=None
R=sadrul
TBR=oshima

Review URL: https://codereview.chromium.org/904733002

Cr-Commit-Position: refs/heads/master@{#315072}

This change will allow Googlers to bisect over Android builds at a finer
grain than what is currently possible (currently can only bisect over
official builds for Android).

BUG=

Review URL: https://codereview.chromium.org/851333004

Cr-Commit-Position: refs/heads/master@{#315071}

Add tests which exercise wifi_sync's ability to add networks.
These tests add a network to the platform wifi config, and then
verify that the new network appears in other sync clients.

BUG=chromium:431435
TEST=sync_integration_tests --gtest_filter="*Wifi*"

Review URL: https://codereview.chromium.org/843483004

Cr-Commit-Position: refs/heads/master@{#315070}

Loosen the parsing of CDB output in windows; it can start with at least 'ChildEBP' or 'Child-SP', and the extra output probably isn't much if those are not found.

BUG=433966

Review URL: https://codereview.chromium.org/904063002

Cr-Commit-Position: refs/heads/master@{#315069}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/50785a3..02c8fd0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/904913002

Cr-Commit-Position: refs/heads/master@{#315068}

* Fix dependency issues in //extensions
* Make protobuf library add the "src" directory to the compiler's include
  directory list, otherwise it tries to use /usr/include/google/protobuf
  which has incompatible headers.

BUG=455919
TEST=compiles and links in both component and non-component builds

Review URL: https://codereview.chromium.org/889253004

Cr-Commit-Position: refs/heads/master@{#315067}

WebRTC 8220:8272
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..0506804

Libjingle 8221:8270
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..184c120

TBR=magjed@chromium.org

Review URL: https://codereview.chromium.org/902183002

Cr-Commit-Position: refs/heads/master@{#315066}

Revert of Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation (patchset #1 id:1 of https://codereview.chromium.org/905463004/)

Reason for revert:
Test fixed in https://codereview.chromium.org/904673004/, https://crrev.com/315063.

Original issue's description:
> Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation
>
> This test fails within the WebContentsObserverSanityChecker, since no IPC
> for RenderFrameCreated is sent. Disable while we find a good way to make
> the sanity checker play nicely within the unit test framework running in
> --site-per-process
>
> BUG=417518
>
> Committed: https://crrev.com/33e0ed259a19bc6c918fa11fcacffdf709440447
> Cr-Commit-Position: refs/heads/master@{#314960}

TBR=alexmos@chromium.org,jam@chromium.org,nasko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=417518

Review URL: https://codereview.chromium.org/870653006

Cr-Commit-Position: refs/heads/master@{#315065}

Also remove unused and outdated 'domui_options'

Review URL: https://codereview.chromium.org/900773005

Cr-Commit-Position: refs/heads/master@{#315064}

Test NavigatorTestWithBrowserSideNavigation.BeginNavigation was broken
due to the way the subframe used was added to the tree. By directly
calling FrameTree::AddFrame the proper observer notifications were not
being executed and triggered a sanity check. It was replaced with the
already test-tailored TestRenderFrameHost::AppendChild.

BUG=455484

Review URL: https://codereview.chromium.org/904673004

Cr-Commit-Position: refs/heads/master@{#315063}

Downloaded by: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/util/cloud_storage.py&l=86

BUG=456091
R=sullivan@chromium.org

Review URL: https://codereview.chromium.org/888883004

Cr-Commit-Position: refs/heads/master@{#315062}

Follow up to https://codereview.chromium.org/900613003/.
Make NewTabButton and TabStripBackgroundView adopt ThemedWindowDrawing.

BUG=455955,453996

Review URL: https://codereview.chromium.org/904503003

Cr-Commit-Position: refs/heads/master@{#315061}

BUG=453708
TEST=as in bug

Review URL: https://codereview.chromium.org/902083002

Cr-Commit-Position: refs/heads/master@{#315060}

According to issue 444835 there were at least two problems with debug info on
the swarming bots:
 - the .dSYM bundles for the test binaries and other applications weren't
uploaded to swarming servers;
 - for some binaries (e.g. Chromium Framework) their names were replaced with
SHA-1 hashes that confused llvm-symbolizer and made finding the .dSYM bundles
impossible.

This CL adds the necessary .dSYM paths to .isolate files for the tests
currently being ran on swarming bots (for other tests their .dSYM paths will be
added as needed).
It also extends tools/valgrind/asan/asan_symbolize.py with a binary name filter
that replaces the hashes with the corresponding file names in the product
directory.

BUG=444835
R=earthdok@chromium.org,maruel@chromium.org,csharp@chromium.org

Review URL: https://codereview.chromium.org/859293002

Cr-Commit-Position: refs/heads/master@{#315059}

We needed this flag to fix HostDriven_SearchByImageTest.testSearchByImageTest.

BUG=455653

Review URL: https://codereview.chromium.org/903983002

Cr-Commit-Position: refs/heads/master@{#315058}

Revert of Roll android_tools f6e2370:2a860d8 (patchset #2 id:20001 of https://codereview.chromium.org/900273003/)

Reason for revert:
Some builders apparently don't yet have Google Play Services installed.

Original issue's description:
> Roll android_tools f6e2370:2a860d8
>
> This rolls in an update to android_tools.gyp that provides targets for
> Google Play Sevices libraries.
>
> BUG=450675
>
> Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d
> Cr-Commit-Position: refs/heads/master@{#315037}

TBR=mcilroy@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450675

Review URL: https://codereview.chromium.org/889603009

Cr-Commit-Position: refs/heads/master@{#315057}

This reverts commit 44036d05
From review: https://codereview.chromium.org/899113002

Original issue's description:
> This CL makes "timezone auto update" feature available (but switched off by
> default) to users. And adds flag to disable this feature.
>
> BUG=416494
> TEST=manual
>
> Review URL: https://codereview.chromium.org/898503002

TBR=stevenjb@chromium.org,dpolukhin@chromium.org,isherman@chromium.org
BUG=416494

Review URL: https://codereview.chromium.org/909453002

Cr-Commit-Position: refs/heads/master@{#315056}

The heuristic ensures that the user is not prompted too much, and is only
prompted after showing sustained engagement with a site.

BUG=452825

Review URL: https://codereview.chromium.org/886643003

Cr-Commit-Position: refs/heads/master@{#315055}

Replaced occurrences of [HyperlinkTextView setMessageAndLink:withLink:
atOffset:font:messageColor:linkColor:] with
[HyperLinkTextView setMessage:withFont:messageColor] and
[HyperLinkTextView addLinkRange:withName:linkColor:]. Removed the
[HyperLinkTextView setMessageAndLink:withLink:...] method.

BUG=253755

TEST=it's very difficult to produce test sequences for most of these changes.
Here is the one sequence I do have:

for sad_tab_view_cocoa.mm: Launch Chrome, run
    ps augx | grep “Chrome Helper”
in a Terminal window, create a new tab and go to some page, run the ps...
commands again and figure out the process number of the new Chrome
Helper (the one that wasn’t there before). In a Terminal window type kill -9
<XXX> where <XXX> is the process id of the new Chrome Helper. Confirm
the new tab now shows the sad tab page and that the last line of text reads,
“If you're seeing this frequently, try these suggestions.” with the word
“suggestions” as a clickable link that takes you to the “Aw, Snap!” Chrome
help page.

Review URL: https://codereview.chromium.org/887823002

Cr-Commit-Position: refs/heads/master@{#315054}

1.Parallelizing run of tests
2.All options were moved from command line args to config
3.Introducing possibility to avoid writing to sheet

BUG=435249

Review URL: https://codereview.chromium.org/903763003

Cr-Commit-Position: refs/heads/master@{#315053}