GitLab

BUG=386982
TEST=VISUAL

Review URL: https://codereview.chromium.org/379253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282406 0039d316-1c4b-4281-b951-d872f2087c98

In this test, index 0 is set as separator and TextComboboxModel::GetItemAt
asserts that separator items are not reached.
However, the combobox's selected index is 0 (default value) and on the Mac
OnPaint() will be triggered to cause the NOTREACHED to trigger.
TestComboboxModel is now initialized with the separators instead of being 
mutated after, and GetDefaultIndex is implemented to return the first
non-separator index.

BUG=378134

Review URL: https://codereview.chromium.org/376703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282405 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/383763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282403 0039d316-1c4b-4281-b951-d872f2087c98

Broke gpu_unittests FramebufferInfoTest.DrawBuffers:
[ RUN      ] FramebufferInfoTest.DrawBuffers
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:653: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:657: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] FramebufferInfoTest.DrawBuffers (1 ms)

> Do not call glDrawBuffersARB when the extension is absent
> 
> The function Framebuffer::ChangeDrawBuffersHelper was assuming
> that binding of an FBO with no GL_COLOR_ATTACHMENT0 was
> accompanied by setting the first draw buffer to GL_NONE with
> glDrawBuffersARB in the fix introduced in:
> https://codereview.chromium.org/315283002
> 
> When the extension is not present, it can be assumed that the
> glDrawBuffersARB state need not be set and restored.
> 
> BUG=(wrangling)
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/375413003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/382003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282402 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375333

Review URL: https://codereview.chromium.org/372683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282400 0039d316-1c4b-4281-b951-d872f2087c98

in chromeos_unittests

TBR=stevenjb@chromium.org
BUG=392936
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/387663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282399 0039d316-1c4b-4281-b951-d872f2087c98

This only added conversion functions to/from PP_Bool. We have those
in pp_bool.h, so we don't need it.

BUG=

Review URL: https://codereview.chromium.org/384793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282398 0039d316-1c4b-4281-b951-d872f2087c98

This is a relanded https://codereview.chromium.org/307673002. It was reverted due to concerns that non-Chrome passwords may suffer (which is untrue). After https://codereview.chromium.org/360343002 is landed the only affected passwords are those created by Chrome within the current profile.

BUG=343891

Review URL: https://codereview.chromium.org/363013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282397 0039d316-1c4b-4281-b951-d872f2087c98

This change just exposes information about what tabs are selected
and fires proper notifications when tab selection changes. This will
allow screen readers to announce when switching tabs even if the
web content doesn't have focus. It's also a good first step towards
making the tab strip fully accessible too (e.g. making it possible to
perform operations on multiple tabs with just the keyboard).

As part of this change I renamed the "selection changed" event to
"text selection changed" so that there's no confusion between the
text-selection-related events, and tab/list selection events.

BUG=100412

Review URL: https://codereview.chromium.org/349033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282396 0039d316-1c4b-4281-b951-d872f2087c98

Define the hit test mask for MicButton by implementing
MaskedTargeterDelegate instead of overriding
View::HasHitTestMask() and View::GetHitTestMaskDeprecated().

BUG=388838
TEST=SpeechViewTest.ClickMicButton

Review URL: https://codereview.chromium.org/365753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282395 0039d316-1c4b-4281-b951-d872f2087c98

Reason: My TODO was wrong. export.h should stay in athena/.

> athena: Move athena_export.h into common/ directory.
> 
> Fix a TODO in athena.gyp.
> 
> BUG=None
> TEST=None
> R=oshima@chromium.org
> 
> Review URL: https://codereview.chromium.org/371573002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/382913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282394 0039d316-1c4b-4281-b951-d872f2087c98

The function Framebuffer::ChangeDrawBuffersHelper was assuming
that binding of an FBO with no GL_COLOR_ATTACHMENT0 was
accompanied by setting the first draw buffer to GL_NONE with
glDrawBuffersARB in the fix introduced in:
https://codereview.chromium.org/315283002

When the extension is not present, it can be assumed that the
glDrawBuffersARB state need not be set and restored.

BUG=(wrangling)
NOTRY=True

Review URL: https://codereview.chromium.org/375413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282393 0039d316-1c4b-4281-b951-d872f2087c98

This is part #2 of https://codereview.chromium.org/354343002/

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/345133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282392 0039d316-1c4b-4281-b951-d872f2087c98

This implementation is similar to that in ui/cocoa/autofill/autofill_sign_in_container.mm.

BUG=364644
TEST=Start Chrome with --new-profile-management turned on. From the avatar
menu, select "Not <name>". The User Manager should show up. Cmd+W should
close it, but other accelerators (eg. Cmd+t) should not work.

Review URL: https://codereview.chromium.org/378693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282390 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/386543002 , probably fixed by
https://codereview.chromium.org/381883002/

BUG=392768
TBR=hamaji@chromium.org

Review URL: https://codereview.chromium.org/382013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282389 0039d316-1c4b-4281-b951-d872f2087c98

Disable animations to get TextfieldTest.DragToSelect to pass.
AuraTestHelper disables animations, so they were already disabled on non-Mac.
This change creates ViewsTestHelperMac that disables animation the same way
as ViewsTestHelperAura does.

BUG=378134

Review URL: https://codereview.chromium.org/378663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282385 0039d316-1c4b-4281-b951-d872f2087c98

TBR=robertphillips@chromium.org
BUG=392912
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/388563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282384 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282383 0039d316-1c4b-4281-b951-d872f2087c98

webrtc bug 3211.

R=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/376053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282382 0039d316-1c4b-4281-b951-d872f2087c98

This is how there were supposed to be before someone accidentally
renumbered the match types.

BUG=390597

Review URL: https://codereview.chromium.org/362033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/381123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282380 0039d316-1c4b-4281-b951-d872f2087c98

Split linux library expectations for debian into 32 and 64 bit, remove libgcc1 from 64 after clang switch

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/385693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282379 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Experimental app list: Added a current page indicator to the launcher. (https://codereview.chromium.org/380613002/)

Reason for revert:
Caused a static initializer, see http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/67534

Original issue's description:
> Experimental app list: Added a current page indicator to the launcher.
> 
> Adds a current page indicator to the launcher when the experimental app launcher is enabled.
> 
> BUG=391642
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282335

TBR=calamity@chromium.org,mgiuca@chromium.org,kcarattini@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391642

Review URL: https://codereview.chromium.org/384803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282378 0039d316-1c4b-4281-b951-d872f2087c98

A better fix is to set clang further up, so that gcc_version is set to
0 when clang is on automatically
( https://codereview.chromium.org/384633005 ). This is however blocked
on nacl also using the "clang" symbol, so that needs to be fixed first
( https://codereview.chromium.org/384793002 ). To make the build go for
people in the meantime, land this hack. I'll revert it once the nacl change has
landed in nacl and then rolled into chromium, and the better fix has landed.

BUG=360311
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282377 0039d316-1c4b-4281-b951-d872f2087c98

The old mechanism of estimating the wall clock time isn't as accurate as
the frame-level information tracked inside AudioClock. For example,
AudioClock properly handles situations where the playback rate changes
over time.

BUG=370634

Review URL: https://codereview.chromium.org/382633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282376 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282375 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177817:177844&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/381943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282374 0039d316-1c4b-4281-b951-d872f2087c98

Looks like we have to be a little more careful with the permissions now.

Tested on LPV79.

BUG=389362

Review URL: https://codereview.chromium.org/380073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282373 0039d316-1c4b-4281-b951-d872f2087c98

Changed from Quickoffice to "Office Editing for Docs, Sheets & Slides"

BUG=
R=kurtz@chromium.org, asargent@chromium.org

Review URL: https://codereview.chromium.org/328143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282372 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary file that will facilitate landing a two-sided patch in Blink/Chromium that changes the location of the generated ui resources directory.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/380283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282371 0039d316-1c4b-4281-b951-d872f2087c98

If we omit the frame pointer on Arm64 there is no way for
breakpad to correctly symbolize stack traces which contain
stack frames for which we don't have CFI information (e.g.,
system libraries like libc.so).  This is because the Arm64
ABI does not specify where a frame pointer should be in a
stack frame, so, without CFI information, there is no way 
to calculate the start of the caller's frame if the caller
omits the frame pointer.

More details are on the bug.

BUG=391706

Review URL: https://codereview.chromium.org/381923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282370 0039d316-1c4b-4281-b951-d872f2087c98

Make interfaces to handle TrackerIDSet on DB.
Simulate behavior of TrackerIDSet to handle it easily.


BUG=None
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOn*"

Review URL: https://codereview.chromium.org/377413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282369 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some of the Ash unittests dealing with cursors.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/384753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282368 0039d316-1c4b-4281-b951-d872f2087c98

This patch updates password_manager_enabled_ to saving_passwords_enabled_
to avoid confusion. This setting controls whether to offer to save password
or not.

BUG=392387

Review URL: https://codereview.chromium.org/380713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282367 0039d316-1c4b-4281-b951-d872f2087c98

TabDragController::detach_into_browser_

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/376513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282366 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282365 0039d316-1c4b-4281-b951-d872f2087c98

This change causes Android to build with Linux asm files and also bumps the
BoringSSL revision in order to pull in a change to define MIPS as a generic,
32-bit CPU.

BUG=392745
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/387583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282364 0039d316-1c4b-4281-b951-d872f2087c98

Define the hit test masks for Tab and TabCloseButton
by implementing MaskedTargeterDelegate instead of
overriding View::HasHitTestMask() and
View::GetHitTestMaskDeprecated().

BUG=388838
TEST=Existing coverage in TabStripTest.*

Review URL: https://codereview.chromium.org/361083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392781

Review URL: https://codereview.chromium.org/383683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282362 0039d316-1c4b-4281-b951-d872f2087c98

UserScriptList from UserScriptMaster. This leads to problems:
- What if master goes away?
- What if the UserScriptList is modified, as in
  UserScriptMaster::OnExtensionLoaded?

Fix this by making the script loading process in UserScriptMaster much simpler:
UserScriptMaster calls LoadScriptsOnFile thread, and uses the result, using a
weak pointer.

Added bonus: Two fewer ref-counted objects!  50 fewer lines of code!  Less script loading!

BUG=383973

Review URL: https://codereview.chromium.org/362343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282361 0039d316-1c4b-4281-b951-d872f2087c98