- 18 Apr, 2018 40 commits
 - 
- 
sebsg authored
The previous implementation was finding the form and field of the select element that was modified for each option added or removed. Since this can happen several times in a row it was not efficient. This search now happens after all the add/remove have been debounced. Bug: 832077 Change-Id: Icf28910459163a4d92eca96e2e4adad65a147cf7 Reviewed-on: https://chromium-review.googlesource.com/1015322 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#551719}
 - 
kylechar authored
This uses the new TextureLayer APIs to register SharedBitmapIds instead of using ClientSharedBitmapManager, in order to get the registration in the same IPC channel that the compositor uses for submitting frames that include the ImageLayerBridge's shared memory bitmaps. This CL also fixes a bug where bitmap data wasn't properly copied into shared memory. All rows from the source were copied into the same row of the destination. This was causing the canvas to appear (almost?) all black when using software compositing. I've tested the fix with https://codepen.io/anon/pen/qoeQEE which looks the same using GPU and software compositing. Bug: 730660, 831303 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibf778947a68c5948596f5dd516606937a8c5c442 Reviewed-on: https://chromium-review.googlesource.com/1014380Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#551718}
 - 
Christopher Grant authored
BUG=834318 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ib1023da9cd09a3291725aa539fdfa044356a7e81 Reviewed-on: https://chromium-review.googlesource.com/1016691Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551717}
 - 
khmel@google.com authored
This fixes the issue when OEM folder is created empty after new user flow and OEM items are placed to non-named folder. This also fixes various crashes when trying to manipulate these items. Bug: 828209 Test: Manually Change-Id: Ib07f0ab1d301d1e38a6ad91fca10396e9f58ccf7 Reviewed-on: https://chromium-review.googlesource.com/1016024Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#551716}
 - 
Bob Owen authored
This was only required because it is not available on Windows XP, which is no longer supported. R=forshaw@chromium.org Bug: 821290 Change-Id: Ie5fba51391b25f7a1a01549f67a054c00aefa50f Reviewed-on: https://chromium-review.googlesource.com/1012119Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551715}
 - 
Christopher Grant authored
The omnibox is a text element that updates according to user input. User input happens after element layout, and since the text texture heavily relies on layout, "dirtying" the text texture really means laying it out again. Prior to recent cleanup and refactoring, we mistakenly got away with this - a text element could resize itself after the layout stage and appear incorrectly. Post-cleanup, the re-layout can't happen, but a new bug was introduced where a post-layout phase could dirty a texture, and the texture update phase would redraw and "clean" the texture without doing layout. The broken layout would then persist indefinitely. To address the problem, elements may mark themselves as requiring measurement for texture draw. These elements will not be redrawn unless their measurement step has happened. There was a measured() DCHECK mechanism previously, that was taken out because most textures no longer measure themselves. This change reintroduces that check in it's new form. BUG=834297 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ib17315a5c053d487edfbf7b858c2e9541924c3a6 Reviewed-on: https://chromium-review.googlesource.com/1016064Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551714}
 - 
Bence Béky authored
This CL also slays some dead methods (*Setting*Old) for old behavior. This CL lands server change 193221621 by diannahu. BUG=488484 Change-Id: I420b10a15cef120176cce8842616e47154afc43e Reviewed-on: https://chromium-review.googlesource.com/1016702 Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:
Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551713}
 - 
Matt Menke authored
It already has Brotli enabled when using the network service, so this makes behavior the same whether the network service is enabled or not. Enabling makes more sense than disabling, since this matches Chrome's behavior, and it's a web standard. Bug: 825687 Change-Id: Ifa45aa704df5e3948e27cf2f1b23f8f06764425f Reviewed-on: https://chromium-review.googlesource.com/1015555 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551712}
 - 
Peter Collingbourne authored
This is really what we ought to be doing to avoid ODR violations caused by linking the prebuilt .a into multiple components, but I previously couldn't see a way to link the .a into the component .so with --whole-archive. However, it turns out that it's possible using ldflags. This is a little hackish but it's probably better than dealing with ODR violations. Bug: 749784 Change-Id: I1ae275d57f36bc4a2c816d7f0ee8fdc4c000cf63 Reviewed-on: https://chromium-review.googlesource.com/1016092Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551711}
 - 
Chris Lu authored
Creates new HeaderFooterClass for this section header. Also moves the "Syncing..." text to the section header subtitle and removes the cell that originally displayed that text. Video: https://drive.google.com/file/d/1jP5uSrm1MUyZVDMFPntQanqSe0hWh7GL/view?usp=sharing Bug: 825017 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2343c98adbaef6fee9ed7c851291d92a1b63502 Reviewed-on: https://chromium-review.googlesource.com/1011351 Commit-Queue: Chris Lu <thegreenfrog@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551710}
 - 
Rohit Rao authored
The custom bottom toolbar is removed in favor of the toolbar already built into UINavigationController. Showcase support is removed because this container is no longer materially different from a stock UINavigationController. BUG=805013,805201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8e78793ea73c411ad8c72cabe18568c4cb71840 Reviewed-on: https://chromium-review.googlesource.com/1015541Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551709}
 - 
Rune Lillesveen authored
Disabling flaky ServiceWorkerLazyBackgroundTest.EventsAfterRestart. TBR=lazyboy@chromium.org Bug: 834200 Change-Id: Ib0ec023bbd9edd2220e10cde3d9ed1b89a6191cd Reviewed-on: https://chromium-review.googlesource.com/1016606Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551708}
 - 
Vadym Doroshenko authored
This CL adds class NewPasswordFormManager as part of Password Manager redesigning go/new-cpm-design-refactoring. Now this class has very basic functionality. NewPasswordFormManager is aimed to replace PasswordFormManager Bug: 831123 Change-Id: Idd5e0e477ce939407c4c85dd49eb19412b098d04 Reviewed-on: https://chromium-review.googlesource.com/1012838 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551707}
 - 
chrome://policySergey Poromov authored
GAIA ID is now provided as part of PolicyData for user policies. It could be exposed together with user email if it's OK from privacy perspective. It will be useful because username field doesn't change on user rename and GAIA ID is now used for PolicyData user identification. BUG=831655 TEST=Open chrome://policy Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia4cfea54c80a2a5cfa7f9e8803f7ca50f9596c70 Reviewed-on: https://chromium-review.googlesource.com/1016903Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551706}
 - 
John Z Wu authored
//ios/web_view needs this to manage a list of credit cards. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I87815d790af5202d0f92183446398858a7febed7 Reviewed-on: https://chromium-review.googlesource.com/1014396Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551705}
 - 
Doug Arnett authored
Current implementation does not match spec. Bug: 834081 Change-Id: Ida585a10e38d002e1fc9333f1e16eeeb9dfc93d6 Reviewed-on: https://chromium-review.googlesource.com/1016000Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#551704}
 - 
Chris Hamilton authored
This acts as a "global" context for resource coordination signals that aren't appropriately aimed at any individual coordination unit. This will be required as part of the CPU and memory usage plumbing and aggregation. BUG=829575 Change-Id: I5424351924a77c378c49c2d7aca892464a2d5064 Reviewed-on: https://chromium-review.googlesource.com/999017Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#551703}
 - 
Elly Fong-Jones authored
These themes are Aura themes, but do not depend on USE_AURA or any Aura code, so it is fine to expose them on other platforms. This allows the Mac "legacy" omnibox to use the same logic around NativeThemeAuraDark as other platforms do. Bug: 826754 Change-Id: I69a6ffd5ebbb52cd2765edc99ec4b8c567e71e41 Reviewed-on: https://chromium-review.googlesource.com/1014738 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#551702}
 - 
Ryan Daum authored
Bug: b/76228145 Test: manual, unit test Change-Id: I5661da5cd92f37661a030bbc2d3b1cac2b8bdd39 Reviewed-on: https://chromium-review.googlesource.com/1016692Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#551701}
 - 
Jeremy Roman authored
These can just call base and net directly, leaving only the sandbox-specific WebFileUtilities::GetFileInfo. Change-Id: Iebfbede46212575ae27ab21f38ff3d5adcc58227 Reviewed-on: https://chromium-review.googlesource.com/1016135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551700}
 - 
gogerald authored
Bug: 833416 Change-Id: I9cbe9fdf66a4e8e75c10043b62fe18a8dc0039af Reviewed-on: https://chromium-review.googlesource.com/1014502 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#551699}
 - 
Mohsen Izadi authored
This reverts commit 23e0b326. Reason for revert: Suspected cause of net_unittests failures on Mac-10.10 Original change's description: > Add cookie security metrics > > Log the degree of protection against cookie theft, split by 1st/3rd > party. > > Includes a bit of TransportSecurityState refactoring (no functional > change) to provide easy access to HSTS lifetime. > > Bug: 749059 > Change-Id: Ib9ab7cff6a7fb4c65e84d7085e70ef13d5c00ba9 > Reviewed-on: https://chromium-review.googlesource.com/978142 > Reviewed-by: Nick Harper <nharper@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551644} TBR=isherman@chromium.org,tnagel@chromium.org,nharper@chromium.org,mkwst@chromium.org Change-Id: I9e7411956eb5d748b547edcf6aec7f40dde88d8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749059 Reviewed-on: https://chromium-review.googlesource.com/1017141Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551698}
 - 
Katie D authored
This should catch future regressions as we make changes to EventHandlers and EventRewriters for Accessibility. Change-Id: Ifd3b2e4554b9a0f8673c0bb0ebb5ddbd994501d5 Reviewed-on: https://chromium-review.googlesource.com/1015840Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#551697}
 - 
Christian Dullweber authored
When the activity is recreated, e.g. due to a change in font size, the ClearBrowsingDataFetcher instance that is shared between ClearBrowsingDataTabs and ClearBrowsingDataPreferencesBasic/-Advanced is not wired up correctly again. As the fetcher just acts as a cache for important sites and history data, we can store it in savedInstanceState when getting suspended. Bug: 834169 Change-Id: I49f3896ec669477736ca39e07fce5126f83e1f49 Reviewed-on: https://chromium-review.googlesource.com/1016621Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#551696}
 - 
Gauthier Ambard authored
This CL updates the asset for the "Add bookmark" action and adds a new asset for the "Edit bookmark" action. Bug: 829718 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I57afdc8fc963ff6620842c4ee3c105b2b8c97fb4 Reviewed-on: https://chromium-review.googlesource.com/1016604 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551695}
 - 
Yuichiro Hanada authored
Checking a window name is OK for now because NotificationSurfaces are not used outside ARC++. We will set an application id for a notification surface and use it in a follow up CL. Bug: 829383, 833259 Test: Manual. Inline reply on ARC notifications works. Change-Id: Icf3d43df527988f92ca88f7b89b673fdd02b00bc Reviewed-on: https://chromium-review.googlesource.com/1015440Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#551694}
 - 
Danyao Wang authored
This reverts commit f1291fb3. Reason for revert: broke test bot: crbug.com/834307 Original change's description: > [Nav Experiment] Propagate virtual URL in ReloadWithUserAgentType. > > This hides the internal URL used by WKBasedNavigationManager to force > create an entry in WKBackForwardList when reloading with a different > user agent type (see crrev.com/c/919175). > > Also fixed a bug in NavigationManagerTest which wasn't testing the > redirect case when GetParam() == TEST_WK_BASED_NAVIGATION_MANAGER. > > Bug: 833958 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I095178302bfc4d209c2d058aab736777cc8b2de4 > Reviewed-on: https://chromium-review.googlesource.com/1016002 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551548} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I82169134c6efc6e1574840eeaae311497d91b02f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833958 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1017140Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551693}
 - 
Jérôme Lebel authored
If the title in the user consent view doesn't fit on line, it should be wrapped. Screenshot: https://drive.google.com/open?id=1ucGkSOu0_YjoFaZMO_U2LNAqhrvUHyhE Related to: crrev.com/c/1009906 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id8ddc57e8f311146fadb4558427d082caa37bfac Reviewed-on: https://chromium-review.googlesource.com/1016607Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551692}
 - 
Scott Violet authored
This is *not* a complete implementation, but enough to pass some of the existing tests (copied from existing window service). BUG=none TEST=covered by tests TBR=tsepez@chromium.org Change-Id: I6d4bb9b3ead7a32eadb24c85c066a01c01188a51 Reviewed-on: https://chromium-review.googlesource.com/912395Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551691}
 - 
Ryan Hamilton authored
NOPRESUBMIT=true Change-Id: I622971eb17a86b299aeb9c088e3339e1112ea755 Reviewed-on: https://chromium-review.googlesource.com/1015600 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551690}
 - 
David Roger authored
The operator is already used in production, even though it was originally intended for tests only. This CL makes the operator available for production code, and fixes it so that it compares all the fields. Bug: None Change-Id: I87185529cd61dadf15408b65d09288f967a8fc1b Reviewed-on: https://chromium-review.googlesource.com/1016644Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#551689}
 - 
Leonard Grey authored
Bug: 827604 Change-Id: I67b0478de52e7f5bf4bd659afc5b305407072ee3 Reviewed-on: https://chromium-review.googlesource.com/1015514Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551688}
 - 
Gauthier Ambard authored
This CL force a layout of the toolbar when the loading state change, to prevent the button changing from "stop" to "reload" with an animation when there is another animation happening at the same time. Bug: 831763 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1bb5265c308067626ea00e154f8f18fd791701e5 Reviewed-on: https://chromium-review.googlesource.com/1016761Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551687}
 - 
Jan Wilken Doerrie authored
This change changes BluetoothAdapter::DiscoverySessionErrorCallback from base::Callback to base::OnceCallback. Furthermore, it updates relevant methods to pass it by value and to std::move instances of the callback. Bug: 821766, 834319 Change-Id: Ibac2304c7540f2e9d80069ff19abb36ccbbd5527 Reviewed-on: https://chromium-review.googlesource.com/1013944 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#551686}
 - 
Troy Hildebrandt authored
LocationBarLayout#getDisplayText used to exit early if we were viewing an NTP and avoid adding the LRM character on Android 4.2 and below. Since it no longer did, the location bar string wasn't technically empty but contained just the LRM character, causing the cursor and hint to disappear. This just adds a check to make sure we're not adding the LRM character to an empty string. Bug: 833437 Change-Id: Ia24b5f18d496ad77e9b4b437f977734c56dd519e Reviewed-on: https://chromium-review.googlesource.com/1015964Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551685}
 - 
Matt Menke authored
It's possible to URLLoader to have a posted ReadMore task when it learns its producer data pipe has been closed. If this happens, when ReadMore is executed, it would DCHECK, since reading from a pipe a consumer knows is closed it a possible symptom of a bug. This CL fixes that behavior, by deleting the URLLoader when either the data pipe or the client pipe is closed, or when the request is complete, rather than waiting for both consumer pipes to be closed. Bug: 832600 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0334773c8e701eb7dd106fa1c0fe0890e80861e7 Reviewed-on: https://chromium-review.googlesource.com/1012455Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551684}
 - 
Kent Tamura authored
New file name is wpt_update_expectations.py for consistency. Bug: 829697 Change-Id: I7a2a01c58ac277729af201819bb60a7004aa6141 Reviewed-on: https://chromium-review.googlesource.com/1014920 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#551683}
 - 
Mikel Astiz authored
As described in the design doc ([1], accessible for Google employees only), the proposed bridge integrates all relevant classes for syncing sessions and exposes a USS API for a processor to use. This includes propagating local changes to the server, as well as receiving remote updates for foreign sessions. The class is analogous to SessionsSyncManager and implements similar logic, although many bits are handled in SessionStore (preceding patch) to make the bridge simpler. Some functionality is still pending implementation, including the actual wiring to use the bridge instead of SessionsSyncManager. [1] https://docs.google.com/document/d/1UGM1yhHznmXvfeGvckdzBcrE6GLpgk7LsLmgPhFcIdk/edit# Bug: 681921 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I40ccfad85061076079ab3159f09fcea4a4e6c096 Reviewed-on: https://chromium-review.googlesource.com/911091 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551682}
 - 
Francois Doray authored
All uses have been replaced with the well-maintained base::Timer. TBR=kinuko@chromium.org Bug: 760326 Change-Id: I1542f0f03de11961e67ef4447966dd145327f886 Reviewed-on: https://chromium-review.googlesource.com/1012741 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551681}
 - 
Francois Doray authored
Previously, HostNameHandler::OnDeviceHostnamePropertyChanged() could synchronously wait for machine statistics to be loaded by a TaskPriority::BACKGROUND task while being called on the main thread: chromeos::system::StatisticsProviderImpl::WaitForStatisticsLoaded() chromeos::system::StatisticsProviderImpl::GetMachineStatistic() chromeos::system::StatisticsProvider::GetEnterpriseMachineID() policy::HostnameHandler::OnDeviceHostnamePropertyChanged() chromeos::NetworkStateHandler::NotifyDefaultNetworkChanged() chromeos::internal::ShillPropertyHandler::GetIPConfigCallback() This was problematic since a TaskPriority::BACKGROUND task can take "an arbitrarily long time to complete", and the main thread is supposed to be responsibe at all times. This CL fixes the issue by continuing the work asynchronously when machine statistics are loaded rather than waiting synchronously. Bug: 831835 Change-Id: Idde6fb85f584b0110e673025f83fe53b86b657ea Reviewed-on: https://chromium-review.googlesource.com/1012182 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551680}
 
 -