GitLab

Review URL: https://codereview.chromium.org/402903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/397743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284366 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284365 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178521:178524&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/407803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284364 0039d316-1c4b-4281-b951-d872f2087c98

OBJECTIVES

This change is to refactor RTCP handling in media/cast such that RTCP
message parsing is done in CastTransportSender.

This side effect of this refactoring is much cleaner code: RTCP handling
code are grouped under one module. VideoSender and AudioSender do not
handle packets directly.

This also affect the architectutre in Chrome that RTCP message parsing
is now done in the browser process. A parsed RTCP message is passed to
the renderer instead of raw packets.

REATIONALE

RTCP is used as a feedback mechanism in Cast Streaming. It used to be
parsed and handled by VideoSender and AudioSender in the render process.
This was very ineffective because packetization and sending is done in
the browser process. This created inefficiencies in packet
retransmission. It also made improvement to the transport protocol /
algorithm much more difficult. A side effect is very messy code.

DETAILS

Rtcp - This class is responsibile for maintaining a bi-directional RTCP
session. It is now owned by CastTransportSender.

CastTransportSender - It now performs packetization and also parsing of
incoming RTCP packets. RTCP packets are small UDP packets for signaling
only. Eventually retransmission can also be moved to this class. It will
handle all packet level send transport.

AudioSender / VideoSender - They don't handle packet directly any more.
Which means render process doesn't see raw packets.

FrameSender - Base class for AudioSender and VideoSender to share code
for RTCP message handling. Eventually AudioSender and VideoSender will
merge here but it is not the point of this change.

RtcpBuilder - Removed and merged with RtcpSender.

Net deleted 400 lines of code and simulation shows the same results.

BUG=393042

Review URL: https://codereview.chromium.org/387933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284363 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284360 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284358 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284357 0039d316-1c4b-4281-b951-d872f2087c98

Negate the vertical glyph offset in RenderTextHarfBuzz.
Also restores the hb_buffer_set_language call and comment.
These were victims of merge errors in r284297.

BUG=391203
TEST=Arabic diacritics are drawn correctly.
R=ckocagil@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/408733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284356 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284355 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes a past-the-end iterator and relands
https://crrev.com/284335, which was reverted in
https://crrev.com/284340.

TBR=estade@chromium.org,aruslan@chromium.org
BUG=270261

Review URL: https://codereview.chromium.org/403923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393677
TEST=Ran on Linux. The file loaded and all tests passed.

Review URL: https://codereview.chromium.org/404713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284353 0039d316-1c4b-4281-b951-d872f2087c98

This type has subclasses and is destroyed polymorphically, so the destructor
needs to be in the vtable. Found by clang.

Follow-up to https://codereview.chromium.org/252513004/

BUG=347693,82385
R=sky@chromium.org

Review URL: https://codereview.chromium.org/407653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394491

Review URL: https://codereview.chromium.org/407683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TEST=content_unittests
R=jam@chromium.org,jamesr@chromium.org
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/403453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284348 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284347 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178516:178520&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/406773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284346 0039d316-1c4b-4281-b951-d872f2087c98

Plus some minor style fixes, mainly clang-format the header. Source file
was not fully converted to Chromium C++ style, because it is too big to
be done manually and to be fun :/

BUG=331299
TEST=content_unittests, content_shell. No functional changes
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/393983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284345 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Four new pages added to tough_scheduling_cases (https://codereview.chromium.org/372243003/)

Reason for revert:
All new pages failing on all android bots.

Example:
http://chromegw/i/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1116/steps/scheduler.tough_scheduling_cases/logs/stdio

We shouldn't try to reland without some kind of unittest coverage (perhaps the smoke test?).



Original issue's description:
> Four new pages added to tough_scheduling_cases
> 
> BUG=391005
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282740
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284060

TBR=jdduke@chromium.org,skyostil@chromium.org,picksi@google.com,miletus@chromium.org,picksi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391005

Review URL: https://codereview.chromium.org/406783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284344 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Remove tilings from recycle tree when active tree removes them. (https://codereview.chromium.org/400633004/)

Reason for revert:
Related crashes are showing up on Android bots. Details in bug.

BUG=395398

Original issue's description:
> cc: Remove tilings from recycle tree when active tree removes them.
> 
> This patch is the second part of ensuring that recycle tree does not
> contain any unshared tiles.
> 
> This is done by removing recycle tree tilings when active tree removes
> those tilings.
> 
> BUG=393802
> R=danakj
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284311

TBR=danakj@chromium.org,vmpstr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393802

Review URL: https://codereview.chromium.org/407763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284343 0039d316-1c4b-4281-b951-d872f2087c98

Move the default event-targeting implementation for views from
View::GetEventHandlerForRect() into the new method
ViewTargeterDelegate::TargetForRect() and make the method
View::GetEventHandlerForRect() call into its effective ViewTargeter
instead. The "effective" targeter for a View is the
ViewTargeter installed on that View if one exists, otherwise
it is the ViewTargeter installed on its root view.

Once this change has landed, the overrides of
View::GetEventHandlerForRect() can be removed and their
implementations moved into overrides of
ViewTargeterDelegate::TargetForRect().
View::GetEventHandlerForRect() can then be made
non-virtual.

BUG=391845
TEST=existing coverage in ViewTest.GetEventHandlerForRect

Review URL: https://codereview.chromium.org/401933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284342 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use language-specific street address line separators (https://codereview.chromium.org/397233002/)

Reason for revert:
Broke 'Chromium Linux on Linux Clang (dbg)':

http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62289

AutofillDialogControllerTest.BillingVsShippingStreetAddress (run #1):
[ RUN      ] AutofillDialogControllerTest.BillingVsShippingStreetAddress
Xlib:  extension "RANDR" missing on display ":9".
/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.h:289:
    error: attempt to advance a past-the-end iterator 1 steps, which falls
    outside its valid range.

Objects involved in the operation:
iterator @ 0x0x7fffd4a50d58 {
  state = past-the-end;
  references sequence @ 0x0x7fffd4a50d58
}
Received signal 6
#0 0x7f716d77ecee base::debug::StackTrace::StackTrace()
#1 0x7f716d77e827 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f7168451cb0 \u003Cunknown>
#3 0x7f71648cf425 gsignal
#4 0x7f71648d2b8b abort
#5 0x7f7164ed25ad __gnu_debug::_Error_formatter::_M_error()
#6 0x0000026271ce __gnu_debug::_Safe_iterator\u003C>::operator+=()
#7 0x0000026270f5 __gnu_debug::_Safe_iterator\u003C>::operator+()
#8 0x000005506f39 i18n::addressinput::(anonymous namespace)::CombineLinesForLanguage()
#9 0x00000550703a i18n::addressinput::GetStreetAddressLinesAsSingleLine()
#10 0x000005548289 autofill::(anonymous namespace)::FillStreetAddress()
#11 0x000005547b91 autofill::AutofillField::FillFormField()
#12 0x0000055907cd autofill::FormStructure::FillFields()
#13 0x000004972335 autofill::AutofillDialogControllerImpl::Show()
#14 0x000001ec0f2a autofill::(anonymous namespace)::AutofillDialogControllerTest::SetUpControllerWithFormData()
#15 0x000001ece5c8 autofill::AutofillDialogControllerTest_BillingVsShippingStreetAddress_Test::TestBody()
#16 0x0000039fcc63 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#17 0x0000039e9f9e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#18 0x0000039e0e05 testing::Test::Run()
#19 0x0000039e151b testing::TestInfo::Run()
#20 0x0000039e1b0a testing::TestCase::Run()
#21 0x0000039e6118 testing::internal::UnitTestImpl::RunAllTests()
#22 0x0000039f5973 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#23 0x0000039ebb0e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#24 0x0000039e5da4 testing::UnitTest::Run()
#25 0x000005b72b61 RUN_ALL_TESTS()
#26 0x000005b71be7 base::TestSuite::Run()
#27 0x000005b8455d content::UnitTestTestSuite::Run()
#28 0x000003aa40d2 base::internal::RunnableAdapter\u003C>::Run()
#29 0x000003aa403c base::internal::InvokeHelper\u003C>::MakeItSo()
#30 0x000003aa3fea base::internal::Invoker\u003C>::Run()
#31 0x000002a29e9e base::Callback\u003C>::Run()
#32 0x000005b6b830 base::(anonymous namespace)::LaunchUnitTestsInternal()
#33 0x000005b6b527 base::LaunchUnitTests()
#34 0x000003aa3db5 main
#35 0x7f71648ba76d __libc_start_main
#36 0x000000715159 \u003Cunknown>
  r8: 00007f715f665980  r9: 00007fffd4a507d8 r10: 0000000000000008 r11: 0000000000000206
 r12: 00007fffd4a50aa0 r13: 0000000000000001 r14: 0000000000000001 r15: 0000000000000000
  di: 00000000000016b2  si: 00000000000016b2  bp: 0000000000000002  bx: 00007fffd4a50a30
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007fffd4a50828
  ip: 00007f71648cf425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000


Original issue's description:
> Use language-specific street address line separators
> 
> Fill street address into a single-line text input field with separators
> that depend on the language code of the profile.
> 
> TEST=components_unittests:AutofillFieldTest.FillStreetAddress*
> BUG=270261
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284335

TBR=estade@chromium.org,aruslan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=270261

Review URL: https://codereview.chromium.org/401103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284340 0039d316-1c4b-4281-b951-d872f2087c98

Apparently tryserver is not capable of doing tries with binary data so
we need to copy first then update the test.

This was discovered while doing https://codereview.chromium.org/403453002/.

BUG=338338
TEST=None
TBR=jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284339 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284338 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178515:178515&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/407743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/405673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284336 0039d316-1c4b-4281-b951-d872f2087c98

Fill street address into a single-line text input field with separators
that depend on the language code of the profile.

TEST=components_unittests:AutofillFieldTest.FillStreetAddress*
BUG=270261

Review URL: https://codereview.chromium.org/397233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284335 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/381593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284334 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284333 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178510:178514&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/401133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389314

Review URL: https://codereview.chromium.org/353043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284331 0039d316-1c4b-4281-b951-d872f2087c98

and Use ExtensionTestBrowserContext for ImageLoader unittest.

ExtensionsTestBrowserContext class does 
set TestExtensionsBrowserClient from constructor and
call DestroyBrowserContextServices from destructor.

ExtensionTestBrowserContext will be used instead of TestingProfile.

R=yoz@chromium.org, rdevlin@chromium.org
BUG=354046
TEST=unit_tests --gtest_filter=ImageLoaderTest.DeleteExtensionWhileWaitingForCache

Review URL: https://codereview.chromium.org/355223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284330 0039d316-1c4b-4281-b951-d872f2087c98

The cl defines a new job type for UPDATE_JOB and modifies the ServiceWorkerRegisterJob class to be able to perform this type of job in addition to the REGISTRATION_JOB. There is much in common between the two.

An update job is scheduled to run shortly after a page is loaded thru a service worker. The job checks for a new script resource and if found, goes thru the process of installing the new service worker and possibly activating it. Generally, activation has to be deferred until the page that was loaded closes. The update job sets up a deferred activation helper for that case prior to completing w/o having performed the activation.

BUG=371671
TEST=unittests

Review URL: https://codereview.chromium.org/380093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284329 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284328 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178495:178509&mode=html
TBR=abarth@chromium.org,johnme@chromium.org
BUG=

Review URL: https://codereview.chromium.org/400673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284327 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284326 0039d316-1c4b-4281-b951-d872f2087c98

wm::WMState isn't available or required on Mac.

This guards the wm::WMState in ChromeBrowserMainExtraPartsViews with an
#if defined(USE_AURA).

BUG=390755

Review URL: https://codereview.chromium.org/400543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284325 0039d316-1c4b-4281-b951-d872f2087c98

Windows build fix cherry-picked.
 
BUG=394484
R=eae,bashi,behdad

Review URL: https://codereview.chromium.org/396393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284324 0039d316-1c4b-4281-b951-d872f2087c98

> Allow EmbedRoot to be called multiple times.
> 
> Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window.
> 
> R=sky@chromium.org
> BUG=none
> 
> Review URL: https://codereview.chromium.org/403083002

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/405803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284323 0039d316-1c4b-4281-b951-d872f2087c98

Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/403083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284322 0039d316-1c4b-4281-b951-d872f2087c98