- 07 Aug, 2018 40 commits
-
-
Rune Lillesveen authored
This reverts commit 30d8a3b9. Reason for revert: Made SetIconAPITest.Overview test flaky (871720) Original change's description: > Fix flaky webrequest related network service tests in component builds > > These tests needed some extra synchronization due to the changes made in > http://crrev.com/c/1139048. These were flaking in component builds. > > Bug: 871224 > Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 > Reviewed-on: https://chromium-review.googlesource.com/1163987 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580980} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871224, 871720 Reviewed-on: https://chromium-review.googlesource.com/1165122Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581195}
-
Rune Lillesveen authored
Only one of the subtests reported flaky, but didn't know how to disable them separately. TBR=noel@chromium.org Bug: 871684 Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451 Reviewed-on: https://chromium-review.googlesource.com/1164958Reviewed-by:
-
Koji Ishii authored
TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I16f3f57a2389c3d48573817fb5e96a30a825e85a Reviewed-on: https://chromium-review.googlesource.com/1164867 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581193}
-
Oscar Johansson authored
When building using jumbo, files gets merged together and macros with the same name may end up in the same namspace and conflict. This happens for the macro UMA_HISTOGRAM_MBYTES. This commit solves the issue by moving the macro to a shared util file. Bug: 871163 Change-Id: If3af541913a6add55ce739eb43f5a747cf4afd9a Reviewed-on: https://chromium-review.googlesource.com/1163602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#581192}
-
Adam Rice authored
Display a console message (in the context of the page) when a WebSocket is created via the Pepper pp::WebSocket API. Also add deprecation warnings to the documentation. Tested by manual verification that the console message is shown when the PPAPI WebSocket browser_tests are run. Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3NYHaxhRs14/XOdUJBvHAwAJ BUG=870586 Change-Id: Ib4631d11cd94cecad6c42e6b3fb1fb81ffc2b7fb Reviewed-on: https://chromium-review.googlesource.com/1161712 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581191}
-
Jean-denis Muys authored
This CL is part of the long-term goal of eliminating SigninManager as a public API for Chromium's identity code, replaced by IdentityManager. signin_error_notifer_ash_unittest builds a fake signin manager. This is not necessary: tests succeed without that. So removed creation of unused fake signin manager from tests. Bug: 797899 Change-Id: I7bcfca18f2c94192e629385a7c481957387e7fec Reviewed-on: https://chromium-review.googlesource.com/1158685Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Cr-Commit-Position: refs/heads/master@{#581190}
-
Morten Stenshorne authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4dcc14002fc786887ed5dbbe1523c4ba22af94df Reviewed-on: https://chromium-review.googlesource.com/1163518Reviewed-by:
-
Morten Stenshorne authored
Orthogonal flow root children are going to need to calculate an extrinsic constraint space. We already got this right for direct block children, but not for floated children of inline child nodes. Three tests start to pass, but I wrote a new test as well, that's more to the point (it used to fail a DCHECK, and then render incorrectly, if we bypassed that). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7 Reviewed-on: https://chromium-review.googlesource.com/1162175Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#581188}
-
Philip Jägenstedt authored
TBR=markdittmer@chromium.org No-Try: true Change-Id: I7711071a625d3a98c06d09663541cd250e0b9839 Reviewed-on: https://chromium-review.googlesource.com/1164951Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581187}
-
Mohamed Amir Yosef authored
This CL checks bookmark fields for validity/existence before parsing them when migrating from directory to USS architectures in uss_migrator.cc. The original problematic code has been introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1162226 Bug: 516866,871671 Change-Id: I843c62325f3e3ec37ce05783c999bdfd5f3542a0 Reviewed-on: https://chromium-review.googlesource.com/1164946 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581186}
-
Manuel Rego Casasnovas authored
The CSSWG decided to change how percentage row tracks and gutters in a grid container with indefinite height are resolved. The CSSWG issues are: * https://github.com/w3c/csswg-drafts/issues/1921 * https://github.com/w3c/csswg-drafts/issues/509 So far they were resolved as "auto", like it happens with percentage heights in regular blocks. But now they're going to behave similar to what happens in the columns axis, they would be ignored to compute the intrinsic height. This causes that we need to repeat the track sizing algorithm when we have a grid container with indefinite height that has some percentage rows using the intrinsic height calculated on the first pass. Then the percentages will be resolved against the intrinsic height. We are adding two new tests for this new behavior on top of updating several tests that were using percentages. We also add a test for content alignment and the second pass when the row size changes, the last case fails due to crbug.com/871230. JFTR, intent to implement and ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/CJgcT4hR7Rk/58WfZNbWBQAJ BUG=846187 TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html TEST=css/css-grid/alignment/grid-content-alignment-second-pass-002.html Change-Id: I2a1959af6c95e0c47d294580599fdbf9bc432348 Reviewed-on: https://chromium-review.googlesource.com/1142409 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#581185}
-
Alexander Timin authored
In addition to existing limit of 200 messages in a single task also limit it to 10 milliseconds to avoid starvation. This logic will be removed when message-per-task mojo dispatching will be implemented. BUG=867133 R=mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1152815Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579751} Change-Id: Idb757ddbc91c3e732e34e834bf8e00cc2292ddb5 Reviewed-on: https://chromium-review.googlesource.com/1163782 Cr-Commit-Position: refs/heads/master@{#581184}
-
Jan Krcal authored
This CL implements the following features in the wallet_metadata USS sync bridge: - caching current sync data and filling the cache on start, - informing the processor the bridge is ready to sync, - reacting to local single modifications of server profiles and cards (i.e. to updating the use stats when the address/card is used). Bug: 853688 Change-Id: I07405e02cdf9cd0eb814179d883594253859845c Reviewed-on: https://chromium-review.googlesource.com/1151628 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581183}
-
Gauthier Ambard authored
This CL disables JavaScriptDialogTestCase/testShowJavaScriptAlert and PrintControllerTestCase/testPrintNormalPage as they are failing on iPad iOS 10 simulator for the multitasking test suite. Bug: 871685 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0486941bdfcba501001e6c3e8e6e3ff0c997245a Reviewed-on: https://chromium-review.googlesource.com/1164944 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#581182}
-
jdoerrie authored
This change simplifies and generalizes base::STLIsSorted() by dispatching to std::is_sorted() and allowing C arrays as input containers by making use of std::begin() and std::end(). Bug: NONE Change-Id: I6c29fb2aea508b10420a2703d96d5306a849444e Reviewed-on: https://chromium-review.googlesource.com/1160163Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#581181}
-
Scott Wu authored
The purpose is to share this logic with both ios chrome and ios web view Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id6f16a05eb3408238c2772b420ec408e499ed2e8 Reviewed-on: https://chromium-review.googlesource.com/1151181Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581180}
-
Gauthier Ambard authored
This CL updates the top margin of the SideSwipe image, which is otherwise wrong after changing device orientation as the toolbar height is different. Bug: 869902 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I767ab0fa76fea9c538e4e2c4e1ad49bc86b0d652 Reviewed-on: https://chromium-review.googlesource.com/1158826Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#581179}
-
Hayato Ito authored
This is a follow-up CL after http://crrev.com/581145. Rewrite each caller of EventTarget::DispatchEvent(Event*) to use EventTarget::DispatchEvent(Event&). Now we can remove EventTarget::DispatchEvent(Event*). There are still a lot of other places where Event* should be replaced with Event&, which can be addressed in another CL. See also http://crbug.com/871662, where we might want to make various Event::Create(..) functions return a reference, instead of a pointer. BUG=871637 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If2e04cbaeea4b540428937dea6a1f9eedf7821ba Reviewed-on: https://chromium-review.googlesource.com/1164806Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581178}
-
Koji Ishii authored
This patch removes fragments after ellipsis when 'text-overflow: ellpisis' is applied. When the container box has paddings, ellipsizing is computed for the content box, but clipping is performed for the padding box. This patch hides fragments that fall into the paddings. We may need to revisit how to hide them. Before this patch, we moved them outside of the content box. With this patch, we stop producing fragments for them. Neitehr is paint- effects as the spec defines, and may require other parts to special case. I'll explorer other options if problems arose with this approach. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I44256440b4afbf1f4caf35269abf3450372fbf65 Reviewed-on: https://chromium-review.googlesource.com/1158670 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yi Su authored
Current Copy Image feature downloads the image outside WKWebView. This CL adds functionality of fetching image's data by JavaScript in 2 steps: 1. Draws <img> to <canvas> and exports it; 2. If 1 failed, downloads the picture by XMLHttpRequest, which may be responsed from cache. Both 2 methods may fail due to cross-origin restriction, but under different conditions. More info in this design doc: https://docs.google.com/document/d/1twZ1-Ssn4_9L4eN23-7H-wJkKKWSWLJTSt6Kwn0DqsU/edit?usp=sharing Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12bac9d6bd40b4c42d35a23745edaa4dca9fa071 Reviewed-on: https://chromium-review.googlesource.com/1145276 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#581176}
-
Gauthier Ambard authored
This CL updates the ConsentBump ViewController such as it is showing the "More" button instead of "Yes, I'm in" when the view isn't scrolled to the bottom. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib31c7622007c0aab713e15aed9a6f277b751c837 Reviewed-on: https://chromium-review.googlesource.com/1163681Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#581175}
-
Gauthier Ambard authored
This CL updates the SideSwipe animations, using transforms instead of modifying frames. Modifying frames wasn't working as expected as the cards are positioned using autolayout. Bug: 867968 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3532a50a50078c07ee68e4c47f59c426c7dd461c Reviewed-on: https://chromium-review.googlesource.com/1158824Reviewed-by:
-
Makoto Shimazu authored
Previously ChromeDoNotTrackTest only tested updates in RendererPreference instead of issuing actual network request. This CL is to change the test to send a request to check if the header is sent with respecting to the preference. Bug: 853085 Change-Id: I62d7eb88b3fea14db68baf5a23d1c44b4e8ab8db Reviewed-on: https://chromium-review.googlesource.com/1164862Reviewed-by:
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray should keep the position of the notification list from the bottom of the notification. Notifications should be pushed up when UST is expanded, and the notification right under the expand button should be the same one. TEST=manual BUG=856060 Change-Id: I0393dadca02a2e1d633a5a7e3fa165b7c4e3ba82 Reviewed-on: https://chromium-review.googlesource.com/1164807 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581172}
-
Adam Rice authored
Update TransformStream to standard version https://github.com/whatwg/streams/commit/51227372cc84846bdcf68312724c4cac6a4b9e58 Remove failing test expectations. Changes: The order of access of strategy parameters has been changed to match the standard. This mostly only affects the tests that are looking for it. Algorithms are cleared out once they will no longer be called, enabling garbage collection. Bug: 866388 Change-Id: I26a062acee86112d72aeae439f461b4a1713babd Reviewed-on: https://chromium-review.googlesource.com/1146533Reviewed-by:
-
Luciano Pacheco authored
Metadata backend raise an error if we pass a non-Entry object. This fixes an error when clicking on "Drive > Shared with me". Bug: 867974 Change-Id: I741c310c86b1481823dc9fa5bd84575050c428d3 Reviewed-on: https://chromium-review.googlesource.com/1164802 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581170}
-
Momoko Sumida authored
Currently, empty CSSStyleSheets can only be constructed using a constructor method. This CL adds Document.createEmptyCSSStyleSheet so that it can be tied to document in the future. Tying it to document restricts the use of a CSSStyleSheet in different documents, which means CSSStyleSheets can only be used in the documents where they are constructed. This will reduce security risk. Note: The constructed CSSStyleSheet is not currently tied to the Document yet Constructor method will be deleted in another CL createEmptyCSSStyleSheet(CSSStyleSheetInit) produces an empty CSSStyleSheet, while createCSSStyleSheet(text, CSSStyleSheetInit) creates a CSSStyleSheet with text Link to related comments in discussion: https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786 https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056 Bug: 807560 Change-Id: I94ea6f795deaf0dee67fba5c2705c8749ac72da8 Reviewed-on: https://chromium-review.googlesource.com/1160422 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#581169}
-
Greg Kraynov authored
SequenceManagerPerfTest now runs in both environments. Bug: 828835 Change-Id: Ib06dc1bbabd4fe972c428605247f6bf86b2c9825 Reviewed-on: https://chromium-review.googlesource.com/1163883Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581168}
-
Elad Alon authored
Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: 1. If the policy was disabled before, and becomes enabled, subsequent calls to StartRemoteLogging() will succeed (barring unrelated issues), even for peer connections created while the policy was disabled. 2. If the policy was enabled before, and becomes disabled: a. Peer connections associated with the profile reject calls to StartRemoteLogging(). b. Active logs (associated with the profile) are stopped, and those log files deleted. c. Pending log files (associated with the profile) are deleted. d. If a log file associated with the relevant profile is currently being uploaded, the upload will be cancelled, and the file deleted. Bug: 775415 Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f Reviewed-on: https://chromium-review.googlesource.com/1162168Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#581167}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: Ieb39e079c26a508f11fe582b7419bf47b1be696a Reviewed-on: https://chromium-review.googlesource.com/1164804Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581166}
-
Giovanni Ortuño Urquidi authored
Some clients like Default Apps and Policy Apps install apps without a Browser window. Some steps can be skipped for these clients, like sending the install event to the page, but other are needed for example creating shortcuts. Changes BookmarkAppHelper to not return early if there is no Browser window but still skip some unnecessary steps. Bug: 844278 Change-Id: I24003ff51d47937dc349aafca67912224db1eab2 Reviewed-on: https://chromium-review.googlesource.com/1164160Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#581165}
-
Rakina Zata Amni authored
TBR=kenrb@chromium.org Bug: 871648 Change-Id: Iff588adef9a640e699bb8d50009d83d2a1987f58 Reviewed-on: https://chromium-review.googlesource.com/1164803Reviewed-by:
-
yoshiki iguchi authored
This CL introduces the feature to defer events from notifications until the device unlocks, add adds the UI to encourage user to unlock the clicked notification to perform their events. The main concept of this CL is introducing LockScreenManager to message center code, which intercepts the event handlers in MessageCenter and defers the event if necessary. And Ash has the implementation of LockScreenManager named AshMessageCenterLockScreenManager, which handles message center events depending on the status of the lock screen. PRD: go/notification-on-lock-screen Bug: b/79951342 Test: added tests pass Change-Id: I3be8897598eda490590217837a7169d7505877e7 Reviewed-on: https://chromium-review.googlesource.com/1161715 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581163}
-
Koji Ishii authored
This patch marks outline-related failures in FlagExpectations for LayoutNG. TBR=atotic@chromium.org NOTRY=true Bug: 835484 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib5bba0976d0bae63d838c4b02f3f6be33ede8e30 Reviewed-on: https://chromium-review.googlesource.com/1164819 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Nicholas Verne authored
Crostini linux containers are going to use a new Cicerone based API for setup. This will allow us to surface more install progress for users. A future CL will wire this in to CrostiniManager and CrostiniRestarter. Bug: 860094 Change-Id: Iea91285af1bd42e5bb8ecfd5f62f66091b7e6eae Reviewed-on: https://chromium-review.googlesource.com/1163350 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581161}
-
Yutaka Hirano authored
No-Try: True Bug: 871578 Change-Id: I90e8d63d4d0424cfa189db3ba726022c7b30c6eb Reviewed-on: https://chromium-review.googlesource.com/1164809Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#581160}
-
Rakina Zata Amni authored
TBR=msw@chromium.org Bug: 871652 Change-Id: Ic5ecabf54b1915a3c29cdf65d4bcc4e400300840 Reviewed-on: https://chromium-review.googlesource.com/1164805Reviewed-by:
-
David 'Digit' Turner authored
NOTE: This is a reland of the following CL which was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1131190 The revert was due to a problem with an internal clank/DEPS runhooks step that calls jinja_template.py (see BUG entry below for details). The new CL was checking inputs by defaults, which would raise an error during gclient sync. To ease review, the first CL on gerrit is the original one, unmodified, and the second fixes the issue. ---- end of NOTE ------ ProTip: start by looking at the action_with_pydefps() definition in internal_rules.gni to review changes in this CL. This CL tries to make "gn analyze" smarter by ensuring that it knows about Python module dependencies, for any python script under //build. At the moment, these dependencies are computed by build_utils.WriteDepFile() automatically (unless the add_pydeps=False argument is passed). This adds all imported module paths to the generated .d file written by the script. Unfortunately, because this .d file is generated by the actions, the corresponding Python sources are not part of the target's inputs, known by GN at parse time, and thus do not appear in "gn analyze" properly. This CL tries to solve the problem by adding a new template named "action_with_pydeps", which acts as "action", but also expects a foo.pydeps file for every foo.py invoked through the 'script' scope variable. This '.pydeps' file is read directly at GN parse time and added to the action's target inputs. These .pydeps contain the path of each imported module, one per line, and are generated with build/print_python_deps.py Benchmarking shows no significant difference in the time taken to perform a "gn gen out/Release" on a full Chrome for Android checkout. This also needs a PRESUBMIT.py step that ensures that all .pydeps files are up-to-date with regards to their corresponding .py source files (this can be done with 'gen_pydeps.py --check .../foo.py') + Remove some --depfile options on a few Python scripts that don't need it anymore (e.g. when their inputs and outputs are now fully known by GN at parse time). + Remove uses of compute_inputs_for_analyze in rules.gni and internal_rules.gni (as well as exec_script() calls to print_python_deps.py). Note that the variable itself is still needed for grit inputs, see tools/grit/grit_rule.gni for details). BUG=870845,843562 R=agrieve@chromium.org, estevenson@chromium.org Change-Id: Id1f606a0c9df9e4e8971fd885ac0394103ca7b03 Reviewed-on: https://chromium-review.googlesource.com/1163512Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#581158}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If74a5b3fa28406bacfe489cff08e9bd636bef897 Reviewed-on: https://chromium-review.googlesource.com/1164842 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581157}
-
Rune Lillesveen authored
This reverts commit c9cbab07. Reason for revert: Caused flakiness https://crbug.com/871601 Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If5d71d67ad54ed590408c7ef1af0c71431c788d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164822Reviewed-by:
-
