GitLab

This change removes CrostiniAppRestartView, replacing it with:
* Construction and configuration of a bare View + DialogDelegate pair
* A pair of public functions that create and show this dialog

This change also adds some unit test coverage for this dialog to
ensure that I didn't break it when doing this refactor.

This change also fixes a bug in the dialog found by the new tests: the
message used for the body was being given a parameter that was never
used, which would have caused a crash if it had ever happened in a debug
build.

Bug: 1075649
Change-Id: Ia29640e1e47bd96c2996eba6c39722c477ff4aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#819545}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490518
Cr-Commit-Position: refs/heads/master@{#819979}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I5a893ecb7ac4756396d9e5e47799900840207894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492564Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819978}

See upstream change at
https://quiche.googlesource.com/quiche/+/557dfbcce6630971df1722e6add40c5c1db44144.

Also rename ElideSpdyHeaderBlockForNetLog* and
SpdyHeaderBlockNetLogParams accordingly.

Change-Id: I6980bafe2eaa7a1830dbd59d1b407aee356d9a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491314
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819977}

What:
Adds new output for all newly obsoleted histograms.

Why:
It can be useful when modifying histogram suffixes to see what
histograms are being obsoleted, especially when removing individual
prefixes.

One motivating case is: https://crrev.com/c/2441189

This change also updates extract_histograms.py to support pulling
the obsolete reason of <affected_histogram> tags.

Bug: 1133522
Change-Id: I376d7ae54c40609c6784a97dd595419fdeb31d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490923
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819976}

Change-Id: I0168ff4b278c1542600313dc7f3c1d7bed3d580b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492600
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819975}

This field is unused.

Bug: 482049, 1015882
Change-Id: Iea504c2c9589db5dc3fe63e8970ff77b3ccb117f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490257
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819974}

This file has to be updated every time a new OS settings section is
added, so let OS settings owners review it.

Bug: none
Change-Id: If3e5c431512c00665081edd823e3b2f64ae69d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492941Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819973}

Instead, refer to Android Activity and ActivityLifecycleDispatcher.

Bug: 1123209
Change-Id: Ib073793ec0f78b7c7b1e0fcd9216f2fb9bf9b757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472614Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819972}

Bug: 1126640
Change-Id: I99157fecb5c912d38521bec33946e2e92824895e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485518
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819971}

Not all lorgnette scanners have model names which include the
manufacturer. Check for the manufacturer at the beginning of the
model, and if it does not exist, add the manufacturer to the
display name.

Bug: b:171478580
Change-Id: Idd0bfdeca538e055c9ef7a7a5ad7e04f4b059bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492545Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819970}

QuickAnswers is a sub-feature from the Assistant team.

Bug: None
Change-Id: Ia706c1d595d4915fcd22d18bb04545950575fb31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478022
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819969}

BUG=1140170

Change-Id: Ia48e945f7b0c16d76daa28a12bf63afd646d2224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485149Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819968}

This CL adds  new color id for Guest Avatar icon and rename the current
color ID to be incognito specific.

Screenshot:
https://screenshot.googleplex.com/33fFdKX72CHeaEm.png

Bug: 1105763
Change-Id: Ie2e6c37c7898dbfa11eacc02804f01f3128ca461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489890Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mariam Ali <alimariam@google.com>
Cr-Commit-Position: refs/heads/master@{#819967}

Some meta-data attributes need to be in the base module's manifest to
make Play happy when uploading. This moves all the meta-data attributes
for consistency.

Bug: 1141430, 1126301
Change-Id: I62924da23532739de1ca370be88a5ac69eeeb83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491986
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819966}

Several places compare a FrameTreeNode id to a sentinel value, "-1," to
check if it's valid. We replace instances of "-1" to a suitable constant
representing this sentinel value:
content::RenderFrameHost::kNoFrameTreeNodeId or
FrameTreeNode::kFrameTreeNodeInvalidId.

Bug: None
Change-Id: Ia52662396bc32d999b8a98c683aa443a10fd016c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490505Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819965}

This trades off some size for performance.

Binary-Size: Trading size for speed
Bug: 1125115
Change-Id: If18e8ef4449dec6aab4494fa7d04063d8d94b845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491540Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819964}

The check was never updated to support --gn-paths.

Also adds missing --output arg to error messages when missing.

Bug: 1141255
Change-Id: I1e5fa5b6926247f3f00ae2687c72b894c666e2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491521Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819963}

Finishes transitioning layout and GPU tests from using "web_engine" to
using "web_engine_with_webui" instead, and strips unused resources from
"web_engine".

Bug: 1092729
Change-Id: Id6da0e6a051554ee330a219e15e4c9ae25775413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485341
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819962}

This flag is not used for other platforms except MAC so wrapping it in
the Chromium code search has a bug where references for Mac are not
indexed (128985) so it is confusing that code search doesn't show the
four references to this flag inside the #if defined (OS_APPLE) in
gl_renderer.cc.

Bug: n/a
Change-Id: Ife127ec0297e7fccb41e6be68665cde29210b0cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488722Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819961}

https://quiche.googlesource.com/quiche.git/+log/5504d2fb5434..37c5f8fa5ffc

$ git log 5504d2fb5..37c5f8fa5 --date=short --no-merges --format='%ad %ae %s'
2020-10-21 renjietang Fix original issue of QNZR by only forcing the first CHLO to be inchoate. Also replace the connection option with QNZ2.
2020-10-21 quiche-dev Rename SpdyHeaderBlockPeer to Http2HeaderBlockPeer.
2020-10-20 bnc Introduce granular QPACK encoder/decoder stream error codes.
2020-10-20 mattm Add flag counts for quic_enable_aead_limits and quic_key_update_supported.
2020-10-20 danzh Add QuicPathValidator implementation.
2020-10-20 mattm Add kMaxValue alias to KeyUpdateReason enum.
2020-10-20 quiche-dev Record stats for packets reset for missing connection ID & version.
2020-10-20 dschinazi Send version negotiation in response to short connection IDs
2020-10-20 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock, with a using alias.
2020-10-20 vasilvv Replace QuicheWrapUnique with absl::WrapUnique.
2020-10-20 dschinazi Reduce number of packets sent by ROWP
2020-10-20 vasilvv Replace QUICHE_ARRAYSIZE with ABSL_ARRAYSIZE. Delete QUICHE_ARRAYSIZE.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ie948110e226652a14c84e5927520d70e1528ffb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491516Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819960}

Use of base::Bind and base::Callback is deprecated in favor of the more
explicit Once/Repeating versions. A presubmit enforces this, except on
a set of files and directories that have not yet been converted. This
list, however, has not always been updated when a directory is migrated.
This cl removes the legacy exemption for a number of directories that
have been converted over, but not yet removed from the list. This will
help prevent regressions.

Bug: 1141533, 1007649, 1007666, 1007703, 1007704, 1007835
Change-Id: I1ab08a12fb8eded644272440c7d1d4d0acc9f033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490801Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819959}

This code path is used by chrome://downloads, devtools, and elsewhere
to show a file in the operating system's native file explorer. Wire the
call in lacros to the equivalent call in ash via crosapi.

This is a new interface, instead of part of "SelectFile", because
SelectFile deals exclusively with opening/saving files. It's an
implementation detail on Chrome OS that the open/save dialog and the
general purpose file explorer share the same implementation.

Bug: 1139128
Test: Download a file, "Show in folder" in chrome://downloads works
Change-Id: I6234ea03e673ca4c9ca2566721e281d52041e101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488396
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819958}

Tell ANGLE that it doesn't need to perform robust resource init
on the result texture for YUV to RGB copies because the entire
result will be overwritten.

Also block GLES clients from modifying the resource initialization
state.

Bug: chromium:1132514
Change-Id: Ie233bc129a4e3acdd13e77110b2dc572347bbf15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476414Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819957}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3a1dbae309e..bf66f2d5f6b3

2020-10-22 brucedawson@chromium.org Allow TLS 1.2 and print error codes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I75bfc01b02e89a0e5fc08868d1d1451ce110ca05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492168Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819956}

This patch avoids to check for "auto" margins
if MayHaveMargin() is true in BlockAlignment().

The patch also modifies the calls to SetMayHaveMargin()
so they are also called for "auto" margins.

BUG=1098231

Change-Id: I400c0c0b92f52ffbd4c0333a27e17e7083c4bae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489301Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#819955}

This reverts commit 41d30701.

Reason for revert: to investigate crbug.com/1139657. I did run revert and ony saw 0.5~0.9% improvements. I'll revert this first and reland with ctor change.

Original change's description:
> Introduce gfx::MaskFilterInfo to define a filter based mask on a layer.
>
> This is a preparation to add GradientMask[1] support.
>
> [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit#
>
> Bug: 1039003
> Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817987}

TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1039003
Change-Id: If5c3d49100e0bbb4dcd712b0e158c29536f79d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491242Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819954}

Prior to this CL, only the StackLayoutBase, OverviewListLayout and
StartSurfaceLayout calls Layout#doneShowing.

With crrev.com/c/2486623, LayoutStateObserver#onFinishedShowing should
be called on all Layouts, not just the three above. This CL make sure
Layout#doneShowing is always called when Layout finish showing.

Change-Id: Iebf5b36eb231a3001694ae9801109535f1735734
Bug: 1108496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483031Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819953}

Bug: 1138541
Change-Id: I3984809ea6144823145d70eaeb443c730563fb4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473379
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#819952}

No change to behavior. This removes the Variations.AppSeedRequestState
histogram and the associated tests.

Fixed: 1130651
Test: run_webview_instrumentation_test_apk -f *Variations*
Change-Id: If7102fe04758c864e00cadd671fc4875af98322a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491184
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819951}

These histograms were obsoleted recently.

I would like to bring them back to validate the hypothesis that the
HistoryQuickProvider / InMemoryURLIndex cache is not needed.

Details of experiment: go/chrome-omnibox-hqp-ablate-cache-file

Specifically, my theory is that the time it takes to restore + save the
cache file is in the same order of magnitude as it takes to rebuild the
index from the History DB.

The cache causes two known problems:
 1. Saving it is responsible for roughly 10% of shutdown hangs.
 2. Restoring it seems to take a lot of memory.

This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/2324551

Bug: 750845, 1032679, 1141539
Change-Id: I7e679c0ba602cf48ab10ad0a89bd75bc3dbf5ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490148Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819950}

When cl/331651056 landed in the QUICHE shared code and changed
QuicConnectionDebugVisitor::OnPacketSent, it failed to update the
overrides in Chrome. This caused us to stop sending
QUIC_SESSION_PACKET_SENT events to netlog. This CL fixes that
and adds a test to ensure we don't regress.

R=renjietang@chromium.org

Bug: 1141254
Change-Id: I2f6679ffa42779901cc9c088fbbff716f4e56a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492167
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819949}

Server-side CL: http://cl/337577068.

Bug: 1138689
Change-Id: Id73358981c6f70afc4977ee86805d2e2a2a3fc57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482046Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819948}

This CL adds a histogram to track the number of frames produced in
either sRGB or Wide. It does not include HDR frames.

This will be used to see how (in)frequently users see wide colors.

Change-Id: I36ec1cad6177411a298d7f2e9f8cd413ce60235f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458546Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819947}

The output or temp files do need to be writeable, but the input files
do not, e.g. https://source.chromium.org/chromium/chromium/src/+/master:chrome/services/file_util/public/cpp/sandboxed_zip_analyzer.cc;l=45;bpv=1;bpt=1

Bug: 1130762
Change-Id: I22773721de3ec35c920e45f3a1ec29e4a31d32dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486458Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819946}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ea52b3c2d270..3b334b2b8e1a

2020-10-22 johnkslang@users.noreply.github.com Merge pull request #2429 from ben-clayton/test-gn-presubmit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com
Change-Id: I8b2719367162b1737307c1b1297ce8ab09def5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492165Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#819945}

It adds the English patterns, restricted to non-label values (i.e.,name and id attributes) to all non-English patterns.

Bug: 1141407
Change-Id: I093e0364df5cead253d6e164ce104bfde7dd26ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488564Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#819944}

The chromevox navigation of collapse button has been improved at
crrev.com/c/2032508. The collapse button is actually always enabled now.
Remove the useless logic of it.

Bug: 1131543
Change-Id: I3cb398ec7aed15f9eebcb53c567540b7ee3ac586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488385
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819943}

Add a feature to disable applying NetworkIsolationKey to reporting and
Network Error Logging. It's a bit late to hook up this policy, as NIK
is wired up through the reporting and NEL code; however, nothing is
actually passing in a non-empty NetworkIsolationKey yet.

Bug: 993805
Change-Id: I3c826384f7fea017f39e57443b573954ac787601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485173Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819942}

Right now, blink::SecurityOrigin's
  Create(scheme, host, port)
method smushes (that's the technical term, right?) the arguments
together with some URL glue substrings like "://", feeds the result into
KURL, and feeds the resulting KURL into the SecurityOrigin(KURL)
constructor.

Even though this mostly works, it's kind of complex, and it's different
than how the corresponding url::Origin(url::SchemeHostPort) constructor
works. The difference is that url::Origin(url::SchemeHostPort) imposes a
precondition that its input be valid, so that the resulting origin is
never opaque. This lets url::Origin(url::SchemeHostPort) just take the
given scheme, host, and port and store them in Origin's fields.

The immediate motivation for this change is that I'm working on a
concurrent CL that will fix up SecurityOrigin's handling of URLs with
port 0 (crbug.com/1136678). There are a bunch of parameterized
tests that take input structs containing a scheme, a host, and a port,
and they need to support arguments like
  {"file", "", 0}
which should yield the non-opaque tuple origin ("file", "", 0) with
serialization "file://", as well as arguments like
  {"http", "davids.website", 0}
which should yield the non-opaque tuple origin ("http",
"davids.website", 0).

In the latter case, the current implementation omits the 0 from the
string it passes to the KURL constructor, and gives back
  SecurityOrigin(KURL("https://davids.website")),
which means there's no way to construct these test cases for the URL
"https://davids.website:0", in a manner yielding an origin
distinguishable from one constructed with the default port.

Instead of the implemented fix, I considered just making the method
unconditionally add the port to the string it passes to the KURL
constructor. But this doesn't work for the {file, "", 0} case, because
"file://:0" is an invalid URL.

Bug: 1136678
Change-Id: Ifa5deadfd3a5a79fc6e00a2af1291c2063434203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464363Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819941}

DoScheduleCALayerInUseQueryCHROMIUM uses a signed int for the number of
textures. The handler correctly validates the buffer size is large
enough but does not validate that n > 0 before sending it to
DoScheduleCALayerInUseQueryCHROMIUM where it is silently cast to an
unsigned value.

Bug: chromium:1135937
Change-Id: I44d04c3c1b1c09ad20c265e0fd8dd5f88a93bfeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485532Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819940}