GitLab

The CryptAuthKeyRegistry stores key bundles that are enrolled with
CryptAuth. This storage is persisted as a pref, and retrieved on
construction.

Bug: 899080
Change-Id: Ifad5bb2d4ce38de43420061fb375f4fe43416ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1407257
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625238}

The specification (https://w3c.github.io/reporting/#queue-report)
states that the username, password, and fragment of the report URL
should be cleared before queueing a report. We were neglecting to do
this. This CL strips those fields so as to conform to the specification.

Bug: None
Change-Id: I9a04592ee14b3ab953de721b53208cde0cb9be0f
Reviewed-on: https://chromium-review.googlesource.com/c/1427249
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625237}

Interactive doodles don't use the image (data_uri field) included
in the ddljson response. Don't require that responses (on Desktop)
contain an image. Allow logo_cache to cache a doodle that doesn't
include an image.

Bug: 800170
Change-Id: I2161b4b2d33ffdaaa463dd9e59ed2c2f77a9cc1a
Reviewed-on: https://chromium-review.googlesource.com/c/1427564Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625236}

TBR=jochen@chromium.org

Bug: 924183
Change-Id: I149ca188f0aa18d7d8ab351460402987808fe8e1
Reviewed-on: https://chromium-review.googlesource.com/c/1430103
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625235}

Remove overflow shelf clip so that inkdrop ripples can propagate
outside the overflow bubble.

The mask isn't really useful in the first place anyway.

See before/after screenshots here:

    https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14

Bug: 631240
Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa
Reviewed-on: https://chromium-review.googlesource.com/c/1429639
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625234}

Added the following browser tests for the Autocomplete feature:
Retention Policy Flag ON:
- SubmitSimpleValue_Saves
- SubmitSimpleValue_OTR_DoesNotSave
- SubmitSimpleValue_Disabled_DoesNotSave
- RetentionPolicy_Init_SavesVersionPref
- RetentionPolicy_RemovesExpiredEntry
- RetentionPolicy_DoesNot_RemoveValidEntry

Retention Policy Flag OFF:
- SubmitSimpleValue_Saves
- SubmitSimpleValue_OTR_DoesNotSave
- SubmitSimpleValue_Disabled_DoesNotSave
- RetentionPolicy_DoesNot_RemoveExpiredEntry

Bug: 920620
Change-Id: Id422c68b06938a78e6c12a9011b520e59cc0e021
Reviewed-on: https://chromium-review.googlesource.com/c/1412503
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625233}

Currently, navigation predictor code defines two features:
kRecordAnchorMetricsClicked and kRecordAnchorMetricsVisible.
The original plan was to have two features to be used to
independently control two different behaviors of Chrome:
(i) UMA recording of metrics of the clicked anchor element
(ii) UMA recording of metrics of the visible anchor element.
However, we never got around to doing so, and actually used the
same feature to control all the behavior.

This CL merges the two features into a single one to make
code cleaner and simpler to understand. There is no functional
change.

Change-Id: Icedd78c9af50c0f2f76350d20d5af4bb13a7ca0d
Bug: 908725
Reviewed-on: https://chromium-review.googlesource.com/c/1416153
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625232}

This creates a HttpNegotiateAuthSystem interface which the network
service can implement which calls out to the browser process for token
generation. A NegotiateAuthSystemFactory can be passed through to the
HttpAuthHandlerFactory, which will be used in the Android network
service case to override the default android AuthSystem.

This has been manually tested on Android with the instructions here:
https://chromium.googlesource.com/chromium/src.git/+/lkgr/tools/android/kerberos/README.md
If there is a more robust way of testing, please let me know.

Bug: 922127
Change-Id: Ia858c157d823cafe13bcfcbd97dd19e8a85c6c68
Reviewed-on: https://chromium-review.googlesource.com/c/1413140Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625231}

With the shadowing warning enabled and a sufficiently new clang, there
will be warnings about gfx::Font::ITALIC (and STRIKE and UNDERSCORE)
shadowing gfx::ITALIC, coming from the enum gfx::TextStyle. To prevent
that shadowing, this renames the gfx enum values TEXT_STYLE_*,
including a new name, TEXT_STYLE_COUNT, for what would otherwise be
TEXT_STYLE_NUM_TEXT_STYLES.

This shadowing problem currently prevents content (where the shadowing
warning is already enabled) from using these headers together.

Fixes to other shadowing problems, including enabling the shadow
warning, will come in
https://chromium-review.googlesource.com/c/chromium/src/+/1421104
after this has landed.

Bug: 923078,794619
Change-Id: I3018054f06a2fd2dc04cc4e0e72e5a0d641e99c5
Reviewed-on: https://chromium-review.googlesource.com/c/1424799
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#625230}

This CL makes enum CanvasResourceType an enum class, and
extracts the ResourceType fallback list selection logic
out of CanvasResourceProvider::Create() -- so I can add a
DCHECK() to enforce similarity between vectors.

Bug: 920626
Change-Id: Icac251b0c1e7676b4eb0b1c6876a953858920eff
Reviewed-on: https://chromium-review.googlesource.com/c/1423348
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625229}

Add test to ensure that handling the fetch doesn't trigger stale
while revalidate loading.

Add test to ensure that scripts loaded trigger a stale while revalidate
cache hit and resource timing entries are correct.

The PR for the spec changes is here:
https://github.com/whatwg/fetch/pull/853

BUG=348877

Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518
Reviewed-on: https://chromium-review.googlesource.com/c/1383297
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625228}

This reverts commit 34d69265.

Reason for revert: breaks msan
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14500

Original change's description:
> Don't record first filling result for sign-in forms
> 
> The new form parser may decide that a form has no current-password element, but
> only new-password / confirmation elements. In this case, the parser sets the
> unique_renderer_id to 'undefined'. The credentials will be sent to the renderer
> for filling via manual fallback but the renderer won't ever fill (as there is
> no password element defined for filling.
> 
> This CL ensures that this case does not get recorded as a failure to fill. This
> is important because we record two metrics about the first fill attempt:
> PasswordManager.FirstWaitForUsernameReason and
> PasswordManager.FirstRendererFillingResult For websites that have a sign-up
> form followed by a sign-in form, we don't want to record the failure to fill on
> the sign-up form.
> 
> Bug: 918846
> Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f
> Reviewed-on: https://chromium-review.googlesource.com/c/1422018
> Commit-Queue: Dominic Battré <battre@chromium.org>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625178}

TBR=battre@chromium.org,dvadym@chromium.org

Change-Id: I3c68004b67b5fcc65511c611c2d205297596e782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918846
Reviewed-on: https://chromium-review.googlesource.com/c/1430581Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625227}

UX requests menus prefer right, not above.

In reference to the menu's anchor rect:
Above prefers in order:
 - Above and right.
 - Below and left
 - Below and right.

Right prefers in order:
 - Above and right
 - Below and right
 - Below and left.


Bug: 924367
Change-Id: Ida7a24703c97d9a13bc13f387c1ef70416ff8fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1428560
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625226}

PasswordSyncableService code used two methods in PasswordSyncStore
to retrieve all passwords FillAutofillableLogins() and
FillBlacklistLogins() and then concatenated the results.
This has three issues:
1- This unnecessarily hit the DB twice.
2- Each DB hit involved sorting over some string field that isn't
required.
3-Those calls don't expose the DB primary key of each form which
is required by the new sync architecture.

This CL is replace those APIs in the PasswordSyncStore with a single
API that returns all logins together with the corresponding DB primary
key.

This is in preparation for a later CL that would actually use this API
in the PasswordSyncBridge that belongs to the new sync architecture.

Since the methods FillAutofillableLogins() and FillBlacklistLogins()
are used in the password manager codebase, they have been moved to be
part of the PasswordStore interface rather than the PasswordStoreSync

Bug: 902349
Change-Id: Ic94b83fcc24dfc1833e07653426c064292be5ba7
Reviewed-on: https://chromium-review.googlesource.com/c/1424941Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625225}

Bug: 294171
Change-Id: I5d2b506816f7be51ecac2d2b761e516ba8dc350e
Reviewed-on: https://chromium-review.googlesource.com/c/1427020Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625224}

Bug: 923541
Change-Id: Ic5e2dbc0c6053e4bb5f2df792c894f45c8619580
Reviewed-on: https://chromium-review.googlesource.com/c/1426481
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625223}

https://skia.googlesource.com/skia.git/+log/d562545e8a23..4f81bb73311d


git log d562545e8a23..4f81bb73311d --date=short --no-merges --format='%ad %ae %s'
2019-01-23 reed@google.com remove all support for drawText


Created with:
  gclient setdep -r src/third_party/skia@4f81bb73311d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I66fb6cf8104ba5070db1f2a69d5dac1be14d5087
Reviewed-on: https://chromium-review.googlesource.com/c/1430501Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625222}

Sync dynamicmodule repository.

Bug: 912127
Change-Id: I738fb1a7f042f72975a4b28e5cafda9c06b23584
Reviewed-on: https://chromium-review.googlesource.com/c/1388155
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625221}

As a step to make to use IdentityManager,this CL replaces all uses of ATS
with IdentityManager's ones in chrome_signin_view_controller_unittest.mm.

Bug: 922800
Change-Id: I4d64e98af4ba8d4ca334d4e6d805b309758a9e08
Reviewed-on: https://chromium-review.googlesource.com/c/1429721Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625220}

Sync visual properties is only called in response to an IPC. The close
IPC drops the IPC route before removing the WebWidget so IPCs can't
arrive that would SynchronizeVisualProperties() after the WebWidget is
gone.

The one exception is the screen metrics emulator which can call it from
its destructor, but it is also destroyed in CloseWebWidget() before the
WebWidget is destroyed precisely to avoid these sorts of things (with
a TODO about how to make that more clear..).

R=avi@chromium.org

Change-Id: I0621f4e3f4a708dd209b996129b9e17a765d6296
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1427881Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625219}

Bug: 922713
Change-Id: Ia1cbb340b050878734a5e33d52b7f6adfd6b5f7e
Reviewed-on: https://chromium-review.googlesource.com/c/1428082
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625218}

Bug: 916991
Change-Id: Id978bded0e9906a3b6077ff7b00efa612593a70f
Reviewed-on: https://chromium-review.googlesource.com/c/1425726
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625217}

It is a precondition to enable warmer welcome notification.

Bug: b:123077811
Test: Manual
Change-Id: Iad04ba8f231e31aa969aecd4121735c94196dcfa
Reviewed-on: https://chromium-review.googlesource.com/c/1422758Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Yilei Li <yileili@google.com>
Cr-Commit-Position: refs/heads/master@{#625216}

Race conditions can lead to abort/pause events after the fetch is
complete, in which case they should be ignored.

This CL also adds an unrelated test for aborting from the UI.

Change-Id: I00a290581653c0243815a39b03340aea8899fb85
Reviewed-on: https://chromium-review.googlesource.com/c/1429987Reviewed-by: Mugdha Lakhani <nator@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625215}

height: <percent> sizes of flexbox could be incorrect after flexbox
resize.

Bug: 907911
Change-Id: I19616f7f9cda7cd55a7206b3bb379f4957fccd4c
Reviewed-on: https://chromium-review.googlesource.com/c/1428579
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625214}

Bug: 910218
Change-Id: Ic27b7153552e8ac6cd9a8ceb67207a4004607b4c
Reviewed-on: https://chromium-review.googlesource.com/c/1424847
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625213}

This updates the minimum SDK version to 19 (KitKat), which in practice
deprecates supports for Android Jelly Bean (SDK 16, 17, 18).

//components/cronet still needs to support Jelly Bean, so those
manifests are upgraded from SDK level 14 to 16, referring to the meta
bug for Jelly Bean support in cronet.

The WebAPK minSdkVersion will be updated in a different CL.

Bug: 923477, 922656
Change-Id: Ib1b8b4269d930a8cecb3e45d6ca3ff57f7006d00
Reviewed-on: https://chromium-review.googlesource.com/c/1423117Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625212}

I just learned about these guidelines through
https://chromium-review.googlesource.com/c/chromium/src/+/1340802/18#message-b68ecbafe6212025dd856998736431eea6a19991
and think they should be surfaced in base/OWNERS (which points to
base/README.md).

R=dcheng@chromium.org

Change-Id: I0acf3eec7a2d4e888eac4d15e9e8fbf8ad7acf02
Reviewed-on: https://chromium-review.googlesource.com/c/1422742Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625211}

This is a followup to http://crrev.com/366963 . That change made
the '--disable-web-security' flag have no effect unless the
'--user-data-dir' flag was also specified. This was done to encourage
the use of the '--disable-web-security' flag only for development
and not for general purpose use.

However, that change (locking '--disable-web-security' to
'--user-data-dir') was made only in one place in the Chromium code.
There are quite a few other places in Chromium that turn off security
features when '--disable-web-security' is specified, and none of
them lock it to the use of the '--user-data-dir' flag.

Therefore, move the lock to much earlier in Chromium startup, and if
the '--user-data-dir' flag isn't specified, remove the
'--disable-web-security' flag entirely from the CommandLine. That
way, this correctly locks together those two flags for all of
Chromium.

BUG=923523,327804

Change-Id: I9000f1fbd2c236a435d8dae25870dead870ddd55
Reviewed-on: https://chromium-review.googlesource.com/c/1423342Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625210}

This CL changes the init of the main BrowserInterface in BrowserViewWrangler to be
explicit, and to be done as part of creating the main Browser instance.

BrowserViewWrangler's -mainInterface implementation is now a simple (synthesized)
getter, and thus will return nil before -createMainBrowser is called.

BrowserViewWrangler's -incognitoInterface implementation now returns nil if there's
no mainInterface.

This mitigates the risks around calling -mainInterface prior to the main browser
being created. It does slightly change the timing of BVC creation (it's slightly
earlier), but at least now it's explicit.

TEST: The crash for this bug is triggered by auth service init forcing a sign-out
of a managed account, which causes MainController's removeBrowsingDataForBrowserState:
method to be called. The completion block in that method uses mainInterface to
disable user interactions. To test this fix, I added an explicit call to SignOut()
in AuthService::Initialize() and launched Chrome with a signed-in managed account.
It crashes as expected before this fix, and works fine afterwards.

Bug: 919932
Change-Id: Iaffb29cd7d0dfb5b54f3347755fc9e15f0aa4539
Reviewed-on: https://chromium-review.googlesource.com/c/1430239
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625209}

Bug: 916991
Change-Id: I1d22e80d3f942464a5e577210e8be3ae242565bd
Reviewed-on: https://chromium-review.googlesource.com/c/1424889
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625208}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2aeeb2d0..21b1ee52

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ief63e9c080afea332a1caacfff8526e5167879bb
Reviewed-on: https://chromium-review.googlesource.com/c/1430499Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625207}

Remove usage of deprecated base::Bind, base::Callback, base::Closure,
base::CancelableCallback and base::CancelableClosure types from gpu/*.
Where possible convert to the corresponding once type. Otherwise replace
with the repeating type which is equivalent to the deprecated type.

This CL is the second of multiple to cleanup callback types in gpu/*.

Bug: 714018
Change-Id: Ifc2af8ee36feed7815f053a5f53147fc983cb005
Reviewed-on: https://chromium-review.googlesource.com/c/1426010Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625206}

Bug: 860467
Change-Id: I71bab32bd386f425eee3837ceb7180d6a40b26eb
Reviewed-on: https://chromium-review.googlesource.com/c/1426787Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625205}

This CL refactors WebappSplashScreenController in preparation for not
having the WebApkActivity show a splash screen if
WebappInfo#isSplashProvidedByWebApk(). The code which should not run for
new-style WebAPKs is moved to SameActivityWebappSplashDelegate

BUG=918459
R=dominickn
TBR=yfriedman (For WebappUma rename)

Change-Id: Ie47b4b26590f6fa1606e0594c979591def9aaf75
Reviewed-on: https://chromium-review.googlesource.com/c/1408353
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625204}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/88d06ccdd29b..e409915310e1

$ git log 88d06ccdd..e40991531 --date=short --no-merges --format='%ad %ae %s'
2019-01-07 ejcaruso cryptohome: add UnmountEx method
2019-01-21 hmchu runtime_probe: report additional information for generic battery
2019-01-21 hmchu runtime_probe: Report "path" and "size" for storage device
2019-01-22 jkardatzke vm_tools: Cleanup IsContainerRunning dead code
2019-01-16 jkardatzke vm_tools: Remove unneeded VM ip, subnet, netmask from cicerone
2019-01-15 kdlee debugd: Sanitize print URIs before calling lpadmin
2019-01-14 ljusten system_api: Add login manager go protos
2018-11-28 briannorris shill: wifi: add RxBitrate
2019-01-07 jimmyxgong smbprovider: Add PremounOptionsProto

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 916991
Change-Id: I5538b70753139a3f041107cf370b4e721d080bf0
Reviewed-on: https://chromium-review.googlesource.com/c/1429988Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625203}

This CL adds a function to get a CSSPropertyName from a CSSProperty.

Change-Id: I76f0a09367a082142dd38bc48f82200a630be527
Reviewed-on: https://chromium-review.googlesource.com/c/1429643Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625202}

This patch depends on https://chromium-review.googlesource.com/c/chromium/src/+/1229234 which implemented a virtual accessibility view class.
I propose that we use the grid role for the table view and mark it readonly because in Views a table view is interactive like an ARIA grid.
On Windows it will be exposed as a list view control  and on Mac as a table view.
R=dmazzoni@chromium.org, ellyjones@chromium.org, sky@chromium.org, aleventhal@chromium.org

Bug: 811277
Change-Id: I9e02563f1220f300e7fd78dc4cbbf5ee5e585acb
Reviewed-on: https://chromium-review.googlesource.com/c/1363793
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625201}

This makes the datatype less special and reduces the complexity of
"core" sync, although further patches are needed to complete that.

Short term, the main goal is to avoid circular dependencies across
keyed services without subtle tricks to get references lazily, as it was
done for SessionSyncService (and more datatypes are coming).

TBR=asvitkine@chromium.org,pkasting@chromium.org,olivierrobin@chromium.org

Bug: 922971
Change-Id: I944f1a74fa9b843185393d0d34bb590a6e6a27f6
Reviewed-on: https://chromium-review.googlesource.com/c/1420737Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625200}

* Adds MutateAynchronously method to the mutator dispatcher.
* Adds tests for ansynchronous mutation.
* Stubs in API for notification of mutation state (pending/complete).

Note async mutations are not used outside of testing with the patch pending completion of the notification plumbing in a separate CL.

Bug: 791280
Change-Id: I91545306c71899945f797a641831257247849b86
Reviewed-on: https://chromium-review.googlesource.com/c/1409600Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625199}