- 09 Jul, 2019 40 commits
-
-
Peter E Conn authored
New Tab Page and Webapp Disclosure junit tests are failing on touchless builds. For the Webapp Disclosure these tests are not relevant - we would never show a disclosure on a touchless device. For the New Tab Page tests, they should probably be updated to test the touchless specific functionality, but I'll leave that to their team. For now the tests are just being disabled. Bug: 981871, 981870 Change-Id: I3c88fbd26cad3e67328f4c80c1101b9b7edc65fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692164Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#675659}
-
Sadrul Chowdhury authored
This reverts commit 1189f593. Reason for revert: Broke official builds on Windows. https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/91116 https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/91061 Original change's description: > Add GN args for using orderfile for Chrome OS > > This patch adds GN args to use an orderfile for linking Chrome. > By default, it's pointing a path will be updated by autoroller. > Chrome ebuild can also override the path to test a custom orderfile. > > This patch also consolidates the efforts across Android and Windows, > to have a configuration of using orderfile in build/config/compiler. > > Bug: chromium:950627 > Test: Chrome builds locally on Chrome OS. Android and Windows is not tested. > > Change-Id: If9fd06368da81e02488cb991c3b7490e6ed91363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672231 > Commit-Queue: Tiancong Wang <tcwang@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675412} TBR=llozano@chromium.org,hans@chromium.org,dpranke@chromium.org,agrieve@chromium.org,gbiv@chromium.org,bsheedy@chromium.org,manojgupta@chromium.org,tcwang@google.com Change-Id: Ifca0a426bf7fc616c9e7e0d7033a55da4de9865f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:950627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692238Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#675658}
-
Ella Ge authored
GetFrame can be null Bug: 981232 Change-Id: I25d504a32c1a9d14b9274e861edbadc6eafa6029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691144Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#675657}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It constructs the DeviceO2TSdelegate internally in DeviceO2TS constructor and passes DeviceO2TS as a constructor param to DeviceO2TSDelegate instead of having DeviceO2TS take in the unique_ptr to DeviceO2TSDelegate. This CL is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an OAuth2TokenService subclass. To allow for doing this folding incrementally, it's helpful for DeviceO2TSDelegate to have a pointer back to DeviceO2TS. In order to enable *that* without having to worry about the validity of the pointer inside DeviceO2TSDelegate, it's useful to have that pointer be passed in as part of constructing the delegate. Bug: 967598 Change-Id: Ia1d69b171da39e8817ce45b331b20413d81f3b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690951 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#675656}
-
Anton Bikineev authored
This patch mostly makes access to arena pages thread safe. Bug: 967258 Change-Id: I8b9ac8944093bc994c8d9a5f893b5662b74a9992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690871 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#675655}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26cfccc5f526..726371f57927 git log 26cfccc5f526..726371f57927 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 lalitm@google.com Merge "trace_processor: add support for wide mode" Created with: gclient setdep -r src/third_party/perfetto@726371f57927 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iceb1080f36b54bc267967a1cb3190d151b73f98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675654}
-
sczs authored
- Calculates the PasswordsTableView Modal target height based on the Modal width and not the Window's. - Uses safeArea bounds to calculate the Modal height, this will prevent overlapping to the Status bar. Bug: 981882, 981880 Change-Id: I421ab04420b323400db78899328665c41417b3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691035Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#675653}
-
Dave Tapuska authored
These tests accidentally were submitted with absl::make_unique and they fail when C++17 build flags are set. BUG=752720 Change-Id: Ia3ec81a155553236e937a8598f2ef174fb7c5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693022Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#675652}
-
Devlin Cronin authored
Stop recording Extensions.ResourceDirectoryTimestampQueryLatency. No one has been looking at it lately. Bug: 974993 Change-Id: Id4acfca6082d699bc9afea5607ecae4226b78b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691585Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675651}
-
Devlin Cronin authored
Push back the expiration of PageActionController.ExtensionsWithPageActions. This is still a useful metric to monitor. Bug: 975087 Change-Id: I54edf9969cd7dcf9514bfd2e8491e69c0fa585b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690813Reviewed-by:
-
arthursonzogni authored
There are actually two paths for loading about:srcdoc. 1. The default path for almost everything, driven by the browser. 2. Navigation driven by the renderer process for edge cases. Note: The 2nd path for edge cases is going to be removed in follow up. There is a slight difference in between the two paths. When using the browser path, the subresource loader for files is never provided, because its scheme is not 'file'. When using the renderer path, the subresource loaders are inherited from the parent. This CL adds a regression test and a fix for path 1). It consists of "inheriting" loaders from the parent frame, using existing code for this. This is already what is happening in code path 2). Note: Ideally, inheriting from the parent to the child should have been done in the browser process, but other reviewers and I aren't feeling confident enough. Providing the FileUrlLoader to the wrong document would give unknown origins access user's files. Previous attempt to fix this bug: https://chromium-review.googlesource.com/c/chromium/src/+/1554665 Bug: 949510 Change-Id: I1a7b75abb863076327ff26e7f2889a97ecfa249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660850Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#675649}
-
Yoav Weiss authored
Currently, Accept-CH-Lifetime tests are not covered by the bots, as content_shell had no persistency for them. Moving the CH logic to content/ [1] was a first step in that direction, but I never went ahead with the rest of it and enabled persistency in content_shell. This CL fixes that! It also rewrites the tests as they were no longer passing. Change-Id: I9c19bc52afd9ced5477da99ccce2e27ecc5d89c5 Bug:981027, 972569 [1] https://chromium-review.googlesource.com/c/1450127 Change-Id: I9c19bc52afd9ced5477da99ccce2e27ecc5d89c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687815 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#675648}
-
Nick Diego Yamane authored
Add Activate/Deactivate functions to PlatformWindow interface, so that DesktopWindowTreeHostPlatform can implement window activation and deactivation for ozone implementations. A concrete consumer for this API is Ozone/X11, actual implementation for it will be done in a followup CL. Bug: 973772, 981606 Change-Id: I51f0e147bf9b81544b52209d6197ae6da9ebe0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690049Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#675647}
-
A Olsen authored
The spinner is shown if it showSpinnerInitially is true, or when the save button is clicked. ShowSpinnerInitially is set to true if passwords are scraped successfully and so we have the ability to try and change the password without prompting the user for more input. The confirm-password-page now listens to the password change manager and if the auth fails, it prompts again, showing the error message "incorrect password". It doesn't listen for success - in this case, the dialog is closed. Bug: 930109 Change-Id: Ib497aceec64ad6981168689425bacf2eb634ebda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687539 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675646}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71fc7dc2e520..1540b3ba37cf git log 71fc7dc2e520..1540b3ba37cf --date=short --no-merges --format='%ad %ae %s' 2019-07-09 rmistry@google.com [perf_skottiewasm_lottieweb] Handle case where start TS of frame_id not added yet Created with: gclient setdep -r src/third_party/skia@1540b3ba37cf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: Id51b4810d8bd70d11e2fe9e2b26d922028b88b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692326Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 981376 Change-Id: I661b4984fe050f4022f918bd4897bd4e5bd6bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691094 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#675644}
-
chrome://webapksckitagawa authored
chrome://webapks wasn't correctly importing cr.js leading to issues with PromiseResolver not being found. Additionally, the deps in BUILD.gn were similarly not inkeeping with other examples. Examples for comparison: https://cs.chromium.org/chromium/src/chrome/browser/resources/welcome/welcome_win10.html https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/BUILD.gn?l=151&rcl=df853fc8595e494d6e6dceb36eda8763dbe2b56d Change-Id: I3c9f9a5a7b04df9ff6adc6c8b1ffcbafd03ddb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686867 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#675643}
-
Eric Willigers authored
<'font-style'>, <font-variant-css2>, <'font-weight'> and <font-stretch-css3> can each be 'normal'. When we consume 'normal' in the font shorthand, we no longer assume it belongs to the first of these that has not already been seen. Bug: 982237 Change-Id: I3f77f24e1c06650c760528f38920db48f3645e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692388 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#675642}
-
Monica Basta authored
Added more coverage to test DICE account reconcilor. This work is to verify the behaviour of account reconcilor after DICE is as we expect it to be. Bug: 981358 Change-Id: I9542e76d03cb62de6ca75e71f4b6c4015a925c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688839 Commit-Queue: Monica Basta <msalama@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#675641}
-
Matthew Cary authored
This makes it consistent with the IsValid methods of the region and mapping that it contains. Change-Id: Ibb893ec753f1adc0690da1b7162fd54b7c5bae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690845Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
W. James MacLean authored
This CL fixes RenderAccessibilityImpl::OnHitTest for OOPIFs by having the point under hit testing transform if it's going to be passed to an OOPIF. While the transformation used in this CL isn't fully general, it will fix the majority of cases. Bug: 977381 Change-Id: Ie2f3bfb9334c6f4a3f38680f2b8de887620fe26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687562Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#675639}
-
Javier Ernesto Flores Robles authored
Updates |ConfigureAppBarViewControllerWithCardStyle| to use dynamic colors. Refer to the following screenshots to compare the new and current colors. Current: https://drive.google.com/file/d/10qCWfVAOsX9qyAcsVxH2j4z0ITZxpjii New: https://drive.google.com/open?id=1Zg41IJbdRNy_inW0XkpVf-53yGXSK5J2 New [DarkMode]: https://drive.google.com/file/d/1W5GLOqs1pQRzLFwYnXhKZbP_boemtYCQ Bug: 976640 Change-Id: Ide94265446256cad561acea538ee1430bfa0d946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690852 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This changes AcceleratedVideoDecoder::SetStream() argument to DecoderBuffer. DecoderBuffer has any required information to decode. It may have additional info that is specifically necessary in AcceleratedVideoDecoder. For instance, it has frame sizes of spatial layers in VP9 SVC stream aside from bitstream data. This is a second step to enable VP9 k-SVC decoding with HW decoder on chromeos intel platform. Design doc for this change is go/VP9-k-SVC-Decoing-VAAPI. Bug: chromium:935411 Test: media_unittests Test: Hangout Meet with VP9 SVC stream Change-Id: I45ca9e6ea7e7c6b8ac619495049be51fa9aed486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686981 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#675637}
-
Alexander Timin authored
When --enable-tracing-output=FILE is not provided, use a filename which has some information about the test this trace was coming from and the result of the test. This allows us to easily trace multiple tests at the same time and trace repeated runs of the same test when debugging flakes. R=sky@chromium.org,eseckler@chromium.org BUG=976795 Change-Id: I578a38f4c5be30e8e38cc0ddf8847e0e30ffc64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667667 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#675636}
-
Mario Sanchez Prada authored
Convert implementation (VirtualFidoDiscoveryFactory) in the browser process as well as the definition of the GetVirtualAuthenticatorManager() in the interface blink.mojom.DocumentInterfaceBroker. There's no need to convert C++-written clients in this case, because the only client is a JavaScript class from virtual-navigator-credentials.js. Bug: 955171, 978694 Change-Id: Ie3851572e5dbcef7bcf18dd9fc370b932a099d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689198Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#675635}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1cde0eab512d..9be098b52fbb git log 1cde0eab512d..9be098b52fbb --date=short --no-merges --format='%ad %ae %s' 2019-07-09 cwallez@chromium.org PRESUBMIT.py: Don't require "Bug:" for autoroller CLs. Created with: gclient setdep -r src/third_party/angle@9be098b52fbb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib4a3783296afecb21df8e6795484a7719b365fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692725Reviewed-by:
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Change-Id: I7bedefa3b3be82914377060a8e1b9e2eafd530f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690714Reviewed-by:
-
Lan Wei authored
When we filter the touch move messages which are not in contact with the digitizer surface with a flag "POINTER_FLAG_INCONTACT", we should not check for "POINTER_FLAG_INRANGE", because they are not in the detection range of the screen of the digitizer. This is based on the messages we get from the smart board touch device. Bug: 874948 Change-Id: I06bfd9a4048aa9800c59d974548bc8d82375b8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691150Reviewed-by:
-
Edvard Thörnros authored
The method now takes in an argument of which interval to look at. This makes it clearer what piece of state is being used in the method and it makes it easier to make future changes to the code base, where dependencies are tangled. This is the second step in a series of commits to be able to separate the timing logic from the updating logic. This aims to make it easier to make upcoming edits. No changes should be made with this commit in how the application functions or the runtime. Bug: 981522, 641437 Change-Id: I6be50e1d6812d0238a127a42f582fbc44c82b265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692575 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#675631}
-
Anton Bikineev authored
This patch also adds sweeper_scheduler that schedules sweeping tasks (currently no-ops) in background threads. Bug: 967258 Change-Id: I0074b3ae52cb02be8e9929a1562fdb4f59481d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688892 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Omer Katz authored
Prefinalizer clears image resource (as previous destructor did) and invalidates the current element. Bug: 981043 Change-Id: If36c30923b2be5c1713b23d4021dfe800f7d73ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690874 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Jordan Demeulenaere authored
Before this change, entering the PROMPT state with TalkBack enabled and no touchable area would hide the overlay instead of showing a full overlay. This CL ensures that we don't set the overlay state to PARTIAL if there is no touchable area. After this change, entering the PROMPT state with TalkBack enabled and no touchable area will correctly show a full overlay. Bug: b/137072369 Change-Id: Ic75392838be3cf865b5fd471b51d9fecabae3529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692170 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#675628}
-
Rouslan Solomakhin authored
Feature status: https://chromestatus.com/feature/5709702556024832 Intent to remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5gxzhdS1KNs/Fs-Bvz4iAQAJ Bug: 981907 Change-Id: I7646bc0b22e1d7853a809609f143e5fec7bed34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688546Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#675627}
-
Peter Beverloo authored
These continue to influence product decisions, so let's revisit next year. Bug: 975107, 975584 Change-Id: Ib8e638f9fdd11acf1cd80d5899a30f75bac00ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674100 Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#675626}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. DeviceOAuth2TokenService stops inheriting from OAuth2TokenService. Instead, it inherits from OAuth2TokenServiceObserver and OAuth2AccessTokenManager::Delegate and holds |token_manager_|. It exposes StartAccessTokenRequest and InvalidateAccessToken. These methods are handled through |token_manager_|. Bug: 967598 Change-Id: I5a9b3a0044eafeb0de412848e0e465203d0cf0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688466Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Jimmy Gong authored
Bug: 981958 Change-Id: I518d7bd98a0bf7ee7075d4f9e95f464c0e17ce89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687282 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#675624}
-
Edward Jung authored
Currently chrome:// URLs don't adhere to the prefers-color-scheme media query as the pages are forced to light mode. This enables the feature so that pages like chrome://flags and chrome://dino switch to a dark theme. Bug: 979173 Change-Id: I1f5cb0c58a96786b58b266c8b6514d45c41c6b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685099Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#675623}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f947ee47. With Chromium commits locally applied on WPT: bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 2ebcc1f6 "Move movementX/Y calculation for aura pointer-locked state to Blink." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iac1acd197b62b35db414c7f7ff0469a3d9920d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692324Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675622}
-
Sunny Sachanandani authored
Increasing individual GPU thread priorities isn't sufficient due to the effects of priority inversion (with ANGLE worker threads) and priority boosting (of renderer threads). Increasing process priority is less susceptible to these issues. Also ensure vsync thread priority is same as GPU main thread priority in this case. Bug: 965778 Change-Id: I2e7f29b5c9f54ec3f27edfc6f4367d7741251889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689921 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#675621}
-
Jordan Demeulenaere authored
Before this CL, TalkBack would not announce the onboarding view when focused. This CL correctly sets the content description on the onboarding view, and removes the call to #announceForAccessiblity as we will rely on the BottomSheet to announce it for us when opened instead After this CL, TalkBack announces the onboarding view when focused. Bug: 978295 Change-Id: Ifaba8b3537b8ea97c1fa31ecd56fae8fad3ff5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692569 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#675620}
-
