- 18 Feb, 2020 40 commits
-
-
Kurt Horimoto authored
These containers will be used to present the banner and modal view controllers. Bug: 1030357 Change-Id: I824563eb5b028b576dc29eb270685711e148f87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033339 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742229}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 37 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-16. Change-Id: Ibc83f2b3c6cc0afb47de8490d80e58c372abfc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062472 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742228}
-
Toni Barzic authored
Makes existing tests pass by explicitly disabling the feature (once the feature flag is removed, the test set up should be updated to enable the accessibiltiy feature to force shelf navigation buttons in tablet mode). Adds tests that verify the overview button gets shown when spoken feedback, autoclick, or switch access is enabled (and fixes an issue where the button visibility was not getting updated when accessibility features value changed). BUG=1051714 Change-Id: I618206e2d56857cd119f07ff9cad915b2944d213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055347Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742227}
-
Becca Hughes authored
Add the media sessions tab to the WebUI for debugging. Change-Id: Iecbe717a118e44b05a95fd5432b1384f3d32f6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055597Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742226}
-
Tina Wang authored
- Add ContentPreviewData.java to store information needed for content preview. - Add ArrayList<ContentPreviewData> field to ProfileCardData object. - Add content_preview_contatinor.xml and content_preview_post.xml. - Add logic that passing ContentPreviewData to ProfileCardVeiw and forming the posts view dynamically. Bug: 1051154 Change-Id: I89bb9960bad95a5a57be9c4ddcd13719f7710867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055433 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742225}
-
Jose Lopes authored
Remove base::Callback in some media unittests. The following callbacks are called every time a texture is created: * https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer_unittest.cc?rcl=f511dfda653e4f840e520384df599885ae827039&l=934 * https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer_unittest.cc?rcl=f511dfda653e4f840e520384df599885ae827039&l=949 The following callback is used in a factory: * https://cs.chromium.org/chromium/src/media/mojo/test/mojo_video_decoder_integration_test.cc?rcl=99887411e48037a3d41ab6862b460d1f501fea34&l=193 The following base::Callback definition can be omitted by rewriting the gmock code: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_state_unittest.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=55 The following callback is called on a stream until false is returned: * https://cs.chromium.org/chromium/src/media/gpu/video_encode_accelerator_unittest.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=849 The following callback is called on every frame: * https://cs.chromium.org/chromium/src/media/remoting/end2end_test_renderer.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=61 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I568b22ff281c0217f1cb49f6fe9a040cefd24d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058953 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742224}
-
kylechar authored
The test that runs after conformance/state/gl-object-get-calls.html is failing on Nexus5/6 GPU FYI bots consistently. It also might be causing failures on Nexus 5X and potentially other bots. Skip running the test. TBR=ynovikov@chromium.org Bug: 1052790 Change-Id: Ic3b65ca5948b591ad95e2095ae753f7086286cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062548Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#742223}
-
Alex Leung authored
Bug: b/149422033 Change-Id: Iffca5a1ab394ddafee3bbfa81c255db14df180ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056930Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#742222}
-
Andrew Xu authored
Basically two elements are required by View::ScrollRectToVisible: the rectangle to show and the bounds of the visible space. However, in ScrollableShelfView::ScrollRectToVisible, the rectangle to show is not mirrored under RTL while the visible space is mirrored. This CL mirrors the visible space from RTL to LTR when RTL is enabled. A test case is also created for this scenario. Bug: 1052553 Change-Id: I3a051c40a87f93f612edf558944479aad61d6ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056938Reviewed-by:
-
Changwan Ryu authored
Extend the current StartupTimeActivity to measure the time series of UI blocking of WebView creation tasks. Bug: N/A Change-Id: I5511fb6da1fd978c562100d79cf0b0bcaa7f6d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056500Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742220}
-
Dominique Fauteux-Chapleau authored
Also fix how the SHA256 is obtained to avoid having giant files in memory. Bug: 1048784 Change-Id: Ifec7cab506c8501ff01f3c7e5295297f1447f4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036660 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#742219}
-
Rohit Rao authored
BUG=1024115 Change-Id: Ib9f9491d7650dba83d6cbc7ae822eaf04f907b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057116 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#742218}
-
Dominic Mazzoni authored
Bug: 607777 Change-Id: I2c44c3e7be8a53086d761d65557c7a1f6d214aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057290 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742217}
-
Alex Chau authored
- Also updated experiment group name for UnidoOnSignInV2 to prepare for http://cl/295704680 Bug: 1050189 Change-Id: I5187505b2691d3f71e62a62bf8996d7bd5fc4940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062329Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#742216}
-
Sylvain Defresne authored
Instead of passing -F ... via cflags & ldflags, use the new config parameter framework_dirs to set the framework search path. As this is properly propagated, stop using all_dependent_configs in favor of just public_configs. Fix the definition of the ios_framework_bundle template to not pass the public_configs to the internal source_set and shared_library target in order to fix the build with goma RBE. Change libs to frameworks to give the list of frameworks in the modified files (to reduce the churn). Add missing dependency on //ios/third_party/webkit. Bug: 1052560 Change-Id: I8ba046bec961edd6396509cc087782013a66e7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061194 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#742215}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e51f8dd09af0..0aa86a7ae831 git log e51f8dd09af0..0aa86a7ae831 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 enga@chromium.org Validate that sampler compare function requires iOS GPU family 3v1 Created with: gclient setdep -r src/third_party/dawn@0aa86a7ae831 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia0996f1729119fc951339b9c2032f24c5567d5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742214}
-
Garrett Beaty authored
Builders defined in one of the versioned directories should avoid referring to the bucket name explicitly because on branch day when the code is copied to a new milestone directory the bucket reference would need to be updated. Change-Id: I752dddf7d8a1f405dba6393e9cd218a2630f35fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062828 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#742213}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab52f9fd..d247eaa8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6784efb3c9439ec1f2a54de42e9daaa6c101042d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062093Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742212}
-
Liquan (Max) Gu authored
Context: The full state of the Expandable Payment Handler should leave some room above the sheet, in order for users to see the main tab's toolbar. Before change: The height of the full state of the PH bottomsheet covers the whole tab. After change: The height of the full state of the PH bottomsheet occupies 90% of the tab height. Bug: 1052158 Change-Id: Id683da48a10119e97a935aabf7dc06ed5a6b69bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058909Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742211}
-
Kalon Hinds authored
This patch updates overlay tooltip styling to be readable in high contrast mode. Before: https://i.imgur.com/PV4jOg2.gif, https://i.imgur.com/X1WLSb8.png After: https://i.imgur.com/m3FYatu.gif, https://i.imgur.com/IYLER0s.png Bug: 1048378 Change-Id: I4f2c1af944eb090c03c312aaf5d255257ff12b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049954Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Kalon Hinds <kahinds@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742210}
-
Findit authored
This reverts commit 11357e7b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 742204 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzExMzU3ZTdiMzgwZjdlYjBmYjc3ZjNjNDRmMTg3OGUwMmM2YjEyNzAM Sample Failed Build: https://ci.chromium.org/b/8888094669312124288 Sample Failed Step: compile Original change's description: > Proof of concept for XPC service in the updater. > > Continues https://chromium-review.googlesource.com/c/chromium/src/+/2045058 > > Rebased. Moved code to the new chrome/updater/server/mac/server.mm::LaunchServer, addressed more feedback. > > Need to create a plist for the xpc service. It is not clear yet what executatble will be used. > > Bug: 1048653 > Change-Id: Iadbbd7004afa39fcc902f2ec68297845c2f94571 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055284 > Commit-Queue: Mila Green <milagreen@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742204} Change-Id: I699b45f0e1c87b5a7ccadb9a36d293d9fd7a0484 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062789 Cr-Commit-Position: refs/heads/master@{#742209}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e96da533c5df..f87fac56d22f git log e96da533c5df..f87fac56d22f --date=short --first-parent --format='%ad %ae %s' 2020-02-18 jmadill@chromium.org Use non-mutating getQuery in validation. Created with: gclient setdep -r src/third_party/angle@f87fac56d22f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I3557ef7bf88fe00ce696bd05a969ceec6e86290b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062312Reviewed-by:
-
danakj authored
This would allow us to decouple moving LayerTreeView to blink and moving RenderWidget to blink. Possibly WebWidgets could create and own LayerTreeView and provide limited use of it through WebWidget APIs to RenderWidget. Since LayerTreeHost (and LayerTreeView) are encapsulated in RenderWidget from blink through WebWidgetClient, they should be also on the content side so things don't change as RenderWidget moves to blink. LayerTreeHost can be removed from the public RenderWidget API afterwards (with some work). R=dcheng@chromium.org Change-Id: Ib18ff1965f65ffc106e05cb972b29eef20019c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044876 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742207}
-
John Budorick authored
crrev.com/c/2047453 appears to have changed the layout of RenderPassSize in some cases, causing it to not match the size of RenderPass due to two missing boolean fields, e.g. https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/365 This CL adds the two missing fields. Bug: 1022533 Change-Id: Icd7a275adc671baa5f989cfd7421799e4f2f289d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062608Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#742206}
-
Victor Costan authored
Manifest scope checks are enabled by default in M80, and have baked in stable for quite a bit. This CL removes the flag and cleans up some conditional logic. Change-Id: Ie53f0f4b897169e50ab6502c77ff4019a2216db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055695Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742205}
-
Mila Green authored
Continues https://chromium-review.googlesource.com/c/chromium/src/+/2045058 Rebased. Moved code to the new chrome/updater/server/mac/server.mm::LaunchServer, addressed more feedback. Need to create a plist for the xpc service. It is not clear yet what executatble will be used. Bug: 1048653 Change-Id: Iadbbd7004afa39fcc902f2ec68297845c2f94571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055284 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742204}
-
Dana Fried authored
This reverts commit de7cd485. Reason for revert: Fixing issue with Mac tests. Original change's description: > Revert "Make PWA titlebar and icons flex and animate properly." > > This reverts commit 8f2f4243. > > Reason for revert: speculative revert for test failures on Mac > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g. > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700 > > Original change's description: > > Make PWA titlebar and icons flex and animate properly. > > > > Nested layouts now allocate available space properly to their > > descendents. Also, we consistently use flex layout in the PWA titlebar. > > > > Removed a couple of invalid assumptions that were encoded as DCHECKs. > > > > There are still some inkdrop issues but they are purely cosmetic, see > > crbug.com/1006162 for more detail. > > > > Bug: 1048061 > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738874} > > TBR=pbos@chromium.org,dfried@chromium.org > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738907} TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#742203}
-
Robbie Gibson authored
This separate protocol is in preparation for moving the find bar coordinator usage code from BVC to BrowserCoordinator. Once there's a separate protocol, the BrowserCoordinator can implement it instead of the BVC. From this, most of the code here is passing the new protocol through various levels of command handler. Bug: 1052818 Change-Id: I0d1d3be56632d21851545a47ffb9e6550729d237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060495 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Majid Valipour authored
This feature is counted when a document which has a scroller with non-default writing mode (horizontal-rl or vertical-rl) is scrolled with a positive scroll offset. This counter will be used to reason about the web-compat impact of shipping spec compliant scroll offsets (gated behind CSSOMViewScrollCoordinates) 1) The collection has been approved by privacy review 2) The feature is rare as measured by UMA (0.0X% of page loads) and satisfies <1% of page views requirement for this counter. For more info see the intent-to-ship thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/7X2CKPGeEa0/m/PqICcwwMBgAJ Bug: 721759 Change-Id: I1a49590e5e92657ca8cdf588d2f57991e569cd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055350Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#742201}
-
John Budorick authored
Bug: 922145 Change-Id: Ic788d110f4a18bb40eaaa1679aa84db3bd36f027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058925Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#742200}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8103c827183..8ef17447d64b Created with: gclient setdep -r src-internal@8ef17447d64b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iba15352501ad53d474205c849b22ca23cea4d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742199}
-
Guillaume Jenkins authored
Now that the WindowsSpellChecker class has been reorganized to not rely on a base::NoDestructor life cycle, it is now safe to re-create an instance of it every test. The WindowsSpellChecker unit tests were working around the base::NoDestructor by having a single TEST_F that tested all methods. This CL splits that test up into multiple tests. There are no functional changes to the tests. #Squeegee Bug: 1035044 Change-Id: I180f8fa6fedec4470a8f8e77c124bf321ba62e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057245Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1bb9cba16be..3c4a9d347da1 git log c1bb9cba16be..3c4a9d347da1 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 benjaminwagner@google.com Run fetch-gn in PRESUBMIT if needed 2020-02-18 benjaminwagner@google.com [infra] Merge SwiftShader into CPU dimensions logic 2020-02-18 scroggo@google.com Enable Windows host build for Skia 2020-02-18 yiyix@chromium.org Update SkSurface::ReplaceBackendTexture to take ContentChangeMode Created with: gclient setdep -r src/third_party/skia@3c4a9d347da1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014246 Tbr: lovisolo@google.com Change-Id: I1b5f61cca0441b4af9f77403998d55819e99d114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062468Reviewed-by:
-
Avi Drissman authored
Nil-check the URL before feeding it to the Universal Link API. Bug: 1051802 Change-Id: I357880d0ffbd512de85c50a461f01fdd8ba238a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062253 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Navid Zolghadr authored
Based on the latest proposal accumulate the overscroll deltas and expose the accumulation to the js. Bug: 907601 Change-Id: I28b154799bfa003ad2e206e0742c5b5ab0a73b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012807Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742195}
-
Tom McKee authored
Bug: 1045064 Change-Id: I4c3007cea48f7de00180295884d01ee51fab4b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050729Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742194}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fced1b9a3942..ff5ad47b8295 git log fced1b9a3942..ff5ad47b8295 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {resources,sdk,search,security}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {source_frame,sources,text_editor,text_utils}-legacy.js 2020-02-18 tvanderlippe@chromium.org Fix screenshot image_diff for Linux Created with: gclient setdep -r src/third_party/devtools-frontend/src@ff5ad47b8295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1051458 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie334d55c7106f8f0af08a37adcd15a6c2e252229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061205Reviewed-by:
-
Xiao Yang authored
1. Implement quick answers native view which supports rich content and will be placed outside of context menu. 2. Update quick_answer_model to provide QuickAnswers data to QuickAnswers View. Bug: 1020004 Change-Id: Id6ee62352e143559170fe58ba1d928f16187d488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026114Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Raymond Toy authored
When a source changes for a MediaElementAudioSourceNode, the number of channels and sample rate can be the same as the previous source. However, we were skipping updating |is_origin_tainted_| in this case, which allowed audio through even though we printed a message that CORS prevented this. Now always update |is_origin_tainted_| right away. Bug: 1050996 Change-Id: I82b596993c7b88dbb899e5aeb00294db57a08613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055989Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#742191}
-
Ilya Nikolaevskiy authored
Bug: 1053184 Change-Id: I8d0b01a71104c224fd1642a3e52018517d0c2aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060975 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
-
