- 06 Aug, 2020 40 commits
-
-
Gary Tong authored
Bug: 1106950 Change-Id: I401a4dc9d47daa3feee3baf30860e6e42510b8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341348 Commit-Queue: Gary Tong <gatong@chromium.org> Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#795662}
-
Joe Mason authored
This is done near the start of wWinMain instead of in InitializeOSUtils to ensure that it happens before any ScopedHandle's are used. R=vakh Bug: 1113819 Change-Id: Ie2a9362da04defdc727637858031e69d8195d8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341155 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#795661}
-
David Maunder authored
I believe the problem is we are not synchronizing the delete and save operations - we try to verify one is done without waiting for the operation to complete. I solved this by adding in some callbacks Bug: 1101760 Change-Id: I851e9488df971728738b47292de96710d00a4bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300811Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#795660}
-
Collin Baker authored
In immersive mode, the toolbar floats on top of the tab content. Their bounds intersect. The WebUI tab strip would autoclose whenever an event occured inside the tab content's bounds. However, this didn't consider if the event would ultimately be delivered to browser UI instead. This CL lets events whose locations are in the toolbar pass through. It also adds test coverage for these behaviors. A more robust solution would consider the event's target window rather than just its location, but this is more complex. For now these bounds checks should be sufficient. Bug: 1112028 Change-Id: Id290bacb973bad1db535c7f69122c1d4019571e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339591 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795659}
-
Trent Begin authored
This change adds a button to the chrome://network to send a feedback report populated with the results of the Network diagnostic tests. content Bug: chromium:1098405 Test: Click Send Feedback Report button and inspect EXTRA_DIAGNOSTICS Change-Id: I3707d62878bd49a80ecf76ec235619a6662b34dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334000 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795658}
-
Natalie Chouinard authored
TBR=robertogden@chromium.org Bug: 1105908 Change-Id: Iaa8be308734a24879c43687c197f600d64a062ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341814Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795657}
-
Yue Zhang authored
Since GridTabSwitcher has an instance of TabGridDialog, having instant start on means that TabGridDialog can also be constructed before native. Similar to http://crrev.com/c/2328038, this CL moves things in TabGridDialog that should happen after native is ready to appropriate places. Bug: 1111391 Change-Id: I7c4e96a715b5867aa62fdd30d9e7dc2a8436d306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329154 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795656}
-
Dominic Mazzoni authored
A file picker control (<input type=file>) is exposed as a button in the accessibility tree. Previously the filename chosen was only exposed in the accessible value, like with other input elements - but most screen readers were not reading the value, since it's not normal to read the value of a button. So users couldn't tell what file was chosen, or whether a file was chosen at all. Fix this by making the accessible name include both the filename (as already exposed in the value) and the text of the "Choose File" button. Add a test to confirm this is working correctly when a file is selected. Bug: 903655 Change-Id: Iaa22ee66e21079014999e8af3d762ee481c85c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340163 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795655}
-
K. Moon authored
We no longer support PDFEngine implementations other than PDFiumEngine, so there's no need for a PDFEngine::Create() factory that abstracts which PDFEngine implementation is created. This also allows OutOfProcessInstance to use PDFiumEngine directly, rather than having to add methods to PDFEngine first. Bug: 1076554 Change-Id: I8808038ff5ed0db58719905c2aa8157fbd4bb092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340280Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795654}
-
mark a. foltz authored
This converts the last usages of base::Bind in media/blink to pass the types expected by the media::ChunkDemuxer ctor. Bug: 1102651 Change-Id: Id5af750df306168d2307d43bef363ef19ced81ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341385Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795653}
-
David Grogan authored
This test flaked on me locally with: height expected 100 but got 0 Which is consistent with calling checkLayout before the image has loaded, but not a guarantee that's what's happening. I haven't been able to reproduce it. In any case, this change can't hurt. Change-Id: I1bf8ccb935845c6e5e4529694c2d77e3f4a529a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340735Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795652}
-
Sorin Jianu authored
Bug: 1113862 Change-Id: I0ec30cbaeab8ace6de40661548e239860672e2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341391Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795651}
-
Etienne Bergeron authored
The HandleVerifier is currently enabled on Canary and Dev channel. It is currently not running for a chrome developers local build. This CL enables the HandleVerifier for builds with DCHECK_ON. It will run on Canary builds for a reduced set of the population under the albatross build instead of on all Canary/Dev. This helps isolate the performance impact to builds with that intent in my mind and avoids polluting performance diagnosis tools. The developers can reproduce issues locally. A build with dcheck_always_on and supporting the IAT/EAT patching will run the HandleVerifier. R=wfh@chromium.org Bug: 1104342, 1103801 Change-Id: Ie565dcc99c8c2faa27f61bcc4533bb48494c0492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294562Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795650}
-
Yue Zhang authored
This CL adds a dummy ntp-grid into the dummy module. This works as a proof of concept that NTP-provided custom elements can be used in modules. Bug: 1110062 Change-Id: Ib106888c99680f14ed8b0a1282f9660a46f4ffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339338 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795649}
-
Angela Yoeurng authored
Bug: 1046523 Change-Id: Ifa9950ffb2495775b567239d931e8a39dbe69e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339998 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795648}
-
Livvie Lin authored
Lookalike interstitials require committed interstitials to be enabled, so add a check in tab_helper_util. Change-Id: Ia991dcb4630b576cc7d59fd0ec2ce5a78c3d4de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341040Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795647}
-
Nate Fischer authored
This addresses a few issues I noticed with the IME (AKA "soft keyboard") with the new search bar: * Switches to "adjustPan" mode, which overlays the IME on top of our layout rather than resizing our layout to sit above the IME (avoids an issue where the bottom nav bar sits above the keyboard) * Hide the IME when the user clicks the "done" button * Hide the IME when the user taps away from the EditText Bug: 1052345 Test: Manual - verify IME works as expected Change-Id: I1275299ffa562a48bd2f99586c8c10974b376927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340931Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795646}
-
James Long authored
Previously, items in the filter list would continue to show up as options for the filter input. This change prevents them from showing up. Bug: 1102546 Change-Id: I259cbb9c78033991f5bb60c93f212062f6bcdb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340362 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795645}
-
Charlie Hu authored
Previously, in CL(https://chromium-review.googlesource.com/c/chromium/src/+/2281104), 'Default' is added to document_policy_features.json5 as an entry to make document policy parsing logic simpler, but it also caused issue with presubmit script. PRESUBMIT.py previously ignores the Default entry in mojom file, because 'Default' was not included in json5 file. Including 'Default' in json5 file will break presubmit script. The update to enums.xml is caused by renaming of 'NotFound' to 'kDefault' in an earlier CL(https://chromium-review.googlesource.com/c/chromium/src/+/2134583). Change-Id: I44f10a8d0b3178b842f2d3be7345144ac6f0baf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333493Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#795644}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fa4b74d479aa..2cf5a08cfc1b 2020-08-06 enga@chromium.org Track depth/stencil aspects independently If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If1cbecc2f1863e15890ead509d3c051ed018ec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795643}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id5188af544d97519cb9cb4264799a59adf94d465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340737Reviewed-by:
-
Arthur Eubanks authored
This changes the name of clang packages from clang-n123123-45674567-1 to clang-llvmorg-12-init-12345-g11112222333-1. Change-Id: Ib664d235c83c524d5e6d78703cdb6268a54deec7 Bug: 1015315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327633 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795641}
-
Ehimare Okoyomon authored
Change confusing string. Desktop screenshot: https://screenshot.googleplex.com/1HjyCxkzMDe.png Android screenshot: https://screenshot.googleplex.com/trgaE4x10km.png Bug: 1077766 Change-Id: If4ffd1b5babf7ef71b348618969b8843a0fa1479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338795Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795640}
-
Titouan Rigoudy authored
Mostly cribbed from crrev.com/c/1699159. This introduces a setting that controls whether insecure websites are allowed to make private network requests. This setting will eventually be wired up to enterprise policies. It will never be exposed on chrome://settings. For the moment this does not affect Chrome behavior at all. Along the way, rename the feature that controls the default behavior to reflect the latest naming settled on per discussion on design doc. Bug: chromium:986744 Change-Id: Iefb3a61bb2a7c53e844d289a495a94b34bea3541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282932Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795639}
-
My Nguyen authored
As part of the update, the "Languages and Inputs" page is split into 2. Create two pages. Subsequent CL will update them. Note the strings are translateable=false because it hasn't received UX writing review yet. Refer to bug for more details. Bug: 1113439 Change-Id: Ibf58d382c1c8884fee59631766db8dd97f3f4667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340113Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795638}
-
Gavin Williams authored
This function will be used to determine if the Chrome OS user should see the Save to Drive option in their Print Preview dropdown. Reasons why Drive could not be mounted (function would return false) include: Drive is disabled by the user, disabled by enterprise policy, or is in a crashing state. Bug: 1112416 Change-Id: Ibfc1cbf7c0662bd6eb15fb9204ef5b8c9812097e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339919 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Chris Hamilton authored
This adorns content::ServiceWorkerVersion, blink::ServiceWorkerThread and blink::ServiceWorkerGlobalScope with a ServiceWorkerToken. The token is generated in the browser process and communicated to the renderer as the worker is started. BUG=1085129, 1096617 Change-Id: I24972cf9be48dd0208042abaa3607807e0f6afed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330450Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#795636}
-
Sergey Poromov authored
Add Data Leak Protection feature that enforces ePrivacyScreen when confidential data is being shown on the screen. Bug: 1112447 Test: New unit tests. Change-Id: Ife24b02486b6a5cd5bd69b65ecc2cbfc7f0544f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332635Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795635}
-
Justin Cohen authored
* roll ios14-sdk-simulator to build with 12a8179i_audio * ios14-beta and ios14-sdk to run tests with 12a8179i_audio git grep -l '12a6163b' | xargs sed -i '' -e 's/12a6163b/12a8179i_audio/g' Tested with: led get-builder luci.chromium.try:ios14-sdk-simulator | \ led edit -p 'xcode_build_version="12a8179i_audio"' | \ led edit-cr-cl http://crrev.com/c/2340705 | \ led launch Bug: 1112941 Change-Id: I64c0beea00c554aa7c1c8cfa2b33383cd3e11493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340705Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795634}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76488e6d8e63..dc68e3248ed9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id1c1625a67d253145e2d6dfde0dd2ff5949ea643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341406Reviewed-by:
-
Nasko Oskov authored
The navigation_handle_id_ is initialized when the navigation starts. The goal of this CL is to initialize it during the construction of the NavigationRequest object, so it can be used as unique identifier for emitting tracing events for the lifetime of the NavigationRequest. Bug: None Change-Id: Iee966826d4275a1b6659348d89f7f3dd3855c871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274596 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#795632}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70df33d24eb1..19c3850508fd 2020-08-06 westont@google.com [infra] iPad 13.6 2020-08-06 westont@google.com [infra] Add new provisioning profile including 4 new ipad UIDs. 2020-08-06 adlai@google.com Revert "Migrate SkImage::MakeFromTexture to GrRecordingContext" 2020-08-06 adlai@google.com Revert "Migrate MakeCrossContextFromPixmap to GrDirectContext" 2020-08-06 brianosman@google.com Disallow runtime effect color filters that depend on position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Ica8f2a96b19ca8dfbddddf44a5a4aafe5c03b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340313Reviewed-by:
-
Rahul Arakeri authored
This CL implements the bounce forwards animation for when user performs a fling. When the scroller reaches the bounds, the residual velocity determines the extent of the overscroll. This then gets applied to the scroller followed by the usual bounce back animation. Bug: 1058071 Change-Id: Id14cfff5e99843bd9849d7122058dc16d929e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337940 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795630}
-
Yue Ru Sun authored
This additional logging will allow us to have a simple way to visualize a breakdown of entry counts by entry type, similar to what we already have for dropped entries. Change-Id: Ic86230cd43541492b171d3572224db02900788da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340706Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#795629}
-
Bruce Dawson authored
This reverts commit f4832bba. Reason for revert: Chrome branded builds are breaking. First breakage was https://ci.chromium.org/p/chrome/builders/ci/win64-trunk/51134 Error is: FAILED: obj/chrome/test/unit_tests/metrics_reporting_handler_unittest.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc(108,10): error: no matching member function for call to 'Set' map()->Set(policy::key::kMetricsReportingEnabled, This file is only compiled for official builds so that's why it was missed. Original change's description: > Reland "Remove the old version of PolicyMap::Set" > > This is a reland of 9b84489c > after fixing google_update_policy_fetcher_win.cc > > Original change's description: > > Remove the old version of PolicyMap::Set > > > > 1. Removed the old version of PolicyMap::Set, > > which passes value as unique_ptr. > > 2. Changed all the remaining refs use the new > > version which passes value parameter as base::Value > > instead of unique_ptr. > > > > Bug: 1092469 > > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#795078} > > Bug: 1092469 > Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795338} TBR=avi@chromium.org,eugenebut@chromium.org,emaxx@chromium.org,ayaelattar@chromium.org Change-Id: I66eeda5d032bcbf1d8e3628690e38911dbc5dd13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341817Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795628}
-
Jeremy Chinsen authored
This reverts commit db70952d. Reason for revert: Caused a regression in preview (bug: 1112747) Original change's description: > cros: Replace custom header for wallpaper picker with default. > > Currently the wallpaper picker uses a customer header that lacks a > maximize button. However, the wallpaper picker is resizeable and can be > maximized. To make the wallpaper picker consistent with similar apps, > replaced custom header with the default. > > Test: manual > Bug: 1096274 > Change-Id: If7d31b2ef53c782b05d361b8147554736742726f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316152 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791553} TBR=xdai@chromium.org,chinsenj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1096274 Change-Id: I06a800ead6cd20a22e4a1f222b90ff681b1d0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341750Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795627}
-
Yves Arrouye authored
Bug: None Test: None Change-Id: I9bed2a106220ab51aa6aa2e7324833e8dd9b5826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341389Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#795626}
-
David Van Cleve authored
The browser's views of certain same-origin subframes' feature policies can disagree from the values available to a well-behaved renderer, erroneously triggering this renderer kill. This is because not all same-origin subframes commit navigations, but the Feature Policy code in RenderFrameHostImpl depends on a call to DidNavigate to update RFHI's |feature_policy_| member after learning a new frame's origin. For frames that don't see DidNavigate calls, RFHI::feature_policy_ ends up in a state that can disagree with the renderer-side feature policy state for the same frame, stored in blink::SecurityContext. This change adds a fix by adding a call to ResetFeaturePolicy to RFHI::SetOriginAndIsolationInfoOfNewFrame, which is the first time that the browser's representation of a new frame learns the frame's origin. This allows computing a correct feature policy for features whose values depend on the frame origin. (Currently, we compute the policy before knowing the origin, which leads to the problematic inconsistent state.) Bug: 1112959, 1111735 Test: Add a browser test that crashes before the fix and passes after Change-Id: Ic3c42fbf10a468d230d85981eba10b4be4533307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335910Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795625}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/d39fe6cd6f..f66bc74928 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/d39fe6cd6f..f66bc74928 Bug: None Change-Id: I70da4b407f6cd29566285e8f7a87a0a3a7ea44b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340044Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1113259 Change-Id: If8fb61be399b871baa34c0bace03dceebe60b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339695Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795623}
-
