GitLab

BUG=699347
TBR=csharrison

Review-Url: https://codereview.chromium.org/2740023002
Cr-Commit-Position: refs/heads/master@{#455701}

This is a clean-up CL and doesn't change behavior.

For improving extensibility, this CL separates WorldIdConstants to 2 parts:
WorldTypes and WorldId. This encapsulates identifier allocation logic in
DOMWrapperWorld[1] and makes it easier to expand the identifier space for
Worklets[2].

[1] WorldIds for IsolatedWorlds still need to be given from out of
    DOMWrapperWorld because of its unique convention to allocate the identifier.
[2] https://codereview.chromium.org/2735823006/

BUG=697622, 697629

Review-Url: https://codereview.chromium.org/2735973006
Cr-Commit-Position: refs/heads/master@{#455700}

Rather than using the (obviously "racy") technique of looking up the
event-base element again when disconnecting from it, store the reference
on connect (sharing storage with the sync-base element since they are
mutual exclusive) and use it to disconnect properly.

BUG=641437

Review-Url: https://codereview.chromium.org/2739893002
Cr-Commit-Position: refs/heads/master@{#455699}

BUG=webrtc:6424

Review-Url: https://codereview.chromium.org/2737133002
Cr-Commit-Position: refs/heads/master@{#455698}

This should be impossible, but we'd like to try it in canary
to try and figure out what's going on in the linked bug.

This should be reverted by 17 March.

BUG=694520

Review-Url: https://codereview.chromium.org/2740013002
Cr-Commit-Position: refs/heads/master@{#455697}

platform/loader has a BUILD.gn, but it defines only production files,
and files for testing are still defined in platform/BUilD.gn.

This patch moves test file definitions for blink_platform_unittests
from platform/BUILD.gn to platform/loader/BUILD.gn.

BUG=699369

Review-Url: https://codereview.chromium.org/2733253003
Cr-Commit-Position: refs/heads/master@{#455696}

This is being done by default in V8 itself.
The API used to do this is being deprecated.

R=marja@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2740913002
Cr-Commit-Position: refs/heads/master@{#455695}

Network traffic annotation is added to network request of
search_provider_logos/logo_tracker.

BUG=656607

Review-Url: https://codereview.chromium.org/2718443002
Cr-Commit-Position: refs/heads/master@{#455694}

Convert dumb single/double quotes to smart quotes just like gitiles.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2740863004
Cr-Commit-Position: refs/heads/master@{#455693}

Current behavior when trying to browse to the basic URL is to return
an error message, and then force the dev to figure out the full path
to the doc and put it in.  Let's present a simple directory listing
instead for them to navigate if they want.

This doesn't try to emulate gitiles, just produce something that isn't
awful on the eyes.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2742683002
Cr-Commit-Position: refs/heads/master@{#455692}

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Review-Url: https://codereview.chromium.org/2739993002
Cr-Commit-Position: refs/heads/master@{#455691}

This CL fixes the SHOWING_TERMS_OF_SERVICE part.
- Renamed to NEGOTIATING_ to reflect its actual responsibility.
- Move checks if ToS negotiation is skipped into the state.
  - For better encapsulation.
  - Removing state machine transition from STOPPED to
    CHECKING_ANDROID_MANAGEMENT as simplification.
- Get rid of CancelAuthCode() on Terms of Service rejecting.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2737453003
Cr-Commit-Position: refs/heads/master@{#455690}

enum.

BUG=626786
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2733823003
Cr-Commit-Position: refs/heads/master@{#455689}

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2732963002
Cr-Commit-Position: refs/heads/master@{#455688}

This is a follow-up CL to https://codereview.chromium.org/2371673002, to make testing of length-accepting properties more complete.

To do this, I added "Length" as a typedom_types for each property in CSSProperties.in
While I was at it, I also added the valid keywords for those properties.

BUG=545318

Review-Url: https://codereview.chromium.org/2583063002
Cr-Commit-Position: refs/heads/master@{#455687}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f529f7c9..fc069168

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2740793003
Cr-Commit-Position: refs/heads/master@{#455686}

The library is intended for mutation protocol buffers for fuzz testing.
It can't function without proto descriptors and proto reflection.
The library is and will be testonly, so there should be low risk
of linking with production binary.

BUG=

Review-Url: https://codereview.chromium.org/2736333002
Cr-Commit-Position: refs/heads/master@{#455685}

Revert of Finish OSMesa support for Ozone X11. (patchset #2 id:40001 of https://codereview.chromium.org/2730993002/ )

Reason for revert:
Sorry, speculatively reverting based on persistent ozone builder flake. Started with this CL as best as I can tell.

Appears to be a sync command buffer IPC hang on shutdown, affecting only tests which force single-process mode. Possibly a deadlock caused by ... something in the OSMesa/X11?

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_ozone_rel_ng%2F336922%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FSavableResourcesTest.GetSavableResourceLinksWithPageHasInvalidLinks%2F0

Original issue's description:
> Finish OSMesa support for Ozone X11.
>
> Modify the GLOzone implementation for Ozone X11 OSMesa to use
> GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
> XWindow so it's visible.
>
> BUG=698780
>
> Review-Url: https://codereview.chromium.org/2730993002
> Cr-Commit-Position: refs/heads/master@{#455306}
> Committed: https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c764eca1aae018

TBR=kbr@chromium.org,kylechar@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=698780

Review-Url: https://codereview.chromium.org/2742713002
Cr-Commit-Position: refs/heads/master@{#455684}

The gitiles renderer doesn't require URLs to be bracketed with <...>.
Add an extension to support that.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2743553002
Cr-Commit-Position: refs/heads/master@{#455683}

consistency when verifying certificates.

The underlying platform verifiers don't do this, which can lead to
confusion when trying to enforce policy for SHA1 on the verified chain.

* If the two signature algorithms don't match will fail with
  ERR_INVALID_CERT.

* If the chain contains a signature algorithm that we don't know how to
  parse, will also fail with ERR_INVALID_CERT

BUG=690821

Review-Url: https://codereview.chromium.org/2731603002
Cr-Commit-Position: refs/heads/master@{#455682}

This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take
|EphemeralRange| instead of |Range| object to avoid registering temporary
|Range| object to range update list to reduce memory usage and relocation cost
for improving code health.

BUG=691199
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2729823002
Cr-Commit-Position: refs/heads/master@{#455681}

This test is crashing on Debug build because of OOM.
This CL changes the test to use promise_test instead of async_test inorder not to start multiple service workers in parallel.

BUG=698872

Review-Url: https://codereview.chromium.org/2738143002
Cr-Commit-Position: refs/heads/master@{#455680}

This test verifies that in the presence of both primary Surface and fallback
Surface, the fallback will not be used.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2741613002
Cr-Commit-Position: refs/heads/master@{#455679}

When text decoration is underline or lie-through, some related IA2 attributes need to deviate from their defaults.

BUG=695646
R=dmazzoni@chromium.org, aleventhal@google.com
TESTED=browser test, manually with the file attached to bug

Review-Url: https://codereview.chromium.org/2716183003
Cr-Commit-Position: refs/heads/master@{#455678}

Instead code can create the window directly. I've also added the
WindowType to the constructor of aura::Window to make the common
task of creating a window then setting the type slightly easier.

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2733303004
Cr-Commit-Position: refs/heads/master@{#455677}

BUG=NONE

Review-Url: https://codereview.chromium.org/2744543002
Cr-Commit-Position: refs/heads/master@{#455676}

e21eb6a Post-detection mapping for HTML5 mode

BUG=630113
TEST=gclient sync, make
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2736423002
Cr-Commit-Position: refs/heads/master@{#455675}

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2738123002
Cr-Commit-Position: refs/heads/master@{#455674}

ARIA Implementation Guide 1.0 says that math should be mapped to ROLE_SYSTEM_EQUATION but we omitted to expose its children.
Mac works fine ones AX_ROLE_MATH is removed from the list of leaf objects.
Also checked with Safari and it does expose the children of role="math".
BUG=645168
R=dmazzoni@chromium.org
TESTED=manually

Review-Url: https://codereview.chromium.org/2715403002
Cr-Commit-Position: refs/heads/master@{#455673}

it.

As a general rule, doubling the blur values passed in will yield nearly
identical visuals. The main difference is that ShadowValues::GetMargins()
will now return the correct value because of the corrected blur values.
For example, ShadowBorder will now set the correct margins. Previous to
this change, the ShadowBorders in the AppList were clipped because of
the incorrect margins.

BUG=684627,624175
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2733363002
Cr-Commit-Position: refs/heads/master@{#455672}

It was being called by AsyncResourceHandler which isn't used for navigation requests. Move the call to ResourceDispatcherHostImpl instead.

This fixes
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnGoogleCom
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnGoogleCom_with__--webview-sandboxed-renderer_
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnNonGoogle
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnNonGoogle_with__--webview-sandboxed-renderer_
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginWithNullAccount
org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginWithNullAccount_with__--webview-sandboxed-renderer_
with PlzNavigate.

BUG=645983

Review-Url: https://codereview.chromium.org/2741433002
Cr-Commit-Position: refs/heads/master@{#455671}

Adds UMA metrics for renderer uptime to understand memory usage of long running Chrome.

This adds two metrics:
Memory.Experimental.Renderer.Uptime logs uptime of a render process.
Memory.Experimental.Renderer.LoadsInMainFrameDuringUptime logs the number of main frame page loads that happen in the lifetime of a render process.

BUG=693524

Review-Url: https://codereview.chromium.org/2697323004
Cr-Commit-Position: refs/heads/master@{#455670}

Override CreateNewTarget in the HeadlessDevToolsManagerDelegate to be able to create new tabs in headless mode from the json/new endpoint

BUG=699392

Review-Url: https://codereview.chromium.org/2735943005
Cr-Commit-Position: refs/heads/master@{#455669}

This patch makes the PrePaintTreeWalk context object heap allocated
to avoid overflowing the stack.

Using an iterative algorithm was explored in [1] but the design
is complicated because of early-out and clearPaintFlags logic.
This patch uses the existing recursive walk which is easier to
follow, but moves the large allocation out of the heap.

[1] https://codereview.chromium.org/2735823005

BUG=698653
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733143004
Cr-Commit-Position: refs/heads/master@{#455668}

BUG=636289
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2734033004
Cr-Commit-Position: refs/heads/master@{#455667}

Move the field FrameHost::m_eventHandlerRegistry to Page, and update
FrameHost methods to directly call the equivalent Page method.

BUG=691794

Review-Url: https://codereview.chromium.org/2728423005
Cr-Commit-Position: refs/heads/master@{#455666}

Added a blend between the color extracted from the wallpaper image and black
before applying it to the shelf.

This is still experimental work behind the --ash-shelf-color flag.

BUG=595010

Review-Url: https://codereview.chromium.org/2744493002
Cr-Commit-Position: refs/heads/master@{#455665}

Justifications for each of the existing names have been added as well.

This adds two more allowed cases;

-----

 with open(filename) as f:

This is a very common pattern in Python as you can't use the more
logical name "file" as it shadows the inbuilt file function
(which is equivalent to open). Other names include fd.

-----

 try:
   ....
 exception XXXError as e:
   ....

Another very common pattern in Python. Other names include err and exp.

-----

Review-Url: https://codereview.chromium.org/2738823003
Cr-Commit-Position: refs/heads/master@{#455664}

Remove a lot of pre-MD code from NetworkStateListDetailedView

BUG=686251
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2737353002
Cr-Commit-Position: refs/heads/master@{#455663}

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:698623
TEST=gn gen --check

Review-Url: https://codereview.chromium.org/2727113002
Cr-Commit-Position: refs/heads/master@{#455662}