GitLab

When the DomDistillerViewerSource got a request for chrome-distiller://foobar/
it would crash if there was an empty path argument. This CL adds a safety check
for the length of the path, to ensure to not take a substring of an empty
string. 

In addition, this adds regression tests for the crash it fixes. It also fixes
the rest of the disabled browser tests for the DomDistillerViewerSource. 

BUG=356866

Review URL: https://codereview.chromium.org/288353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271178 0039d316-1c4b-4281-b951-d872f2087c98

Note that the outcome now in the case where you click the chip and then the back button is that the Omnibox retains focus but the chip is shown.  We normally don't allow this but it's analogous to the non-origin-chip behavior in this case.

BUG=371684

Review URL: https://codereview.chromium.org/290623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271177 0039d316-1c4b-4281-b951-d872f2087c98

Remove resources for "not toolkit_views and not is_macosx and not is_ios". This matches android, but android is not using them (I believe).

This seems to be left-over from linux_gtk configuration, which has been removed.

I'll remove png files in separate CL.

BUG=373482

Review URL: https://codereview.chromium.org/288033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271176 0039d316-1c4b-4281-b951-d872f2087c98

If the stream ID space is exhausted, SpdySession must allow active
streams to complete, but prevent new streams from being created.
Change SpdySession to begin going away in this case, and add an explicit
test on ID exhaustion.

Also allow stream IDs to use the full 31-bit space available.

BUG=373858

Review URL: https://codereview.chromium.org/287063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271175 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271174 0039d316-1c4b-4281-b951-d872f2087c98

This allows passing of arbitrary length list-like structures across the
a message pipe. This is a pre-requisite for passing corrupt, circular, or
otherwise malformed list-like structures across a message pipe for testing.

Also fix excessive indentation in one place in js_to_cpp_unittest.cc
(leading to larger diff). Sorry.

Review URL: https://codereview.chromium.org/282063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271173 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=7&start=14765
TBR=
BUG=

Review URL: https://codereview.chromium.org/287203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271172 0039d316-1c4b-4281-b951-d872f2087c98

Also gets rid of Android dependency on quota-internals, which doesn't
work on Android.

BUG=373943

Review URL: https://codereview.chromium.org/285233007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271171 0039d316-1c4b-4281-b951-d872f2087c98

FakeInputMethodContextOzone is the same as FakeInputMethodContext, and there's no
other use for InputMethodContextFactoryOzone. So remove both. The ozone platform
can directly set an IME context using LinuxInputMethodContextFactory::SetInstance
if so desired.

BUG=361137
R=sky@chromium.org, spang@chromium.org, yukishiino@chromium.org

Review URL: https://codereview.chromium.org/284323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271170 0039d316-1c4b-4281-b951-d872f2087c98

This is needed by content.

BUG=None
TEST=gn gen out/Debug; followed by ninja -C out/Debug surface
R=brettw@chromium.org,piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/282353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341554
TEST=none

Review URL: https://codereview.chromium.org/285383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369500

Review URL: https://codereview.chromium.org/292493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693
R=asvitkine

Review URL: https://codereview.chromium.org/291513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271160 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some minor GN build issues on Windows

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/290633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271159 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271148 0039d316-1c4b-4281-b951-d872f2087c98

This change caused most of the indexeddb tests to fail on win7 :(.

TBR=ericu@chromium.org
BUG=108012

Review URL: https://codereview.chromium.org/287093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271146 0039d316-1c4b-4281-b951-d872f2087c98

Moves the preferences related to the core parts of the invalidator into
components/invalidaton/invalidation_prefs.{cc,h}.

Moves the InvalidatorStorage into the component.  Its only dependency on
chrome/ was the preference definitions.

TBR=pam
BUG=336571

Review URL: https://codereview.chromium.org/288353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358657

Review URL: https://codereview.chromium.org/261753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271144 0039d316-1c4b-4281-b951-d872f2087c98

cc: Remove layers that are not drawn from tile manager.

This patch removes layers that are no longer have their tile priorities
updated from tile manager, in order to ensure that we don't process
tile or use any other information from these layers.

R=enne
BUG=176557, 358350

Review URL: https://codereview.chromium.org/285373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271143 0039d316-1c4b-4281-b951-d872f2087c98

This change reduces the amount of code its complexity, and is the natural follow up from having alt tab separated into a different class.

Please note that no functionality has been changed, and that the change is pretty much only moving code around.

BUG=371884
TEST=WindowSelectorTest.*

Review URL: https://codereview.chromium.org/280423008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271142 0039d316-1c4b-4281-b951-d872f2087c98

This whitelist matches the current list in app_current_window_internal_api.cc for SetShape(). That whitelist will be removed in a separate cl.

BUG=374433,323773,356200,327507,354258
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/290043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271140 0039d316-1c4b-4281-b951-d872f2087c98

The layer_tree_host() is never null and this is DCHECKed in the
constructor.

R=enne
BUG=

Review URL: https://codereview.chromium.org/289063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271139 0039d316-1c4b-4281-b951-d872f2087c98

establish connection with remote endpoint.

If we don't send signal, TCP based cricket::Port(s) think they are still
connecting.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3249
R=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/288923014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364675
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/294443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271137 0039d316-1c4b-4281-b951-d872f2087c98

The tests use EXPECT_EQ with a constant variable equal to false,
that tricks GCC 4.7+ into beliving the variable should be compatible to null
pointers in some internal macro. This CL workarounds that by
using EXPECT_TRUE(a == b) instead.

BUG=https://code.google.com/p/googletest/issues/detail?id=458
TBR=mek
NOTRY=true

Review URL: https://codereview.chromium.org/290723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271136 0039d316-1c4b-4281-b951-d872f2087c98

Added histogram Network.Shill.UserInitiatedEvents for sampling
the number of user-initiated events in shill. Currently only
tracks the user-initated WIFI scans.

Added histogram Network.Shill.WiFi.TransmitBitrateMbps for sampling
the transmit bitrate for the wifi device. The bitrate is updated
every minutes when wifi is connected to a network.

Added histogram Network.Shill.WiFi.UserInitiatedConnectionResult
for sampling the outcome of user-initiated connection attempts.
This histogram is updated everytime the wifi connection is initiated
by the user.

Consolidate the histograms for DHCPOptionFailureDetected, where there
was one histogram per technology type. Instead, changed to one only
histogram, with each technology type as a bucket under the histogram.

BUG=chromium:368761,chromium:369135,chromium:369545
TEST=Start chrome, browse to chrome://histograms to make
sure these histograms exist after manually
initiate/establish a wifi network connection.
NOTRY=true

Review URL: https://codereview.chromium.org/273883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271135 0039d316-1c4b-4281-b951-d872f2087c98

This is causing crashes related to the resource bundle. Not
doing this makes content_shell's initial cursor invisible,
but it's better than crashing.

BUG=chromium:362755
TEST=link_freon chromeos build
TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/292563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271134 0039d316-1c4b-4281-b951-d872f2087c98

Content should not have knowledge of NaCl. Moving per process NaCl debug
stub port information to NaClBrowser.

More explicitly distiquish between the case where the debug port is not yet
known versus when it is unused.

Switch debug port to being a per-process value (as it is).

This relands r270907 with a fix to make it work with disable_nacl=1
and therefore ASAN.

BUG=None
TEST=trybots
R=jam@chromium.org,sehr@chromium.org

Review URL: https://codereview.chromium.org/286143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271133 0039d316-1c4b-4281-b951-d872f2087c98

Read the target encode bitrate and bind it to the "encoded" callback
before actually encode the frame instead of reading the target bitrate
after frame has been encoded . This gives a more accurate value of
the encode bitrate each frame was encoded at.

Review URL: https://codereview.chromium.org/286203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271132 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/282363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271131 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/294473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=ericu@chromium.org, erg@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/290233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271121 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/290113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271110 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271109 0039d316-1c4b-4281-b951-d872f2087c98

So that we can avoid creating PassThroughFilter.
The CL also makes FilterChain::GetHead() a little more efficient (SyncDispatcher calls it once for receiving each message).

BUG=None
TEST=None
R=darin@chromium.org

Review URL: https://codereview.chromium.org/291583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271107 0039d316-1c4b-4281-b951-d872f2087c98

Currently we pass the service path of networks as the "GUID" in the
networkingPrivate implementation on Chrome OS. We should be using the
actual GUID (if one exists) or create a GUID if one does not.

Note: This change should not break any existing usage since the GUID
value should be transparant to the implementation. (This will have the
positive side effect of making the GUID consistent across sessions).

BUG=284827
For fake_wifi_service.cc:

R=asargent@chromium.org, pneubeck@chromium.org
TBR=mef@chromium.org

Review URL: https://codereview.chromium.org/275543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/282103009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374392
TBR=erg
NOTRY=True

Review URL: https://codereview.chromium.org/287003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271103 0039d316-1c4b-4281-b951-d872f2087c98

In HWNDMessageHandler::ShowWindowWitState(), when ui::SHOW_STATE_DEFAULT
is passed as state, the window grabs activation after being shown. The
correct behavior would be to activate the widget if and only if the
can_activate flag is set. HWNDMessageHandler::Show() method already does
this since r244605.
Also, the DefaultWidgetDelegate should honor InitParams::can_activate
flag.

BUG=340736

Review URL: https://codereview.chromium.org/154783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271102 0039d316-1c4b-4281-b951-d872f2087c98