GitLab

Setting the background color on delegated layers can cause artifacts
(only non-tiled areas get the background color). This also appears
not to have been necessary.

Bug: 845968, 840173
Change-Id: If8eca7d3eb793952a9a606a2d27683b02d2c4b3f
Reviewed-on: https://chromium-review.googlesource.com/1071117Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561390}

The method RenderWidgetHostViewMac::GetOffsetFromRootSurface is to be
used to indicate where the view is in its root ui::Compositor. It used
to be that the two were always aligned, but now they can be offset.

Bug: 846018, 	840173
Change-Id: Id3f761d56c75ebd33b75c40c05d46a84b485d162
Reviewed-on: https://chromium-review.googlesource.com/1070883Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561389}

This CL sets up a subsequent CL which refactors a shared chunk of code
out of the browsertest file.

These files are being checked in as-is (i.e. trigger a number of
formatting warnings) however they aren't included in any build files
so they shouldn't cause any build issues and will be fixed in the
follow-up CL.

TBR=sky@chromium.org

Change-Id: I428463c0a6c9e942899a44c76bebb2e0e0b34856
Reviewed-on: https://chromium-review.googlesource.com/1071070Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561388}

This reverts commit fe197c07.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 561305 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZlMTk3YzA3ZDE2ZjdiZWQzNTQ0NTRhZDYzOTkxYmI5YjRmYWE1MjYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27583

Sample Failed Step: display_unittests

Original change's description:
> Minor bug fix for incorrect DCHECK in display util
> 
> This patch fixes an incorrect DCHECK that was landed in the previous
> patch. The DHCECK_LT should instead be DCHECK_GT.
> 
> Bug: 839458
> Change-Id: I4b45aae9a1cb1c3870774b4c3e2d654ffbf7bb4f
> OriginalChange: I4d5bd761506c6ec14dc92b3d3a120b87e02e2cb7
> Component: Display util, dsf, zoom levels
> Reviewed-on: https://chromium-review.googlesource.com/1070619
> Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561305}

Change-Id: I803ccaa9ecb839f2efc4499c9f78dfbf346578ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839458
Reviewed-on: https://chromium-review.googlesource.com/1070892
Cr-Commit-Position: refs/heads/master@{#561387}

Quick update after the fix for an uninitialized variable[1]
that caused random crashes depends on memory layout.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1068793

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iba5b6b13e199d4ff5a3f67611c5e7158c79ac5b2
Reviewed-on: https://chromium-review.googlesource.com/1068792
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561386}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic5bb4506dccaa78871f025f235592a6401240141
Reviewed-on: https://chromium-review.googlesource.com/1067689Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561385}

As per crbug.com/788015 Comments 1,5:
- Fix padding sizes
- Change button text "Dismiss" -> "Got it"
- Make a button default (blue)
- Replace "Learn more" link with (?) button
  - Button has a11y text and is Tab stop
- Remove X (Close) button from upper right
- Clean up code, use standard LayoutProvider

Bug: 788015
Test: Set up a new Chromebook with Goodies offer available, witness a
dialog living in Harmony

Change-Id: I95058420c54a1b2b48881b95b458971ec163a8ae
Reviewed-on: https://chromium-review.googlesource.com/1040868
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561384}

Disable persistent heap collections on non-main thread, so we only have to worry about Persistents when terminating a thread.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibcbde2d3fe4bce1534999d19be3188d477e958d5
Reviewed-on: https://chromium-review.googlesource.com/1058994Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561383}

I2S Link: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Na7aTFJOpWs/_tpdtav8CAAJ
Plan is to flip the flag before branch cut and unflip if Intent doesn't go through.

Change-Id: I4564e4180b7903f67ac6186390b6c5d1acb74cb7
Reviewed-on: https://chromium-review.googlesource.com/1070448Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561382}

Merge output is important to see any counter overflow warnings.
On coverage bot, this is already captured. So, support similar
functionality in verbose mode.

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 844432
Change-Id: I5bffb5c8d1c5b0748c66ebed3e4becca7619a3eb
Reviewed-on: https://chromium-review.googlesource.com/1070997Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561381}

We only set the format_modifier_ field if the GBM_BO_USE_SCANOUT flags
was set. On platforms where we can't scanout NV12, we fall back to
allocating GbmBuffers without the scanout flag and consequently end up
assuming those are all linear. Except libva, which picks up the tiling
from the kernel bo and decodes with y-tiling enabled.

We need to always and unconditionally store the format modifier, it's
as much part of the buffer meta data as the pixel format. Move
assignment to initializers.

Bug: 845076
Test: crosvideo.appspot.com plays correctly on pre-KBL Intel chromebooks
Change-Id: I74c435807947afb60ea4417ace39751e213792bc
Reviewed-on: https://chromium-review.googlesource.com/1070995
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561380}

This CL makes ScriptElementBase::Loader() protected, and thus
after this CL PendingScript no longer has access to ScriptLoader,
making separation between PendingScript and ScriptLoader more strict.

XML/HTMLParserScriptRunner previously get ScriptLoader via
ScriptElementBase, but after this CL they get ScriptLoader
directly via ScriptLoaderFromElement().

No behavior changes.

Bug: 842349
Change-Id: I5104c0817669e871a68b8d8286d037e3e23622cc
Reviewed-on: https://chromium-review.googlesource.com/1054855
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561379}

The layout test unnecessarily depends on a non-standard behavior
that, HTMLElement.offsetLeft returns non-zero result even for
inline elements without any box (*). The test fails with LayoutNG
as the behavior isn't implemented there.

This patch changes the layout test to compute mouse coordinates
from non-empty inline elements, so that it passes.

(*) https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft:
    "... Return the result of subtracting ... from the x-coordinate of
     the left border edge of the first CSS layout box associated with
     the element ..."

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I35beeb83674a034486b00890f6267ab778892087
Reviewed-on: https://chromium-review.googlesource.com/1070937
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561378}

Sometimes, another app can grab the focus while the confirm-to-quit bubble is
showing. When this happens, Chrome won't get the key release event and the
bubble will stay open forever.  The only way to close it would be to press
Ctrl+Shift+Q again, but this would close Chrome.

This CL closes the confirm-to-quit bubble and resets the state of the controller
when this happens.

BUG=243164
R=sky

Change-Id: I1800501be3cd4896876347ce2fb511a08e90eba7
Reviewed-on: https://chromium-review.googlesource.com/1069487Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561377}

These 2 files "connection.js" and "es6_workaround.js" seem to be to
backport some definitions from ES6 and newer Web APIs not covered by
Closure compiler "back on the day", to be able to compile with these
methods that were already available in our Chromium version.

I've run Closure compiler locally as well as in the bots, so Closure
seems to support these on it current version.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48f61c9bf439fb8c438dc0155e00f0db9610d96c
Reviewed-on: https://chromium-review.googlesource.com/1068586Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561376}

In Watchdog implementation we notify another thread not holding the
lock. Here
https://www.chromium.org/developers/lock-and-condition-variable it's
stated we need to put Signal() inside the critical section to avoid hard
to find bugs.


Change-Id: I60725d2a33a87ff9067b779f11b372a22e006e10
Reviewed-on: https://chromium-review.googlesource.com/1018462Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561375}

Before https://crrev.com/c/657787, FetchParameters::MakeSynchronous() always
calls SetTimeoutInterval(10). So I thought that 10 second is the default timeout
for all synchronous resouce loading.

But this was wrong. The TimeoutInterval of ResourceRequest was not used. After
the CL the value is used for the timeout in SyncLoadContext. But the default
timeout of sync XMLHttpRequest must be infinite. This caused the bug 844268.

To fix this bug, this CL stops resetting 10 sec timeout in MakeSynchronous().

Bug: 844268
Change-Id: I7295ec78637548dc810bb3a8a12a54db4cfbc368
Reviewed-on: https://chromium-review.googlesource.com/1068893Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561374}

Request bodies may be a blob if NetworkService is disabled. We need to plumb it
to a service worker world if we ship NetS13nSW without NetworkService.
After this CL, there are three cases of how to send the request body to the
service worker's fetch event.

(A) NetworkService is on
In this case, blobs should be passed as a data pipe. Data pipes will be included
by a network::ResourceRequestBody.

(B) NetworkService is off and ServiceWorkerServicification is on
Blobs should be passed as a blink::mojom::BlobPtrs, but
network::ResourceRequestBody cannot contain the blink::mojom::BlobPtrs. Instead,
the BlobPtrs are passed as a parameter of DispatchFetchEventParams separately.

(C) NetworkService and ServiceWorkerServicification are off
All request bodies are passed as a blob. The information of the blob is passed
as three parameters of DispatchFetchEventParams.

Bug: 830292
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I36eb0e08e80ae9feb5af926af4b97757607c1950
Reviewed-on: https://chromium-review.googlesource.com/1046426
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561373}

This CL removes MockScriptLoader definition,
migrates MockScriptLoader::Create*() to MockPendingScript, and
makes ScriptLoader final.

Other changes to test bodies are mechanical:
- Replaced script_loader with pending_script,
- Replaced ScriptLoader with PendingScript,
- Remove "->GetPendingScriptIfControlledByScriptRunner()",

Bug: 842349
Change-Id: I515890efeaffcb0f8dc8c9dad1102591974e8d67
Reviewed-on: https://chromium-review.googlesource.com/1056399
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561372}

The workaround of https://crrev.com/c/1062990 is no longer necessary
because of https://crrev.com/c/1068646, which fixed ListItemOrdinal's behavior.

See also http://crbug.com/845770. In general, we should avoid recalc assignment
in detaching a node.

Bug: 776656, 845770
Change-Id: Ia98b35dce0b6d2e16829f79dde4b88470ced0d3f
Reviewed-on: https://chromium-review.googlesource.com/1070007Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561371}

This CL addresses some comment typos and style changes. These changes
were included with 1066732, which was reverted. Separating these changes
in this CL will make further CLs on these files cleaner (fewer lines
changing).

There are no logic changes in this CL.

Bug: None
Change-Id: Ic2d75bdf2f1726d9044da18caec56ec5b374100f
Reviewed-on: https://chromium-review.googlesource.com/1071093
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561370}

If the user pulls out the SD card, currently the download database
record will be removed and user can no longer see the download.

Instead, we shouldn't erase the database records for files on SD card
when checking if they are externally removed. Later we can add a timestamp
to persist the time when the file is found missing for the first time, and
erase the db record 30 days after this timestamp.

TBR=mpearson@chromium.org

Bug: 845369
Change-Id: I5b129df435119d501867cedde85ef49ec844aa38
Reviewed-on: https://chromium-review.googlesource.com/1068273
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561369}

DownloadLocationPreference directly uses native pref to persist the
selection result. However the native pref may have a delay when
persisting the data, and the UI may refresh the view before native pref
is done, which causes double radio button selection.

This CL caches the selection ID so the UI can always get fresh data.


Bug: 842464,792775
Change-Id: I39bec3a61ea2c7f0e656658cfc41a62e12956560
Reviewed-on: https://chromium-review.googlesource.com/1070480
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561368}

Bug: 841060

Change-Id: I1542a8f07da2c433406c733bf0489d42e8bd69b3
Reviewed-on: https://chromium-review.googlesource.com/1068533
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561367}

BUG=769630

Change-Id: I1985c14b93872b887d14bbcd5697e431c845ba8b
Reviewed-on: https://chromium-review.googlesource.com/1069983
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561366}

Bug: 844329
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id9b00c368e32c9cea170af7c6dfaf9a5272e1301
Reviewed-on: https://chromium-review.googlesource.com/1066326Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561365}

https://chromium.googlesource.com/angle/angle.git/+log/b0e9ddb55381..b001528ffa00

$ git log b0e9ddb55..b001528ff --date=short --no-merges --format='%ad %ae %s'
2018-05-18 courtneygo Use libnativewindow for Android builds
2018-04-27 brandon1.jones Add initial specification for EGL_ANGLE_explicit_context Extension
2018-05-23 tobine Update required Windows SDK version to 10.0.17134

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I80eb7c606ade2e65c3df61d3b29ff1a71b6ca442
Reviewed-on: https://chromium-review.googlesource.com/1070889Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561364}

Using wpt-import in Chromium ec57b4a2.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18480

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
jsbell@chromium.org:
  external/wpt/encoding
rego@igalia.com:
  external/wpt/css/css-grid
timvolodine@chromium.org:
  external/wpt/battery-status
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=lukebjerring

No-Export: true
Change-Id: I00e7d6755a5e7a72365f67f5147a87fb847ddf65
Reviewed-on: https://chromium-review.googlesource.com/1070881
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561363}

BUG=769630

Change-Id: I2a4317f0ca9f9cbd1ffd1bd3c1d12a8487651c40
Reviewed-on: https://chromium-review.googlesource.com/1069982
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561362}

BUG=767901
R=thakis
CC=pcc

Change-Id: Ib394126f8e729192ee41520eefd85e22531bfd65
Reviewed-on: https://chromium-review.googlesource.com/1066596
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561361}

MotionEventSynthesizer class is used by Chrome (VR) and content
internally. This CL splits it into public interface with create
method and implementation class. Helps remove the exception rule
in DEPS.

Bug: 617324
Change-Id: I99fa8c01089ede078a7c2b2929897fdbbd7b40aa
Reviewed-on: https://chromium-review.googlesource.com/1058873
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561360}

This patch changes "merge-start-blockquote.html" to utilize |selection_test()|
for ease of maintenance.

Bug: 679977, 707656
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib8b5d63687c42e9ead5167a11f0a592e19297f84
Reviewed-on: https://chromium-review.googlesource.com/1069965Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561359}

All existing callers really want to know when the LifecycleUnit was
last visible, not when its visibility last changed (they are not
interested in transitions between visible and hidden).

Change-Id: Ie57d8c3219d69cdb5ede938544a434063ebe9e04
Reviewed-on: https://chromium-review.googlesource.com/1069451
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561358}

These network quality estimator histograms were deprecated earlier,
but they were not correctly marked as deprecated.

Bug: 843210
Change-Id: Ie852a015072a4734c02c7cd2fd6d03fb35bf5f95
Reviewed-on: https://chromium-review.googlesource.com/1063552Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561357}

* TraceWriters will no longer be destroyed when their TLS slot is cleaned
  up on thread shutdown as this can trigger a CommitData() call from
  Perfetto and cause asserts when Mojo does a TaskRunnerHandle::Get()
  for a PostTask; instead we leave the deletion to the taskrunner
  Perfetto is running on (if it's getting shut down, the task should
  get dropped).
* Run ProducerClients on their own sequence.

Bug: 844379
Change-Id: Ie45b36a4e463674122555dbec2105953a882f37c
Reviewed-on: https://chromium-review.googlesource.com/1069528Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561356}

This is a regression in http://crrev.com/c/1053116.
The target widget is used in DetachedTitleAreaRenderer and WideFrameView.

BUG=b/33693796
TEST=covered by unittest

Change-Id: I839d13113a40abde4d25d7e634ad549937dac30b
Reviewed-on: https://chromium-review.googlesource.com/1067319
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561355}

DecryptingAudioDecoder was added to support decrypt-and-decode of audio
buffers by a CDM using the Decryptor interface. Since then CDMs have
evolved and today there's no CDM supporting this path in production.
Though in browser tests, this paths is still used where the Clear Key
CDM can decrypt-and-decode audio.

This CL changes DefaultDecoderFactory such that by default
DecryptingAudioDecoder will not be created except when External Clear
Key is enabled, which typically is only set in browser tests.

This will save an IPC round trip during initialization when playing
media with encrypted audio, and hopefully will improve start-to-play
time.

Note that decrypt-and-decode of audio is supported on Android, but via
MojoAudioDecoder directly, not through an explicit Decryptor interface.

Bug: 846064
Test: browser tests still pass
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iffcbd488e613b63d50bf077dc27b4e5c4105adc3
Reviewed-on: https://chromium-review.googlesource.com/1070554Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561354}

Items in single selection containers that have accessibility focus
should get the selected state. Code to mirror focus to selection exists,
but the selected state must be refreshed.

Bug: 846089
Change-Id: I90eb6aaec3be196b78126241ebf7e3d38ccda7c2
Reviewed-on: https://chromium-review.googlesource.com/1070520
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561353}

(1) Update native_inference.h, native_inference.cc,
example_preprocessor_config.pb to be the newest model.

(2) Update tab_score_predictor_unittest.cc

(3) Add amoylan as extra owner of this directory.

Change-Id: Iffb2f84e5cbf65ae20d864fccc2edface051055e
Reviewed-on: https://chromium-review.googlesource.com/1068952
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561352}

This CL replaces ScriptLoader::Execute() with
PendingScript::ExecuteScriptBlock().

To do this, this CL clears ScriptLoader::pending_script_ in
ScriptLoader::PendingScriptFinished(), i.e. slightly before
ScriptLoader::Execute().

Bug: 842349
Change-Id: Ia010d370ce1e139808b39e66ad4557f9151e2a47
Reviewed-on: https://chromium-review.googlesource.com/1054553
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561351}