GitLab

The TRACE_EVENT_CATEGORY_GROUP_ENABLED sets enabled to true even when
filtering mode was turned on. This should be set only for recording and
etw modes.

BUG=669611, 670013

Review-Url: https://codereview.chromium.org/2547193002
Cr-Commit-Position: refs/heads/master@{#437686}

Change message to show that clicking on a trash can actually
deletes items instead of just removes them, even though the
operation is "remove" by the DownloadHistory backend.

BUG=666292

Review-Url: https://codereview.chromium.org/2564053003
Cr-Commit-Position: refs/heads/master@{#437685}

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2563883005
Cr-Commit-Position: refs/heads/master@{#437684}

Secondary: This change causes constraint space to not be const

Also, minor bug fixes by Ian to make tests pass.

BUG=635619

Review-Url: https://codereview.chromium.org/2562703003
Cr-Commit-Position: refs/heads/master@{#437683}

This CL adds Rappor metrics to collect data for the cross-origin
autoplay experiment. It records the ETLD+1 of top-level frame and
iframes when a video is allowed to/blocked to autoplay and also
when the user has manually started a blocked video.

BUG=672526

Review-Url: https://codereview.chromium.org/2524443002
Cr-Commit-Position: refs/heads/master@{#437682}

BUG=none

Review-Url: https://codereview.chromium.org/2563553002
Cr-Commit-Position: refs/heads/master@{#437681}

As the first step in making BookmarkIndex usable on non-bookmark items, add
a TitledUrlNode interface to represent objects like bookmarks that expose a
title and URL. BookmarkIndex now expects its items to be TitledUrlNodes and
BookmarkNode implements the TitledUrlNode interface.

BUG=630769

Review-Url: https://codereview.chromium.org/2537223008
Cr-Commit-Position: refs/heads/master@{#437680}

Add native_lib_version_rule = "//build/util:chrome_version_json" to
chrome_public_apk to fix the build failure caused by "No such file or
directory: 'gen/CHROME_VERSION.json'" when building
monochrome_public_apk in a fresh output directory.

Review-Url: https://codereview.chromium.org/2565853002
Cr-Commit-Position: refs/heads/master@{#437679}

I'm adding histogram for different events during ClearServerData flow. They'll
help monitor how often enabpling passphrase encryption encounters issues.

R=zea@chromium.org,jwd@chromium.org
BUG=490836

Review-Url: https://codereview.chromium.org/2557733004
Cr-Commit-Position: refs/heads/master@{#437678}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/df2363501bd7..707aaac64b3c

$ git log df2363501..707aaac64 --date=short --no-merges --format='%ad %ae %s'
2016-12-09 eakuefner [Telemetry] Add temporary logging to desktop_browser_finder

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2566723002
Cr-Commit-Position: refs/heads/master@{#437677}

This bot config is having stability problems - disable all tests until
the issue is resolved.

BUG=672502
NOTRY=true
NOPRESUBMIT=true
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2562133002
Cr-Commit-Position: refs/heads/master@{#437676}

BUG=666796

Review-Url: https://codereview.chromium.org/2565843002
Cr-Commit-Position: refs/heads/master@{#437675}

When copying around TraceWrapperMember, e.g., when it is dded to a backing
store, we want the write barrier because the initial trigger could've observed a
different state.

(This is how it was supposed to be when initially designed.)

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2567463003
Cr-Commit-Position: refs/heads/master@{#437674}

Per dpranke, it seems Gerrit strips out <a id=foo> anchors.

BUG=

Review-Url: https://codereview.chromium.org/2567583002
Cr-Commit-Position: refs/heads/master@{#437673}

BUG=646176

Review-Url: https://codereview.chromium.org/2562033003
Cr-Commit-Position: refs/heads/master@{#437672}

As part of this, also moved computation of PaintLayer::ancestorScrollingLayer,
because that is required for sticky position constraint updates.

BUG=646188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2561693002
Cr-Commit-Position: refs/heads/master@{#437671}

Prior to completing the FRE on Android, we should disallow
UI options that allow creating new tabs in Chrome.

This disables "Web Search" from the action mode menu and
also the various "Open in X" menu options.

BUG=671149

Review-Url: https://codereview.chromium.org/2559573002
Cr-Commit-Position: refs/heads/master@{#437670}

The code will now open files in the browser process before passing the
handles across IPC to the utility process. The utility process in turn
invokes courgette/bsdiff, which memory maps the files and operates on
them as before.

There is a behavioral difference when using the courgette or
courgette_mini tools: the output file will now be created/overwritten
at the start of the operation, and in the case of a failure, will be
deleted. Previously, the output file was created late in the operation
operation and several failure modes would leave it unmodified.

BUG=660325

Review-Url: https://codereview.chromium.org/2534873005
Cr-Commit-Position: refs/heads/master@{#437669}

Display error message when user try to open a locked supervised user profile when force-sign-in is enabled.

BUG=642059

Review-Url: https://codereview.chromium.org/2552473002
Cr-Commit-Position: refs/heads/master@{#437668}

The MS VP9 MFT swallows driver exceptions and later hangs because it gets
into a weird state. Instead the vectored exception handler can upload a
crash dump so we can get more actionable feedback.

BUG=636158
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559633002
Cr-Commit-Position: refs/heads/master@{#437667}

Add a ColorBehavior argument to
- blink::Image::imageForCurrentFrame
- blink::Image::draw
- blink::Image::applyShader

Plumb these arguments through to all sub-classes. For sub-classes where
there is a trivial implementation, add it (e.g, blink::BitmapImage).
For all other sub-classes and callsites that need behavior changes, add
TODOs referencing the appropriate bugs.

This patch should have no behavior change -- it just formally
propagates arguments that were previously implied or pulled out of
global variables.

BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559013002
Cr-Commit-Position: refs/heads/master@{#437666}

This cl is to enable HW H264 encoding on Android by default, with a flag.
This feature is firstly introduced in crbug/615108 (cl
https://codereview.chromium.org/2358683002), disabled by default with
a combined flag for both VP8 and H264. Now we separate the flag into
two and still keep VP8 HW encoder disabled by default.

BUG=664652

Review-Url: https://codereview.chromium.org/2549283002
Cr-Commit-Position: refs/heads/master@{#437665}

The new audit.js and audio-testing.js have a duplicate library of Audit task
runner. Separate legacy utilities out of audio-testing.js and create a new
audit-util.js so we can use those utilities in both settings.

To add the inclusion of 'audit-util.js' before all the instances of
'audio-testing.js', I ran this bash script:

```bash
for f in `find . -name '*.html'`
do
  echo $f
  perl -p -i -e 's@(\s*)<script(.*)src="(.*)audio-testing.js"></script>@
$1<script src="$3audit-util.js"></script>\n
$1<script src="$3audio-testing.js"></script>@g' $f
done
```

After adding the new JS file, some expected files needed care on console
warning messages. To update the expected text files:

FILES="audioparam-automation-clamping
audioparam-nominal-range
audioparam-setValueCurve-duration
audioparam-setValueCurve-exceptions
biquadfilternode-basic
oscillator-basic
pannernode-basic"

```bash
for f in $FILES
do
  echo "~/chromium/src/out/Default/layout-test-results/webaudio/
$f-actual.txt ~/chromium/src/third_party/WebKit/LayoutTests/webaudio/
$f-expected.txt"
  cp ~/chromium/src/out/Default/layout-test-results/webaudio/
$f-actual.txt ~/chromium/src/third_party/WebKit/LayoutTests/webaudio
$f-expected.txt
done
```

Note that I had to change `onstatechange.html` file manually, because it was
using the style of `<script ... />`. Except for this file, all the changes
is done by two scripts above.

BUG=672926

Review-Url: https://codereview.chromium.org/2567713002
Cr-Commit-Position: refs/heads/master@{#437664}

BUG=660942
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2561653002
Cr-Commit-Position: refs/heads/master@{#437663}

This CL ensures the origin header is properly set when using
browser-side navigation.

BUG=648588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2496293003
Cr-Commit-Position: refs/heads/master@{#437662}

It's not relevant at all.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2566493004
Cr-Commit-Position: refs/heads/master@{#437661}

The allows using RenderFrameHost::GetLastCommittedOrigin() correctly
when the RenderFrameHost is different from a frame's current RFH, such
as when it's pending or pending deletion.

BUG=590035, 663740
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2546533007
Cr-Commit-Position: refs/heads/master@{#437660}

This will put the onus on individual observers to extract the security
information they require, after a change has occurred.  The intent is to
allow chrome/browser-residing observers to monitor security level
changes, independent of style.

BUG=641508

Review-Url: https://codereview.chromium.org/2562503002
Cr-Commit-Position: refs/heads/master@{#437659}

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563863002
Cr-Commit-Position: refs/heads/master@{#437658}

Currently the TracedValues were being created even when the tracing category was
disabled. This CL moves the creation of the TracedValues into a function, which
is called only when the TRACE macro arguments are evaluated, which, in turn,
only happens when the tracing category is enabled.

Measuring on a linux workstation using the linux perf tools, the instrumentation
overhead with the tracing category disabled is now below 2% of the cost of the
ResourceFetcher::requestResource function, as opposed to the 12% measured
before.

Review-Url: https://codereview.chromium.org/2537143005
Cr-Commit-Position: refs/heads/master@{#437657}

Adding dependencies needed by libGL.so and libpam.so.

BUG=668205

Review-Url: https://codereview.chromium.org/2558343002
Cr-Commit-Position: refs/heads/master@{#437656}

BUG=555865

Review-Url: https://codereview.chromium.org/2389613002
Cr-Commit-Position: refs/heads/master@{#437655}

While main frame loads already disabled the load being handled by the browser (in RenderViewTest::LoadHTML), requests from subframes are created inside Blink and so were missing that flag. Fix this by adding it in TestRenderFrame. Note this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2557223002
Cr-Commit-Position: refs/heads/master@{#437654}

This CL does two things to the Plugins Block Omnibox popup:

 1. Removes the radio buttons. They are misleading and irrelevant in the HBD world, and weren't actually that useful in the pre-HBD world either.

 2. Hides the Run All Plugins link in the policy-managed BLOCK case or the HBD BLOCK case.

 3. Hides the Manage... link in the policy-managed case. User cannot manage the setting anyways.

BUG=655899

Review-Url: https://codereview.chromium.org/2552343005
Cr-Commit-Position: refs/heads/master@{#437653}

We measure frame time so the granularity of frame cycle affects the
accuracy (small load sometime causes 1 cycle flakiness) and visibility
(performance difference of a too small load is hidden by the smallest
frame cycle) of the results. See https://goo.gl/wGEsdM for samples of
the flakiness.

Increase load to avoid the above issues, especially after we excluded
GC time from the measured time (https://codereview.chromium.org/2559893002/)
for crbug.com/667811.

Now most of the measured times on my local Linux machine are between
100ms and 300ms.

Modified some tests to avoid the increased load from causing too much
layout time.

NOTRY=true (try bots help nothing for this CL)

Review-Url: https://codereview.chromium.org/2564773003
Cr-Commit-Position: refs/heads/master@{#437652}

This makes client side (in-process / proxy) command buffer state thread-
safe and adds release count to the client-server shared state. This
allows the compositor thread to monitor worker context sync token in the
service.

Client side command buffer state is synchronized using a lock. Extra
caching of the state is added to command buffer helper so that it
doesn't acquire the lock for every command.

Also fixes command buffer memory tracing so that it happens on the same
thread which the context provider is bound to.

R=piman@chromium.org,jbauman@chromium.org
BUG=514813,638862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550583002
Cr-Commit-Position: refs/heads/master@{#437651}

The drop-down list closes on a GestureTapDown, and the next GestureTap
cannot open the same list. The regression was because of the following
cl: https://codereview.chromium.org/2517253002/

BUG=670185, 569092
Test=LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html

Review-Url: https://codereview.chromium.org/2558113002
Cr-Commit-Position: refs/heads/master@{#437650}

Forcing this through the CQ to roll dEQP.

https://chromium.googlesource.com/angle/angle.git/+log/023c2b1..e735511

BUG=chromium:671021
TBR=geofflang@chromium.org
TEST=bots
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563643004
Cr-Commit-Position: refs/heads/master@{#437649}

Specify the ColorBehavior from GraphicsLayer to GraphicsContext.

Use the GraphicsLayer's ColorBehavior to determine if the
WebDisplayItemList has an implied color space.

This does not change any behavior, but makes implied behavior
explicit.

The ColorBehavior in GraphicsLayer is unused, but will be used by
future patches.

BUG=667411

Review-Url: https://codereview.chromium.org/2552893005
Cr-Commit-Position: refs/heads/master@{#437648}

crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API.

BUG=647296

Review-Url: https://codereview.chromium.org/2555743008
Cr-Commit-Position: refs/heads/master@{#437647}