- 01 Jul, 2020 40 commits
-
-
Christian Dullweber authored
This reverts commit c92df469. Reason for revert: This CL caused test failures in https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16175 Original change's description: > Ensure test settings are fully reset between tests > > Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, > dirtying TestRunner state for the next test. A navigation to about:blank > is done after every test. This patch resets the TestRunner state after > the navigation to about:blank, when we are sure no test javascript can > change TestRunner state. This fixes a class of flaky bugs. > > This behavior happened with video-overlay-scroll.html which would set a > custom layout dump (setCustomTextOutput) in a fullscreenchange event > handler. This event handler was not removed at the end of the test > (this will be fixed in a followup), and would run a second time, after > the custom text output setting was reset. This caused later tests to > run with custom text output from video-overlay-scroll.html. With this > patch, video-scrolled-iframe.html is no longer flaky. > > Code in WebFrameTestProxy::BeginNavigation to intercept navigations > relied on TestRunner::PolicyDelegateEnabled being reset before it ran. > This patch now skips WebFrameTestProxy::BeginNavigation when the test > is not running. > > Bug: 1048597 > Change-Id: I888f7cc2ae91d7d3cfdd143a7573f62cb052c1cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275348 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Auto-Submit: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784110} TBR=danakj@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ieb22e1d115bd284aaa942c60ca7c6dc5e8ea71b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276418Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#784367}
-
Javier Ernesto Flores Robles authored
Dock the keyboard on tear down when an attempt to undock it was made. Bug: 1092828 Change-Id: I6dc338f8b4b03e3f81d2d36f2f660c491bcffa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270066 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#784366}
-
Colin Blundell authored
//chrome's InfoBarContainerLayout.java has now been componentized and WebLayer can reuse it. As part of that componentization, the InfoBarAnimationListener interface was pulled out of //chrome's InfoBarContainer.java to live in a standalone //components-level file. This CL changes WebLayer to use the componentized InfoBarContainerLayout and the componentized InfoBarAnimationListener on which the former depends. There are no behavioral changes, as none of the code being deleted was changed from the now-componentized //chrome versions. Bug: 1099169 Change-Id: Ic443dc5cd266da1add574e85caf100a809111e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275895 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#784365}
-
Christian Dullweber authored
This reverts commit 8d6a9454. Reason for revert: All/NavigationControllerBrowserTest.PageStateWithIframeAfterForwardInCompetingFrames/2 is failing on https://ci.chromium.org/p/chromium/builders/ci/android-asan/6791 Original change's description: > Parameterize NavigationControllerBrowserTest etc for RenderDocument. > > These tests are sensitive to RD's type of changes and several of them > needed fixing already. > > Bug: 1100745,1068965 > Change-Id: I1bd93ebac207c502d0dda7f749a4c5f25f4e506b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275459 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784274} TBR=alexmos@chromium.org,fergal@chromium.org Change-Id: I8c7ebc4cb5b0c82d5a2a9e8b01f9abc71918b7e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100745, 1068965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277804Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to cancel Password Check when it's running. Bug: 1075494 Change-Id: If266b44db8b52cae16346d37782cac5cd1a4dbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274881 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784363}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0a1c32f21b8..95099f475463 2020-07-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2fbbc830b6fa17c7e53c528cb9bb24f6da9ca0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784362}
-
Dominic Mazzoni authored
This restores things to how they were before Reland "Consolidated some text helper methods in AXNode" (http://crrev.com/2224224) with regards to what ViewAXPlatformNodeDelegate::IsChildOfLeaf returned. Later if we come up with a better fix for the endless loop we can restore the proper implementation of IsChildOfLeaf for Views. Bug: 1100047 Change-Id: I8e34fed0e4dcfd4822386f90b3724dc4977ed5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277502 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784361}
-
Sylvain Defresne authored
This is a remnant from building with xcodebuild/gyp. Can safely be removed as it is unused. Bug: None Change-Id: I501146d14d2b1256180d1d3db40592019c0e5cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270061 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784360}
-
Lam Lu authored
Notify devtools client on fontUdpated event when initialize CSS font face with binary data. The current devtools fontUpdated event only gets called when initialize font face from src url. third_party/blink/tools/run_web_tests.py -t Release third_party/blink/web_tests/inspector-protocol/css/ css-fonts-updated-event-with-data-buffer.js Bug: 1095185 Test: autoninja -C out/Release blink_tests and run python Change-Id: I8507953e3046c3c21e3bc9ec6e681961fb5a11de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247159 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#784359}
-
Anand K Mistry authored
The header was previously included transitively. Fixed: 1101222 Change-Id: Ic8a4beeab5dc2f6cd61c63c119c93688ae1dd04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276357 Auto-Submit: Anand K Mistry <amistry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#784358}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6bd8e303c90e..afd27509974a 2020-07-01 dhoss@chromium.org Fix FPDFTextObj_SetTextRenderMode() to stick when the document is saved 2020-07-01 dhoss@chromium.org Encapsulate access to CPDF_TextObject's text rendering mode 2020-06-30 thestig@chromium.org Roll v8/ 41918cc2b..65a118899 (48 commits) 2020-06-30 thestig@chromium.org Roll third_party/skia/ 6f56f2ed3..7c1f3fabf (41 commits) 2020-06-30 vmiklos@collabora.co.uk Add FPDF_GetSignatureObject() API 2020-06-30 thestig@chromium.org Roll v8/ bfc0d2f43..41918cc2b (4 commits) 2020-06-30 thestig@chromium.org Roll third_party/skia/ aa10dfeec..6f56f2ed3 (1 commit) 2020-06-30 thestig@chromium.org Roll build/ 3405bae23..d4fe00fc1 (103 commits) 2020-06-30 thestig@chromium.org Roll v8/ 9912e35d5..bfc0d2f43 (84 commits) 2020-06-30 thestig@chromium.org Roll tools/clang/ 9f3f85f0e..6849229b3 (34 commits) 2020-06-30 thestig@chromium.org Roll third_party/skia/ c48caaae4..aa10dfeec (68 commits) 2020-06-30 thestig@chromium.org Roll buildtools/ 574cbd5df..1ed99573d (4 commits) 2020-06-30 thestig@chromium.org Roll third_party/icu/ 630b884f8..79326efe2 (10 commits) 2020-06-30 thestig@chromium.org Roll third_party/googletest/src/ cb44c86c1..4fe018038 (6 commits) 2020-06-30 thestig@chromium.org Roll third_party/zlib/ a68151fd9..8603eee37 (5 commits) 2020-06-30 thestig@chromium.org Roll third_party/freetype/src/ 62fea391f..a44347475 (18 commits) 2020-06-30 thestig@chromium.org Roll base/trace_event/common/ dab187b37..ef3586804 (1 commit) 2020-06-30 thestig@chromium.org Roll third_party/depot_tools/ 393b040fb..d912aa913 (70 commits; 31 trivial rolls) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iff09a1379f062dfce03a2838aaa447644a890165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276568Reviewed-by:
-
Koji Ishii authored
This patch adds the guard against dirty tree to |ScrollableOverflow|, similar to r779382 <crrev.com/c/2249281> and r784297 <crrev.com/c/2275373>. Bug: 1101141 Change-Id: Id428cd408dfd36869e83170ff534339235ed3984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275281Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784356}
-
Francois Beaufort authored
This is a reland of 56bfd87f with an additional fix of initializing pan_tilt_zoom_supported to false in blink::MediaStreamDevice. to address the "use-of-uninitialized-value" raised by MemorySanitizer. Original change's description: > [PTZ] Measure prevalence of cameras supporting PTZ > > This CL adds metrics for how many users have cameras with PTZ > capabilities. This metric is triggered only when a permission prompt > would show up. > > Bug: 990185 > Change-Id: Icba513c14977ef1249ed68788fc91d5059b1c0c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273237 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783901} Bug: 990185 Change-Id: I3629ccfe9c254784815b631d4ac56390f2ced9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275447Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#784355}
-
Christian Dullweber authored
This reverts commit 24f7513d. Reason for revert: This broke compilation on a chromeos bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/166646 Original change's description: > Remove references to cacheinvalidation from BUILD.gn files > > The cacheinvalidation library is deprecated, not used anymore, and will > be deleted soon. > > Bug: 1099672 > Change-Id: Ic8467c611b4d99294e06e0e5c848059ff77c3e26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270151 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784345} TBR=treib@chromium.org,jochen@chromium.org Change-Id: I98e328e146aef8375ba58e2cd3bdedd1c64ef068 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274611Reviewed-by:
-
Colin Blundell authored
This class can be reused as-is by WebLayer. To facilitate the componentization, we break the dependency on InfoBarContainer by moving the InfoBarAnimationListener interface into its own file in //components/infobars as well. InfoBarWrapper will be able to return to being package-private once I change //weblayer to use the componentized InfoBarContainerLayout in a followup. Whether InfoBarContainerLayout's methods will be able to go back to being package-private depends on the resolution of sharing InfoBarContainerView, which I will be examining shortly. Bug: 1099169 Change-Id: I50b68b8269dd7f0df12fe4f8bda1c32baf43e55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275873 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#784353}
-
Fergal Daly authored
A test in here fails when the render document level is set to replace crashed frames and overall COOP seems like it will be sensitive to RD's changes, so it's best to ensure that its tests also run with the RD flags enabled. This just disables the failing test and leaves a TODO. Bug: 1066376 Change-Id: Ie2d0c6ef69445c59a48d393cca2bd08a4f951a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274739 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#784352}
-
Colin Blundell authored
//chrome's SwipableOverlayView.java has now been componentized, and hence //weblayer can reuse it rather than having its own custom copy. The only change made to this code in //weblayer was to support the fact that //weblayer needs to add the SwipableOverlayView to its parent at a specific index. This CL adds that API to the //components-level SwipableOverlayView.java and eliminates //weblayer's copy in favor of its using the //components-level class. Note: I didn't have the existing SwipableOverlayView#addToParentView() call through to the newly-added SwipableOverlayView#addToParentViewAtIndex() because the default value used for the index in the ViewGroup#addView() variant that doesn't take in an index doesn't seem to be documented publicly anywhere. In practice it looks like -1 from looking at the ViewGroup.java source, but I don't want to hardcode that without public documentation. Bug: 1099169 Change-Id: If159701d611b7eee1a600911ff0b2aa1bda10154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274390 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#784351}
-
Alex Danilo authored
Changes the logic that shows a sub menu to check if any other sub menu is showing, and if so, hide it before showing the new sub menu. Bug: 1100177 Change-Id: I33527c776bdff7cb0d7d9a452a0fe13b8df60434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277376Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784350}
-
Xida Chen authored
This CL converts base::Closure to base::RepeatingClosure. This is a code health CL, should not cause any behavior change. With this CL, there will be no base::Callback, or base::Closure or base::bind in autofill/ Bug: 1007635 Change-Id: I2d387ba822917dc080deeda93b2511d623b37beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272610 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#784349}
-
Rakina Zata Amni authored
This reverts commit ab3d270b. Reason for revert: Tests are failing in https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/7987 Original change's description: > Implement HTTPSOCSPTests as browsertests > > Right now the most complete set of OCSP tests is implemented in > url_request_unittest.cc using HTTPSOCSPTest. This CL creates a parallel > set of browsertests, so we can test that OCSP works with the > CertVerifierService as well. > > The new tests are in ocsp_browsertest.cc, and existing OCSP > browsertests were moved from ssl_browsertest.cc into > ocsp_browsertest.cc to reduce the size of the ssl_browsertest.cc > file. > > The new tests are nearly identical, structurally, to the original > tests, but SystemSupportsOCSP() is no longer necessary as it > was really checking support for EV certificates, and the checks > for EV certificates are already guarded by > SystemUsesChromiumEVMetadata(). > > Bug: 1015134, 1022561 > Change-Id: I32e9355d276f75de3432c09f8e7309db1525f729 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274581 > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784338} TBR=falken@chromium.org,rsleevi@chromium.org,mpdenton@chromium.org Change-Id: I79bf58c017a324ca32f6b5a4e2dd30d9c2652683 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015134, 1022561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277380Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#784348}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Icf891ffb2c036ed165b94ce136fc23e8fb1db32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274632 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784347}
-
Ionel Popescu authored
This CL updates the icon for input type="search" to match the spec. Added several search appearance tests to validate the new UI. Bug: 1099643 Change-Id: I4d44069443632f09ebbdbad6e6a670ad66a8736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275947Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784346}
-
Marc Treib authored
The cacheinvalidation library is deprecated, not used anymore, and will be deleted soon. Bug: 1099672 Change-Id: Ic8467c611b4d99294e06e0e5c848059ff77c3e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270151Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#784345}
-
Minoru Chikamune authored
To deprecate kWithoutContextObserver mode, we are going to enable HeapMojoUseContextObserver feature for waterfall testing. By doing this, we can detect crashes during the waterfall testing. Bug: 1049056 Change-Id: I96e0be25ad6e6cc9eeac2fad600f1dadec02ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277369Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#784344}
-
Shakti Sahu authored
This CL adds 1 - Vector icon for download later on the infobar (modified for dark mode as well) 2 - Correct formating for download later text which should say Download scheduled on Jun 25, 2020 or 3:30 PM (if same day) 3 - A color bug in download home which wasn't showing the progress circle for in-progress downloads. (It was making it same color as inner solid background) Bug: 1066379 Change-Id: Ibeb3cdb9102e7c5270d792637f4fb9b78747a885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276800Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784343}
-
Sophey Dong authored
Also fix the issue where the QR Code was not being loaded after revoking permissions. Bug: 1079467, 1083351, 1099291 Change-Id: Ia5b61a461e0321e46631119c22a15ef851d8ddd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265248Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784342}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/465b1021048a..ae6540492fcb 2020-07-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25f64508f172452554565990681ea56a44d75d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277484Reviewed-by:
-
Anupam Snigdha authored
This CL moves functions that fire events to JS from anonymous namespace to the |InputMethodController| so we can check if the ExecutionContext is still valid after firing the events or not and bail out if its not valid. Bug: 1088364 Change-Id: I2b98724bf305aed998222581a608dc16b0f64baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276666Reviewed-by:
-
Koji Ishii authored
When computing ink overflow against dirty tree, r784297 crrev.com/c/2275373 fixed to skip if corresponding |LayoutObject| was destroyed or moved. This patch adds another check of this, this time in |RecalcInkOverflowForCursor|, because without it, |HasSelfPaintingLayer| will crash. Bug: 1101079 Change-Id: Ia7abb284dd52b467b492e81da5523d0546d7a61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275926Reviewed-by:
-
Matthew Denton authored
Right now the most complete set of OCSP tests is implemented in url_request_unittest.cc using HTTPSOCSPTest. This CL creates a parallel set of browsertests, so we can test that OCSP works with the CertVerifierService as well. The new tests are in ocsp_browsertest.cc, and existing OCSP browsertests were moved from ssl_browsertest.cc into ocsp_browsertest.cc to reduce the size of the ssl_browsertest.cc file. The new tests are nearly identical, structurally, to the original tests, but SystemSupportsOCSP() is no longer necessary as it was really checking support for EV certificates, and the checks for EV certificates are already guarded by SystemUsesChromiumEVMetadata(). Bug: 1015134, 1022561 Change-Id: I32e9355d276f75de3432c09f8e7309db1525f729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274581 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784338}
-
Fergal Daly authored
It currently waits 500ms to allow time for RAFs. On some Mac builders this does not allow enough time, so increase the timeout to 1s. Bug: 1098715 Change-Id: I4e8cedb0706404f373ca381c9490395f42bd5886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269617Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77d7d5ea92ca..5638f489af56 2020-07-01 mtklein@google.com add windows skvm bots 2020-07-01 mtklein@google.com save only xmm6-15 on windows 2020-07-01 johnstiles@google.com Update ImGui to latest stable version (1.77). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I1dd9fdf76821bc723d8f4ef6935309228d3e36b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276562Reviewed-by:
-
David Maunder authored
PersistedTabData stores tab metadata across restarts and FilePersistedTabDataStorage is the method of persisting the data in a file. Various use cases such as serialization, save, restore and delete now have metrics associated with them. Bug: 1059635 Change-Id: I3f7d267227819eefb30b23b95a85a637e22fef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125229 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784335}
-
Matt Giuca authored
Links to it from new README files in other related directories. Change-Id: I9dcca96de0e8e0b4fc885727efac800bdcc2abd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275976Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdd2cd6e5fc0..f0a1c32f21b8 2020-07-01 vadimsh@chromium.org [lucicfg] Update it to v1.17.1. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096936 Tbr: agable@chromium.org Change-Id: Ia4a37c2efbe6a1abaa7f1bff374507053ff7fe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1b825219eae..4cb7be407fb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rakina@google.com Change-Id: I0efb231e69313e4a114954636ee595abf4cfc0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277483Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Dominic Farolino authored
This CL augments the existing iframe lazyload test for srcdoc lazyload support. Chrome currently does not implement this. The test accompanies the spec change made at: https://github.com/whatwg/html/pull/5579. R=sclittle@chromium.org Bug: 1101170 Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276624Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#784331}
-
Minggang Wang authored
For dedicated worker (PlzDedicatedWorker) and shared worker, the main script is pre-requested in browser process and passed to renderer process through WorkerMainScriptLoadParams, which is set into WebWorkerFetchContextImpl as NavigationResponseOverrideParameters. Finally, a faking request will be sent and gets hooked in ResourceDispatcher::ContinueForNavigation to receive the response. The downside is that we have to depend on content layer and construct an unnecessary WebURLRequest in renderer process to get the mian script. So, we are going to make changes: 1. This patch - Creates WorkerMainScriptLoadParameters to take over the WorkerMainScriptLoadParams passed from browser process. - Creates WorkerMainScriptLoader to load the main script in renderer process directly instead of sending a faking WebURLRequest to load the main script executed as classic or module for dedicated worker (PlzDedicatedWorker) and shared worker. - Adds the blink platform test for WorkerMainScriptLoader. - Creates a mojom interface ResourceLoadInfoNotifier to notify the loading info of the main script. 2. https://chromium-review.googlesource.com/c/chromium/src/+/2115554 - Enables WorkerClassicScriptLoader/WorkerModuleScriptFetcher to use WorkerMainScriptLoader to load the top-level scripts. 3. https://chromium-review.googlesource.com/c/chromium/src/+/2115459 - Removes NavigationResponseOverrideParameters. Change-Id: If36e7f2a0ba67967b160abe2231de31e332b2827 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916682 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#784330}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib61cf9be8fbc09fabd8765b8177c1b34d84494be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276565Reviewed-by:
-
Miyoung Shin authored
This CL fixes nullptr access in prerender::PrerenderObserverList::RemoveObserverForFrame since RenderFrame is destroyed first before ChromePluginPlaceholder dtor that removes an observer for RenderFrame is called. Fuzzer report: https://clusterfuzz.com/testcase-detail/4966404840816640 Bug: 1099851, 1100030, 1100780 Change-Id: Id0db5a3c6d3fc9018a120d7ad0b0d3125d875302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272179Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#784328}
-
