- 22 Oct, 2019 40 commits
-
-
John Delaney authored
There are a few tests in AdsPLMO that still create a mock noise provider with 0 noise, even though this is now the default for all tests after https://crrev.com/c/1849130 .These tests landed shortly after that change. Change-Id: Icd8a1468b38a2943dcf94f148249a5e6f0ba96c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869471Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708191}
-
ckitagawa authored
As noted in crbug/1010396 dropping hints breaks some CJK Freetype fonts. Disabling this will slightly increase subset font sizes for fonts that rely on bytecode hints. However, this seems to be uncommon based on the discussion in the bug. Change-Id: Ib2a621ebfcfad3fbc015f50ec7c5bf3b18e6fa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873238 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#708190}
-
Elly Fong-Jones authored
This dialog gets its strings from an ExtensionInstallPrompt::Prompt, via the Get{Accept,Abort}ButtonLabel methods. Those methods, in turn, depend on two fields of Prompt: type_ and extension_. Better yet, type_ is already const. I attempted to make extension_ const but wasn't able to do so. Instead, this change relies on the current behavior of that class, which is that it is always used like this: auto prompt = make_unique<Prompt>(); // somewhere else: prompt->set_extension(...); // yet a third place: ShowDialog(..., std::move(prompt), ...) Not all the places where Prompt is constructed have ready access to the extension it will eventually represent, which makes passing the extension as a constructor parameter to Prompt infeasible. Rats. This change calls the prompt from ExtensionInstallDialogView's constructor to get the appropriate button labels and apply them. Bug: 1011446 Change-Id: If4ceff51f3aa4a5ca3cb8c3013954748377c8544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872420Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708189}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/704ce5c7..0b40cfb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I310c508378eacad976e34712b7b2c9813743869e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871905Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708188}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4191602bb51..bfdfc7ac4118 git log c4191602bb51..bfdfc7ac4118 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 perezju@chromium.org [Telemetry] Stricter check on Tracing.requestMemoryDump response Created with: gclient setdep -r src/third_party/catapult@bfdfc7ac4118 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:987858 Change-Id: I2cdb495564f320c08857ef546f3e54e64357bb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708187}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/acb77af66d..2c3fbc1c99 TBR=bmeurer@chromium.org Change-Id: Iea5088922dbaf74235d7fa67b52e312ae684dc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871886Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708186}
-
Martin Robinson authored
This will ensure that Orca knows to properly move the text caret after anchor navigation even when Chromium-based text caret navigation is disabled. Normally, this is handled by the sequential focus navigation starting point, but this value is not propagated to the accessibility layer. Bug: 1011942 Change-Id: I21d2cde59e12f8aff212b2d9bf3700dad27242c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871887 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Auto-Submit: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#708185}
-
Gyuyoung Kim authored
This CL applies new Mojo types to VideoSourceProvider interface. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Replace std::find_if with a for-loop. - Replace mojo::Binding with mojo::Receiver Bug: 955171 Change-Id: I9ce0a8a075b84ce4f65a6ebd79e025e598faa3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863795Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#708184}
-
Ruslan Burakov authored
Intent to ship here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4W4orKqA3Rs This concludes origin trial for RTCJitterBufferDelayHint described here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Tgm4qiNepJc We embed it to RTCRtpReceiver under different name - playoutDelayHint. The spec describing it can be found here: https://henbos.github.io/webrtc-extensions/#dom-rtcrtpreceiver-playoutdelayhint Bug: webrtc:10287 Change-Id: I24edf1b6146a0ad1c8d979833e53a27617af44af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836508 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#708183}
-
Francois Beaufort authored
Following Web NFC spec change at https://github.com/w3c/web-nfc/pull/303, this CL makes sure NFC is not suspended when frame loses focus. http://crrev.com/c/1862475 added a focused test but it wasn't working. Later http://crrev.com/c/186439 fixed it and added a timeout test expectation. This CL removes it as focus is not a requirement anymore. Bug: 996250, 520391 Change-Id: I6b5d14796dc00c8d3c8634dd9caac6da337df10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764132 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#708182}
-
Juan Antonio Navarro Perez authored
Running the command, e.g.: $ tools/perf/run_benchmark loading.cluster_telemetry --browser stable Used to fail with an exception. Now instead prints a more user friendly error message: Usage: run_benchmark run benchmark_name [<options>] run_benchmark: error: Please specify --user-agent. Bug: 1009012 Change-Id: Id3b3ba521f3aa10b98a8e7a6aeae52c6f5cd8e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872103 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708181}
-
Mitsuru Oshima authored
Bug: None Test: None Change-Id: I571bbcd40613ce255a1b323ec2fdae4d137dd389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863358 Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#708180}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88adfb7aa2e6..1872e136d13b git log 88adfb7aa2e6..1872e136d13b --date=short --no-merges --format='%ad %ae %s' 2019-10-22 lalitm@google.com trace_processor: refactor row map tests to be more explicit Created with: gclient setdep -r src/third_party/perfetto@1872e136d13b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: Ie0e3ba42f967efdc1d8c4826d14e805c050cd21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873596Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708179}
-
K Moon authored
Use a new |document_loaded_| field to decide whether or not to call FPDFAvail_IsPageAvail() in PDFiumEngine::LoadPageInfo(). This enables calling LoadPageInfo() without precisely tracking the correct value for the |reload| parameter. The |reload| parameter is used to defer calls to FPDFAvail_IsPageAvail() from LoadPageInfo() until after FinishLoadingDocument() is called, but this requires the caller to track whether or not FinishLoadingDocument() has been called. It's simpler just to have FinishLoadingDocument() directly mark whether or not it has executed. The |reload| parameter previously was used to decide how to create PDFiumPage instances as well, but this usage was eliminated in crrev.com/702636. This incidentally made the DCHECK added in that change superfluous, so it has been removed in this change. Bug: 885110 Change-Id: I33a2d437c2f8abbea655b054c2259d85441d0752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857545 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708178}
-
Arthur Hemery authored
NavigationClient is now on by default, so removing an unused branch in tests. Also removing a test that does not make sense anymore. Bug: 784904 Change-Id: Ibf91fdfbdc23d03a9f5a966ca02c82314fcdca97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821558 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708177}
-
ckitagawa authored
Use <> for harfbuzz includes to support the option to build with system harfbuzz rather than the version in third_party. Bug: 1016158 Change-Id: I8a85e928c010ca65e04b5ebc4909a051b4312672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873236 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#708176}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/272295005 and https://critique.corp.google.com/#review/272429997. Change-Id: I40679092834078a9c44df5a5767de1d01134ab03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872220Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#708175}
-
Christian Dullweber authored
Change the flow from keeping the UI open to closing the bubble when a button is clicked. This is the typical behavior of most bubbles and doesn't lead to users accidentially reversing their previous action. Bug: 1016747 Change-Id: Ia9ad0f73ff02af8cab6f5a53b9385676b8ef9661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873746Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708174}
-
Olivier Li authored
This is ground work for experimenting with running ProfileSyncEngine's backend work on the ThreadPool. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. For the change that will enable the experiment please refer to: https://chromium-review.googlesource.com/c/chromium/src/+/1856922 Bug: 1014464 Change-Id: I60e8081eefe40c90fc258aa9ac0467f910ca3356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872410Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708173}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27f6d3d34924..4ec0e215bc4a Created with: gclient setdep -r src-internal@4ec0e215bc4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43f773fe979d734a501f511ab47f5f5dba0a6c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873595Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708172}
-
Clemens Arbesser authored
Bug: b/142864606 Change-Id: I9e21c4f42e55ae6c5cdd84621da73bc6bd6bf590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871555Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#708171}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85a10001a508..528a03441eac git log 85a10001a508..528a03441eac --date=short --no-merges --format='%ad %ae %s' 2019-10-22 saza@webrtc.org Fix fuzzer-found inconsistency in AEC3 config json parsing 2019-10-22 ilnik@webrtc.org VP9 decoder: replace DCHECK with error message 2019-10-22 nisse@webrtc.org Delete unused members of MediaReceiverInfo and MediaSenderInfo Created with: gclient setdep -r src/third_party/webrtc@528a03441eac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1016139,chromium:1016160 Change-Id: If0cf8eeb9ee754b7d982b2021c1b2b7e8ce28c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708170}
-
Vasiliy Telezhnikov authored
This CL adds HardwareRendererViz as part of implementation of 'Viz for WebView' path. HardwareRendererViz responsible for submitting root CompositorFrames. Bug: 805739 Change-Id: If5b57c39e3d625286248598f23aaa29a9ab55025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863136 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708169}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I28d12515eb518579f1cbf1b90b6ee61568314f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871903Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708168}
-
Francois Beaufort authored
This CL adds the data attribute to NDEFRecord as specified in https://github.com/w3c/web-nfc/pull/379 Bug: 520391 Change-Id: Icab2c69d6cec95540e6f8525354e86a6937aa4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871369Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#708167}
-
Vasiliy Telezhnikov authored
This CL extracts surfaces initialization from SurfacesInstance class to be later reused in HardwareRendererViz. Bug: 805739 Change-Id: Ic7cd344c4c250dfb2be08aaf1dc5acd5ad80fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868975 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708166}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e7968db31d4..c4191602bb51 git log 1e7968db31d4..c4191602bb51 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 khokhlov@google.com [tracing] Add HistogramSet.Merge method Created with: gclient setdep -r src/third_party/catapult@c4191602bb51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349 Change-Id: Ia0d28fade66a729de31ef9045b944e4539994bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708165}
-
Dominik Inführ authored
Add flag for promoting all live young objects during a Mark-Compact GC. Flag is disabled by default. Bug: chromium:1014943 Change-Id: Iaad05f0f99c87756230519c9be7e0ec9a59ca37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865331Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708164}
-
Mike West authored
We're defining the `gopher:` protocol only so that we can declare it as "standard" and assign it a default port. Since there's no actual support for the Gopher protocol in //net or //content (or //chrome (or anywhere else in the repository)), we can remove the definition with no practical effects. Hopefully, that makes evaluating Chrome's support for various protocols a little simpler to ascertain while skimming through code. This follows along with WebKit's change in https://bugs.webkit.org/show_bug.cgi?id=201852 and the related proposal in https://github.com/whatwg/url/issues/342. Change-Id: Ia18d862e574dcaea796041d27210cec235d97d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/612983 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708163}
-
Andreas Haas authored
We are removing external uses of ArrayBufferContents::DataHandle so that eventually we can remove the whole class and change the implementation of WTF::ArrayBuffers. This CL is an intermediate step on the way which replaces the external use of DataHandle to make a later refactoring of ArrayBufferContents easier. Bug: chromium:1008840 Change-Id: I9bcdee83e26eeccc7a8028c0bf3dd8fe9a455692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868993Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#708162}
-
Julian Pastarmov authored
Those fields are irrelevant for the user when local sync is turned on because no connection with a sync server can be established in this case. BUG=972563 Change-Id: I8dab3c48215b8c8fa05218d0df5e318923a849da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859974Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708161}
-
Andy Paicu authored
This is a reland of 55a4bb68 The original CL caused a crash (crbug.com/1016233) The first patchset is the original CL, unmodified. https://chromium-review.googlesource.com/c/chromium/src/+/1860015 introduced a crash because InfoBarService::RemoveInfoBar DCHECKS that the infobar is part of the owned list of infobars. When the tab is closed, the infobar is removed but then the PermissionPromptAndroid object destructor attempts to remove it again. This CL ensures that that this situation does not happen by listening for the infobar remove event and ensuring we don't try to remove the infobar that was already removed. Original change's description: > Kill quiet permission requests if a new request is made > > Bug: 1014026 > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706445} Bug: 1014026, 1016233 Change-Id: Iaa857811c6617afd97af9708a51ea49ea98fe385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871698 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708160}
-
Manu Cornet authored
That CL had removed the line that is being re-added here, causing the |home_launcher_animation_state_| field to never get updated. TBR=newcomer@chromium.org Bug: 1006013, 1012353, 1013737, 1015995, 1012760 Change-Id: I489a4df984b2221b299a2bc31692b2ce38b9730a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873725Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708159}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74d521f2..704ce5c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13d420c6ff5caa01d2df93375459cadecb621b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b9014fb4bb68..85a10001a508 git log b9014fb4bb68..85a10001a508 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 danilchap@webrtc.org Use deprecated SingleThreadedTaskQueueForTesting as regular task queue Created with: gclient setdep -r src/third_party/webrtc@85a10001a508 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id24d86e7932540276a21e661097134cec758196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708157}
-
Peter Kasting authored
Bug: 82078 Change-Id: I83c992a0c9eaaf1130ace3892cc38dbfeb266214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872983 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708156}
-
Leo Zhang authored
Add the IME decoder flag in the chrome://flags, so that QA/Dev can turn on/off the feature to verify native deocers. Bug: 837156 Change-Id: I6ace99acf2127958ec4f0868962c721c035fd06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866370 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca28b0ef0037..e3dcc758ca56 git log ca28b0ef0037..e3dcc758ca56 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 dburger@chromium.org Change controller_util and goma_util to handle custom goma approach. Created with: gclient setdep -r src/third_party/chromite@e3dcc758ca56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I00260f81a2e7489aad99e0ff600cbe0cd3f2ee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708154}
-
Mihai Sardarescu authored
This CL ensures that the OAuth multi-login endpoint is always used by the Mirror account reconcilor. The feature |kUseMultiloginEndpoint| is removed from ChromeOS, Android and iOS and is now moved to DiceAccountReconcilorDelegate. Bug: 1013610 Change-Id: I02299b15225e1666d5160bac2ef25d767c3d01c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859966 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708153}
-
Jan Wilken Dörrie authored
This change replaces existing usages of mutable base::Value::GetList() with newly introduced ListValue APIs in //components/autofill and //components/password_manager. Bug: 646113 Change-Id: I0b0bea5d341951585698ad7438a43be459198c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872212Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#708152}
-