- 04 Jan, 2019 25 commits
-
-
Devlin Cronin authored
Do the following clean-ups in the webstore installer classes and its callers: - Convert base::Callback to base::RepeatingCallback/base::OnceCallback - Convert base::Bind to base::BindRepeating/base::BindOnce - Pass callbacks by value when an instance is retained Bug: 714018 Change-Id: Ia55a04264ac528625c3f8664fd30607036945c24 Reviewed-on: https://chromium-review.googlesource.com/c/1391867Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619844}
-
Hector Carmona authored
Also fix some const references surfaced by presubmit. Bug: 912026 Change-Id: I2661f69f0e63e613a9b8e9d565813c3e27fed340 Reviewed-on: https://chromium-review.googlesource.com/c/1377494Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#619843}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ad409510d23..936a99460834 git log 4ad409510d23..936a99460834 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@936a99460834 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idd2757e1ac83a7430b399e2952a9e70e0e2c8202 Reviewed-on: https://chromium-review.googlesource.com/c/1395157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619842}
-
Xu Xing authored
Bug: 894806 Change-Id: Id76b1a229b9583e7d7304b4f5262e2b8d9bbbbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1388020 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#619841}
-
Stephen Barber authored
The image server URL should have a %d in it, to be replaced with the Chrome OS milestone at runtime. BUG=chromium:918970 TEST=set up crostini; check that container has wget preinstalled Change-Id: I3cdfce9ea1b80e704719da05449734c82d2b7dc9 Reviewed-on: https://chromium-review.googlesource.com/c/1395025Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> Cr-Commit-Position: refs/heads/master@{#619840}
-
David Bertoni authored
LazyEventDispatcher no longer distinguishes between background page and service worker tasks. Bug: 915814 Change-Id: I9346b1d97c7df7080dbac67e28cbb7ceaa919b06 Reviewed-on: https://chromium-review.googlesource.com/c/1391475 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619839}
-
Miguel Casas authored
This CL extends VaapiVideoDecodeAcceleratorTest to use the flag |decode_using_client_picture_buffers| as test parameter, and teaches it what to do when it's true (on ToT is always false). Test: bots chromeos-amd64-generic-rel linux-chromeos-rel run the new cases. Bug: 875005 Change-Id: Id0d500d4f27e273037a80c2e0507d906690ac98d Reviewed-on: https://chromium-review.googlesource.com/c/1394946Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#619838}
-
Dmitry Gozman authored
We currently parse content type header to extract boundary in WebURLLoaderImpl, while we can do so lazily in ImageResource. The rest of multipart image processing has been already moved to Blink. Bug: none Change-Id: Ic00bb08f2cb0148ae3425135451a403ef755f964 Reviewed-on: https://chromium-review.googlesource.com/c/1394185Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619837}
-
Gabriel Marin authored
Move additional logic to the base class MetricCollector for reuse between different collector implementations, e.g. writing outcomes to UMA histograms, removal of unknown fields from protos, saving profiles to the local cache. This change enables making two additional fields private. Moved tests for discarding unknown fields and for saving perf data and perf stat protos, to the metric collector unit tests. BUG=b:110205489 TEST=Unit tests pass Change-Id: I8877e9abc6ee8d89e6be391063d3ddf7ba231bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1392352Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#619836}
-
Devlin Cronin authored
Do the following clean-ups in some miscellaneous installation utility classes/files in extensions code: - Convert base::Callback to base::RepeatingCallback/base::OnceCallback - Convert base::Bind to base::BindRepeating/base::BindOnce - Pass callbacks by value when an instance is retained Bug: 714018 Change-Id: Ia58a8467b6956bdf2bd15557d51f312e9cc0a4cc Reviewed-on: https://chromium-review.googlesource.com/c/1391866 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
John Williams authored
Forked from https://chromium-review.googlesource.com/c/chromium/src/+/1178225 This patch introduces CastSessionTracker, which is a singleton that listens for RECEIVER_STATUS messages and keeps track of CastSession object for each Cast MediaSink. It also exposes an Observer interface for CastActivityManagers to listen for session changes in order to update MediaRoutes. Also, added logic to terminate existing session (if any) when trying to launch a new session. Refactored launch parameters into a struct to keep the number of input params down. Bug: 809249 Change-Id: Ieb38e26d7b8191390f2fea5a8c41ea8955cbc352 Reviewed-on: https://chromium-review.googlesource.com/c/1297299 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#619834}
-
Sky Malice authored
Bug: 908963 Change-Id: Ie43aa837502e7dcb15df0a69d628fdb92bf8fa77 Reviewed-on: https://chromium-review.googlesource.com/c/1394950Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619833}
-
Kyle Horimoto authored
This metric measures the boolean success/failure result of the app uninstallation. Bug: 917855 Change-Id: Iad12046f28b647cf58cb6f22aa6862ff086204ef Reviewed-on: https://chromium-review.googlesource.com/c/1392011Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
-
Nasko Oskov authored
As of https://crrev.com/617708 the expectation is that all renderer initiated navigations must specify the origin of the document that started the navigation. This CL adds support for initiator origin in headless code. Bug: 882053 Change-Id: I67dfff88932174f8098f4349412c37fac6e54381 Reviewed-on: https://chromium-review.googlesource.com/c/1395064Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619831}
-
Marzena Dell'Aquila authored
Removing cast.__platform__.vidoePlane bindings. This reverts commit 1f4c1220 Bug: internal b/119639315 Test: CQ Change-Id: I188445d84b02b120408f357280d84311810b777c Reviewed-on: https://chromium-review.googlesource.com/c/1387729Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Marzena Dell'Aquila <mdellaquila@google.com> Cr-Commit-Position: refs/heads/master@{#619830}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f83a28a6880a..225f08bf85a3 git log f83a28a6880a..225f08bf85a3 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jmadill@chromium.org Cleanups to StripArrayIndices. 2019-01-03 jmadill@chromium.org Add WGLWindow and WGL test configs. 2019-01-03 jmadill@chromium.org Refactor BlockLayoutEncoder APIs for std430. Created with: gclient setdep -r src/third_party/angle@225f08bf85a3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I269d31b1eddb2e2de7a7049b357b1b4c29c26461 Reviewed-on: https://chromium-review.googlesource.com/c/1394999Reviewed-by:
-
Nate Fischer authored
No change to logic, only a docs update. This updates supported-projects.md to reflect WebView's most recent feature support, and points out where WebView differs from Chrome. * We've supported CLI flags ~forever. These are useful for local debugging, even if they can't be used on production devices. This links to upstream docs. * Finch support launched this year. It still has some caveats, which are described by the linked internal documentation. * Per an offline discussion with rsleevi@, WebView has enterprise policy support, although this is poorly documented. * We've supported UMA for over a year. This links to internal documentation describing caveats. R=rsleevi@chromium.org Test: None Change-Id: I088880eb9c5bf78e8c8f9574f62b8acac94073bf Reviewed-on: https://chromium-review.googlesource.com/c/1392255Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619828}
-
Michael Warres authored
Merge internal change: 223386522 R=zhongyi@chromium.org Change-Id: Iad4ddf1eb5b18e6e48730ccafd0aad3e595c60d2 Reviewed-on: https://chromium-review.googlesource.com/c/1394428 Commit-Queue: Michael Warres <mpw@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619827}
-
Eric Roman authored
The reason they failed was they rely on the following behaviors from "content_shell --run-web-tests": (1) Sending reports is allowed for all origins, irrespective of the BACKGROUND_SYNC permission. (2) The timeout for sending reports is 100ms instead of the default (1 minute) This CL makes "content_shell --run-web-tests" with Network Service enabled behave the same way. Bug: 910212 Change-Id: I0756a9605b2aa37647d2c049eb2868499f07e65e Reviewed-on: https://chromium-review.googlesource.com/c/1387449 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619826}
-
Matthew Mourgos authored
- Add drop shadow with elevation 12px using BubbleBorder; - Change background of search box to always be white (#FFF); - Change rounded corners to 20px; Bug: 876091 Change-Id: Ic028bd5146a6618d03265929d12c82d74724e4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1389120Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619825}
-
Ted Choc authored
BUG=876369 Change-Id: I72d0a94273381ee22cc095d17ab9da27d41f2e9f Reviewed-on: https://chromium-review.googlesource.com/c/1394931Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619824}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/86c48a10110c..ebf0d23ee62e git log 86c48a10110c..ebf0d23ee62e --date=short --no-merges --format='%ad %ae %s' 2019-01-03 bsheedy@chromium.org Add gtest perf test conversion script Created with: gclient setdep -r src/third_party/catapult@ebf0d23ee62e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843643 TBR=sullivan@chromium.org Change-Id: Iddb0acdf73020d462a3a04654b01472bc24a4daf Reviewed-on: https://chromium-review.googlesource.com/c/1395000Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8b0f9d18ddf8..5820b0c3f3ce git log 8b0f9d18ddf8..5820b0c3f3ce --date=short --no-merges --format='%ad %ae %s' 2019-01-03 michaelludwig@google.com Use specialized quad lists in rectangle ops 2019-01-03 reed@google.com change textutils to require font param 2019-01-03 kjlubick@google.com [canvaskit] Refactor skottie into own file 2019-01-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-03 robertphillips@google.com Make the RRectEffect's screen coords be Float4 (rather than Half4) 2019-01-03 michaelludwig@google.com Normalize vectors in dot product for quad type calculations. 2019-01-03 halcanary@google.com SkPDF: eliminalte one member function 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4627b3705d59..9fa54eab2590 (1 commits) 2019-01-03 reed@google.com use drawSimpleText 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e9b211dd665b..8b9d1f9db8a8 (1 commits) 2019-01-03 reed@google.com remove legacy drawPosText (and variants) Created with: gclient setdep -r src/third_party/skia@5820b0c3f3ce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:915025,chromium:917242,chromium:b/122105577 TBR=bungeman@chromium.org Change-Id: I6d8fd6fb28bbee8eb2eca4dc1e3118139b57ae65 Reviewed-on: https://chromium-review.googlesource.com/c/1394922Reviewed-by:
-
Matthew Jones authored
Bug: Change-Id: Ie49fde45c2efc4c70fbfa8e99841541064e7540d Reviewed-on: https://chromium-review.googlesource.com/c/1395158Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619821}
-
Bruce Dawson authored
The recently added timer performance test for __rdtsc fails to compile on ARM64, for obvious reasons. This change fixes the test to use the ARM64 cycle counter when building for that platform. The ReadCycleCounter definition was copied from base\time\time_win.cc Bug: 893460 Change-Id: I0d891c5a197e097084a765ab66e9da1b4173b418 Reviewed-on: https://chromium-review.googlesource.com/c/1394987Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#619820}
-
- 03 Jan, 2019 15 commits
-
-
Chris Harrelson authored
Bug: 918848 Change-Id: I1b712a3aee6f8950160886141065e1b0a3799c34 Reviewed-on: https://chromium-review.googlesource.com/c/1394873 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#619819}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5f346a1b0b4..c48496fe54a9 git log b5f346a1b0b4..c48496fe54a9 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jclinton@chromium.org cbuildbot/manifest_version.py: Use Gerrit autosubmit feature throughout Created with: gclient setdep -r src/third_party/chromite@c48496fe54a9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5620619fb1301138d4ad1c23725ab15725756d0d Reviewed-on: https://chromium-review.googlesource.com/c/1394992Reviewed-by:
-
Karan Bhatia authored
This CL moves handling of the "sandbox.content_security_policy" to the CSPHandler from SandboxedPageHandler. This should have no behavior change. This is in preparation of introducing the "content_security_policy.sandbox" manifest key. BUG=914224 Change-Id: I27e839a09211d7fccc0104e6195d6c123cca8ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1391877 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 889106 Change-Id: I7c5fa213d3ca323b495d1e785605e9e1f1b6f986 Reviewed-on: https://chromium-review.googlesource.com/c/1385482Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619816}
-
Varun Khaneja authored
PVer4 rolled out in M57. I had added code to delete PVer3's files from disk along with a comment saying: // This method can be removed after the UMA metrics for the following prefix // go down to 0 in Stable: "SafeBrowsing.V4UnusedStoreFileExists.V3." Well [1][2] shows that this metric is down to 0 for all stores now. [1]: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=6ebed968120f27fb42f41b6a21afb541 [2]: http://screen/NWvJt0wwNjv R=drubery Bug: 916192 Change-Id: I504c51c32a1247aa3375c13c902ec12612c46429 Reviewed-on: https://chromium-review.googlesource.com/c/1382896 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#619815}
-
Christian Fremerey authored
As per report at crbug.com/910044 Bug: 910044 Change-Id: I43b4467710b44cb9a6c2b755e23512d7b7318479 Reviewed-on: https://chromium-review.googlesource.com/c/1394398 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#619814}
-
Robert Ogden authored
Adds UKM metrics about the Lite Page Redirect preview including a bool if it was committed and what navigation restart penalty it incurred. Bug: 917491 Change-Id: I6db29a49b2ec8d0ac8127209dcf2a5925d325f7a Reviewed-on: https://chromium-review.googlesource.com/c/1394792Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Split the Cocoa-facing parts of JavaScriptAppModalDialogCocoa into a separate views_bridge_mac::AlertBridge class, implementing a mojo interface of the same name. The mojo interface has a single method, Show, which has a single callback, indicating the disposition of the alert. Make JavaScriptAppModalDialogCocoa instantiate views_bridge_mac::AlertBridge across mojo either in-process or out-of-process as needed. Note that this subtly changes the behavior of JavaScriptAppModalDialogCocoa::AcceptAppModalDialog in that it will no longer attempt to read the dialog's text when programmatically quitting (note that this feature may be dead code). This makes alerts appear in the appropriate process. Note that the alerts of PWAs and of Chrome are still interconnected. Only one alert may be present at once, and an active alert will take focus from Chrome and all PWAs. Bug: 898604 Change-Id: I37267cf7aa41d8e68cb2d342a5058e257b2d4385 Reviewed-on: https://chromium-review.googlesource.com/c/1390757Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#619812}
-
Daniel Rubery authored
We still intend to use these histograms for analysis. Looks like I was a little too ambitious with how long it would take to be done with these. Bug: 915890 Change-Id: Iebbd33fb9bc7fc0df698abe431e9dde7e45f190b Reviewed-on: https://chromium-review.googlesource.com/c/1393891Reviewed-by:
-
Nasko Oskov authored
IsBrowserSideNavigationEnabled() is now always returning true, causing this test to be disabled. It does pass now, so we can potentially enable it if it is still valid. Bug: 789577 Change-Id: I85438a626b6b764c4ad07e6e74d7cb08c8adad4a Reviewed-on: https://chromium-review.googlesource.com/c/1394932Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619810}
-
chrome://settings/deviceJohn Lee authored
Change-Id: Ia467b55e2e56df946dfd7a0268c3bc1ccad2f291 Reviewed-on: https://chromium-review.googlesource.com/c/1391719Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#619809}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74ec15010f8a..0b364067d04c git log 74ec15010f8a..0b364067d04c --date=short --no-merges --format='%ad %ae %s' 2019-01-03 cwallez@chromium.org MetalBackend.h: Remove dead declarations Created with: gclient setdep -r src/third_party/dawn@0b364067d04c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4f2dcf9fd64daa5cacd7d0642e4b5e4004f5df96 Reviewed-on: https://chromium-review.googlesource.com/c/1394826Reviewed-by:
-
Karan Bhatia authored
This CL changes CSPHandler so that it can be used for both extensions and platform apps without creating a different instance for the two. This helps simplify the code. BUG=914224 Change-Id: Ib99fd306071514706d6a3a6b032870f016736a9e Reviewed-on: https://chromium-review.googlesource.com/c/1394912Reviewed-by:
-
Zhongyi Shi authored
When QuicSession::ClosePendingStream, before remove the pending stream from the pending_stream_map_, QuicSession::SendRstStream is invoked to send a reset acknowledgement to the peer. In Chromium, QuicChromiumClientSession overrides SendRstStream method, and calls into GetOrCreateDynamicStreamImpl() to close the pending stream as well as remove from pending_stream_map_. QuicSession holding the already deleted iterator will attempt to remove the entry again. This change adds iterator check right before removing the entry to avoid use after free issue. Bug: 918849, 918890 Change-Id: I27b7a4433d6783e4484a5dcb49446d89e997b8bf Reviewed-on: https://chromium-review.googlesource.com/c/1394920 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#619806}
-
Marzena Dell'Aquila authored
This reverts commit 0cf17084 Bug: internal b/119639315 Test: CQ Change-Id: Ibbd4e8469895299f938549bb146641504643d3f3 Reviewed-on: https://chromium-review.googlesource.com/c/1387464Reviewed-by:
-
