GitLab

Previously WTF::bind() returns |Function|, but this causes implicit temporary objects and copies of |Function|, resulting potential thread-safe issues.
This CL changes the return type of WTF::bind() to |OwnPtr<Function>|, thus removing such temporary objects and making the ownership of |Function| explicit.

- Change the return type of WTF::bind().
- Replace |const Function&| in parameter with |PassOwnPtr<Function>|.
- Replace |Function| with |OwnPtr<Function>|.
- Add |.release()| and replace |f()| with |(*f)()|.
- Other types of changes are in |callOnMainThread| and NetworkStateNotifierTest.cpp.
(|Function| appears in typedef'ed names such as Closure.)

Also this CL makes |FunctionBase| non-copyable to prevent unintended copies of |Function|.

BUG=390851

Review URL: https://codereview.chromium.org/705003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix a problem where a control's willValidate change wouldn't trigger the containing form's or fieldset's style change. Cache form validity while at it to avoid style recalculation

BUG=360466
TEST=Added cases to layout tests that toggle controls disabled and readonly in form and fieldset

Review URL: https://codereview.chromium.org/703473003

git-svn-id: svn://svn.chromium.org/blink/trunk@185347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes SVGAnimatedProperty and its subclasses inherit from ScriptWrappable.
This change increases the size of SVGAnimatedProperty and its subclasses
by 8 bytes (on 64-bit env).

BUG=235436

Review URL: https://codereview.chromium.org/720113003

git-svn-id: svn://svn.chromium.org/blink/trunk@185346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=433146
TBR=bokan@chromium.org, senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/723413002

git-svn-id: svn://svn.chromium.org/blink/trunk@185345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have three specialized getWithUndefinedOrNullCheck(), but we don't
need them, as DictionaryHelper::getWithUndefinedOrNullCheck() template
does the job.

Review URL: https://codereview.chromium.org/725023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This unintuitively caused drags to end immediately if a page called
setDragImage with a detached node or one that hadn't been through layout
yet. There's nothing in the spec that says the drags should abort in
this case either, so this makes Blink more spec-conformant.

BUG=413795

Review URL: https://codereview.chromium.org/724663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/719253002, Skia disables LCD text
for non-opaque save-layers automatically.

Also remove a couple of single-use getters.

R=reed@google.com,jbroman@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/724063004

git-svn-id: svn://svn.chromium.org/blink/trunk@185342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates the clip recorder and clip items to track a
RenderLayerModelObject (a subclass of RenderObject) so invalidations
are properly handled in the update algorithm just like regular
DisplayItems. Clipper callsites have been updated accordingly.

With this patch, the ASSERT in ViewDisplayList::findDisplayItem can
now be removed.

TEST=ViewDisplayListTest_UpdateClip

Review URL: https://codereview.chromium.org/719353004

git-svn-id: svn://svn.chromium.org/blink/trunk@185341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The error message should explain what types are expected.

BUG=240176

Review URL: https://codereview.chromium.org/726793002

git-svn-id: svn://svn.chromium.org/blink/trunk@185340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=inspector/layers/layer-canvas-log.html

BUG=430557
TBR=senorblanco@chromium.org, caseq@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/727663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Flakyness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/dom/Geolocation/error-clear-watch.html

BUG=373430
TBR=mvanouwerkerk@chromium.org, senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/722383002

git-svn-id: svn://svn.chromium.org/blink/trunk@185338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EventHandler maintains a ton of state, and making sure everything is in
sync gets rather complicated. m_didStartDrag was only used as by gesture
code, to detect if it should fall back to default handling.

This patch changes handleDrag()'s CheckDragHysteresis parameter to
DragIniator, which more accurately reflects how it's used. The updated
parameter is also used to determine when default handling is needed,
eliminating the need for the m_didStartDrag bool. Yay!

BUG=none

Review URL: https://codereview.chromium.org/720693003

git-svn-id: svn://svn.chromium.org/blink/trunk@185337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536

Review URL: https://codereview.chromium.org/723943002

git-svn-id: svn://svn.chromium.org/blink/trunk@185336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because this build time flag is only used for debugging purpose,
rename it to DEBUG_TEXT_AUTOSIZING_ON_DESKTOP.

Review URL: https://codereview.chromium.org/720203002

git-svn-id: svn://svn.chromium.org/blink/trunk@185335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions

================

Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch.

Here are the 5 steps:
1. Chrome side - save the data (https://codereview.chromium.org/652283002/).
2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (https://codereview.chromium.org/654953002/).
3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/).
4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData (this CL).
5. Chrome side - remove redundent implmentations of the old APIs (https://codereview.chromium.org/728653003/).

BUG=370696

Review URL: https://codereview.chromium.org/721973002

git-svn-id: svn://svn.chromium.org/blink/trunk@185334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Animations are shown for the selected element making it difficult to
find and navigate between animations. This change introduces a persisted
checkbox setting to show all animations for the selected node's DOM tree.
When hovering on an animation section title the animating element on the
page is now highlighted. Clicking on the title to expand/collapse an
animation section is also enabled. The subtree setting is turned on by
default. This change is behind the Animation Inspection experiment.

BUG=419269

Review URL: https://codereview.chromium.org/682423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added new entry to the Blink.MediaElement.Autoplay histogram to account for cases where autoplay is reenabled on a Media element by a user-gesture triggered script

R=qinmin,adamk
BUG=432734

Review URL: https://codereview.chromium.org/719413002

git-svn-id: svn://svn.chromium.org/blink/trunk@185332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(WebIDL's "long" is a 32-bit type)

BUG=267360

Review URL: https://codereview.chromium.org/716323002

git-svn-id: svn://svn.chromium.org/blink/trunk@185331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I guess we're all so used to looking at Chromium's
base::Callback::Run() that no-one noticed. Oops!

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/724953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/724483002

git-svn-id: svn://svn.chromium.org/blink/trunk@185329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes a bug when hiding and showing transition elements and adds the test for it.

BUG=370696

Review URL: https://codereview.chromium.org/723073003

git-svn-id: svn://svn.chromium.org/blink/trunk@185328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185307

BUG=407416
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/718373003

git-svn-id: svn://svn.chromium.org/blink/trunk@185327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch implements the showNotification() method by extending the
ServiceWorkerRegistration object, and calling through to the Platform
for requesting display of a persistent notification.

BUG=432527

Review URL: https://codereview.chromium.org/717273002

git-svn-id: svn://svn.chromium.org/blink/trunk@185326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, LayerPainter would try to avoid starting a transparency layer
until it encountered actual drawable content within the RenderLayer that has transparency, or its child.

This optimization makes for code complexity and speed issues, makes it hard to
implement clean display lists, and is most likely not a useful optimization.
It is likely not useful for two reasons:

* It only has effect if the webpage has opacity but no actual content. That does not seem common.
* Skia already has optimizations to remove unnecessary layers if there is no content within them:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/src/core/SkRecordOpts.cpp&q=SkRecordNoopSaveRestores&sq=package:chromium&type=cs&l=21

BUG=432755

Review URL: https://codereview.chromium.org/725433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per SW spec issue:
https://github.com/slightlyoff/ServiceWorker/issues/550

Cache.put() should throw if request/response bodies
are already used, and consume request body (if non-empty)
and response body.

BUG=430962

Review URL: https://codereview.chromium.org/708703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PHP 5.4.0 and newer implement hex2bin natively. Since PHP versions
aren't uniform across platforms, just prefix it and hope it doesn't
collide with another function in the future.

BUG=none

Review URL: https://codereview.chromium.org/724863003

git-svn-id: svn://svn.chromium.org/blink/trunk@185322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame's size is no longer simply the viewport size. Instead,
WebViewImpl sizes it after layout to be the either the content width with
a height matching the viewport aspect ratio, or the viewport at minimum page
scale. This fixes a bug where the innerWidth/innerHeight values would be
wrong during an onload event if the onload would happen before the content was
properly sized.

BUG=431097,428722

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185145

Review URL: https://codereview.chromium.org/705423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the second patch in the series to migrate
to LayoutUnits in all InlineBox classes.

BUG=321237

Review URL: https://codereview.chromium.org/699683002

git-svn-id: svn://svn.chromium.org/blink/trunk@185320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#ecdsa

This changelist
 * Defines a new key type for EC keys
 * Implements structured clone for EC keys
 * Adds algorithm parameter parsing for WebCrypto's EcdsaParams, EcKeyGenParams and EcKeyImportParams

This change does not include any LayoutTests, as the tests depend on the Chromium side landing first.

The LayoutTests are part of: https://codereview.chromium.org/707753002/ and will be landed last.

BUG=399094

Review URL: https://codereview.chromium.org/707743002

git-svn-id: svn://svn.chromium.org/blink/trunk@185319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert "Only allow background tabs if the underlying input event allows it" (patchset #1 id:1 of https://codereview.chromium.org/721793002/)

Reason for revert:
Removed failing browser test

Original issue's description:
> Revert "Only allow background tabs if the underlying input event allows it"
> 
> This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205.
> 
> Speculative revert to green up browser_tests:
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab
> 
> TBR=jochen@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185220

TBR=senorblanco@chromium.org
BUG=

Review URL: https://codereview.chromium.org/720283002

git-svn-id: svn://svn.chromium.org/blink/trunk@185318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431697

Review URL: https://codereview.chromium.org/725583003

git-svn-id: svn://svn.chromium.org/blink/trunk@185317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=426520

Review URL: https://codereview.chromium.org/715863004

git-svn-id: svn://svn.chromium.org/blink/trunk@185316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(WebIDL's "unsigned long" is a 32-bit type)

BUG=267360

Review URL: https://codereview.chromium.org/717413002

git-svn-id: svn://svn.chromium.org/blink/trunk@185315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit dd138e54138a00f80fa1547bb3b4922aa02ad335, aka r185305.

Speculative revert to fix Android AOSP build breakage: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/33131/steps/compile/logs/stdio.

TBR=yangguo,jochen@chromium.org,vogelheim
BUG=

Review URL: https://codereview.chromium.org/721373002

git-svn-id: svn://svn.chromium.org/blink/trunk@185314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces the notificationclick and notificationerror
events on the ServiceWorkerGlobalScope, and provides the necessary
plumbing to be able to invoke them from the embedder.

BUG=432527

Review URL: https://codereview.chromium.org/720873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trailing optional Dictionary are automagically handled by bindings,
with a new empty dictionary passed in if the argument is not
specified by script. Overloads are not needed in this case.

BUG=373120

Review URL: https://codereview.chromium.org/717283002

git-svn-id: svn://svn.chromium.org/blink/trunk@185312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Count decoded frames in ImageFrameGenerator, and remove remove multi-frame image decoders when the image is completely decoded

This saves memory on pages with a lot of multi-frame images. data and discussion please see https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KZ8EDtEZ9-c

BUG=429614

Review URL: https://codereview.chromium.org/688423004

git-svn-id: svn://svn.chromium.org/blink/trunk@185311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The plugin might attempt to call invalidateRect while it is being
destroyed, in which case its renderer could be NULL.

BUG=432045

Review URL: https://codereview.chromium.org/723733002

git-svn-id: svn://svn.chromium.org/blink/trunk@185308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The class was misguided and only needed because
we generated the invalidations using this code
path before https://codereview.chromium.org/665673004

BUG=407416

Review URL: https://codereview.chromium.org/696703005

git-svn-id: svn://svn.chromium.org/blink/trunk@185307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/722683003

git-svn-id: svn://svn.chromium.org/blink/trunk@185306 bbb929c8-8fbe-4397-9dbb-9b2b20218538