- 09 Apr, 2020 40 commits
-
-
Matt Menke authored
Previous, when fetching the URL itself, that URL was used to compute the NetworkIsolationKey, but for subresources, the initiator's origin was used to set the NetworkIsolationKey. This was incorrect, and results in SameSite cookies being leaked across NIKs, since they're sent with SameSite fetches make by the shared worker. Since cross-site SharedWorker aren't supported, this only affected SharedWorker created by extensions. Bug: 1067744 Change-Id: I3119b605c7918339a2094eab31dad27c2e1267fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138211 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#757890}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5c883d3c18db..6480643d669a git log 5c883d3c18db..6480643d669a --date=short --first-parent --format='%ad %ae %s' 2020-04-09 bclayton@google.com Vulkan/Debug: Fix clang-10 warning 2020-04-09 bclayton@google.com third_party/cppdap: Roll forward to 4dcca577 Created with: gclient setdep -r src/third_party/swiftshader@6480643d669a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie8f4fda662bd6a34b76399b11c78d2e520353b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757889}
-
Gauthier Ambard authored
This test makes sure that when the default search engine is changed, it is reflected in the URL used when the user is typing a word in the omnibox. Fixed: 910333 Change-Id: I948330807d5a9d40e5d36b698934c55bad3c60c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139693 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#757888}
-
Peter Kasting authored
Bug: none Change-Id: Iad1d006fb42d98a583449ff3f4b659fee2fbdf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143674 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757887}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I86ed66b8f8ff332ba4b3f063d4f383953f86733b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140200 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757886}
-
Jesse McKenna authored
This change moves SystemSessionAnalyzer to its own subdirectory and adds the Chrome Windows team as owners. SystemSessionAnalyzer queries Windows' logged events, and is used by StabilityMetricsProvider to determine whether an unclean shutdown of the browser process was caused by system instability (rather than Chrome instability). Because this file is only tangentially related to the metrics service in components/metrics, it makes sense for it to be owned by the Windows team rather than the broader metrics team. Change-Id: I61f2ed168db418b6368051f41aea19d3912b25be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142135Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#757885}
-
Caitlin Fischer authored
(Another CL for non-UKM-related duplicate code forthcoming. I wanted to keep the CL sizes reasonable.) Bug: 1066297 Change-Id: I699d3e72ff69c3844b1f6838bd1b329d2804bcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135826 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#757884}
-
Peter Kasting authored
A bunch of miscellaneous changes that reduce duplication, etc. Bug: none Change-Id: I1dc017879f3923a12ab89396b069652a0d98c2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143673 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757883}
-
Peter Kasting authored
Add registration for all factories which request service creation at context creation time. Bug: none Change-Id: I865b1090855500877ac21d9fda2e0fb7cff39e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133655 Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#757882}
-
Brian Sheedy authored
Adds the following optimizations related to Skia Gold in LocalInstrumentationTestRun: 1. Uses a single working directory for Gold across all tests, which allows goldctl to re-use the downloaded expectations across all tests. 2. Pulls all the files off the device and works with them locally instead of checking for their existence and pulling them individually. Bug: 1057846 Change-Id: I58c67afedd4b0169d97a6b64a96a64e069383cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141249 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757881}
-
Peter Kasting authored
This provides a customization point for subclasses to override, to change the Widget subclass that's instantiated by CreateTestWidget(). This will be necessary to remove DefaultThemeProvider, because ChromeViewsTestBase will need to provide widgets with a non-null ThemeProvider at that point, and subclassing Widget is the only way to do so. Bug: none Change-Id: I9057301e2a86449832e036ce943d595e56954e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143518 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757880}
-
David Bertoni authored
I tested 3000 iterations of the ExtensionTabsTest.GetAllWindowsAllTypes and it was only flaky on Windows: linux-rel: 0/3000 linux-chromeos-rel: 0/3000 win10_chromium_x64_rel_ng: 6/3000 Bug: 1035620 Change-Id: Ia25c0a0e14c4b2c38d5443a45f23f3e38fcff819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142333Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757879}
-
Garrett Beaty authored
Update the console sorting to allow for a category entry in the console ordering dict to alias another entry. Bug: 1067057 Change-Id: I479871bae1ab8e9476db5c1bd0178acd6c74a5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139435 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757878}
-
Peter Kasting authored
The "widget owns native widget" tests were split into two sections. Group them together and make the naming consistent. Bug: none Change-Id: Ic956623b5a7d1db7e81b42e10d17baddf7777932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143672 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757877}
-
Hailey Wang authored
Added memory constraint, maximum restored tab threshold and a minimum restored tab threshold. Bug: 1059341 Change-Id: Iba6200b7f706ee74917b0bc2c0428ec5ec5dbc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130427 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#757876}
-
Ayu Ishii authored
Change-Id: Id9ab078652ae626170b51fb5e6697808de67f34a Bug: 1068395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141114Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#757875}
-
Matt Menke authored
There have been a number of changes since the document was last updated. Also clarify a few things. This CL covers through checking the cache. I'll continue updating other sections once this lands. Bug: None Change-Id: I5b205f81fb42c4d2727515fbc5d10f49d0b7736b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141138 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#757874}
-
Andrew Xu authored
The root reason is: when calculating the edge padding for display centering strategy, RTL was not taken into consideration. It was not noticeable before since under display centering strategy, |before_padding| and |after_padding| are the same or only differ by one DIP. This issue is exposed by hotseat bounds animation because: when the layout strategy changes from display centering to another due to the varying hotseat bounds during animation, the dramatic change in |before_padding| (note that calculation for other strategies under RTL is correct) causes the janky animation issue. This CL fixes the issue by calculating the edge paddings for hotseat under display centering strategy correctly. In addition, remove the obsolete comment in scrollable_shelf_view.h. Bug: 1069241 Change-Id: I62b2483c57803bc67a3cbfeac360426db005246e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142771Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757873}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eb17dbb23599..a5c914b63a0c git log eb17dbb23599..a5c914b63a0c --date=short --first-parent --format='%ad %ae %s' 2020-04-09 morg@google.com Add arm (32) artifacts to RVC build targets 2020-04-09 bmgordon@chromium.org usergroup_baseline: Add saned to ippusb group 2020-04-09 lamontjones@chromium.org api: update python bindings. 2020-04-09 cjmcdonald@chromium.org run_tests: Move tests that fail outside the chroot to inside-only 2020-04-08 manojgupta@google.com cbuildbot: fuzzer: Sync chrome source 2020-04-08 saklein@chromium.org flash-ap: Use standardized config names. 2020-04-08 saklein@chromium.org flash-ap: Standardize deploy config variable names. 2020-04-08 cjmcdonald@chromium.org run_tests: Change top-level wrapper to split test execution Created with: gclient setdep -r src/third_party/chromite@a5c914b63a0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ia61682cf7b29faca8d0fbe141cc018a954ab93d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757872}
-
Steven Bingler authored
Provide a function for consumers of the class to use to retrieve a context value when they need to determine a cookie's inclusion status. While this currently has no meaningful difference between accessing the context member directly it will be helpful when the schemeful context member is added so that callers will be returned the correct value depending on the state of the schemeful same-site feature. This CL also makes the member variables private. Bug: 1030938 Change-Id: I29e30ab1266d1f8195483ae9fbe8e4e63b62e2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140032Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#757871}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ebb5c85ab932..10b9675c807b git log ebb5c85ab932..10b9675c807b --date=short --first-parent --format='%ad %ae %s' 2020-04-09 jacktfranklin@chromium.org Strip line breaks when copying into TextPrompt 2020-04-09 alexrudenko@chromium.org Determine whether request params should be decoded by default 2020-04-09 jacktfranklin@chromium.org Fix poor contrasts in dark mode in computed styles view 2020-04-09 tvanderlippe@chromium.org Use CSSMetadata URL regex in StylePropertyTreeElement.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@10b9675c807b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066415 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I823b230604e9c129e2d06aad27f4b6f226258006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144379Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757870}
-
Vladimir Levin authored
This patch eliminates an unintentional re-entrant call to create a scoped force update object in Element::focus. This wasn't really a bug since the scopes would be deleted in the reverse order of creation, but in order to change this code further, we should maintain a guarantee that we do not create scopes on the stack that already has scoped objects. This patch does this by making the ctor private and allowing a few document functions to access it as friends. All other callers should be calling one of the document functions, depending on what type of update they need. R=chrishtr@chromium.org Fixed: 1068330 Change-Id: I32ac2fa6b095def65d64531e68ae03ab0d1d7b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140062Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757869}
-
David Van Cleve authored
TrustTokenRequestRedemptionHelper, which is responsible for executing Trust Tokens redemption operations, currently has its logic for generating a signing-and-verification key pair mocked out. This CL implements a concrete key pair generator satisfying the TrustTokenRequestRedemptionHelper::KeyPairGenerator interface on top of BoringSSL, using Ed25519, so that it's possible to construct redemption helpers with key pair generators that actually generate keys. Bug: 1068677 Change-Id: Ibe69486cba589884cfa69254971b9ec244b51cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139443Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757868}
-
Chris Sharp authored
This involves adding a few missing deps. gn check output for changes: ERROR at //chrome/browser/policy/policy_path_parser_win.cc:17:11: Can't include this header from here. #include "chrome/install_static/policy_path_parser.h" ^----------------------------------------- The target: //chrome/browser/policy:path_parser is including a file from the target: //chrome/install_static:install_static_util ERROR at //chrome/browser/policy/policy_path_parser_mac.mm:21:11: Can't include this header from here. #include "build/branding_buildflags.h" ^-------------------------- The target: //chrome/browser/policy:path_parser is including a file from the target: //build:branding_buildflags Change-Id: If70fc54a85ee31089a51aff2c0d08d5af5d8558a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140414Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757867}
-
Corentin Wallez authored
Bug: chromium:1064305 Change-Id: Id49edb06b68f2ce91fc6edc5f092a2b2dcb165f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143795Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757866}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5076bd228fba..5d1c16380705 git log 5076bd228fba..5d1c16380705 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mtklein@google.com fix JIT min/max 2020-04-09 fmalita@chromium.org [svg] Skip "inherited" presentation attributes 2020-04-09 jvanverth@google.com D3D fixes to clean up crashes in tests 2020-04-09 robertphillips@google.com Delay creation of GrTextStrike and GrGlyphs until flush time 2020-04-09 tdenniston@google.com [SVG] Fix polyline/polygon point parsing 2020-04-09 fmalita@chromium.org [svg] Adjust container size on Viewer window resize Created with: gclient setdep -r src/third_party/skia@5d1c16380705 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: csmartdalton@google.com Change-Id: I375d467a852b1183653124221bd45b142dfd755c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757865}
-
Johann authored
The Finalized version of GC was removed in afdb2e7a and the plugin was updated in f229ff46 Change-Id: I3a89f8e91fed1aaeda301b0d54d168607ad6197d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143413Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#757864}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5faec02776c..89fa61264af5 Created with: gclient setdep -r src-internal@89fa61264af5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I3dc123e1c9c117b3249169b189309ce851ca3975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144374Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757863}
-
Peter Kasting authored
This test is line-for-line identical with the test below it. Long ago these two differed. They don't anymore, so nuke one. Bug: none Change-Id: I80c11632589cb8e781fd4a272eb4540c37129f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143516 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757862}
-
Mikel Astiz authored
As of today, BookmarkModelObserver does not distinguish two very different events: 1. A favicon has actually changed for a bookmark. 2. A favicon for a bookmark has been loaded. They both get reported identically and in sync's case it needs to know whether a bookmark should be reuploaded (committed) or not. Treating all favicon-just-loaded events as local changes, as prior to this patch, is prone to undesired uploads that can lead to resurrected bookmarks and other sync conflicts. Before this patch, sync could identify some trivial cases, based on the fact that BookmarkSpecifics (hashed) hasn't changed at all. In such cases, BookmarkModelObserverImpl::BookmarkNodeFaviconChanged() didn't make a distinction, but the commit was later optimized away and never made it to the protocol. This mechanism is notably fragile in case BookmarkSpecifics go through code changes, such as new proto fields being introduced (unrelated to favicons). With this patch, the underlying design flaw is addressed and instead the two scenarios (favicon-just-loaded vs actual favicon change) are distinguished more reliably. A new hash is introduced in per-bookmark sync metadata that represents the last known content of the image, which allows determining whether the image has changed and a commit is needed. Change-Id: Ib88bed201b3f95be083026073a3c9422ab403b2b Bug: 1064945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141985Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757861}
-
Emanuel Ziegler authored
The WPT directory contains some expected failures for tests that do not exist anymore under that name. These files have been removed to avoid confusion. R=ahaas@chromium.org R=binji@chromium.org Change-Id: Icbf3278fe2ec7e80326460e8741fb5b447f096ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137396Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#757860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/25eeda1872e4..7db1491a85f6 git log 25eeda1872e4..7db1491a85f6 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 titovartem@google.com Restore call's final stats collection in PC level framework Created with: gclient setdep -r src/third_party/webrtc@7db1491a85f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I274d63aa4c9492518b7aeeb4a057fbcf17717009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757859}
-
Steven Bingler authored
Adding a comment describing effects of a compromised renderer and noting that a fix is in progress. Bug: 1069040 Change-Id: I3914730e02cbd3d21dce500c52f7abdaebf53df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142613 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757858}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I8102ce6b9c449e657603fd5173b457c4f669f105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140778 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#757857}
-
Sigurdur Asgeirsson authored
Bug: 1068233 Change-Id: I31999fdfdada0061ca3bd274eded98a858ca1c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137515 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#757856}
-
Andrew Grieve authored
This just renames the extensions in order to make build speed summaries distinguish the two. Bug: 1067273 Change-Id: I0a1e14cfed3557d29cd6beb0987436cacfaf6b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140908 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757855}
-
Garrett Beaty authored
The following changes were made to the console: * android-lollipop-arm-rel had its category changed to on_cq to match android-lollipop-arm-rel and android-marshamallow-arm64-rel. * The on_cq builders for the different android versions were grouped together before other on_cq builders. Bug: 1067057 Change-Id: I3f127a2addbe5311e5b05c26e993427aee3f36cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140096 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757854}
-
Xiyuan Xia authored
RequestNewThroughputTracker creates a ThroughputTracker to track throughput of ui::Compositor. Each ThroughputTracker is assigned a per-compositor unique sequence id. The sequence id will be used on impl side to create a kCustom typed cc::FrameSequenceTracker. When a tracker is started, stopped or canceled, an entry is created in AnimationHost to store the pending start/stop info of the id. This info is pushed to impl side along with other properties. Bug: 1021774 Change-Id: I8cf8b4051bc68054c199d510083abf7bd41cf6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008001Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757853}
-
Caitlin Fischer authored
These tests correspond to those in metrics_service_user_demographics_browsertest.cc. (Note that there will be a follow-up CL to remove duplicate code.) Bug: 1065870 Change-Id: I13df596c3ca62b90ba138a973db8f344011d02f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132534 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#757852}
-
Paulo Warren authored
This CL introduces SharedImageRepresentationVaapiOzone, a representation that is responsible for signaling to SharedImageBackingOzone that a VASurface has a pending write. A SharedImageBackingOzone::VaSync() function is added to check on pending VASurface writes before producing a different representation. BUG=1058103 TEST=NONE Change-Id: Ia769f81a76fc0ee3374b696db0eb427f22460bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132830Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Paulo Warren <pwarren@chromium.org> Cr-Commit-Position: refs/heads/master@{#757851}
-