GitLab

Long term solution is to tweak Dr. Memory to print out such errors to stderr

TBR=bruening,rnk
Review URL: http://codereview.chromium.org/8638010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111138 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 111135

BUG=
TEST=

Review URL: http://codereview.chromium.org/8636010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111137 0039d316-1c4b-4281-b951-d872f2087c98

1. experimental.metrics is now metricsPrivate
2. metricsPrivate is available to component extensions only
3. removed getEnabled/setEnabled functions as useless/harmful.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8548013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Existing tests

Review URL: http://codereview.chromium.org/8634006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23247
TEST=See bug.

Review URL: http://codereview.chromium.org/8547008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111134 0039d316-1c4b-4281-b951-d872f2087c98

This CL introdcues the front-end change which will enforce all clients of
signed settings to go through the CrosSettings class which mimics a normal
PrefService and will hide the gory details of the underlying layer.
The only difference being the extra GetTrusted function which will ensure
that fresh data from the policy blob has been fetched before returning the
cached value.

BUG=chromium-os:14054
TEST=All existing signed settings tests should still be green.


Review URL: http://codereview.chromium.org/7867044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111133 0039d316-1c4b-4281-b951-d872f2087c98

Make PassiveModelWorker class.

Make FakeModelWorker class and make tests use it.  Also make some tests
use realistic groups instead of shunting everything to GROUP_PASSIVE.

Rename MockModelSafeWorkerRegistrar to FakeModelSafeWorkerRegistrar.

This will make it easier to test an upcoming change that makes
ModelChangingSyncerCommand post on only the threads it needs to.

BUG=97832
TEST=


Review URL: http://codereview.chromium.org/8625005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111131 0039d316-1c4b-4281-b951-d872f2087c98

Also change valgrind_tests.py to use cygpath to give DrMemory Windows paths
when running with Cygwin Python.

The original change was made by Reid Kleckner and reviewed at
http://codereview.chromium.org/8505028/

TBR=glider
Review URL: http://codereview.chromium.org/8636008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111129 0039d316-1c4b-4281-b951-d872f2087c98

This enables overriding user preferences on a per-tab rather
than per-profile basis.

Based on this CL: http://codereview.chromium.org/7838030/

BUG=none
TEST=unit_tests pass

Review URL: http://codereview.chromium.org/8568019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual with chrome://histograms

Review URL: http://codereview.chromium.org/8638007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111125 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23079
TEST=policy_prefs_ui.py passes on chromeos for all policies

Review URL: http://codereview.chromium.org/8584004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111120 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111117 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erik.corry

Review URL: http://codereview.chromium.org/8636005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111116 0039d316-1c4b-4281-b951-d872f2087c98

See bug report for details.

BUG=104600
TEST=no


Review URL: http://codereview.chromium.org/8587029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8610006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111114 0039d316-1c4b-4281-b951-d872f2087c98

Makes way for upcoming ProfileSyncServiceFactory.  Note combining the two into one was considered, but the PKS pattern is to use a singleton, which is not ideal for ProfileSyncComponentsFactory.

TBR=mirandac@chromium.org

BUG=93922
TEST=compiles


Review URL: http://codereview.chromium.org/8596017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8569006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22896
TEST=build success

Review URL: http://codereview.chromium.org/8618013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run all the tests with prefix:DownloadProtectionService.*


Review URL: http://codereview.chromium.org/8638002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16552
TEST=chrome and tests build

Review URL: http://codereview.chromium.org/8602006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111109 0039d316-1c4b-4281-b951-d872f2087c98

We don't need it now that NativeWidgetViews is dead.
Also simplify View::ConvertPointToView() to look (mostly) like Layer::ConvertPointToLayer().

http://crbug.com/102573
TEST=existing unittests

Review URL: http://codereview.chromium.org/8620008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111108 0039d316-1c4b-4281-b951-d872f2087c98

In one instance, we can simply use currying to remove the need to
inherit from Task; in the other, we retain the wrapper since it wraps an
Objective-C call. Also remove an overload of ui::Clipboard::WriteObjects
that's never used.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/8606002

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/8634002

Review URL: http://codereview.chromium.org/8638004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111107 0039d316-1c4b-4281-b951-d872f2087c98

DevToolsManager should be created and destroyed inside content implementation, not by the embedder.

BUG=104625
TEST=Exising tests

Review URL: http://codereview.chromium.org/8609010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111105 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aklein

Review URL: http://codereview.chromium.org/8632003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=broken build
TEST=fixes build

Review URL: http://codereview.chromium.org/8633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111103 0039d316-1c4b-4281-b951-d872f2087c98

Added an std::max to prevent negative width calculation.

TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
I filed crbug.com/105014 for the placement regression on NTP.

BUG=98323
TEST=The avatar menu bubble works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111018

Review URL: http://codereview.chromium.org/8500004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111102 0039d316-1c4b-4281-b951-d872f2087c98

This moves the functions into a pattern that is component-friendly.

BUG=98755
TEST=chrome test_shell test_shell_tests browser_tests DumpRenderTree

Review URL: http://codereview.chromium.org/8602002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111101 0039d316-1c4b-4281-b951-d872f2087c98

- Create ShellAcceleratorController that manages global keyboard accelerators and also processes several accelerators as a target.
- Create ShellAcceleratorFilter, which is used by DesktopEventFilter to handle accelerators.
- Add a function to Shell for accessing ShellAcceleratorController.

The 1st attempt (http://crrev.com/110637) broke aura_shell_unittests and this fixes it.
The differences are
- moving ShellAcceleratorFilter to Shell from DesktopEventFilter, and
- adding the ShellAcceleratorFilter in Shell initialization code to DesktopEventFilter.

BUG=97255
TEST=Manual, aura_shell_unittests succeeds.


Review URL: http://codereview.chromium.org/8561012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111100 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8510069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111098 0039d316-1c4b-4281-b951-d872f2087c98

This moves the functions into a pattern that is component-friendly.

BUG=98755
TEST=Chrome, DRT, test_shell

Review URL: http://codereview.chromium.org/8591030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111097 0039d316-1c4b-4281-b951-d872f2087c98

Only one place was left using it (FirstRunSearchEngineView), and Brian said that didn't need to use it if it would just pick the first of the engine choices (prior to randomization) as the window was closed.

http://crbug.com/102581
TEST=unittests, and: run organic first run chrome, close the search engine selector, the Google should be the default. run organic first run Chrome, choose a non-Google engine, it should be the default.
Review URL: http://codereview.chromium.org/8618001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111096 0039d316-1c4b-4281-b951-d872f2087c98

Disables moar failing PPAPI tests on Mac.

BUG=105080
TEST=Valgrind on Mac goes green
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8637003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111095 0039d316-1c4b-4281-b951-d872f2087c98

Fixes logic for USE_AURA=1 case in Mac compositor.  Changes the code to not rely on |IsOffscreen| test to determine NSView-based surface.

BUG=105036
TEST=Manual test according to bug.
R=jbates@chromium.org, kbr@chromium.org

Review URL: http://codereview.chromium.org/8620009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111094 0039d316-1c4b-4281-b951-d872f2087c98

(The accessor gtk_widget_get_window was added in 2.14, so it was never used in
initial linux port development.)

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8625001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/8586044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104685
TEST=


Review URL: http://codereview.chromium.org/8622006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111089 0039d316-1c4b-4281-b951-d872f2087c98

1. Change from using zoom levels to a range of preset zoom factors (percentages). Zoom levels are the values that WebKit uses for page zoom. While zoom levels are simple to implement, they result in undesirable percentages like 57%, 144%, 207%, etc. Changing to zoom factors gives us user-friendly zoom percentages.
2. Increase the range of supported zoom values. A user can now zoom between 25% to 500%.
3. Use an epsilon value when comparing zoom floating point values. The previous version was doing an equality comparison of double values which may not always work as expected.

BUG=71484
TEST=Exercise zoom in/out via the wrench menu; exercise default page zoom setting in options window
Review URL: http://codereview.chromium.org/8528011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111087 0039d316-1c4b-4281-b951-d872f2087c98