- 27 Oct, 2018 35 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cc0ff81..39948071 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2fbda2b11cb63bdcc969f46751b2bca7db9fe410 Reviewed-on: https://chromium-review.googlesource.com/c/1303404Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603296}
-
Adrienne Walker authored
Change-Id: I4439caeb761c518928c94b2806c2ab805cc55e82 Reviewed-on: https://chromium-review.googlesource.com/c/1303098Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#603295}
-
Andrey Lushnikov authored
WASM currently creates script-per-function, resulting in a huge number of UISourceCodes reported to the devtools front-end. These sources are useless for automapping subsystem, so we should skip them right away. R=dgozman Bug: 806250 Change-Id: I1c8f81729ce64bb528a60f854a59715a78edbc95 Reviewed-on: https://chromium-review.googlesource.com/c/1300313Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603294}
-
John Abd-El-Malek authored
Change-Id: I7cd134d58ef03b39f2d7864c58b0fcc9d7d33f35 Reviewed-on: https://chromium-review.googlesource.com/c/1303400Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603293}
-
Mitsuru Oshima authored
We should use the adjusted bounds (by workspace) to compare the current bounds. Using non adjusted resulted in re-adjusting the bounds repeatedly, which caused the updating shelf visibility. Bug: 895744 Change-Id: I88f467ffc050c7fe30bc427ed20bf19b784ed965 Reviewed-on: https://chromium-review.googlesource.com/c/1303408Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#603292}
-
chcunningham authored
msarda@ is graciously taking the remaining work. Bug: 866518 Change-Id: Ia1720219386ee51955e74e461e2a4cdf17134bc2 Reviewed-on: https://chromium-review.googlesource.com/c/1175797 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#603291}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/385bf2e04812..9590dee526c5 git log 385bf2e04812..9590dee526c5 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 tsepez@chromium.org Pass unique_ptr to CPWL_Wnd::AddChild(). 2018-10-26 thestig@chromium.org Roll v8/ db22e96fb..a4f6a37da (307 commits) 2018-10-26 thestig@chromium.org Include platform-specific fxge sources with conditionals. 2018-10-26 tsepez@chromium.org Remove pParentWnd field entirely from CreateParams. 2018-10-26 thestig@chromium.org Fix more nits in fx_win32_gdipext.cpp. 2018-10-26 thestig@chromium.org Implement CFX_RenderDevice::GetFlipMatrix(). 2018-10-26 tsepez@chromium.org cp.pParentWindow is always NULL in NewPWLWindow() 2018-10-26 thestig@chromium.org Forward declare a bunch of classes. 2018-10-26 tsepez@chromium.org Stop transfering ownership of |this| as CPWL_Wnd::Create() side-effect Created with: gclient setdep -r src/third_party/pdfium@9590dee526c5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4c6adedd694f322cfefba512bbe3dd80761f26f4 Reviewed-on: https://chromium-review.googlesource.com/c/1303238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603290}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59ebf23f9ffe..625771d1d2bb git log 59ebf23f9ffe..625771d1d2bb --date=short --no-merges --format='%ad %ae %s' 2018-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a539a245..62e33bd2 (603045:603177) Created with: gclient setdep -r src/third_party/webrtc@625771d1d2bb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f9266681002595ae1047fdb538c8fe7c9e6a8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1303237Reviewed-by:
-
Sammie Quon authored
Previous, only removed masks on the window that is animating. But removing masks on all windows reduces jank, and UX is OK with it. Test: manual Bug: 899308 Change-Id: I7daa6bde8cbd2ab839123002024e440cbafa6627 Reviewed-on: https://chromium-review.googlesource.com/c/1302776 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#603288}
-
Yue Cen authored
Bug: 890118 Change-Id: I5bbb3093dfaabc0aa8d7e89fd2bf145f26884f42 Reviewed-on: https://chromium-review.googlesource.com/c/1239437 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#603287}
-
Jun Mukai authored
It has been an window observer + pre-target event handler to conduct the watching of topmost windows. During debugging of a test of tab-dragging, I've noticed that this can't deal with the destruction of the root window itself. Actually, it doesn't have to be a pre-target event handler anymore since there's EventObserver now. BUG=890071 TEST=existing ash_unittests / services_unittests pass Change-Id: Ic6750700e73fd3694be5aa00f080f3019e4fbd95 Reviewed-on: https://chromium-review.googlesource.com/c/1303034 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#603286}
-
Yuke Liao authored
This CL fixes an error in test spec for coverage bots so that test targets can be correctly sharded. Change-Id: I399d32917545a98951dc8ba0bb5ff51b84ccbc61 Reviewed-on: https://chromium-review.googlesource.com/c/1303043Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603285}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3ce69ba3eb60..7cf9cd2423b8 git log 3ce69ba3eb60..7cf9cd2423b8 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 enga@chromium.org Add flags to shader translator to emulate gl_DrawID 2018-10-26 jmadill@chromium.org Fix entry points. 2018-10-26 till.rathmann@gmx.de Support GL_OES_texture_border_clamp 2018-10-26 jmadill@chromium.org Vulkan: Make layers not depend on libvulkan. 2018-10-26 syoussefi@chromium.org Add compiler printf attribute to relevant functions 2018-10-26 geofflang@chromium.org Don't set native blob cache callbacks if the driver doesn't support it. Created with: gclient setdep -r src/third_party/angle@7cf9cd2423b8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=jmadill@chromium.org Change-Id: I94ca225e80293430596f5469c2f714e575b65b62 Reviewed-on: https://chromium-review.googlesource.com/c/1302705Reviewed-by:
-
Weiliang Chen authored
Adding function to record SkPicture using SkiaRenderer. Bug: 887515 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7e57c67ff3a4459db889afda145c86b481097582 Reviewed-on: https://chromium-review.googlesource.com/c/1272020 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#603283}
-
Peter Kotwicz authored
This CL introduces a way of defining a JSON config file as a "base JSON config file" + "delta config file". The generated config follows the following rules: - If a key is present in both the "base config" and the "delta config" the value in the "delta config" is used. - If a key is present in one of the "base config" and the "delta config" the key+value are included in the generated config. The reason for this change are to: 1) Make it easier to add test configs 2) Avoid breakages due to the configs being out of sync such as https://chromium-review.googlesource.com/c/chromium/src/+/1298428 BUG=899274 Change-Id: I48f236c4d6a86cba32c144b773ba6aab8c99b783 Reviewed-on: https://chromium-review.googlesource.com/c/1302326 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603282}
-
James Hawkins authored
Bug: 894305 Test: CrSettingsMultideviceSmartLockSubpageTest.* R=khorimoto@chromium.org Change-Id: Iecad14608d51137c35e9aa7875b0078ee41c541b Reviewed-on: https://chromium-review.googlesource.com/c/1299604Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603281}
-
Johannes Henkel authored
This changes the type in the .pdl file to binary. Wire representation remains as is, but now the protocol layer handles the encoding / decoding into base64, and we use protocol::Binary instead of std::string. Relevant prereqs: Supporting binary in .pdl files: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1285695 Rolled into Chromium / v8. Add protocol::content::Binary to protocol_string{.h,.cc}. https://chromium-review.googlesource.com/c/chromium/src/+/1280555 Bug: chromium:891377 Change-Id: I2a392fcdaca8c695bd1227c8cb68513a675c22fd Reviewed-on: https://chromium-review.googlesource.com/c/1298022Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
CdmPromiseAdapter is often used around trust boundaries, e.g. IPC or library CDM interface. Hence, we can't really trust that the |promise_id| passed in is always legit, and DCHECK it. This CL changes those DCHECKs to be LOG(ERROR)s so they'll show up in logs and we always handles those cases properly, e.g. by return early. Bug: 899032 Change-Id: I4cc46ab2579fc638aeb03cf30eb031777a00adf8 Reviewed-on: https://chromium-review.googlesource.com/c/1303040Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603279}
-
Tim Zheng authored
This CL adds a context menu item for swtiching display density to Crostini app shelf item. It also adds a dialog to give user choice of restarting the app. BUG=chromium:839242 TEST=Manually tested on an eve device Change-Id: Ia1a9ad335711e39305d147c43d001186c2b86f58 Reviewed-on: https://chromium-review.googlesource.com/c/1287255Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Weidong Guo authored
Bug: 890412 Change-Id: Ie72b42092292b26185386661bf29df9d3c7ee4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1303373Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#603277}
-
Xi Cheng authored
Bug: 888716, 851163 Change-Id: I7792883b6e659590bd46a90a0b8efc765a7732ec Reviewed-on: https://chromium-review.googlesource.com/c/1298474Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#603276}
-
Saman Sami authored
Refactor archaic function names and stop passing visibility to SwappedFrame. Change-Id: If083e70202247552c4735dc374781d68e421cd69 Reviewed-on: https://chromium-review.googlesource.com/c/1301957 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/387085f89da6..985e130969ef git log 387085f89da6..985e130969ef --date=short --no-merges --format='%ad %ae %s' 2018-10-26 sergiyb@chromium.org Add LUCI OAuth client id into the list of whitelisted clients Created with: gclient setdep -r src/third_party/catapult@985e130969ef The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895891 TBR=sullivan@chromium.org Change-Id: I4276e5bef13a357a196d7063d14f3ccec71e2a8a Reviewed-on: https://chromium-review.googlesource.com/c/1302706Reviewed-by:
-
John Williams authored
Bug: 897957 Change-Id: I2a40aa56067b2567ace74884cf62898e8c87f883 Reviewed-on: https://chromium-review.googlesource.com/c/1297631 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#603273}
-
Robert Sesek authored
Field trials are initialized in child processes before the IPC channel is set up, so the Mach memory object cannot be transferred using it. And there is no way to transfer Mach ports across child creation, unlike with FDs. This CL introduces the FieldTrialMemoryServer, which is a Mach message server that publishes its endpoint in the bootstrap namespace. Child processes can look up the server and send it a message to request the field trial shared memory object. Access is limited to direct children of the server process. FieldTrialList is the sole caller of the legacy FD-backed shared memory API on Mac, and it needs to be removed in order to transition to new shared memory API (https://crbug.com/795291). Bug: 776564 Change-Id: I0e25469d6b28533a1ab26a4c8907cc704bc3c0fd Reviewed-on: https://chromium-review.googlesource.com/c/1292211 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#603272}
-
Jazz Xu authored
Change-Id: Ic3f0448ae77c9226421132ce911181f53b5ceb7d Reviewed-on: https://chromium-review.googlesource.com/c/1303099Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603271}
-
Fredrik Hubinette authored
This should make VP9Decoder set color spaces on returned video frames correctly on windows and chromeos. Bug: 647725, 847573 Change-Id: I602e61e078795a511caef134256a0676199f031e Reviewed-on: https://chromium-review.googlesource.com/c/1298635 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603270}
-
Tim Haloun authored
- Move QoSCreateHandle to a background task, letting critical socket operations continue unblocked while it executes. - Improve resetting handle when it returns REINITIALIZATION_NEEDED - Widen unit tests - Undo ifdef disabling QOS that was added because of hangs/stalls noted in bug 812137 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I383955c2a218f23974a3f5e7044ae0464e99a43f Bug: 812137, webrtc:5836 Reviewed-on: https://chromium-review.googlesource.com/c/1195936Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Tim Haloun <thaloun@chromium.org> Cr-Commit-Position: refs/heads/master@{#603269}
-
Nektarios Paisios authored
This reverts commit eb17833e. Reason for revert: Broke linux-chromeos-dbg again. AXPlatformNodeDelegateBase::Create and GetData are not defined. Original change's description: > Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants" > > This is a reland of cb9c3091 > > R=dmazzoni@chromium.org,aleventhal@chromium.org > TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org > Bug: 811277 > > Original change's description: > Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants > > Also renamed some methods to make interface more consistent. > In preparation for more changes in AXVirtualView. > > Change-Id: I815d6d941f18ef84864636bc02423af20b0bbc97 > Reviewed-on: https://chromium-review.googlesource.com/c/1303093 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603255} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org Change-Id: I954e26880106e51fe78daa79717300f5ab833341 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811277 Reviewed-on: https://chromium-review.googlesource.com/c/1303556Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#603268}
-
Xiaoqian Dai authored
Bug: 898403 Change-Id: If85fb9d0c90c583110f96a712ae50719c0a3925a Reviewed-on: https://chromium-review.googlesource.com/c/1300105 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
jonross authored
VizDisplayCompositor has been on my default on the CQ for a while. However as we've been preparing for launching to stable, we've realized that we have no coverage of the non-Viz path. So we currently can't be sure that nothing has broken. We want to bring up three test suites on FYI bots, with Viz Disabled. So that we can get coverage back. These are for Linux, Windows, Android and Mac, as Viz is not yet enabled on Chrome OS. I plan to remove this once we are closer to launch: M-71 TEST=browser_tests, content_browsertests, content_unittests. Change-Id: Icd32248beeab3788070bbab10a194f9046c652d9 Reviewed-on: https://chromium-review.googlesource.com/c/1302693Reviewed-by:
-
danakj authored
The call in SetRootGraphicsLayer() comes from this CL: https://codereview.chromium.org/1078473002/diff/100001/Source/web/WebViewImpl.cpp#newcode4168 In that CL it mentions that visibility is not always propagated to the WebViewImpl, but in a racey way. At that time WebViewImpl would initialize its compositor on line 452 after SetVisibilityState on line 449. This means at startup the compositor's visibility would not be set. It would only be toggled if the browser send a shown IPC to the renderer, which it appears did not always end up arriving. Things have changed significantly since then. We now SetVisible on the compositor in order to start its scheduler. At the time we had a separate start signal via SetLayerTreeHostClientReady(). So now RenderWidget would set the compositor as visible if its marked as shown when it is created. The call in SetRootLayer was moved in 7e410b31 from WebViewImpl::attachPaintArtifactCompositor() which included - // TODO(jbroman): This is cargo-culted from setRootGraphicsLayer. Is it - // necessary? - m_layerTreeView->setVisible(page()->isPageVisible()); So I would say no it is not. R=enne@chromium.org Change-Id: Icaea3fb4b164b9b4de348dd2e216c4a6a3344b60 Bug: 896836, 894899 Reviewed-on: https://chromium-review.googlesource.com/c/1298341Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603265}
-
Abhishek Bhardwaj authored
This is a reland of https://crrev.com/c/1297474. This change adds functionality to support lock screen notifications for Android. The wake lock module now listens to dark resume notifications from the power manager. It - 1. Starts a timer to check for partial wake locks acquired by Android. 2. After the timer in 1 expires, if no partial wake lock is acquired the power manager is requested to re-suspend the system. If a partial wake lock is acquired, then another hard timeout timer is set and also an observer to wake lock release is set. 3. If wake lock is released, the system is re-suspended immediately. 4. If a wake lock is still acquired but the hard timeout expires then the system is re-suspended immediately. 5. If the system transitions to a full resume all dark resume related state and timers are cleared. On top of this change - 1. Changes were added to fix linker errors by declaring static constants in the source file as well. 2. Refactored some functions in the test code. BUG=chromium:898297 TEST=Unit tests and end to end test with Android applications. Change-Id: I573f130fad2ed092d8acb83fb3319614b4ce8e02 Reviewed-on: https://chromium-review.googlesource.com/c/1302866Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603264}
-
Stephen Martinis authored
The URL structure of the build info returned by `git cl try-results` is different on LUCI than it was on buildbot. This CL changes git_cl.py to instead look at the build_address of the build to determine the build number. Bug: 891729 Change-Id: I448638178942f2adbbb23c5dd947e305821a5417 Reviewed-on: https://chromium-review.googlesource.com/c/1302097 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#603263}
-
Julie Jeongeun Kim authored
This is a reland of e14722dd Original change's description: > Move the APIs using XRANR to ui/base/x folder > > It creates x11_display_util.cc/h files and moves the APIs to > get display information using XRANR from DesktopScreenX11 to > share the implementation with Ozone/X11. > > 'GetXrandrVersion' is to get xrandr version, > 'GetFallbackDisplayList' is to get a fallback display and > 'BuildDisplaysFromXRandRInfo' is to get a list of displays from > the current screen. > > It also moves 'GetICCProfileForMonitor' from DesktopScreenX11 > to x11_util.cc. > > These APIs are required for Ozone/X11 as well. This change doesn't > bring any behavioral changes. > > Bug: 891175 > Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada > Reviewed-on: https://chromium-review.googlesource.com/c/1295762 > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602634} Bug: 891175 Change-Id: I742eec8285b023adda84d28d68a21f7545a87f8c Reviewed-on: https://chromium-review.googlesource.com/c/1301036Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603262}
-
- 26 Oct, 2018 5 commits
-
-
Chris Mumford authored
GetNetworkChangeManager was incorrectly added in r577168 but was never called. This change removes that vestigial code. Bug: 836188 Change-Id: I618712829d04e94c1bb4e2c1d3fe5c16475daa6f Reviewed-on: https://chromium-review.googlesource.com/c/1271556Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#603261}
-
John Rummell authored
Adding the annotation makes it clear which fields are protected by base::Lock, and enables compile-time analysis to verify this. BUG=893739,887645 TEST=compiles Change-Id: Ideddb22c0687168d25ceab9ad30f32797862fcfd Reviewed-on: https://chromium-review.googlesource.com/c/1302323Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603260}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4f6a37d..6cc0ff81 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cae1492c12250d85f78b246eb682391a2876b8f Reviewed-on: https://chromium-review.googlesource.com/c/1302324Reviewed-by:
-
Etienne Bergeron authored
This event will help figuring out a bug happening with sampling profiler. We currently don't know if the event is emitted from tracing sampler profiler or from UMA sampling profiler. This event should be rare, only on error cases. R=oysteine@chromium.org Change-Id: Id761ef1744c6a2ec924992229ce55e8bc6deac87 Reviewed-on: https://chromium-review.googlesource.com/c/1301968Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603258}
-
Jun Mukai authored
With recent fixes for multi-display (crbug.com/892714), now some tests in tab-dragging works. Still the test code needs to wait for the bounds changes, since related display ID change arrives asynchronously. Two tests are still failing because of other reasons. BUG=890071 TEST=single_process_mash_interactive_ui_tests Change-Id: I2b73f5ded68fcf0431b67d03737cd137ea57e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/1300689 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
