- 01 Jun, 2020 40 commits
-
-
Eric Robinson authored
Bug: 1089680,1089681,1089679,1089211,1077807 Change-Id: I1103f31e6b9152007276f7f15e05f8fd9194fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225265Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#773846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/394c4a94dbc7..3fb1d569defc 2020-06-01 brucedawson@chromium.org Fix command prompt title after update_depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iee9970e4ba7070b356575e01db14032b9179a528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773845}
-
Kai Ninomiya authored
Bug: 1069302 Change-Id: Iea10257e35bd11e724241dbc038955cc8a0b47a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222299 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773844}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 378036cd. With Chromium commits locally applied on WPT: bc9a80d4 "Origin isolation: parse the header" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie0770ea924d20b0a3468826131b5256d9dfa33bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224650Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773843}
-
Ian Struiksma authored
updated giftcardmall.test to remove autofill-information reference in xpath. This required update of cipd version in DEPS diff of cipd versions: 265c265 < "selector": "//select[@id=\"statesList\"]", --- > "selector": "//select[@id=\"statesList\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_STATE server type: ADDRESS_HOME_STATE heuristic type: ADDRESS_HOME_STATE label: State parseable name: state section: address_2-default field signature: 1878375253 form signature: 2667380901547437148\"]", 276c276 < "selector": "//input[@id=\"addressZip\"]", --- > "selector": "//input[@id=\"addressZip\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_ZIP server type: ADDRESS_HOME_ZIP heuristic type: ADDRESS_HOME_ZIP label: Zip parseable name: zip section: address_2-default field signature: 569224803 form signature: 2667380901547437148\"]", Bug: 1088252 Change-Id: I06821a54e0f0e92505e92d31a5b54aef54c951f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224052 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#773842}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0aaf24a2757..ced839500960 2020-06-01 michael.liao@microsoft.com [TreeElement]: null treeOutline exception in TreeElement.select If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1085816 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2840a29f5384df37de70679478af20577c872126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773841}
-
John Chen authored
Add missing commas in _DISABLED_TESTS. TBR=wenbinzhang@google.com Bug: 1060068, 1088106, 1088447 Change-Id: I7f2ab1e14314237e4d4b466f775c6a7108de9f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225338 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773840}
-
Behnood Momenzadeh authored
Some top domains use a common word for their website name. Office.com and weather.com are examples of such domains. As a result, hostnames embedding these common words might be falsely flagged. We allowlist some common words in this CL that have shown to lead to false positives. There are two types of common word allowlisting. One is allowing the common word to be embedded with all TLDs and two is allowing the common word to be embedded with TLDs other than the TLD of the top domain. For example, weather is a common word for all TLDs. As a result, neither of weather.com-foo.com, and weather.info-foo.com would trigger this heuristic. However, office is a common word just for TLDs other than ".com". So, office.info-foo.com won't trigger the heuristic, but office.com-foo.com would trigger it. Bug: 1087636 Change-Id: Id5b6bc5204254f45429a7d91690af192fcef81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224313 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#773839}
-
Jonathan Backer authored
Sometimes a device driver signals an internal error and we just need to reset. This CL checks for reset more aggressively on all {SharedContextState,SharedImageStub}::MakeCurrent calls. This will hopefully turn some crashes into restarts. Bug: 1079161,1081806 Change-Id: I260f90b4ed2ba63be3cf7ca6759c5aa086f0c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214919 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773838}
-
Christopher Cameron authored
Change SkiaOutputDevice::FinishSwapBuffers to take a gfx::SwapCompletionResult instead of just a gfx::SwapResult. This makes its way to the population of the gpu::SwapBuffersCompleteParams in SkiaOutputDevice::SwapInfo::Complete, where we will be adding the gfx::CALayerParams structure in a subsequent patch. Bug: 894929 Change-Id: I873f6611b3e87a0b3bedb116d33224aed59b7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225360Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#773837}
-
Karandeep Bhatia authored
Add tests to ensure empty ruleset paths raise an error while manifest parsing. Also add a regression test for issue 1087348 by ensuring DNRManfiestHandler handles an extension with an empty root path correctly. BUG=1087348 Change-Id: I7d3886d2116f5f6126abba153045ded71dcead71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223372Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773836}
-
Dominic Mazzoni authored
This is a small, targeted fix to prevent an issue where pages with CSS animations - especially long-running animations like spinners - experience poor performance with accessibility. It's completely safe to suppress events when a node is aria-hidden. Bug: 1090046 Change-Id: I431d53ffd97263e1013b5c5a0359f1d7515dce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225497 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#773835}
-
Kelvin Jiang authored
Once again this flakes, at the exact same sub-test as well. Will need further investigation. Bug: 1087765 Change-Id: Ibe431541b835a8e3de613b6006e1526795c0648c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223652 Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773834}
-
Mustafa Emre Acer authored
Users may sometimes press non character keys such as ESC when on a webpage (e.g. to close popups or other prompts). This CL ignores these cases and does not undelay the warning. Bug: 1057157 Change-Id: I4cfc2c621e4c0a84f46fdaa8f800e6843ed6b4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773833}
-
Jonathan Ross authored
On the Intel 0x3e92 bots the deqp/functional/gles3/shaderoperator/binary_operator_* and deqp/functional/gles3/shaderoperator/unary_operator_(01|02).html have continued being flaky, even with RetryOnFailure. I'm marking them as Skip until the root cause can be addressed. TBR=bsheedy@chromium.org Bug:1085222 Change-Id: I04e1ec7e047afd2a63055b5e5b4915f8319dc9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224844Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#773832}
-
Ken MacKay authored
Bug: internal b/151898798 Change-Id: Iefa00b066a834f99f4559d16c94aee47d94ce590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216881Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#773831}
-
Tomasz Wiszkowski authored
Change-Id: Iee930bac15483daaf0bb7a88ab48af0007717a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219580 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#773830}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b369376270f8..6169aca6f508 2020-06-01 jmadill@chromium.org Update dirty bits flow example. 2020-06-01 plamoureux@google.com Move ShaderVariable utility function from utilities.cpp ShaderVars.cpp. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I447f2ba857842dca3ea293d2dbf4315d35b2efb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773829}
-
Ken MacKay authored
The resampler may still have some non-zero data buffered, so we need to flush it to avoid a pop. Therefore, provide one additional buffer of zeros before removing the stream. Bug: internal b/157599040 Change-Id: I2d366c733f2e4cc5df1c1d6011c3f5ab856e4120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225336Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#773828}
-
Jesse Schettler authored
ARC++ printing usage is still being analyzed, and one of the histograms is still brand new. Bug: chromium:1088573 Change-Id: I8b235bd91fc1f08851e618006b634edc5d50f70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224974 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#773827}
-
Paul Jensen authored
Instead of looking at ApplicationStateListener's |newState| param, use hasVisibleActivities() to determine if one of Chrome's activities is visible. Using |newState| causes spurious unregister then register events when flipping between Chrome's Activities (e.g. Bookmarks). Bug: 1030229 Change-Id: Id2ecb19fd612c3a71e49d87047e0eccd8f9859fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219668 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773826}
-
David Benjamin authored
These histograms measure Android devices with some broken CPU capability reporting. Net.HasBrokenNEON measures something we can likely get rid of now, but we haven't yet so extend it a bit. Net.NeedsHWCAP2Workaround measures something that we are *very* far from dropping, but I've extended it for two years (hardware lifecycles are long) to check back in then. Bug: 1089000, 1089009 Change-Id: I068b4c3cdd82579622344cf3cf543560bc299013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225381 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773825}
-
Joel Hockey authored
With my recent crrev.com/c/2189893 to create popups from apps as TYPE_APP_POPUP, rather than TYPE_APP, we are now showing the location bar on these popups which is not expected. TYPE_APP_POPUP should match the set of features from legacy apps, rather than those of popups. The legacy apps are already 'inheriting' from popups, with 2 differences: FEATURE_TITLEBAR: Popups will show this for non-trusted sites which are not in fullscreen. Legacy apps show this for all sites which are not in fullscreen. FEATURE_LOCATIONBAR: Popups will show this for non-trusted sites which are not in fullscreen. Legacy apps never show this. However they will display the CustomTabBarView when the URL navigates out of scope of the app. This CL renames 'LegacyApp...' function to 'AppPopup...', and modifies the TODO suggestion of having TYPE_WEB_APP and TYPE_LEGACY_APP which predates the creating of TYPE_APP_POPUP. It seems that the solution now would be to create legacy apps using TYPE_APP_POPUP rather than TYPE_APP. Bug: 1088300 Change-Id: I77044b62cc5ff88208d02df74af42b59783b78e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224473Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773824}
-
Moe Ahmadi authored
Overriding color of the icon in hovered and focused states (via overriding the background color of the masked image) seems to interfere with the CSS transition applied to the background color of the masked image. See below: :host(:not([iron-icon])) #maskedImage { ... background-color: var(--cr-icon-button-fill-color); transition: background-color var(--cr-icon-button-transition); ... } My attempts at recreating this failed https://jsfiddle.net/g9tj82af/7/ however, setting -cr-icon-button-transition: none; solves the issue Bug: 1087597 Change-Id: I7a0b8e704adf937be5d3cc75b0f1adb46111cf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225339Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33dbd656112d..67e50a6b5c59 2020-06-01 johnstiles@google.com Allow printf-style formatting to be used in SK_ABORT. 2020-06-01 herb@google.com Make fMaskFormat private 2020-06-01 nifong@google.com Additional tests covering parts of path interface 2020-06-01 lingyun.cai@intel.com Add AVX2 implementations for SkSwizzler opts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I68afa7b1eb264e302b0de82991492f3e069cbbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773822}
-
Haiyang Pan authored
Also disabled them in network_service_out_of_process_content_browsertests Also use separate filters on M and P for content_browsertests since failed tests on them start diverging Bug: 1056325, 1081969 Change-Id: Ida0a29736eb9a5532f29942de8a68a4c30ed2c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225155 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773821}
-
Stefan Zager authored
The iframe's root graphics layer should not be treated specially; it should be incorporated into the regular GraphicsLayerTreeBuilder flow. This has the added benefit that it's not necessary for the iframe element in the parent document to be composited. A future CL will stop compositing iframe elements by default. Change-Id: I9bcfdc2384b072601c87786b269a32d86d7973e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220868Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#773820}
-
Charlene Yan authored
Bug: 1018230 Change-Id: I837514789ae6809c3d2eb8f3927837c48c416eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209236 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#773819}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9a0423c5f727..da87b8d8b0a1 2020-06-01 bryan.bernhart@intel.com Support forcing storage buffers to be always declared as UAV. (#1076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia6abe3ece2f49a44f6273b22b86e4601214516f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225306Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773818}
-
David Benjamin authored
The KnownRoot histogram is no longer needed because we now enforce it unconditionally. Extend the unknown root histogram for a year as we have not yet enforced it there. (This doesn't address all the histgrams on the bug. I'll deal with those in separate CLs.) Bug: 1089024 Change-Id: I75aad10136eeb7ec7d74ca0bda70bac23cf13c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225378Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#773817}
-
Salvador Guerrero authored
The following tests are flaky on Android Marshmallow 64 bit tester: LinkManagerAddTwiceCancelTwice LinkManagerAddTwiceAbandonTwiceUseTwice TBR=tbansal@chromium.org,pasko@chromium.org Bug: 1087876 Change-Id: Ib6e55c4820f1d79723303182e9b2b220d4d2e26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225476Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#773816}
-
Ghazale Hosseinabadi authored
ExtensionService::is_ready() uses ExtensionSystem::ready. Since, this is not obvious to users of extensions, we move is_ready() into ExtensionSystem, i.e., we remove ExtensionService::is_ready() and we implement and use ExtensionSystem::is_ready() instead. Bug: 1082300 Change-Id: I1ca422b76369a62cbef11b9eb9a714965512a3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207499Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#773815}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f944ff787246..3bd6d5e39662 2020-06-01 treehugger-gerrit@google.com Merge "tp: add mapping of I for task dead in task state struct" am: f944ff7872 2020-06-01 ilkos@google.com Merge "Add root information to all java heap stats" am: efe9545854 2020-06-01 lalitm@google.com Merge "tp: add global track for lmks" am: af572baece 2020-06-01 fmayer@google.com Merge "Set TraceStorage for TraceProcessorContext." am: 69b3575b25 2020-06-01 lalitm@google.com Merge "Parse task state based on kernel version" am: 96b0d124db 2020-06-01 treehugger-gerrit@google.com Merge "Fix fully qualified proto extension" am: 0e8a301e5c 2020-06-01 fmayer@google.com Fix package parse error. am: 5f3e0d8431 2020-06-01 simonmacm@google.com Merge "Allow traces opened via postMessage() to have a title." am: 2836742ae0 2020-05-30 primiano@google.com Merge "docs: minor fixes" am: 82119ad86b 2020-05-29 oysteine@google.com Merge "Added a UI track for CPU stack samples" am: f5a1461ae5 2020-05-29 eseckler@google.com Merge "service: Fix win/mac/nacl build" am: 7e9f1ed061 2020-05-29 hjd@google.com Merge "ui: Run npm audit --fix" am: 6127c626e6 2020-05-29 eseckler@google.com Merge "service: Capture clock snapshots periodically while tracing" am: 5623cf7ed9 2020-05-29 lalitm@google.com tp: refactor generation into a global variable am: 0436cda320 2020-05-29 lalitm@google.com Merge "tp: fix build of metatrace on GCC" am: b3a8c86f80 2020-05-29 fmayer@google.com Merge "Use IDs instead of raw rows." am: 6e46f0da72 2020-05-29 fmayer@google.com Merge "Use tables rather than HeapGraphWalker for flamegraph." am: ae5b984400 2020-05-29 primiano@google.com Protozero: remove message finalization listener am: 1aa58ae23f 2020-05-29 hjd@google.com Merge "trace_processor: Fix layout track" am: 5666031c61 2020-05-28 oksamyt@google.com Parameterize raw_metrics_per_core with table name am: a075151a21 2020-05-28 fmayer@google.com Merge "Fix invalid reference_set_id." am: e60ccbbb1b 2020-05-28 treehugger-gerrit@google.com Merge "tp: move parsing of cpuinfo to tokenization time" am: 880129a6d2 2020-05-28 fmayer@google.com Merge "Remove unused fields in heap_graph_object." am: e3244f578f 2020-05-28 fmayer@google.com Merge "Remove useless FindPathsFromRoot calculation on ingestion." am: 8a8ccba107 2020-05-28 simonmacm@google.com Merge "Fix time-in-state thread ordering inside processes." am: 0387dfcbf8 2020-05-28 lalitm@google.com ui: plumb tp metatracing into the UI am: fdd70eae32 2020-05-28 simonmacm@google.com Merge "Improve time-in-state UI some more." am: a5b927e19e 2020-05-28 primiano@google.com trace_processor: fix IWYU includes am: 1d51ae3e7a 2020-05-27 primiano@google.com docs: Use absolute links am: a3bddd65ae 2020-05-27 treehugger-gerrit@google.com Merge "sdk: Update documentation to point to v4.1" am: 6efe32b361 2020-05-27 lalitm@google.com Merge "tp: add metatracing" am: c942ef4b66 2020-05-27 treehugger-gerrit@google.com Merge "Read boost frequencies" am: 73cea9cfd9 2020-05-27 fmayer@google.com Use SOCK_CLOEXEC when possible. am: 609c36d7e6 2020-05-27 skyostil@google.com sdk: Add example code am: fffa2ecdc7 2020-05-27 skyostil@google.com Merge "docs: Add guide on making a new SDK release" am: 6f8823b425 2020-05-26 primiano@google.com Merge "Site: fix typo in home page" am: 1a97f7367f 2020-05-26 lalitm@google.com Merge "ui: fix annotations track query when counter table is empty" am: af27e58ea4 2020-05-26 primiano@google.com site: improve layout of home page on mobile devices am: 007dbe77f5 2020-05-26 ilkos@google.com Merge "Add unique_session_name to the metadata" am: fac9f9e293 2020-05-26 primiano@google.com Merge "infra: Add redirect for {www,docs}.perfetto.dev -> perfetto.dev" am: 3cef1d5427 2020-05-26 ilkos@google.com Merge "Downgrade ringbuffer overruns to info" am: 693f1dcf8c 2020-05-26 dproy@google.com Merge "ui: Introduce analyze page with multiline SQL input box" am: 9b5a24e66f 2020-05-26 taylori@google.com Merge "Allow invalid task state for conversion" am: 43b6446650 2020-05-22 primiano@google.com Merge "infra: add perfetto.dev site" am: 9046a42475 2020-05-21 treehugger-gerrit@google.com Merge "Use stack_id instead of track_id for experimental_slice_layout_generator" am: cd9e807ee9 2020-05-21 primiano@google.com docs: Merge back from sprint repo am: a662485bdf 2020-05-21 treehugger-gerrit@google.com Merge "Create tables for cpu info" am: 48c10ec7c5 2020-05-21 simonmacm@google.com Merge "Improve time-in-state UI." am: a15e453bc0 2020-05-21 treehugger-gerrit@google.com Merge "protozero: Add ProtoZero vs protolite benchmark" am: 10792279b6 2020-05-21 hjd@google.com Merge "ui: Merge global async slice tracks by name" am: d88851deb1 2020-05-21 ilkos@google.com Merge "Revisit fixing RSS captured after heap dump was taken" am: c4e15df5d5 2020-05-21 hjd@google.com trace_processor: Add missing header am: 66bd749aed 2020-05-21 ilkos@google.com Merge "Find closest timestamp when looking up RSS mem" am: 529df8d634 2020-05-21 taylori@google.com Merge "ui: Add binder atrace categories to record page" am: 45e268005a 2020-05-21 taylori@google.com Merge "perfetto-ui: Don't catch query errors" am: 2678ba1366 2020-05-20 treehugger-gerrit@google.com Merge "clock: Support specifying an authoritative trace clock in the config." am: 91303e1cbb 2020-05-20 treehugger-gerrit@google.com Merge "build: Fix libperfetto NaCl build" am: b12fc2d9ec 2020-05-20 treehugger-gerrit@google.com Merge "Mark exhaustive time_in_state snapshots" am: 169feea71d 2020-05-20 simonmacm@google.com Merge "Add counter annotations for time-in-state probes." am: 6f7dd262ed 2020-05-20 taylori@google.com Merge "Fix binder destination thread + name" am: f663d41a44 2020-05-19 chiur@google.com Allow counters to be grouped with GpuCounterGroup am: 324f995d28 2020-05-18 lalitm@google.com Merge "tools: make traceconv and trace_processor scripts python3 compatible" am: c8b5718908 2020-05-18 dproy@google.com ui: Factor out query table from viewer page am: 425742f4f1 2020-05-18 rsavitski@google.com Merge "heapprofd_client: systematically leak state in an atfork handler" am: d70359f64e 2020-05-18 lalitm@google.com Merge "ui: add support for upid column on derived tables" am: f5105b3e8c 2020-05-18 rslawik@google.com Bail if time_in_state does not have cpuN headings am: df5f577643 2020-05-18 treehugger-gerrit@google.com Merge "protozero: Expose bool op + get() on MessageHandle" am: f1ad915f0d 2020-05-17 ilkos@google.com Merge "Enhance the process state counters at LMK time" am: ed409310e2 2020-05-15 primiano@google.com Infra: allow curl to follow redirects am: 9ff392c5e3 2020-05-15 fmayer@google.com Merge "Test for IsPostFork() in RecordFree." am: f5f132355f 2020-05-15 fmayer@google.com Merge "Log when removing targets because of low RSS." am: 62c4e96d56 2020-05-14 primiano@google.com Merge "UI: Fix time bounds capping of updateLocalTime()" am: 70e7f58414 2020-05-14 skyostil@google.com Merge "ui: Fix nesting of slice argument table" am: 09d3485a95 2020-05-14 treehugger-gerrit@google.com Merge "Support ion_stat" am: e9ada45993 2020-05-14 primiano@google.com Merge "Use exec(curl) for downloading artifacts" am: 5798357905 2020-05-14 lalitm@google.com ftrace: update descriptors am: effa3ad936 2020-05-14 primiano@google.com Merge "Content-type for wasm files in tools/dev_server" am: 9eaf6cc64b 2020-05-13 hjd@google.com Merge "ui: Update OWNERS" am: d8cb80d7a7 2020-05-13 ilkos@google.com Merge "Add unreclaimable category in rss_stat" am: b09e57385a 2020-05-13 dproy@google.com Merge "ui: Remove unused code in omnibox" am: 4ca39abdbf 2020-05-13 lalitm@google.com tp: add error check for illegal characters in span join am: 974f915feb 2020-05-12 lalitm@google.com Merge "tp: allow preempt depth to be greater than 9" am: 79825c95b6 2020-05-12 khokhlov@google.com Add TRACE_EVENT_COPY_NESTABLE_ASYNC_{BEGIN0,END0} macros am: d4e0aadfce 2020-05-11 taylori@google.com Merge "perfetto-ui: Make annotation slice selectable" am: 237c0fa4e1 2020-05-11 lalitm@google.com bazel: fix compile when precompiled headers are used am: b8698fa089 2020-05-11 lalitm@google.com Merge "tp: update traceconv and trace_processor binaries" am: 6c5248d193 2020-05-11 simonmacm@google.com Merge "Fix battery aggregates." am: a0c7d84a46 2020-05-11 ddrone@google.com Merge "Add ddrone@ to OWNERS" am: f6594590ff 2020-05-11 ddrone@google.com Client API: Parity with macros in Chrome am: 729beff320 2020-05-07 taylori@google.com perfetto-ui: Show one letter on a slice if possible am: 3079074f69 2020-05-07 taylori@google.com Merge "perfetto-ui: Make sleeping slices less visually distracting" am: e160d4ae86 2020-05-06 lalitm@google.com perfetto: add proto lite java config to bazel build am: 46e2bdaa94 2020-05-05 cfijalkovich@google.com Merge "Filter frames preceding app launches for hsc-based metrics" am: 058776deb6 2020-05-05 lalitm@google.com metric: account for multiple ion events at same timestamp for annotation am: 0767220e61 2020-05-05 treehugger-gerrit@google.com Merge "TrackEvent: Make process/thread naming less of a footgun" am: 659339a8c0 2020-05-05 rsavitski@google.com tmux script tweaks, and update test config for scheduling info am: 960da79f3a 2020-05-05 ilkos@google.com Add ion/ion_stat to UI am: ff70e0d273 2020-05-05 treehugger-gerrit@google.com Merge "perfetto-ui: Fix update localTime bug" am: cd43ce1ed4 2020-05-04 treehugger-gerrit@google.com Merge "UI: Add trace title to sidebar and tab title" am: c6e57b7fb8 2020-05-04 treehugger-gerrit@google.com Merge "Set apex_available property" am: 0c5fba676f 2020-05-04 treehugger-gerrit@google.com Merge "Handle cached values in thread time in state" am: 2cce0c9a86 2020-05-04 eseckler@google.com processor: Don't import complete event's end ts counters am: 411e9c858a 2020-05-04 treehugger-gerrit@google.com Merge "Allow android.polled_state to... poll." am: 2da94d52c5 2020-05-02 lalitm@google.com Merge changes from topic "hsc-trace-processor-revision" am: 7516705df1 2020-05-01 primiano@google.com Merge "Fix UI build for python 3" am: 9ad32a7468 2020-05-01 eseckler@google.com Merge "processor: Resolve descriptor track names during tokenization as well" am: 688107ba9c 2020-05-01 simonmacm@google.com Merge "Add support for initial_display_state to the trace processor." am: acd39194f6 2020-04-30 skyostil@google.com Revert "ui: Show process and thread track names as track labels" am: c30e8d978e 2020-04-30 lalitm@google.com Merge "tp: move parsing of systeminfo from parse to tokenization" am: 95ba1d3b61 2020-04-30 ddrone@google.com processor: Iterate over fields using reflection am: 31bc1bcd77 2020-04-29 treehugger-gerrit@google.com Merge "Optimise read time_in_state" am: f22f52ee0c 2020-04-29 treehugger-gerrit@google.com Merge "Add METADATA to perfetto: Apache2=NOTICE" am: 17f1cedaee 2020-04-29 eseckler@google.com client lib: Add a DCHECK to ThreadTracks for tid != 0 am: 311b3607cf 2020-04-29 lalitm@google.com Merge "Enable GN to specify gcc toolchain prefix for Clang" am: 399c0c13ae 2020-04-29 hjd@google.com Bazel: Add Java target for merged config proto attempt 2 am: 41fb1813c0 2020-04-29 skyostil@google.com Merge "ui: Show process and thread track names as track labels" am: faa4bacb4a 2020-04-29 skyostil@google.com Merge "trace_processor: Add a helper for finding Chrome processes and threads" am: 9aa35e26a0 2020-04-28 nuskos@google.com Merge "Add the new gesture_scroll_id field so its in the proto ready for use." am: 97a467a3b1 2020-04-28 hjd@google.com Merge "Bazel: Add Java target for merged config proto" am: f9dd9aeba5 2020-04-28 fmayer@google.com Improve version detection. am: 9a90474af8 2020-04-28 hjd@google.com Merge "traced: Allow statsd more concurrent sessions" am: c18e4b0b7d 2020-04-28 fmayer@google.com Fix heap_profile script for Q. am: 4fc5993abc 2020-04-28 fmayer@google.com Fix heap_profile for Python 3. am: 0bc3252f09 2020-04-28 fmayer@google.com Roll trace_to_text in heap_profile. am: 6cfdbbee2f 2020-04-28 fmayer@google.com Fix heap_profile for Python 3.x. am: 1e6581c46c 2020-04-28 treehugger-gerrit@google.com Merge "gn: Disable new GCC redundant move warning" am: 0df72fe5d2 2020-04-28 eseckler@google.com processor: Fix a potential use-after-free am: 03fcfdd74f 2020-04-28 ddrone@google.com processor: Migrate LegacyIpc to reflection-based parsing am: bed1eba707 2020-04-27 taylori@google.com Merge "perfetto-ui: Show incomplete slice" am: 8a1fbea369 2020-04-27 fmayer@google.com Fix missing space in heap_profile. am: 2fcb7dd0d2 2020-04-27 eseckler@google.com processor: Fix another clusterfuzz-found recursion bug in Track parsing am: e5a041472e 2020-04-24 fmayer@google.com Merge "Document when config options were introduced." am: 713f4f709e 2020-04-24 fmayer@google.com Merge "Autodetect vfork in heapprofd client." am: a52f61f060 2020-04-24 taylori@google.com Merge "Add binder transactions" am: a7534f07e8 2020-04-23 eseckler@google.com Merge "processor: Migrate more TrackEvent arguments to reflection-based parsing" am: bb30100372 2020-04-23 eseckler@google.com Merge "processor: Fix 3 clusterfuzz-found issues related to TrackEvent parsing" am: 2e25f7759d 2020-04-23 ilkos@google.com Merge "Add ion_stat to config muxer for memory" am: 1a7e508fcb 2020-04-23 hjd@google.com Merge "trace_processor: Fix broken commit" am: 7fc3674638 2020-04-23 treehugger-gerrit@google.com Merge "Make github happy with LICENSE" am: 34c40d6680 2020-04-23 treehugger-gerrit@google.com Merge "trace_processor: Parse processDump" am: 595075bda5 2020-04-23 taylori@google.com Merge "perfetto-ui: Fix selection of slice after thread" am: 01d51c4910 2020-04-23 treehugger-gerrit@google.com Merge "Fix for building with msvc2019" am: f4d974874d 2020-04-22 treehugger-gerrit@google.com Merge "Add support for Netflix and maps HSC app latency metrics." am: 1817325ff1 2020-04-22 treehugger-gerrit@google.com Merge "Parse ion_stat metric" am: 303f8107a8 2020-04-22 treehugger-gerrit@google.com Merge "startup tracing: Remove old StartupTraceWriter/Registry code." am: 70f6444d36 2020-04-22 nuskos@google.com Merge "Add new steps which I will add in http://crrev/c/2149329." am: 4ed3b272d9 2020-04-21 rslawik@google.com Merge "Thread time_in_state metric" am: 9c7b4453b1 2020-04-21 fmayer@google.com Clarify incident_report_config error. am: 09aea59a8d 2020-04-21 treehugger-gerrit@google.com Merge "tp: add core and core_type breakdowns per process in CPU metric" am: e30b9d8093 2020-04-21 fmayer@google.com Add --disable-fork-teardown to script. am: f9cd853172 2020-04-21 fmayer@google.com Merge "Allow to disable tearing down profiling sessions in forks." am: 9c32b4f6f1 2020-04-20 primiano@google.com Docs: minor nits and fixes to links am: dfa48135f2 2020-04-20 fmayer@google.com Add heapprofd design documents. am: 885e60247b 2020-04-20 fmayer@google.com Fix next id in HeapprofdConfig. am: a0481ae89c 2020-04-20 skyostil@google.com base: GCC 7.1 compatibility fix am: f059df7a43 2020-04-17 oysteine@google.com Merge "Pass process_priority from the StreamingProfile packets through to the JSON output" am: 34b3e095ff 2020-04-17 simonmacm@google.com Merge "Add a probe to read the display state at the start of a trace" am: a5ce9072b6 2020-04-17 treehugger-gerrit@google.com Merge "Extract basic counters from thread time in state" am: 6da120098f 2020-04-17 treehugger-gerrit@google.com Merge "Merged proto: Add TracingServiceState to merged protos" am: 307b31ea2a 2020-04-17 fmayer@google.com Improve symbolization docs. am: 33e721b210 2020-04-17 treehugger-gerrit@google.com Merge "IPC: Add Sync() method to synchronize Producer and Service" am: 83299d98cf 2020-04-16 gijosh@google.com Fix bazel build win: Correct which isspace override is used am: 0aa745498c 2020-04-16 hjd@google.com ui: Fix map/parseInt bug am: 9bd480acdc 2020-04-16 hjd@google.com Merge "Combine async slices in a single track" am: b8504919f0 2020-04-16 lalitm@google.com tp: add parent slice id to slice table am: 7027d3e67c 2020-04-16 lalitm@google.com Merge "tp: refactor shell main into multiple functions" am: 9036394cfe 2020-04-16 lalitm@google.com tp: don't associate to any process for sde_tracing_mark_write events am: 0ca2cb40b8 2020-04-16 lalitm@google.com Merge "tp: add EXTRACT_ARG function" am: b9fd7bacae 2020-04-16 lalitm@google.com Merge "Revert "tp: ensure that sde_tracing_mark_write tgid is always set to be kthreadd"" am: bb63adbd88 2020-04-16 taylori@google.com perfetto-ui: Fix time slider am: d67b97dfba 2020-04-15 fmayer@google.com Merge "Protect CPU watchdog against short reads." am: 51591a5400 2020-04-15 fmayer@google.com Merge "Add heapprofd CPU guardrail." am: 3aa13c1f8b 2020-04-15 fmayer@google.com Merge "Keep cache of abspc -> Frame in HeapTracker." am: 08c61b0e5b 2020-04-15 ilkos@google.com Merge "Incorporate oom victims in the lmk metric" am: b9ebe01702 2020-04-15 skyostil@google.com TrackEvent: Detect incorrect use of dynamic event names am: 9ac89e3e18 2020-04-15 lalitm@google.com tp: move module code to importers am: 60af4efbe0 2020-04-15 lalitm@google.com tp: add importers build file and create common target am: ccdcbae1f8 2020-04-15 lalitm@google.com Merge "tp: move util related sources to util build file" am: 981e02e545 2020-04-15 lalitm@google.com Merge "tp: move descriptor pool, proto conv and status macros -> util" am: 43d2980102 2020-04-15 fmayer@google.com Merge "Move /proc/self/stat parser to function." am: 7e00aba7ef 2020-04-15 lalitm@google.com Merge "tp: move event, clock, hprofile and slice trackers -> importers/common" am: 87765272e2 2020-04-15 lalitm@google.com Merge "tp: move metadata, perf sample and stack trackers to improters/proto" am: 56785a58b0 2020-04-15 lalitm@google.com Merge "tp: move remaining custom sqlite tables to sqlite/" am: 15b573d565 2020-04-15 ilkos@google.com Merge "Parse OOM reaper kills" am: 46472ecae9 2020-04-15 lalitm@google.com Merge changes Ice9239a7,I92fe8218,I2df6401e am: 2cc24537de 2020-04-15 fmayer@google.com Merge "Allow to specify output dir for heap_profile." am: 989704b090 2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: optional periodic unwinder cache clearing" am: 879966bb1d 2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: support incremental state clears" am: 9bc3b4a5bd 2020-04-15 hjd@google.com Merge "trace_processor: Update ExtendWithColumn to use SharedPtr" am: aa333ac798 2020-04-14 simonmacm@google.com Merge "Add some aggregate values about screen to the battery metrics." am: 8ab5356c19 2020-04-14 primiano@google.com Merge "Tracing protocol: chunk QueryServiceStateResponse" am: 95e8d00d85 2020-04-14 fmayer@google.com Merge "Use package name for deobfuscation." am: 38cf748e7a 2020-04-14 lalitm@google.com Merge "tp: move context to types" am: 7ffdd7ccaf 2020-04-14 treehugger-gerrit@google.com Merge "Fix bazel build win: make Subprocess os-conditional via #if" am: 7a546523f7 2020-04-14 treehugger-gerrit@google.com Merge "perfetto-ui: Fix thread state CPU" am: 6ca7a1bee1 2020-04-14 treehugger-gerrit@google.com Merge "perfetto-ui: Fix bug with record page layout" am: 2f378cc2b8 2020-04-10 lalitm@google.com Merge "Fix max trace_bounds" am: e143286941 2020-04-10 delphij@google.com DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master 2020-04-09 treehugger-gerrit@google.com Merge "tp: move and rename ftrace_utils -> types/task_state" am: 50f449b1df 2020-04-09 treehugger-gerrit@google.com Merge "Rename smaps table to profiler_smaps." am: 99ccc17596 2020-04-09 simonmacm@google.com Add trace_trigger field to trace_metadata. am: aad6472eff 2020-04-09 fmayer@google.com Ingest smaps into trace processor. am: 5a992d9cae 2020-04-09 primiano@google.com Merge "service: allow to specify a file path with write_into_file" am: f3ae9d6b5d 2020-04-09 treehugger-gerrit@google.com Merge "TraceProcessor: ingest TracingServiceEvent.all_data_sources_started" am: 4ad5244495 2020-04-08 rsavitski@google.com fix typo in get.perfetto.dev am: d03fd291f3 2020-04-08 primiano@google.com Merge "GN: enable PIE on Linux" am: 905be785ca 2020-04-08 primiano@google.com Docs: improve comments on builtin data sources am: 53ab0a3c41 2020-04-08 treehugger-gerrit@google.com Merge "CPU frequency indexing function" am: 7bc4b7d0e3 2020-04-08 fmayer@google.com Add new table for heap_graph_class. am: 22588ad895 2020-04-08 lalitm@google.com Merge "tp: add proto for hsc startup metrics" am: 01889c8415 2020-04-08 fmayer@google.com Merge "Create proper table for packages list." am: 75024d7571 2020-04-08 treehugger-gerrit@google.com Merge "perfetto-ui: Fix rounding of merged slice percents" am: 00e6685b05 2020-04-08 lalitm@google.com Merge "tp: add documentation for trace analysis feature" am: df072ec618 2020-04-08 treehugger-gerrit@google.com Merge "base: round two of trying to fix vs2019" am: 6dfb871512 2020-04-08 treehugger-gerrit@google.com Merge "TrackEvent: Fix compatibility issues with Clang 11 on macOS" am: d62d1b0e4c 2020-04-08 lalitm@google.com Merge "tp: fix inconsistency of base::optional<StringId> column API" am: 2f8c6de879 2020-04-08 primiano@google.com service: Emit a marker when all data source started am: 79e4dcbd69 2020-04-08 primiano@google.com tools/gen_merged_proto: automatically traverse all imports am: c98edc4233 2020-04-07 treehugger-gerrit@google.com Merge "base: attempt to fix compile on vs2019" am: 4c8ff7ce1c 2020-04-07 taylori@google.com Merge "Revert "perfetto-ui: Change request track data"" am: 001483d0c1 2020-04-07 treehugger-gerrit@google.com Merge "Remove vts10 tests from vts suite" am: 338be66449 2020-04-07 treehugger-gerrit@google.com Merge "Read /proc/tid/time_in_state" am: 124f03b3f6 2020-04-07 lalitm@google.com tp: implement describe_event dynamic table am: 97d7d4772d 2020-04-07 ilkos@google.com Add oom mark victim event am: 3b13db5446 2020-04-07 lalitm@google.com Merge "tp: ensure that binder transaction ids are always positive in systrace" am: 619ae912ea 2020-04-07 ddrone@google.com Merge "Support process association for global tracks" am: 177d32254e 2020-04-06 lalitm@google.com tp: add support for annotations am: 91aecef3b3 2020-04-06 lalitm@google.com Merge "tp: fix compile on builds with zlib disabled" am: 430f07b534 2020-04-06 lalitm@google.com Merge "tp: ensure that sde_tracing_mark_write tgid is always set to be kthreadd" am: 67db98f337 2020-04-06 ddrone@google.com Merge "Add Track::Global constructor" am: b726d1c21a 2020-04-06 skyostil@google.com Introduce PERFETTO_COMPONENT_EXPORT macro am: bf277d6ad9 2020-04-06 fmayer@google.com Merge changes Ib6e9fa46,I0ee87597,I331a7375 am: 2b61b4444b 2020-04-06 eseckler@google.com Merge "track event: Import legacy thread time/instructions as counters" am: 9b8c6fc521 2020-04-06 treehugger-gerrit@google.com Merge "Client API: Gracefully fail data source registration" am: c90c562668 2020-04-06 primiano@google.com Merge "GN: fix chromium roll." am: 396c6f4d63 2020-04-06 ilkos@google.com Handle absence of profile type am: 32d653592e 2020-04-06 taylori@google.com Merge "perfetto-ui: Change request track data" am: 07ad2a7889 2020-04-04 treehugger-gerrit@google.com Merge "Clean up build files" am: 0b5025034a 2020-04-03 joelaf@google.com Merge "Use protobuf from the system if requested" am: fdcaceef03 2020-04-03 rsavitski@google.com Merge "perfetto_cmd: if unique session is given, set comm to "p-session_name"" am: d49a958f8f 2020-04-03 treehugger-gerrit@google.com Merge "Move Frame Events to a separate table and add frame stats table" am: 7803f6a504 2020-04-03 rslawik@google.com Merge "Create linux.system_info probe reporting CpuInfo" am: 79679990ff 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration (part 2). am: 3896bf19ac 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration. am: e18b6f87b5 2020-04-03 primiano@google.com Service: Add QueryCapabilities method am: f5a94cc683 2020-04-03 primiano@google.com Add ObservableEvent to wait for all data source started am: b5109d9f96 2020-04-02 treehugger-gerrit@google.com Merge "trace-processor stat for data source guardrail." am: 2da86adf0f 2020-04-02 treehugger-gerrit@google.com Merge "Poll heapprofd memory and add guardrails." am: c841f17924 2020-04-02 treehugger-gerrit@google.com Merge "tp: Add missing cmath include needed for std::isnan." am: 0129e7eaeb 2020-04-02 lalitm@google.com Merge "tp: fix returning utid of freed thread in rss stat event" am: 96e1488819 2020-04-02 ilkos@google.com Anonymous memory predicate for profilers am: 586f781bd7 2020-04-02 hjd@google.com Merge "trace_processor: Safer method for casting TypedColumn to Column" am: 338f5dcaf7 2020-04-02 fmayer@google.com Merge "Use UUID for profile files." am: 24b6698498 2020-04-02 fmayer@google.com Merge "Store callstacks bottom up in CallstackTrie." am: c790e19e3c 2020-04-02 treehugger-gerrit@google.com Merge "arbiter: Fix potential crashes during writer unregistration" am: 4e0750ed75 2020-04-01 dproy@google.com Merge "[perfetto-ui] Navigate to slice when clicked from Query Table" am: 5bae2e6212 2020-04-01 cfijalkovich@google.com Merge "Add the mm_event trace event to Perfetto ftrace config" am: 822963b8b8 2020-04-01 fmayer@google.com Merge "Try to connect to central heapprofd on user." am: 77cb6e24f1 2020-03-31 lalitm@google.com tp: improve diff testing script when tp returns error retcode am: b6fd42ad9a 2020-03-31 treehugger-gerrit@google.com Merge "tp: fix memory leak of table objects" am: eaf980288e 2020-03-31 fmayer@google.com Merge "Check for build type, not debuggable, for extra guardrails test." am: 937cfa8b7e 2020-03-31 treehugger-gerrit@google.com Merge "tp: fix import of systrace files with trailing newlines" am: 41867229fb 2020-03-31 rsavitski@google.com Merge "Ban PERFETTO_EINTR(close(...)), which is actively incorrect" am: bc44331c33 2020-03-31 lalitm@google.com perfetto: update trace processor and traceconv shas am: a65fa05549 2020-03-30 treehugger-gerrit@google.com Merge "TrackEvent: Add entry point for track+timestamp+lambda" am: de6d9fd442 2020-03-30 eseckler@google.com chromium: Fix reference to license file. am: e7603d3ab8 2020-03-27 treehugger-gerrit@google.com Merge "tp: add android_appid to process table" am: d1dae2a336 2020-03-27 treehugger-gerrit@google.com Merge "traced_perf: mallopt(M_PURGE) when going quiescent" am: dd82c211fc 2020-03-27 treehugger-gerrit@google.com Merge "Use random session name in HeapprofdJavaCtsTest." am: 4502a63609 2020-03-27 treehugger-gerrit@google.com Merge "arbiter: Support aborting a startup tracing session." am: 4243010e6c 2020-03-27 eseckler@google.com shmem: Release writer ID when destroying a pending startup writer am: dc2d0e8928 2020-03-27 treehugger-gerrit@google.com Merge "client API: Add missing PERFETTO_EXPORT definitions" am: 42f548873c 2020-03-27 treehugger-gerrit@google.com Merge "profilers: treat unset and =0 persist props the same" am: 359bccd619 2020-03-27 ilkos@google.com Merge "Improve the heap graphs ui" am: 7e40936b1d 2020-03-27 treehugger-gerrit@google.com Merge "Added tracking metric to see whether duplicate frames where logged" am: 123c8191bc 2020-03-26 treehugger-gerrit@google.com Merge "Remove redundant NOTICE copied from LICENSE." am: edcb5301a0 2020-03-26 treehugger-gerrit@google.com Merge "tracing_service_impl: Add support for producer name regex filtering" am: 658779b63e 2020-03-25 treehugger-gerrit@google.com Merge "Include progname in malloc hook logs." am: 21a3f16268 2020-03-25 treehugger-gerrit@google.com Merge "Acknowledge flushes / stop with unknown data sources." am: c52057f5e7 2020-03-25 hjd@google.com Merge "Add missing function prototype" am: 4504b6a428 2020-03-24 treehugger-gerrit@google.com Merge "Add vts10 suite to existing vts tests" am: 3685fb977e 2020-03-24 taylori@google.com Merge "perfetto-ui: Fix aggregation of CPU tracks" am: 4e09751d83 2020-03-24 lalitm@google.com Merge "Add #include <stdint.h> in include/perfetto/base/task_runner.h" am: 27948b2c03 2020-03-24 lalitm@google.com Merge "trace_processor: rewrite raw table to systrace conversion code" am: c4327a7bee 2020-03-24 treehugger-gerrit@google.com Merge "traced_perf: make the daemon lazy (i.e. started on-demand)" am: b2da82cd7d 2020-03-24 lalitm@google.com Merge "tp: stop including shell in dist and remove noop stripping" am: 3ed8f6583d 2020-03-24 hjd@google.com Merge "perfetto-ui: Fix async slice bug" am: 7cb3e59f4a 2020-03-24 eseckler@google.com processor: Destroy GlobalArgsTracker after other trackers am: c638bb98df 2020-03-24 treehugger-gerrit@google.com Merge "traced_perf: delay proc-fd signal by 50ms; best-effort execve race mitigation" am: 643201ce76 2020-03-23 primiano@google.com Fix Chromium roll Win+Fuchsia am: 82dd375715 2020-03-23 fmayer@google.com Merge "Ingest location for dex / apk / jar for classes." am: 994e010eee 2020-03-23 treehugger-gerrit@google.com Merge "subprocess: Fix unused result warning in unit test" am: 4c61e7cdbb 2020-03-23 treehugger-gerrit@google.com Merge "Add /proc/<pid>/smaps parser." am: 20a8369cdc 2020-03-23 taylori@google.com Merge "perfetto-ui: Always show CPU slice" am: a0fff9e8f5 2020-03-23 taylori@google.com Merge "perfetto-ui: Fix record page scrolling" am: 5f25b89ba2 2020-03-23 lalitm@google.com Merge "perfetto: add script to strip binary in Android tree" am: fa1d600d79 2020-03-22 taylori@google.com Merge "perfetto-ui: Fix file bug link" am: 8fc58eab4b 2020-03-20 lalitm@google.com tp: allow semi-colon to delimit queries in query files am: 7e2d2d3b19 2020-03-20 skyostil@google.com Merge "TrackEvent: Add more documentation for app instrumentation" am: eb69d4ba14 2020-03-19 primiano@google.com Fix Win+Nacl builds am: a748cf2e47 2020-03-19 primiano@google.com Merge "test: fix GetCurExecutableDir() on Mac" am: 8c11b7370b 2020-03-19 delphij@google.com DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master 2020-03-18 taylori@google.com Merge "ui: Fix showing details for slices where ts = 0" am: 89b43b4ed3 2020-03-18 primiano@google.com Merge changes Ibc7838ee,I3deb0245 am: b9d20d1578 2020-03-18 rsavitski@google.com Merge "traced_perf: metatrace: encode PID that is being unwound as a "counter"" am: 9c5454eb96 2020-03-18 rsavitski@google.com Merge "traced_perf: fix unnecessarily retained heap allocations" am: 04a5efa0a9 2020-03-18 treehugger-gerrit@google.com Merge "tp: strip all info from release android trace processor" am: 4cde817769 2020-03-18 lalitm@google.com tp: ingest args from json events am: 8561f1e807 2020-03-18 taylori@google.com perfetto-ui: Color summarized userspace slices am: 33e164438f 2020-03-17 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: strip trace processor on Android builds" am: e8ce957aec 2020-03-16 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "metrics: add ms duration to all slices" am: 005f42a834 2020-03-16 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "traced_perf: move proc-fd timeout into config, default back to 100ms" am: 8adef0fc13 2020-03-16 android-build-automerger-merge-worker@system.gserviceaccount.com Add brief instructions on IDE setup am: 27657d9727 2020-03-16 android-build-automerger-merge-worker@system.gserviceaccount.com ui: Fix thread state am: 29de50e4d8 2020-03-14 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: refactor JSON code to remove ifdefs, consolidate ingestion into args" am: 7146ea83c0 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "ui: Use track name helper for thread tracks" am: acd3faab76 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "ui: Fix percentage in thread state label" am: a705454203 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Revert^2 "Assert extra_guardrails fails on user."" am: 537e300a74 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "ui: switch process summary tracks to use track_ids" am: 658be97b19 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "docs: Add documentation for recording traces programmatically" am: bf60f5996d 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com ui: Use experimental_counter_dur am: 993ea78dcd 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: add API for decompressing compressed trace packets" am: c9ba12998f 2020-03-13 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Change time_ns to time_us" am: 3df19adcc3 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "heap profilers: reject data sources with unparsable cmdlines in cfgs" am: 8afa26ab1b 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge changes from topic "revert-1253625-heapprofd-e-guardrails-OWLWSAIJHO" am: 2b934d3bb5 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "api: fix compile on mac" am: 25016e3eb5 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "traced_perf: make read period configurable" am: 621f40b7a1 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Assert extra_guardrails fails on user." am: 0c63cc1fc9 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Move enable_extra_guardrails handling to client." am: 6db1249491 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "perfetto-ui: Use gradient to show all colors within a summarized slice." am: a2c6f7fefb 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "trace_processor: Small fixes for owned columns" am: d440ec6a0a 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Link against sqlite_dev library in Chromium" am: 558bf8e400 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "ui: Rename heap_profiler data source icon to match other icons" am: 9699c560e2 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Docs: fix long-traces.md (2) am: a31b0a0fbc 2020-03-12 android-build-automerger-merge-worker@system.gserviceaccount.com Docs: fix long-traces.md am: de29e8343a 2020-03-11 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "docs: Add initial documentation for the Client API" am: 79bf811d23 2020-03-11 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "perfetto-ui: Sort on aggregation columns" am: c095a02a0e 2020-03-11 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "traced_perf: avoid aligning concurrent ReadTick tasks" am: 05d1567943 2020-03-11 android-build-automerger-merge-worker@system.gserviceaccount.com Merge changes I0cbe7c90,I6e4a3344 am: 029aa0d6eb 2020-03-10 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "processor: Support TrackEvent counters in importer" am: ccdbaf215f 2020-03-10 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: fix dynamic table lifetime scoping" am: 82e00fd235 2020-03-10 android-build-automerger-merge-worker@system.gserviceaccount.com Merge changes I34fe91e2,Ia93e6d60 am: 3ddc82494f 2020-03-10 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "processor: TrackEvent: Don't log success statuses as errors :)" am: cf1690fbf6 2020-03-10 android-build-automerger-merge-worker@system.gserviceaccount.com probes: cleanup handling of ProbesDataSource am: 2663ead23f 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "record_page: include two missing Android log buffer options" am: da72053797 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "traced_perf: allow slow proc-fd lookups to recover from expired state" am: d203762b93 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge changes I3010621d,I4f59d1b4 am: 5ed3202f4a 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "traced_perf: unwind queue type" am: f3ae26fcb6 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "perfetto-ui: Handle resolution is Infinity" am: 0955f61c6e 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Fix joining at the boundary" am: 0bb7e211f5 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Add task names metric" am: 9424f59401 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "trace_processor: Pass track_id constraint to generator" am: bd8651ad84 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com ObservableEvents: use the enum defined in the proto am: 1234c8aa62 2020-03-09 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Remove single dangling _COMPONENT suffix" am: b0a8b6693f 2020-03-08 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "heapprofd: mitigate potential data race during UnwindingWorker destruction" am: 3f3ca3d9d2 2020-03-08 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "processor: Refactor TrackEventParser" am: 454474d4f3 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "probes: Make the type id less error prone" am: ea6e1f04de 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "perfetto-ui: Don't throw an error for user queries" am: 6b79fee5ae 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: refactor systrace serialization code in raw table" am: 88d9224c53 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com metrics: make null values passed to repeated fields more obvious am: 0b1579a826 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "tp: add support for parsing systemTraceEvents from JSON traces" am: e9030e1f5b 2020-03-06 android-build-automerger-merge-worker@system.gserviceaccount.com Adds a LAST_NON_NULL window function to the trace processor. am: 7e47609cf2 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Reusing one ProtoToArgsTable instance" am: 0c6dfdbceb 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "perfetto-ui: Fix counter quantization" am: f365c53a18 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Add anon RSS + swap to the java heap stats metric am: 7c0409aa38 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Add AndroidProcessMetadata to startup metrics" am: d1f53320a0 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Add more fields to ChromeLatencyInfo" am: 652ee37df0 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "TrackEvent: Add TrackEvent::GetTraceTimeNs()" am: b583290a6d 2020-03-05 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "UI: restrict non-ready features to internal users only" am: da7fe17f81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:151763422 Tbr: perfetto-bugs@google.com Change-Id: Iaeab1f199e707b93135492a6948dcce51bd24e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773814}
-
Adrienne Walker authored
Special storage policy is a dynamic, complicated, browser-only data structure that IndexedDB needs to query on shutdown to determine whether or not to delete particular session-only directories (or not delete protected directories). Because shutdown is time-sensitive, this chooses to push updates to policies based on active origins (i.e. origins that IDBFactories have been created for). This is the IndexedDB equivalent of this local storage change: https://chromium-review.googlesource.com/c/chromium/src/+/1945940 This is a reland (with better thread safety) of: https://chromium-review.googlesource.com/c/chromium/src/+/2203146 Bug: 1015214 Change-Id: I1d62d5ed93e45a33a85d0935ad7f211428283fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216806Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#773813}
-
Dominique Fauteux-Chapleau authored
This parametrizes tests so they run with both the legacy policies and new Connectors policies used to control deep scanning. The content of the tests does not change since both sets of policies should behave the same with corresponding settings. Bug: 1076083 Change-Id: I0f23b0cf4f6367fc031eed874cc80aa679d9964f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225121Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#773812}
-
Nate Chapin authored
Change-Id: I770dded68d2ff6de14897b5a1666f5931fcfc450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224830 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773811}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: For pointers (address values), use nullptr, as this provides type-safety. Additionally, NULL won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. Bug: 1080832 Change-Id: I70f899fe45a31d55f98063585180686d2a256141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217946 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773810}
-
deepak1556 authored
NTLM always defaults to NTLM v2 at the //net layer for quite sometime now https://crbug.com/22532. Change-Id: I4ea2dedc10c63a7c4e00101c0acc6d8a713c5054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222116 Auto-Submit: Deepak Mohan <hop2deep@gmail.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773809}
-
Peter Wen authored
Lint is no longer using resource_utils. Bug: None Change-Id: I298cab0e956c9433434ce5fc8f70df875f59df99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225500 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773808}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/378bd113c2c0..9482d3f25987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com,tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nsatragno@google.com,tguilbert@google.com Change-Id: Icddace2ab8f788e4a6d9373e23cf08934cbdd7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225299Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773807}
-