- 17 Sep, 2020 40 commits
-
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/a5c338388099..f555d99a084c $ git log a5c338388..f555d99a0 --date=short --no-merges --format='%ad %ae %s' 2020-09-17 wub In QUIC BBRv2, use inflight byte after congestion event to detect queuing during PROBE_UP. 2020-09-16 nharper Remove pure virtual methods from TlsHandshaker 2020-09-16 bnc Abort async QPACK header decompression when stream is closed. 2020-09-16 nharper Remove TlsHandshakerTest 2020-09-16 fayang Don't arm PTO for ApplicationData until handshake confirmed. 2020-09-16 danzh gfe-relnote: fix QUICHE compilation issues with gcc. 2020-09-16 quiche-dev Reduce noisy log message to VLOG rather than LOG(INFO). 2020-09-16 fayang Internal QUICHE change 2020-09-16 haoyuewang Add a kAFFE client option to enable the usage of AckFrequencyFrame, including (1) Send min_ack_delay from client. (2) Update client upon receiving AckFrequencyFrame. 2020-09-16 fayang Cap client suggested initial RTT to 1s instead of 15s. 2020-09-16 vasilvv Replace QuicheContainsKey with a direct call to find() 2020-09-15 fayang Remove processed packets from undecryptable_packets_. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I25468415faab7c444eb100672c590dc49c761da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417111Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808127}
-
Kyle Horimoto authored
This is the PendingConnectionRequest implementation for Nearby connections in the initiator role. A follow-up CL instantiates requests of this type in PendingConnectionManagerImpl. This CL also adds a new mojom::ConnectionAttemptFailureReason value for Nearby-related connection errors. Bug: 1106937 Change-Id: I6090c0b4b49338f5b15d64ad2cdc5bcc5abfd65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415669 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#808126}
-
Rakib M. Hasan authored
Adding this builder to the builders.json file will allow the expectations updater tools to trigger the builder and get test results and baselines from the builder. Follow up to crrev.com/c/2414844. Bug: 1050760 Change-Id: I9c66fa24f337cf57e247d8fbe4a18d49d9a77b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415531 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#808125}
-
David Bertoni authored
Bug: 1093066 Change-Id: I8298635bd7f1717c29f020a6901a362f72c7d9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404943 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808124}
-
yiyix authored
Bug: 1077148 Change-Id: I5277771e81400ea9bdbd7569ee565865e8f7fcdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416262 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808123}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3aa9c6b66aa..e1e4781e5ec2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112956,chromium:1120093,chromium:1124799 Tbr: collinbaker@google.com Change-Id: If696701fb428e1c926823e95762424e9fe018241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417310Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808122}
-
Sky Malice authored
This approach is a short term work around to keep UMA disabled when CCT FRE is skipped due to policy. On FRE load, this pref is set to true (the default), with the expectation that it will be overridden when the user accepts the ToS. However, when the FRE is skipped, the user never accepts the ToS, and the default/incorrect value is persisted. Note that this pref is not the main signal that UMA metrics should be reported, but it is read by a non-zero number of locations. And it seems best to keep this pref in sync with what it should hold. The long term fix will be to remove the default being written to prefs, but doing this would be more risky, and not as suitable for a late merge. See bug for more details. Bug: 1128955 Change-Id: I28b9ab0aeb1e86de9cad5f73b6a2650d9c34aa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416885Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#808121}
-
Mohamed Amir Yosef authored
... GetAccountPasswordStore() Bug: 1119286 Change-Id: I4b81e4d32c61c6487f0787a3d6e4821c9282bef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416379 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#808120}
-
Kyle Horimoto authored
This function was missing from the original TetherController interface; it is needed so that when a connection is active, the UI can trigger a disconnection. Bug: 1106937 Change-Id: I59454f13aabbeec493f2cb73f4f8e1a7e85b15ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417313 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808119}
-
Ovidio Henriquez authored
This change adds the RequestDeviceOptions.optionalManufacturerData property in order to enable manufacturer data to be protected behind this permission. This change also enforces the filtering of service and manufacturer data from BluetoothAdvertisingEvent objects if services and manufacturer codes are not included in the filters, optionalServices, and optionalManufacturerData fields of the RequestDeviceOptions object. Bug: 1108958 Change-Id: Id7f546e3be5b3c3c26538a69f810a33d2a446fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389243 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808118}
-
Kalvin Lee authored
This change modifies all call sites in PPD metadata parsing functions to only check that ParseJsonAndUnnestKey() returns something that is not base::nullopt. ParseJsonAndUnnestKey() already returns nullopt instead of any empty container, so there's no need to double-check that the base::Value is not empty. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: I057b6aab97dc6cc2477488a0238ecced726d06a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378403 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808117}
-
zhaoyangli authored
These tests started failing in try jobs or LED jobs in Xcode 12 GM roll CL (upstream: crrev/c/2411403, downstream: crrev/i/3274047). Bug: 1129588, 1129589 Change-Id: Ib18c0cb05c234d2cfb58ad3c59a9af44861dfc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416754 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#808116}
-
Dominic Mazzoni authored
This is a speculative fix. If WebContentsAccessibilityAndroid ever had a bad pointer to its root BrowserAccessibilityManager, that could definitely cause the sorts of crashes we've been seeing. Rather than keeping a copy of a raw pointer, just have WebContentsAccessibilityAndroid retrieve the root BrowserAccessibilityManager when needed. Also ensures that if GetRootBrowserAccessibilityManager is null, any function called from Java returns an error immediately, as that could also potentially be a source of bugs. Bug: 1126657 Change-Id: I52040a71c21ba4a8f5f30b316082c8b1e7efbb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415928Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808115}
-
btolsch authored
This change adds the ability to forward proto_in_dir to support downstream use of nested directories for grpc protobufs. Bug: 1129637 Change-Id: I0221d7b1a28aa578c8f3f33cd93b6d07879c54f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416568 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808114}
-
Joel Hockey authored
Bug: 1129266 Change-Id: Icb27b527607e42b7ec0eb6ea22a093b2a73968a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415808Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#808113}
-
David Tseng authored
R=akihiroota@chromium.org Fixed: 1098914 AX-Relnotes: ChromeVox will not move its focus indicator when adjusting the volume using hardware keys. Change-Id: I6d64fb39dd63bab76630b667ba37ea5d96a02c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416751 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#808112}
-
Nidhi Jaju authored
As the check is no longer needed, it can be removed from the codebase. Bug: N/A Change-Id: Ic655e0092bbe34592b2b5179c2debdf80ef590cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414312Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#808111}
-
Daniel Classon authored
Adds an override to the focus() function for the multidevice feature item so that the feature controller is focused when the item is focused. Helps with adding deep links to the multidevice page. Bug: 1084154 Change-Id: I9a5c382ccf5b5d6c6f6315bd4da200949e7b2c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417142Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#808110}
-
Kyle Horimoto authored
This class implements ConnectionAttempt for the Nearby medium in the initiator role. A follow-up CL will create instances of this class within PendingConnectionManagerImpl. Bug: 1106937 Change-Id: I796fb982ad935c36d7cd3e569a0ba7aad407553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415688 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#808109}
-
Regan Hsu authored
* Remove the two optionals BrowserTabMetadata from BrowserTabsModel. * Adds sorted vector of BrowserTabMetadata to BrowserTabsModel, from most recently visited to least recently visited browser tabs. * Modifies chrome://multidevice-internals to accommodate. https://screenshot.googleplex.com/ASLmNrodybKchY6 https://screenshot.googleplex.com/5CyAkSuWD5wXM9g Bug: 1106937 Change-Id: I5bc898b12db304491cec8091c51a2bf7b1c2ad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415537 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808108}
-
Pavol Marko authored
Mark key pairs generated in certificate provisioning for Chrome OS as corporate. Bug: 1127506 Test: unit_tests, browser_tests Change-Id: I5379f4b186283d076b2b6f02baf1323f174ea543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404832 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808107}
-
Yuwei Huang authored
For authenticated requests, ProtobufHttpClient first invokes OAuthTokenGetter to get the access token, then enqueue and start the request and pass in the invalidator. But if the access token fails to fetch, ProtobufHttpClient will instead just call OnAuthFailed() without starting the request or passing in the invalidator. The previous OnAuthFailed() implementation of ProtobufHttpStreamRequest was broken, since it just called OnStreamClosed(), which assumes the invalidator_ exists and calls it. ProtobufHttpRequest OTOH seems to be intact and we have test to guard that. This CL fixes this issue on ProtobufHttpStreamRequest and add a test case for it. Bug: 1129567 Change-Id: I45d295b5a744657673568e937cf638f2013f188e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417143 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#808106}
-
Fletcher Woodruff authored
Modify lorgnette_scanner_manager to accept a base::RepeatingCallback<void(std::string)> which will be called every time a page has been successfully scanned. The completion callback has been changed to accept a boolean, indicating whether the overall scan succeeded or failed. This doesn't change the internals of lorgnette_manager_client significantly. It will be migrated to the multi-page scanning API in the next commit. Bug: b:161239919 Change-Id: I50d25fe83215cf6861d800123867f52c566bc33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404402Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#808105}
-
Brian Sheedy authored
Stops using --replace-system-package for AR/VR tests, instead opting for a new --remove-system-package + --additional-apk combination. This avoids some flaky issues associated with attempting to restore the system app after testing is done and ends up speeding tests up since fewer reboots are needed during teardown. Bug: 1120220 Change-Id: I818368114ad7f44fbac282e3b09e2e2494496f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417114 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808104}
-
Gil Dekel authored
This CL is a precursor to https://crrev.com/c/2413407 in preparation to remove all non-universal planes code paths. We add a CHECK to verify that universal planes are supported on all current ChromeOS releases and devices, and that this upcoming change will not break anything unexpectedly. Bug: 1129546 Change-Id: I03a1263161c1da4c1489c88af5f345654391c361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416937 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#808103}
-
Philip Rogers authored
This patch fixes a bug from https://crrev.com/740787 where LocalFrameView::ForAllThrottledLocalFrameViews would stop at non-throttled frames, rather than recursing into them. Change-Id: Iaaaf129fd693fc0adb546ca09ecd78a6a4002f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410526 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808102}
-
Sergey Ulanov authored
OutputPresenterFuchsia was setting image constraints for allocated buffers. As result the images were always allocated with pixel_format=R8G8B8A8 without any flags set in format_modifiers. As result, device-specific optimizations were not enabled for these buffers, so GPU was using more memory bandwidth than would be possible otherwise. This change updates OutputPresenterFuchsia to avoid setting any constraints for the buffer collection. Instead buffer collection constraints are set only through Vulkan. This ensures that the buffers are allocated with all possible optimizations supported by the Vulkan driver. Bug: 1128740 Change-Id: I7ec8f605ace86a33062d5296a1b6b2e1f647b3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414757Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808101}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e2e75b23aa67..8d7201bc3c3c 2020-09-17 gavinmak@google.com Modify git map-branches to show the number of commits on a branch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128716 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ida9d803154057a9378627cbac4bac8d6be206ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808100}
-
Kyle Horimoto authored
This is the ConnectToDeviceOperation implementation for a Nearby Connections attempt in the initiator role. A follow-up CL creates instances of this class when performing a connection attempt. Bug: 1106937 Change-Id: Ie47af35bb23d1d751de1c5833b3acdfb0768824c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415534 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#808099}
-
Kalvin Lee authored
This change follows up on feedback in https://crrev.com/c/2340571 and refactors the way in which the PpdMetadataManager builds PPD metadata paths into the Chrome OS Printing serving root. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: Ie2619526b596656a3186a708272c9e6da8ad3bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377069 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808098}
-
Garrett Beaty authored
Compile targets are copied from the recipe config in chromium/tools/build in anticipation of removing compile targets from recipe config. Bug: 1091004 Change-Id: I024d448e96bbb60d1012f944aa7418d82ed672a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415214 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#808097}
-
Ryan Hansberry authored
Plumb the 'FastAdvertisement' UUID, 0xfef3, into Nearby Connections. Its presence informs Nearby Connections to register smaller, non-connectable BLE advertisements. Manually verified that the correct UUID and advertisement contents are broadcasting, via my Pixel phone and the nRF Connect app. Note: Fast Advertisement support for scanning remains unimplemented. Support cannot be added until b/168659459 is resolved. Change-Id: Ib9160985cf4c8d1f51dbf6113b9ac376237ed035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410876 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#808096}
-
Sahel Sharify authored
Bug: 1122764 Change-Id: I3de9e23f4ac9aad71d6c8b8a52cfac852628c3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412454 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808095}
-
Akihiro Ota authored
This change: 1. Updates the expiry milestone for the annotations feature. 2. Removes the flags to disable the search the menus and language switching features, since they have been launched now for the past several milestones. Bug: N/A Change-Id: I305dd657b441a8a00402ca9163d3c49ddea691a1 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416398Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#808094}
-
ssid authored
Removes exidx wrapper from arm32 unwinds. The wrapper caused issues with unwinding crashes in official test bots, crbug/1078588. Since we are not using libunwind to unwind due to other crashes, this wrapper can be removed. BUG=1078588 Change-Id: Ifc6832345a715e75a4344f4dcdd1b570d6f0626b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330743Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#808093}
-
Robbie McElrath authored
This CL makes the page content scroll with the top controls during animations if OnlyExpandTopControlsAtPageTop() returns true. Prior to this change, animations would expand the top controls without moving the page contents, which would result in them overlapping the page, which isn't the expected behavior when OnlyExpandTopControlsAtPageTop() is set. Bug: 1127076 Change-Id: I4d6f125bae5ac39f27577d3e7aace0c93523e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404378Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#808092}
-
Haiyang Pan authored
According to the device capacity http://shortn/_b0QLWXBn0o, there should be enough devices to support 40% traffic. Bug: 1111436 Change-Id: I38ceb9b54d151bfddbc83e640c8d0f25d981aa81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417102Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#808091}
-
David Maunder authored
Currently we don't do this and it means the user can group tabs, close one of the tabs in the group and then undo the grouping. Because one of the tabs is destroyed this leads to a crash when we try to update its root id. Bug: 1117396 Change-Id: I0d91d44ce2bf8783531ccb3c959010fdf6905fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414995 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808090}
-
Frédéric Wang authored
MathML Core says special properties of operators happen when the corresponding <mo> elements contain text content only [1]. However, Blink currently just reads the element's textContent() without checking whether it contains non-text children. This CL fixes that behavior and also adds a WPT test to verify correct lspace/rspace (including after dynamic change of the <mo> content). [1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator Bug: 6606 Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#808089}
-
Kyle Horimoto authored
Issue was caused by trying to read a "phoneName" field as part of the phone status, but that field is part of another API call. This was mistakenly left in by an earlier CL. Bug: 1106937 Change-Id: Ia6b2123921955354e96115d8334b915011384ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417291 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808088}
-