- 28 Jan, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Disables failing tests on iphone-device: NTPHomeTestCase/testOmniboxPinnedWidthRotation NTPHomeTestCase/testTapFakeOmniboxScrollScrolled NTPHomeTestCase/testOmniboxWidthRotation NTPHomeTestCase/testFavicons NTPHomeTestCase/testTapOmniboxSearchButtonLogsCorrectly NTPHomeTestCase/testCollectionShortcuts NTPHomeTestCase/testTapSearchButtonFakeOmniboxScrolled NTPHomeTestCase/testOmniboxWidthRotationBehindSettings TBR=gambard@chromium.org Bug: 1046253 Change-Id: I7fd7a7b0f524ad9614f0f83fac0a4426ac28f7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023527Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735813}
-
Yoshisato Yanagisawa authored
If we rebase the path, gn seems to confuse to set paths from current working directory to have chrome/ios directory. However, it should not have that. Since XCRun path won't be sent to Goma, we do not need to normalize that here. Bug: 1015730 Change-Id: If175706ae564cbf124c53f0e0e1255b439cea682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022046 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735812}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=peter@chromium.org Bug: 1042208 Change-Id: I06cfd4c1857415875049030e7d7f5c262050a079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017525Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735811}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4025.0-1579517934-benchmark-81.0.4019.0-r1 to 81-4028.0-1580121249-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I32a7f242d2d2972185540f72489f00da3345b0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735810}
-
Yoshifumi Inoue authored
This patch Introduces |LayoutObject::BeingDestroyed()|, was |LayoutBlockFlow|, for ease of tracking life time of |LayoutObject|. Bug: 982194 Change-Id: I2203aac9a87afa61e5054f2659070b89fa5c9b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024131 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735809}
-
Colin Blundell authored
This CL cleans CaptivePortalTabHelper of its remaining //chrome dependency by passing in the CaptivePortalService from the embedder rather than obtaining it internally via the Profile. It also componentizes the class. Componentization of its unittest will be done in a followup. The motivation for this componentization is to enable the componentization of SSLErrorHandler for sharing with WebLayer. Bug: 1030692 Change-Id: Ibca11f2f3d603a411cfe03f00c26ca5be71ada33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019102 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#735808}
-
Delan Azabani authored
DeprecatedEqualIgnoringCase (“DeprecatedEqual”) returns true iff the two given strings are equal under non-Turkic case folding (full iff both strings are 16-bit, simple otherwise). DeprecatedEqual was deprecated in favour of EqualIgnoringASCIICase or EqualIgnoringUnicodeCase [1]. The former is usually the appropriate choice for web platform features that need to check for equality with a constant keyword. This CL optimistically migrates the safest subset of DeprecatedEqual calls to EqualIgnoringASCIICase: those where one of the arguments is an 8-bit literal that contains only ASCII but neither “s” nor “k”. {s,k,S,K} are the only ASCII characters whose equivalence classes would change when switching from simple non-Turkic case folding to ASCII insensitivity [2], so we shouldn’t need web platform tests. This commit in particular was generated by the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"skSK]|(?&escape))*"){0} (?<other>(?:[^(),]|(\((?:[^()]+|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*(?: (?&literal)\s*,\s*(?&other) |(?&other)\s*,\s*(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.ccls-cache/* Replace: EqualIgnoringASCIICase$5 [1] https://codereview.chromium.org/2811793004/patch/1/10109 [2] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt Bug: 627682 Change-Id: I6ee08a9378c782a91ce616362a91a7e0c64c989b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015875 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735807}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/086aded3cb74..43c070193ede git log 086aded3cb74..43c070193ede --date=short --first-parent --format='%ad %ae %s' 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 748ad200897b..34e16df059f8 (6 commits) Created with: gclient setdep -r src/third_party/angle@43c070193ede If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ifd03752571b3f0db8e5e0c87f807f55079eb4ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024581Reviewed-by:
-
nancy authored
BUG=1044844 Change-Id: I7ff65c9335ff864d46bd036e96ce3176132a8f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018622 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#735805}
-
Javier Ernesto Flores Robles authored
Disables testAccessibilityOnCreditCardEditPage on iphone-device. TBR=sczs@chromium.org Bug: 1046096 Change-Id: I6ac90cf5291f5e683a45f33ed24fd90c784090fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023549Reviewed-by:
-
David Grogan authored
This is a reland of 4fb5e9ec which should be fine after 4548e4da landed. Bug: 635619 Change-Id: I374a1f4bc4d8c0ea4fbb91cf9f560ff145c371db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024467 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#735803}
-
Alex Newcomer authored
The hotseat can be dismissed when the user interacts outside of the shelf widget. Record this in metrics for UX. Bug: 1041907 Change-Id: I18fb9b6de63d17bbaf3ac13887a991d2a90bc71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024071 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#735802}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL uses mojom::blink::ScrollAlignment::Behavior and clean up ScrollAlignmentBehavior enum in Blink. Bug: 1039285 Change-Id: I43743284c1ed33f5f720b4973dccfd72de4801ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023711 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735801}
-
Eriko Kurimoto authored
This CL adds referrer-policy web-platform-tests for module shared workers. "sharedworker-module" is added to spec.src.json and it auto-generates tests. Files I changed without auto-generation is 1. referrer-policy/spec.src.json 2. common/security_features/resources/common.sub.js (added WorkerOptions argument to requestViaSharedWorker, added "sharedworker-module path) 3. upgrade-insecure-requests/support/testharness-helper.sub.js (added the second argument in requestViaSharedWorker modified in common.sub.js) Change-Id: I044e4174c5077e7eb0e6790a55aa48534d3e6966 Bug: 824646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023710Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735800}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL uses mojom::ScrollIntoViewParams::Type and clean up ScrollType enum in Blink. Bug: 1039285 Change-Id: Ib0e6db68d371807892831ffabce5cd3d04d4be8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024628Reviewed-by:
-
Javier Ernesto Flores Robles authored
This reverts commit 1f71ed14. Reason for revert: breaks compilation of ios_remoting_unittests Original change's description: > [ios][remoting] Improve linking with MaterialComponents.framework > > Change remoting code to only link with MaterialComponents.framework if > the code is compiled as a framework (this will allow removing the fake > targets that exists in ios/third_party/material_components_ios/BUILD.gn). > > If using MaterialComponents.framework, then bundle it with the app. > > Bug: 1040871 > Change-Id: I05af4bc9a0f80a83f42a2113e01f4c5f0dc09eec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020960 > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735790} TBR=sdefresne@chromium.org,yuweih@chromium.org Change-Id: Iec47ca08ec0ccad42c077ce33c9ffa9a3cea8487 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023526Reviewed-by:
-
Gauthier Ambard authored
This CL fixes the status bar appearance when the BVC is contained instead of presented. With it, the TabGrid is forwarding calls to get the status bar style to BVC. Bug: 1042235, 1038034 Change-Id: Ibb1bce3a201fa3328add33ad012ef9ec0478aa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022654 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735797}
-
Jan Krcal authored
This CL makes the integration tests more robust by waiting for a pre-specified number of entities. This is a speculative fix for the referred bug / a further step in understanding the actual root cause. Bug: 997629 Change-Id: I74a3e7c0d2dba9a3d63664887c4d5d3e3b4b25c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022712 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735796}
-
Ben Joyce authored
Bug: 1021634,896775 Change-Id: I10ba6702db5774af270354cb4ee3b94953aa3bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015734Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#735795}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3906f655f40c..d9709fb4b440 git log 3906f655f40c..d9709fb4b440 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chonggu@google.com [Telemetry] Add fuchsia_ssh_port Option Created with: gclient setdep -r src/third_party/catapult@d9709fb4b440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I8548ecafab6cd867e99c8f025fa8717a8b1addcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024584Reviewed-by:
-
Makoto Shimazu authored
The service worker's idle timeout is triggered when the service worker is idle for a certain period of time. Previously, the idleness is checked periodically on UpdateStatus() in ServiceWorkerEventQueue. However, the periodic check prevents us from introducing arbitrary delay of idle timeout because the delay is quantized by the interval of the periodic check. This CL re-implements the idleness check by using delayed cancellable callback. In the new implementation, the idle callback is scheduled immediately after the worker has no inflight event. If we get another event before calling the scheduled callback, it's cancelled. Bug: 1043845 Change-Id: I0d8950ced2e2465ef3d1bd88c7c499fb2c78f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019142 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b97057e7f747..1b3441036a8f git log b97057e7f747..1b3441036a8f --date=short --first-parent --format='%ad %ae %s' 2020-01-24 syoussefi@google.com Fix chromium build (#3152) 2020-01-24 dneto@google.com Clarify mapping of target env to SPIR-V version (#3150) 2020-01-24 greg@lunarg.com Use dummy switch instead of dummy loop in MergeReturn pass. (#3151) 2020-01-23 alanbaker@google.com Fix structured exit validation (#3141) 2020-01-23 dneto@google.com Add spvParseVulkanEnv (#3142) 2020-01-23 jaebaek@google.com Handle conflict between debug info and existing validation rule (#3104) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b3441036a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: Ic32ead37384c4a4e5b28553673bcbde9fb3a48e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024582Reviewed-by:
-
Colin Blundell authored
This CL starts the componentization of CaptivePortalTabHelper, itself a prerequisite to the componentization of SSLErrorHandler for sharing with WebLayer. In this CL, we move the functionality of opening a new tab via interaction with //chrome's Browser object out of CaptivePortalTabHelper into ChromeSecurityBlockingPageFactory. The latter is a good landing place for this functionality as it in fact already needed to invoke this functionality as part of the configuration of CaptivePortalBlockingPage. Bug: 1030692 Change-Id: I3fc447a1fe74c8cc7c8172f6bd8433e68d4c854f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017488Reviewed-by:
-
Sylvain Defresne authored
Change remoting code to only link with MaterialComponents.framework if the code is compiled as a framework (this will allow removing the fake targets that exists in ios/third_party/material_components_ios/BUILD.gn). If using MaterialComponents.framework, then bundle it with the app. Bug: 1040871 Change-Id: I05af4bc9a0f80a83f42a2113e01f4c5f0dc09eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020960Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735790}
-
Md. Hasanur Rashid authored
Bug: 788604 Change-Id: I879b5307fe17aae16ab900d1e86781982d15db36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023713Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#735789}
-
Dominik Röttsches authored
Analogously to the fix in [1], use Skia's makeClone method for applying variable font axis parameters to a previously decoded and instantiated (as SkTypeface) web font. This avoids the workaround of instantiating the variable instance from a duplicated SkStreamAsset. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1911758 Bug: 1034906 Change-Id: I80406cfd67c60251404bd80b2f99bc59b891dcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970618 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735788}
-
David Roger authored
Dice is now always enabled, these checks are unnecessary around #edit-profile. The sync-overview section can be completely removed, because it is only shown when dice is disabled and signin is allowed, which is no longer a possible state since dice was enabled by default. The test suite DiceUITest can now be removed and merged with the general test suite. Bug: 891781 Change-Id: Ida75b66481d8a29ed983864aa5da24f0e1d835a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019447Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#735787}
-
Yoshifumi Inoue authored
This patch makes accessibility/aom-relation-list-properties.html to pass test instead of hitting |DCHECK()| about |LayoutText| has |NGAbstractInlineTextBox|. Before this patch, detaching |NGAbstractInlineTextBox| from |NGFragmentItem| associated to |LayoutText| is happened at |LayoutObjectChildList:: InsertChildNode()| after changing parent of |LayoutText| to new parent. This prevents us to use next for same layout object list because start of list is hold by previous containg block flow of |LayoutText| and new parent doesn't have it. After this patch, we call |InvalidateInlineItems()| to detach |NGAbstractInlineTextBox| in |LayoutObjectChildList::{Insert,Remove}ChildNode()| before changing parent to use next for same layout object list. Bug: 982194 Change-Id: If36223d434cfda16f8270e2e7759249e4bcdc015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024389 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Aleksey Kuznetsov authored
Invoke OnReceiveRedirect() method asynchronously, because there is way to use this code and get uninitialized variable: We want to create our |loader| variable from static function CreateLoaderAndStart(). But in this function there is way to invoke OnReciveRedirect() from our client code. And in our client code we do not expect, that |loader| variable is not costructed (uninitialized). Bug: 1043752 Change-Id: I5c0722d89ed9f849c0b82281ad6ceb5febfc467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011221 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#735785}
-
Oriol Brufau authored
LayoutNGListItem::FindSymbolMarkerLayoutText is supposed to return the LayoutObject* of the symbol text inside a ::marker. This was working fine if the parameter was a list item, the method just retrieved the marker of that list item (whether outside or inside) and then relied on ListMarker::SymbolMarkerLayoutText. It was also working fine for outside markers by a combination of ToLayoutNGListMarker and ListMarker::SymbolMarkerLayoutText. However, it was returning nullptr for inside markers. It doesn't seem this was causing any issues, but this patch makes the method behave properly. The code is also simpler this way. This patch also removes LayoutNGListItem::SymbolMarkerLayoutText since it had no other caller. BUG=457718 Change-Id: I57dea247e0f8a638c251eff6d71788a5465d74b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022946Reviewed-by:
-
Patrick To authored
When the visibility state is hidden, which is the case when the Windows Mixed Reality Portal is closed or the headset is sleeping when a session is requested, Blink stops requesting frames from the XR runtime. This prevents the OpenXR backend from polling events, thus missing the eventual visibility state change once the headset is ready. This change ensures events are constantly being polled by having a timer run every 1 second that polls events if significant time has passed since the last event poll. Bug: 1043209 Change-Id: Ifb607e393b6eebae3cadf28e4a31db9c9054b90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018186 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#735783}
-
Eriko Kurimoto authored
This CL adds use counter. When SharedWorker constructor is called with 'classic' type, ClassicSharedWorker is counted. If not, ModuleSharedWorker is counted. If type attribute is not defined, it is regarded as ClassicScript. Bug: 1023338 Change-Id: Ia126a51df040d363c66cbe0a7ff91a5e59849eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018354 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Eriko Kurimoto authored
This CL modernize WPT for cleanup. This doesn't change the test behavior. Change-Id: Ic9213ec517ac50601805a69d38d5a6c02db6310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016522 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/067755621ca9..9f8c6ea7afc8 git log 067755621ca9..9f8c6ea7afc8 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 82459860..77c4d4c4 (425 commits) Created with: gclient setdep -r src/third_party/skia@9f8c6ea7afc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I4d1d42030127292d39eeccb663f8dee3221e0e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024577Reviewed-by:
-
Tim Song authored
BUG=1013251 Change-Id: Ib68dfd00adca4af4bafccc3532681901887d566d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024076Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735779}
-
Rakesh Soma authored
previous state of user tos acceptance. Bug: 1045536 Change-Id: Ib87942148d1b7cd82309edb03c8eb8c6e4680f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021332 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#735778}
-
Hirokazu Honda authored
Bug: 1033799 Test: image_processor_test on kukui Change-Id: I5857332393313e5f6aa33fbc1ac505279dd9bc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007802 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735777}
-
Hirokazu Honda authored
This adds the GMB-backed VideoFrame support on input and output. Both input and output VideoFrames are mapped every Process() by using VideoFrameMapper if their storage types are GPU_MEMORY_BUFFER. Bug: 1033799 Test: image_processor_test on kevin Change-Id: Idea3cf4b0fca5e53ed758a5f7a25440933090095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021784 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
LibyuvIP supports Dmabuf-backed VideoFrame on input. This adds the Dmabuf-backed VideoFrame support on output. Both input and output VideoFrames are mapped every Process() by using VideoFrameMapper if their storage types are DMABUF. Bug: 1033799 Test: image_processor_test on kevin Change-Id: I30f5e48027081a6ff7c6debc747543678586c776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016526 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Ionel Popescu authored
Prior to this CL when opening a popup, the focus ring was drawn in two places: one on the original form and the other on the focused element inside the popup. This CL updates the behavior to draw a single focus ring on the focused element inside the popup. After the popup is closed, the focus ring is going to be drawn on the selected in-page element. Node::ShouldHaveFocusAppearance is changed for the affected elements (select, input-date related types and color) to avoid drawing the focus ring for the in-page element when its associated popup is open. Bug: 1041708 Change-Id: I9394900034241dbb9b309196eacfa903370426b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023361 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Dan Clark <daniec@microsoft.com> Reviewed-by:
-
