- 05 Oct, 2020 40 commits
-
-
Mario Bianucci authored
PredictionMetricsHandler appears to be designed to work for anything that is predicting points. However, it currently only reports metrics in the Event.InputEventPrediction.Scroll* histograms. De-couple the class from these histograms so it can be used for things only than scroll metrics. Bug: 1133785 Change-Id: Ib34129fc46b20b45810cbd5ca195483e88c513e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441197Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813813}
-
Sharon Yang authored
This reverts commit fdae2298. Reason for revert: Test is causing Fuchsia trunk builder to fail https://ci.chromium.org/p/chrome/builders/ci/fuchsia-x64-trunk Original change's description: > [fuchsia][a11y] Sends full semantic tree when semantics are enabled. > > This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree. > > Test: web_engine_browsertests > > Bug: fuchsia:59680, 1134147 > Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646 > Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813771} TBR=wez@chromium.org,sergeyu@chromium.org,teisenbe@google.com,yangsharon@chromium.org,lucasradaelli@google.com Change-Id: Id3df2d7e4c31632f65d2dcc4a2a9b07fc92f9b83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: fuchsia:59680 Bug: 1134147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450693Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813812}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1135117 Change-Id: Ic1403098ce31c638da44b1c55c671f60ea0da5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449512Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#813811}
-
nuwanda authored
This change depends on https://android-review.googlesource.com/c/platform/external/perfetto/+/1438933 Bug: 1119834 Change-Id: I55bc44de601479704fd35c2f12ccad2459a61fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431566Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#813810}
-
John Delaney authored
These histograms are no longer needed, see bug for more context. Bug: 1132985 Change-Id: If6a0def7f61923cc2ce08aace717f90d5eacb9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436351 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#813809}
-
Wenyu Fu authored
This change also includes moving the padding for check box set in TosAndUmaFirstRunFragment to the xml. Note that the covered scenario only includes the general UI and the loading phase UI. The UI when FRE is skipped is not included. Change-Id: I31577104b1dd793f9f708268944ed85b3d453cb8 Bug: 1120852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438094Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813808}
-
Daniele Castagna authored
HardwareDisplayPlaneManager::BeginFrame currently iterates all the planes active on a specific crtc and set in_use to false, so that they can be used when building up the next frame to commit. Not all the path of HDPM::AssignOverlayPlanes and HDPM::Commit end up committing the planes though, this means a pageflip test, or a failing pageflip, might end up leaving |in_use| set to false, while the crtc is actually still using those planes. Bug: 1127487 Test: HardwareDisplayPlaneManagerAtomicTest.{AssignPlanesRestoresInUse,PageflipTestRestoresInUse} Change-Id: Iee7f6b87af7e38f9ac7c6dea0687cc37dc4c6493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446831 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#813807}
-
Andrey Zaytsev authored
Part 1/3 for relanding crrev.com/c/2426045. The old files will be deleted in a follow up CL after the internal CL for updating references (https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3301233) lands. Bug: 1131415 Change-Id: Iadae724b6e00a04cbb84e46e04f2c2b1b687df42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442533Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#813806}
-
Mohamed Amir Yosef authored
This CL introduces a feature toggle than controls showing explicit save prompts before storing address profiles. Bug: 1135178 Change-Id: If72c323489a7cee20ea9d812ba8945b4dfe2e366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450094 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#813805}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601286022-benchmark-87.0.4280.7-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie60f00449299d7d0aa39853879f59f1626e75148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813804}
-
Avi Drissman authored
This reverts commit bb269b0e and attempts to solve the original issue in a different manner. That commit attempted to solve the problem of column header labels being cut off (https://crbug.com/1109129) by not setting a maximum column width. That caused the issue of, when the window is re-opened, that all the columns split the width of the table view. That means that, for a large window, lots of space is wasted on columns with small-width data, and no space is left for the "Task" column. That commit also switched the autoresize style to "sequential". That was meant to ensure that the "Task" column got the extra space when the window was resized, but in fact it forces the *last* column to get the extra space. I suppose "reverse sequential" was intended, but reverting things is easier. This CL fixes the problem by adjusting the maximum size to be at least as large as the labels. Bug: 1109129, 1134831 Change-Id: I4452fa2256ec05ce6cca9fbe1fee38df79eddbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447099 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#813803}
-
Peter Boström authored
CalculatePreferredSize() calls GetHeightForWidth() which calls CalculatePreferredSize() if there's no LayoutManager installed. This change adds a new LayoutManager as a workaround that should not be necessary (see linked bugs). Bug: 1128500, 1135104 Change-Id: I0563e3b8c39c892dca84d488f207ebbb0deb4594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448772 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813802}
-
Jochen Eisinger authored
Storing a GlobalFrameRoutingId is the preferred method of keeping a reference to a RenderFrameHost Change-Id: I70266e1e7e5d7c9863df43e300c26a1e7b82e563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449389Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813801}
-
Robert Sesek authored
Bug: 1135150, 1126350 Change-Id: Ic16867aa6db47e26af0a2d971fb5717a4028c43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449931Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813800}
-
Martin Kreichgauer authored
Add support for CTAP 2.1 PIN/UV Auth Protocol Two (6.5.11). Bug: 1129946 Change-Id: I6e0f0bfa3164b84d1e428f83f86e11d4f3151419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440535Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#813799}
-
Scott Lee authored
R=dpranke@google.com,nodir@chromium.org CC=chanli@chromium.org,iannucci@chromium.org Change-Id: I8df1342d5c36e2de2cc2d7343bc07f128c78ce2c Bug: 1017288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315008 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#813798}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69b996bd..88d84cce Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c8e886deb404daac32a76348ac4b68c75818078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449910Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813797}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/af5911446cd0..e6a8f4ed40bb 2020-10-03 engeg@google.com Instantiate the M87 builders 2020-10-03 yichengli@chromium.org Generate python bindings for artifacts.proto change 2020-10-02 frkoenig@chromium.org trogdor: enable hw tests 2020-10-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-02 bmgordon@chromium.org cros lint: Disable warning for local in /bin/sh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I80b5f98880f0ed05705ce23a0903903c131b9e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813796}
-
kylechar authored
VulkanWebEngineIntegrationTest.WebGLContextPresentWithVulkanFeature no longer fails in local or bot testing so re-enable it. Bug: 1104563 Change-Id: I8d91d71fb7916a9c2c5da559571aee08a23707f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446449 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813795}
-
Dominic Mazzoni authored
Fix one remaining tiny test failure, all others should now be fixed. We should leave this flag around for at least one milestone just in case, but if there are no issues then we can remove the flag and hard-code it this way. This is a big step towards getting rid of the "ignored and not included in the tree" state. Bug: 1063155 Change-Id: I92241af7ec752dc537919740ef96c7e149d460e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448656Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813794}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS Build, but it will be unset. This CL is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: Ifffd315c669fd8d0d38ab41c8f4f7bbda6c0cbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450129 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#813793}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4258.0-1601290734-benchmark-87.0.4280.7-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0615282cc895be787d6d053d539fcd069ebad135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813792}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4280.7-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iea2d6b9f27ef1963377cc7d82dd34d3f4d27da39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813791}
-
Danyao Wang authored
This is a reland of dc61429b after infra team fixed the incremental build issue: crbug/1133102 Original change's description: > [Payments][Metrics] Extend expiry for ever-green metrics. > > Also updated ownership. > > Bug: 1128111 > Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811232} Bug: 1128111 Change-Id: I7c00c0cc30538381cda80e2dfb98148b944d6481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446891 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#813790}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010050700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/F5O08dsIWdHTa7NozxSJmHAyJsTLlm6Zxo9jTQjw1qEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I5d2ec3cd4b0c58c9f3e71c1807f4ffee6bfc00a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450112Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/750261f41af6..00a8b5bb4fcb 2020-10-05 brianosman@google.com Revert "Revert "Convert sksl_frag.sksl to an IRIntrinsicMap"" 2020-10-05 johnstiles@google.com Create TinyUnorderedMap class for small-N data storage. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I5d7d6f8d134fd6d300c08dcc2fd9140736dc1a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813788}
-
Vasiliy Telezhnikov authored
This CL fixes color type that we pass to the skia for the FBO0. It changes two things: * Use RGB565 if the surface uses 16 bit format . * Fallback to RGBA is skia doesn't support rgb color type. Bug: 1126490 Change-Id: I6f5342ac7bb128134afc2c5182a6c6b99600c7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441311 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0afca615a816..256b2c258767 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageDecorationManager.js with TypeScript 2020-10-05 bmeurer@chromium.org [ts] Type-check wasmparser_worker/WasmParserWorker.js with TypeScript 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageListView.js with TypeScript 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd03c1c0b2612666fca703754724dd9426064eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813786}
-
Christian Dullweber authored
Set android:includeFontPadding="false" to better align favicon with URL. Use padding instead of margin to get the right background color. Show details link if there is a connection message. Show red warning triangle if there is a connection security issue. Also includes some general cleanup for margins. Bug: 1135124 Change-Id: Iff1f880b51a2a8bd60ef0606afec03fea82e9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449372Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#813785}
-
Mike Wittman authored
This reverts commit 44f6ea57. Reason for revert: crashes in stack_unwinder::Module::Load() Original change's description: > [Sampling profiler] Enable on ARM32 Android canary for render thread > > Enables the ThreadProfiler on Android canary channel Chrome releases > for ARM32. The profiler is enabled solely on the renderer main thread > for now, pending stability and performance metrics from the wild. > > Bug: 1004855 > Change-Id: If393653adf362f3fccbfa93078f45d88284fc81b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433125 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813548} TBR=wittman@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135152, 1004855 Change-Id: I3e04e2b1f5174fb01e29bbf912f70517d1424af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448960Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813784}
-
Scott Violet authored
This is necessary as embedders are pulling from canary, not stable, which makes for a much smaller skew. BUG=none TEST=none Change-Id: I28bc2aac2038fb5757c60ee5251cb281ea10cdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450389Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813783}
-
Oksana Zhuravlova authored
Since webview_power_usage.sql now outputs power usage by core type for the host app process, all renderer processes and WebView-only threads of the host app process, this change updates the corresponding tbmv3 metric to output these values. Bug: b/166476416 Change-Id: I59da13ccc07d91341825475d028a749466f592be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436289Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813782}
-
Hazem Ashmawy authored
Here is a per-class breakdown: - CrashReceiverServiceTest: batch under UNIT_TESTS, all existing tests are unit-tests-like, they don't launch any services or any UI. - MetricsBridgeServiceTest: two tests don't actually launch any service or UI so they are moved to a separate class and batched as UNIT_TESTS, remaining two tests are marked best left unbatched because they bind and unbind to a service and depend on having a fresh instance of that service every time, restarting the process makes sure they start with a clean state. - MinidumpUploadJobTest: These tests have n TestRule that launches a browser process and loads native library, it's safer to leave them unbatched. - VariationsSeedServerTest: Tests launches (bind/unbind) to service, leaving them unbatched makes sure that the service will be killed after each test leaving a clean state. - VisualStateCallbackTest: It has only one test that depends on multiprocess mode and it should remain unbatched. Bug: 1120847 Test: run_webview_instrumentation_test_apk -f "*.android_webview.test.services*" Change-Id: I7dbf0d4d5573eb9865f612d1c087627b705c2b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440658 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813781}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ifade39ca5a9522be2dcebb8ae13b4722e4ab0e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449810Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813780}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS build, but it is being unset. This is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I773b4d46bc2e1f1cba9e3b8d0de5503d4e40eb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449610 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813779}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I1691fb17d2da0268ce77617a00309ae3f5b9f92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442894Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#813778}
-
Brian Malcolm authored
A device or account can be managed by either a Dasher domain, in which case the manager will be a domain (foo.com), or by a FlexOrg, in which case the manager will be an email address (user@foo.com). BUG=chromium:1081272 Change-Id: Ib9b80777d7cd054752f8c5298cfdc23f93b881b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446829Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813777}
-
Ramin Halavati authored
ProfileNetworkContextService is updated to use Guest policy for ephemeral Guest profiles. This change is behind disabled EnableEphemeralGuestProfilesOnDesktop flag. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: Ic58cbbb3d90ce2edca8d43da2cadab4ef28f5aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450189Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#813776}
-
Frédéric Wang authored
This CL removes the CSSOMViewScrollCoordinates experimental flag and cleans up related code. The flag is enabled in the current release M85 via a finch flag. It has been enabled by default on M86+ and ToT since [1]. Bug: 721759 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2310799 Change-Id: I79c631bf7b30a3c5d6f4c1c819bec124a5096c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377706 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813775}
-
David Bienvenu authored
Currently when we do taskbar migration, we do it for every profile launched. After the first profile, this should be a noop, but we still iterate over the shortcuts. Moving migration to ChromeBrowserMainPartsWin::PostBrowserStart() will make us do it only once. Bug: 1132578 Change-Id: I07cb8ea74145407f978efcd6067523d7d79ca1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433427 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813774}
-