GitLab

Certain versions apparently crash when pulling theme string information in TextView.
To attempt to fix this (since it's difficult to reproduce), try to revert the string
usage to the old version.

BUG=416692
NOTRY=true

Review URL: https://codereview.chromium.org/608853007

Cr-Commit-Position: refs/heads/master@{#297859}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/48c0239..9ccd091

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/625613002

Cr-Commit-Position: refs/heads/master@{#297858}

This is the new GN name for this variable.

TBR=scottmg

Review URL: https://codereview.chromium.org/620193002

Cr-Commit-Position: refs/heads/master@{#297857}

There is no reason to hide private API.

BUG=394124

Review URL: https://codereview.chromium.org/611163003

Cr-Commit-Position: refs/heads/master@{#297856}

[chromedriver] Disable large data transmission tests on Android (chrome_shell/chromedriver_webview_shell)

BUG=chromedriver:913

Review URL: https://codereview.chromium.org/619873005

Cr-Commit-Position: refs/heads/master@{#297855}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/29fe24c..6bd4196

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/620153002

Cr-Commit-Position: refs/heads/master@{#297854}

See failure logs at
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/55548

and at the attached bug below.

TBR=jam@chromium.org
BUG=419769

Review URL: https://codereview.chromium.org/623573003

Cr-Commit-Position: refs/heads/master@{#297853}

TBR=asvitkine@chromium.org
BUG=

Review URL: https://codereview.chromium.org/619163002

Cr-Commit-Position: refs/heads/master@{#297852}

The API use is checked on the Blink side, so these checks are to
thwart corrupted renderers. Specifically, renderers that try to
register, unregister or get registrations for non-secure origins must
be nuked from orbit. It's the only way to be sure.

BUG=394213
TEST=content_unittests ServiceWorkerDispatcherHostTest.*

Review URL: https://codereview.chromium.org/618113005

Cr-Commit-Position: refs/heads/master@{#297851}

Revert of Stitch ServiceWorkerCache between renderer and browser. (patchset #8 id:140001 of https://codereview.chromium.org/580063003/)

Reason for revert:
Trybot tests were stale.  Need to rebase and land again.

Original issue's description:
> Connect the ServiceWorkerCache functionality between the renderer and the browser.
>
> BUG=392621
>
> Committed: https://crrev.com/a934835ea3e3091dc6f57681e5af74c257acd01f
> Cr-Commit-Position: refs/heads/master@{#297848}

TBR=michaeln@chromium.org,horo@chromium.org,tsepez@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621

Review URL: https://codereview.chromium.org/623703004

Cr-Commit-Position: refs/heads/master@{#297850}

Custom Android OS flavors often tailor themed resources, sometimes in a
way that Chrome does not expect or cannot anticipate. As a fallback
measure, acquire the selection handle resources from the unthemed
context resources when themed resource loading fails.

BUG=416081

Review URL: https://codereview.chromium.org/614463002

Cr-Commit-Position: refs/heads/master@{#297849}

BUG=392621

Review URL: https://codereview.chromium.org/580063003

Cr-Commit-Position: refs/heads/master@{#297848}

Remove dependencies on Chrome resources from extensions.gyp.

BUG=397250

Review URL: https://codereview.chromium.org/615913003

Cr-Commit-Position: refs/heads/master@{#297847}

BUG=418700

Review URL: https://codereview.chromium.org/617263002

Cr-Commit-Position: refs/heads/master@{#297846}

BUG=419723
R=pinkerton@chromium.org

Review URL: https://codereview.chromium.org/625593002

Cr-Commit-Position: refs/heads/master@{#297845}

This is a race condition that gets triggered if we get *both* audible and
inaudible directives in the same instruction. This causes us to encode both
the tokens, but when ProcessNextTransmit gets called after the samples for the
first token are received, it tries to play the other type of token also (for
which samples may not have been received yet). The simplest way to fix it is
adding a HasKey check to the cache for both types of tokens. We will get
called after each of the samples tokens are added to their respective caches,
so if we skip playing one particular type of token (since it hasn't landed in
its cache yet), we will get called again after it gets added to its cache, so
both the tokens will definitely play.

R=xiyuan@chromium.org
BUG=419585

Review URL: https://codereview.chromium.org/614903007

Cr-Commit-Position: refs/heads/master@{#297844}

The BUG 419364 was solved by crrev.com/297660.

BUG=419364
TEST=None

Review URL: https://codereview.chromium.org/618653003

Cr-Commit-Position: refs/heads/master@{#297843}

* Add unused parameter for toggling spoken feedback handler
* For Athena disable magnification, use proper shutdown API

BUG=419708

Review URL: https://codereview.chromium.org/626503002

Cr-Commit-Position: refs/heads/master@{#297842}

Add 4 Variations.SeedDateSkew.* histograms to analyze whether the system clock or the build time could be used as a long term expiry clock for very old variations seeds.

BUG=419622

Review URL: https://codereview.chromium.org/617263007

Cr-Commit-Position: refs/heads/master@{#297841}

Seems to have some tabs in there too

BUG=

Review URL: https://codereview.chromium.org/619913004

Cr-Commit-Position: refs/heads/master@{#297840}

BUG=413685
R=noms@chromium.org
TEST=Sign in to a profile with an @gmail.com or @google.com account,
lock should be available. Sign in with another other domain (such as
chromium.org) and lock will not be available.

Review URL: https://codereview.chromium.org/566933005

Cr-Commit-Position: refs/heads/master@{#297839}

BUG=399735
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/620093004

Cr-Commit-Position: refs/heads/master@{#297838}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/611983004

Cr-Commit-Position: refs/heads/master@{#297837}

R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/624533003

Cr-Commit-Position: refs/heads/master@{#297836}

BUG=408089

Review URL: https://codereview.chromium.org/622543007

Cr-Commit-Position: refs/heads/master@{#297835}

This caused --report-silk-details to throw exceptions.

TEST=manual,thread_times_unittest

Review URL: https://codereview.chromium.org/615253007

Cr-Commit-Position: refs/heads/master@{#297834}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2152879..48c0239

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/625563003

Cr-Commit-Position: refs/heads/master@{#297833}

BUG=331424

Review URL: https://codereview.chromium.org/294973002

Cr-Commit-Position: refs/heads/master@{#297832}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b77955e..29fe24c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/625443005

Cr-Commit-Position: refs/heads/master@{#297831}

Previously, in order to initialise CommandLine, you had to know whether
you were running as part of Content Shell, Chrome Shell, or Chrome, and
call the corresponding method.

This led to ugly code like ChromiumSyncAdapter.java having to provide an
abstract initCommandLine method that gets implemented by the subclasses
ChromeShellSyncAdapter.java and ChromeBrowserSyncAdapter.java.

Instead this patch adds an abstract initCommandLine method on
ContentApplication.java, implemented by the subclasses:
- ContentShellApplication
- ChromeShellApplication
- ChromeMobileApplication
- ChromeNativeTestApplication

Thus any code in the content layer can now initialize CommandLine with:
    ContentApplication.initCommandLine(context);

BUG=350384
TBR=fgorski@chromium.org
CQ_TRYBOTS=tryserver.chromium:android_aosp,android_arm64_dbg_recipe,android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel,android_clang_dbg_recipe,android_dbg_tests_recipe

Review URL: https://codereview.chromium.org/615153002

Cr-Commit-Position: refs/heads/master@{#297830}

Git hash: 6e94c9e17806e3243f31d96b8049ab0c8ecf7d67

BUG=
TBR=hajimehoshi@chromium.org,toyoshim@chromium.org

Review URL: https://codereview.chromium.org/619953002

Cr-Commit-Position: refs/heads/master@{#297829}

This is to prepare for running the scanner as a presubmit check.

I have added some manual tests to make sure that the new scanner is
compatible with the old one. I plan to replace them with automatic
unittests once I start using presubmit-style input API objects that
are easily mockable.

BUG=343104

Review URL: https://codereview.chromium.org/622493004

Cr-Commit-Position: refs/heads/master@{#297828}

To move the WebView telemetry bot off hard coding
which tests to use and start getting the list of tests
automatically we need to label which tests don't work
on the WebView.

Bug tracking enabling them here: crbug.com/419687

BUG=391488, 419687

Review URL: https://codereview.chromium.org/619903003

Cr-Commit-Position: refs/heads/master@{#297827}

Sync up chrome_restart_request.cc with ui/events/event_switches.h

BUG=none

Review URL: https://codereview.chromium.org/617583002

Cr-Commit-Position: refs/heads/master@{#297826}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/28da02d..2152879

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/617703003

Cr-Commit-Position: refs/heads/master@{#297825}

Use a boolean to only send WINDOW_CONTENT_CHANGED the first time
notifyFrameInfoInitialized is called. See bug for longer discussion of
issue.

BUG=419541

Review URL: https://codereview.chromium.org/624503002

Cr-Commit-Position: refs/heads/master@{#297824}

Propagate touchscreen information so that Ash can map touchscreens to displays.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/616633002

Cr-Commit-Position: refs/heads/master@{#297823}

We never unregistered an audio stream that were using keyboard mic channel, so we never inactivated the keyboard mic when no more streams were using it. This fixes it.

Fix for CL https://codereview.chromium.org/599443003/

BUG=418993

Review URL: https://codereview.chromium.org/618663003

Cr-Commit-Position: refs/heads/master@{#297822}

Creating a runtime table of std::string objects, just to copy those
into a map, is not optimal from a runtime or footprint point of view.

Making the table use raw char pointers shrinks the code and data by 75%,
from 36 KB to 10 KB (clang, Linux, 64 bit content_shell).

clang:
Total change: -27266 bytes
==========================
  2 added, totalling +8448 bytes across 1 sources
  774 removed, totalling -36401 bytes across 2 sources
  1 grown, for a net change of +687 bytes (481 bytes before, 1168 bytes after) across 1 sources

R=estade@chromium.org,mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/573623003

Cr-Commit-Position: refs/heads/master@{#297821}

BUG=v8:3597
R=cpu@chromium.org,wfh@chromium.org

Review URL: https://codereview.chromium.org/619543002

Cr-Commit-Position: refs/heads/master@{#297820}