- 03 Oct, 2019 1 commit
-
-
Kevin Marshall authored
Deletes all remaining Cast APIs from the Cast Runner codebase. Bug: 953958 Change-Id: Ia715e9c972735f11d29978925a2199356e4d1d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793791 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702250}
-
- 02 Oct, 2019 39 commits
-
-
Peter Boström authored
Replaces kHighlightPathKey uses in FindBarButton, ProfileMenuViewBase and BubbleFrameView. Bug: chromium:1007546 Change-Id: Iec2a07ed28913d68bf8e835e9603ca4247eadaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835263Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702249}
-
yilkal authored
This CL records the maximum number of frames present in web contents. The records will help us better predict the cost of improving SupervisedUserNavigationThrottle to filter at the iframe level. The will help us predict the following two information: 1. By how much will the requests for the kids management servers to classify urls will increase as a result of iframe filtering. 2. By how much will we delay the overall page load time? Bug: 850328 Change-Id: I01cf33305a67aa01e3ab416d1659e027156bedef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769663 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702248}
-
Gavin Williams authored
-Current dropdown behavior can show different text than what's actually selected. Bug: 1009772 Change-Id: I8480e054ef33855cd1c2764d3f8591b57139725e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832793 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702247}
-
Xianzhu Wang authored
LayoutScrollbar* were for custom scrollbars, which was not obvious from their names. LayoutScrollbarPart is renamed to LayoutCustomScrollbarPart keeping the Layout prefix because it's a LayoutObject and all LayoutObject classes have the Layout prefix. Move CustomScrollbarTheme (renamed from LayoutScrollarTheme) from layout to paint, and combine ScrollbarPainter into it. Change-Id: Ia65cc7824ed9bdc16372976225a1acbcef59601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835999 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702246}
-
Tao Bai authored
- Added TestMetricsWebContentsObserverEmbedder for sharing between component and chrome browser - Moved chrome browser unrelated tests to components. - Keep extension related tests in Chrome. - Clean up some unused include header file. Bug: 995880 Change-Id: I31f211c83c4faaafa7016a5f9890f242668e5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832034Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702245}
-
Brian Sheedy authored
Switches tracing_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I719e754be1cba67cdec15034e7a614494723a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836006Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#702244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6154fb127e5c..f417d3ad5009 git log 6154fb127e5c..f417d3ad5009 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 ehmaldonado@chromium.org depot_tools: Run git_cache_test and git_dates_test on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@f417d3ad5009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009809 Change-Id: I5be987be591a1a86c70ad81214c451d3765ecc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702243}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/867f72058a4f..0da52f2d92c3 git log 867f72058a4f..0da52f2d92c3 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 bryan.bernhart@intel.com D3D12: Move resource allocators from device into manager. Created with: gclient setdep -r src/third_party/dawn@0da52f2d92c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7282a3ddb89a18c05a92d57b48d24952b3f9f24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836571Reviewed-by:
-
Wez authored
Previously user-mode remote debugging was available for all Frames in a Context created with a |remote_debugging_port| specified in their CreateContextParams. User-mode debugging is now enabled only for Frames created via CreateFrameWithParams() with the |enable_remote_debugging| option set, in a Context with a |remote_debugging_port| set. Remote debugging support in WebEngine is refactored such that: - DevTools is managed by a WebEngineDevToolsController implementation, which is created and owned by the WebEngineBrowserMainParts. - WebEngineDevToolsController has "hook" APIs which must be called to inform it when a Context is created, when WebContents are created, torn down, etc, and an API that returns a list based on the debuggable WebContents to DevTools. - WebEngineBrowserMainParts supplies the controller to the ContextImpl, which arranges for the WebContents "hooks" to be invoked, and uses it to implement the GetRemoteDebuggingPort() API. - WebEngineDevToolsController has three implementations, depending on the command-line parameters passed by WebEngineBrowserMainParts: - User-mode: DevTools is enabled as soon as a Frame is first created with the remote-debugging option set in its CreateFrameParams. Pending GetRemoteDebuggingPort() calls will be notified at that time. - Debug-mode: DevTools is enabled as soon as the Context is initialized and will stay enabled for the lifetime of the browser process. When the first Frame's main document finishes loading[1], all DevToolsPerContextListeners registered at Context creation will be notified. - No-op: DevTools is never enabled. - WebEngineDevToolsManagerDelegate is moved to be an implementation detail of the WebEngineContentBrowserClient. The integration tests are also updated to verify the new behaviour. [1] Debug-mode clients expect to be notified that DevTools is ready, only when at least one Frame has finished loading its main document. Bug: 995057 Change-Id: I8b4e825c77882bb54f2e568a95e383e3eaedfb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774018 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702241}
-
Jarryd authored
This change adds a BrowserContextKeyedService so that we can pass the storage code (which lives in the content layer) a callback after profile creation. The callback will be used to trigger warnings about storage pressure, and thus needs to live in the chrome layer to make use of UI. The logic for storage pressure notifications will come in follow-up, dependent CLs. Bug: 997258 Change-Id: I840da583873b79cc6754a023d09920317890b780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761161 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb5d5accb146..64a01fd9a557 Created with: gclient setdep -r src-internal@64a01fd9a557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1007434,chromium:None Change-Id: I78a872380175c5ca225aec00fa959be8d8f0739c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702239}
-
Erik Chen authored
The method is not necessary if we use the GetClientForTesting() method to extract the client. Bug: 1006442 Change-Id: If25033a12f55079b322b89dbfe1a85c94ef0fc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817288Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702238}
-
Sanket Joshi authored
This CL implements the refreshed look for the color suggestion picker. The existing color suggestion picker tests have been copied into appearance tests, so that the appearance with the controls refresh flag on and off can be validated. Bug: 1009125 Change-Id: I3b481e51699343d36d69804a9a934bd0e6946160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829247 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#702237}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbb8c722..f98bdc1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib222e8f40034e5347ea74850a95b2dca3f349348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702236}
-
danakj authored
This splits apart the computation of each emulated field and makes more clear the intended outcome for desktop vs mobile cases. We remove the applied_widget_rect_ state, which can be computed from other inputs, and the scale_ state which is already stored in the emulation_params_. When the scale is not used, it used to store it as 0 and multiply the context menu coordinates by 0. Now we store a 1 when the scale is not used. R=avi@chromium.org TBR=caseq Bug: 1006052 Change-Id: I9c9aabca73d7d73f946e5889444004e00e181bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834080 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Aaron Colwell authored
This fixes renderer kills caused by creating an iframe whose src is a blob URL created by an opaque origin. Bug: 1010120 Change-Id: I16b5f148522aa390d2d01c2e08353e834c6a48fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836533Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#702234}
-
Thanh Nguyen authored
1. Add |hits| to FuzzyTokenizedStringMatch. 2. Use FuzzyTokenizedStringMatch in AppSearchProvider under a new flag. Bug: 990684 Change-Id: I2da004456ca341d70f0d3398ec3e81095bebeb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833199 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702233}
-
Peter K. Lee authored
New assets from http://crbug/999939 with a slightly lighter grey background. Before: https://screenshot.googleplex.com/Y1AYLsWsZr0 After: https://screenshot.googleplex.com/H6W5xi65gMB Bug: 999939 Change-Id: I831f3bc6df5fc06316f05b097b64a45d9cae53aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835280 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702232}
-
Nick Burris authored
Create a new type of document marker for text fragments to avoid interfering with find-in-page usage of TextMatch markers. The TextFragment marker is a sub-type of the TextMatch marker, equivalent to an inactive text match marker. This also makes text fragments not get painted as tick marks on the scrollbar. Bug: 995381, 924970 Change-Id: I8c6169adfcd5deebc39a40171d61e70113b19bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814937Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702231}
-
Adithya Srinivasan authored
Test fails flakily on all aura platforms. Bug: 1010675 Change-Id: Ic1906b0421dab41ddc14f36462aff459867afc33 Tbr: lfg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836007Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#702230}
-
Jüri Valdmann authored
CheckOpResult is used via CHECK macros in a number of constexpr functions, for example base::time_internal::SaturatedAdd. This is not legal C++, says GCC. Bug: 819294 Change-Id: Ic56a623af61a5c00daa8920136015cfa100ebe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827370Reviewed-by:
-
Peter Boström authored
This is replaced with views::GetHighlightPath() which is used by the other InkDrop and FocusRing. Bug: chromium:931964, chromium:1007546 Change-Id: Id34c89f3a81edffc72d4ff7460882ebbda346368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836372 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#702228}
-
Xianzhu Wang authored
This is a preparation of CompositeAfterPaint composited scrollbar implementation. Previously we create many display items for a scrollbar. This was unnecessary because we always invalidate all display items of a scrollbar (as a DisplayItemClient). Too many display items for one client also increases cost when searching for cached display items. As scrollbar's whole track (including track background, buttons and tickmarks) and thumb are still painted separately for cc painted scrollbars, we still need separate display items for them. Bug: 931486 Change-Id: I4a63797ba1e823810364689b975d065bba0841ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830401 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jeffrey Yasskin authored
This reverts commit 267f7f3a. Reason for revert: The new tests seem to be flaky. See crbug.com/1010658 for error messages. Original change's description: > [bfcache] Add tests for outstanding network requests > > It turns out that fetch() and XMLHttpRequests are now tracked > as network requests. > > This patch adds tests to verify this behaviour. > > This patch also slightly improves tracing for active feature > detection. > > R=kouhei@chromium.org,arthursonzogni@chromium.org > > Change-Id: I368f3b52ba8930269bef284f98bd1831944633f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825419 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701708} TBR=kouhei@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org BUG=1010658 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I62b5cb17c4afc5fac114c9b634d4696404f72e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836155Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702226}
-
Moe Ahmadi authored
Deleting suggestions with Shift+Del (as opposed to right click and choosing delete from the dropdown menu) does not invoke Start() on the provider. Therefore, the list of autocomplete matches were not being updated. This fixes that bug by immediately deleting the match from the list of matches. Bug: 996516 Change-Id: If37a59d80b68a9f64a66140328a49549ef8ae53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832983 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702225}
-
Peter Boström authored
This replaces SetToolbarButtonHighlightPath and removes the OnBoundsChanged calls required to keep it up to date. Bug: chromium:1007546 Change-Id: I942ed7f0e8b9d748ad617af87d3241c1500d35b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836147 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0a784e03b0f0..73fb657586a5 git log 0a784e03b0f0..73fb657586a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 saklein@chromium.org PackagesService: Add BuildsChrome endpoint. Created with: gclient setdep -r src/third_party/chromite@73fb657586a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1924dc7752bc6bfe08c63c49040660f126379ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835261Reviewed-by:
-
Wez authored
TBR=alexmos Bug: 1010256, fuchsia:36774, b/140763277 Change-Id: I9fd94a2435a35c22945100e054caae6ab0e5052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836434Reviewed-by:
-
Miyoung Shin authored
This CL converts XRSessionClient{Ptr, Request} in chrome and blink to the new Mojo type, and uses pending_receiver<XRSessionClient> in vr_service.mojom. Bug: 955171, 978694 Change-Id: Ia226a135173cd3e38c3b52a60beaae562ac63d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828760Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#702221}
-
Trevor Perrier authored
This CL hides the Lite mode summary text on the settings menu when the data used history chart is not shown in the Lite mode settings. Currently both show when 100KB has been received regardless of how much data has been saved. Bug: 944977 Change-Id: Ic2f70deb770f120adf12070ae2c00d69e6822d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835176Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#702220}
-
Tommy Li authored
No one is looking at these anymore. They expired once already in June, but got extended. Bug: 969931 Change-Id: I345ad00364f5cd39b8b228e6a43419a880d7ab5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829491 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#702219}
-
Sanket Joshi authored
The up-down arrow is currently slight off vertical center. This CL fixes that and updates all affected test baselines. Bug: 1010330 Change-Id: Id1965a6243046816207bf521e25bb06413e6c77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832720Reviewed-by:
-
Patrick Noland authored
In the linked bug, retaining the site instance causes he whole entry to be discarded and replaced when returning. This prevents the stored scroll state from being restored properly. Resetting the SiteInstance means the existing entry can be reused for future visits, preserving the state. Bug: 992198 Change-Id: Ib0f3e2b4f259846f02ee3e5e78c7341d2b98e148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825791 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6c43f42ce94be9551b741855cfe8ef3bad6bd5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835220Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#702216}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I488fc6578141f596979a4729afe02e9cdbe97786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833904Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#702215}
-
John Chen authored
Enable ChromeDriver tests on Win10 bot, as win7-rel bot is no longer included by default in Chromium CQ. Change-Id: Ie8d42abe069ccbcd4313d5067a2c474913c36204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835068Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702214}
-
Travis Skare authored
QR Code generation itself is being added as a mojo service in a follow-on change. Launch with a feature flag: chrome --enable-features=SharingQRCodeGenerator Bug: 993908 Change-Id: Iba2772227ec2d494524e90e45bd0e4726047f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769685 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
-
Brian Norris authored
They should also use the cros-network-metrics group. Bug: chromium:975070, chromium:975825 Test: validate_format.py, pretty_print.py, presubmits Change-Id: Id2afb8fed98206268d93a7f2d1f10a379badcf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834654Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702212}
-
Chris Lu authored
Made a mistake in the final patchset of crrev.com/c/1832157. Modified a unittest to cover this mistake. Bug: 976901 Change-Id: I21b06444ca31ba174d217051266c8edaba97aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835097 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
