- 15 Aug, 2020 39 commits
-
-
Lukasz Anforowicz authored
As described in https://crbug.com/917457#c17 enabling the feature should not cause any issues in the wild. At the same time, enabling the feature should make a significant improvement in the protections that Chrome offers against compromised renderers. Bug: 917457 Change-Id: I53856a9f3a9851b5907c5805ce0544a56b7eb87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350881Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#798414}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..22e7f7a0d7d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I60c36e544d59e4d62c36022c1ee32d559b9af212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798413}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3fcf2574157..22e7f7a0d7d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibcbb02c553260f4a3886164cfada9ad40d7596d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358060Reviewed-by:
-
Sophie Chang authored
Change-Id: I8b66e4676dc5485489ea922f41009c2646435025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357562 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798411}
-
Renjie Tang authored
What went wrong: Previously handshake_completion_timestamp_ was only stamped at OnOneRttKeysAvailable(). But from the base method in the shared code, this method is only called with TLS QUIC. Thus this histogram is broken for gQUIC. connection_timing_.connect_end works for both QUIC versions. Change-Id: Ie3b60a8d4169b3a6ccc32b79877290275f26bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358369 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798410}
-
cfredric authored
study. These annotations will automatically generate code to measure how much entropy these APIs leak about the users' cross-site identity. Bug: 973801 Change-Id: Ie3f7bd8d9a77a2e6b75aa91e45ec4dd688bf6a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357450 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798409}
-
Dale Curtis authored
This assembles superframes from vp9 alt ref frames since that's what the macOS VP9 decoder is expecting. Where possible it tries to avoid copying the input buffer, but when we need to create a super frame, a super block is allocated for the combined frame. Fixed: 1115334 Change-Id: I9bfe08201fea1b91f6416143d180bf3d78164827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354641 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798408}
-
Lei Zhang authored
fast/frames/iframe-scaling-with-scroll.html is failing on macOS 10.14 and 10.15. Bug: 1116681 Change-Id: I5674d13913a35b65b1e15b0fe60492af2470086f Tbr: flackr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358431Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798407}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..22e7f7a0d7d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic5cfcffd2231e3b60d0516cca09439e8f9520658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358649Reviewed-by:
-
Yi Gu authored
This patch adds a histogram that records whether a site (via autofill): 1. collects phone number 2. uses autocomplete="one-time-code" 3. uses WebOTP Design doc: https://docs.google.com/document/d/1OPqPNY9l76kvaBPBCS5wbBQv2HNhmNlsDAcUvmYgyNI/edit#heading=h.kua94pd3af6v Bug: 1107590 Change-Id: Id1d4daf33cb26c43987bcf49dea1f737e7528ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332893 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#798405}
-
Lei Zhang authored
The MixedContentSettings_DisallowRunningInsecureContent test case is flaky on Mac. Bug: 1116670 Change-Id: I307c9947284af06ede7019fc60e6c6acca8a0e20 Tbr: estark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358429Reviewed-by:
-
Joshua Bell authored
After developer feedback, the API design has shifted towards returning font files as a whole (as blobs) rather than requesting individual tables. Remove the obsolete getTables() method, and associated tests. Change-Id: I54de7b46ed892d4c7f755e9a9ea7d2db45c6acf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354961 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#798403}
-
Ahmed Fakhry authored
This reverts commit 0158f88d. Reason for revert: This CL broke the entire waterfall: https://screenshot.googleplex.com/7be9bb2e-086d-4e02-a655-68373309ec83.png Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/13827 Traceback (most recent call last): File "../../tools/grit/grit.py", line 29, in <module> sys.exit(grit.grit_runner.Main(sys.argv[1:])) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/grit_runner.py", line 314, in Main return toolobject.Run(options, args[1:]) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 274, in Run self.Process() File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 409, in Process self.ProcessNode(self.res, output, tmpfile) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 333, in ProcessNode formatted = formatter(node, output_node.GetLanguage(), output_dir=base_dir) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/format/data_pack.py", line 90, in Format value = node.GetDataPackValue(lang, util.BINARY) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/node/include.py", line 109, in GetDataPackValue data = util.ReadFile(filename, util.BINARY) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/util.py", line 214, in ReadFile with io.open(filename, mode, encoding=encoding) as f: IOError: [Errno 2] No such file or directory: '../../out/Release/gen/chrome/browser/media/kaleidoscope/internal/resources/module/module.js' Original change's description: > Setup NTP for Kaleidoscope module > > This CL moves the Kaleidoscope NTP module upstream > into the Kaleidoscope repo. > > The public Kaleidoscope module is now responsible for > loading the resources into the NTP page. > > Also adds the KaleidoscopeDataProvider to the NTP. > > BUG=1114862 > > Change-Id: Ibc255ea9d7fd05b10cb151d0f1e86b0f94b192cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354717 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798391} TBR=beccahughes@chromium.org,tiborg@chromium.org Change-Id: I1ec9b538cdd360d97fea01561b21d5f4d48430e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358694Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#798402}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I112219cefc3555c2a4c31b65e3dcdbc9cc9605ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358790Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798401}
-
Jun Mukai authored
This reverts commit 047950bb. Reason for revert: failing arc.Gamepad Original change's description: > Add gamepad rumble support in Exo and Wayland. > > - Add exo::Gamepad interface. > - Add exo::GamepadObserver interface. > - Add WaylandGamepadVibratorImpl to handle vibration and cancel > vibration requests from the client. > - Refactor WaylandGamingSeatDelegate so that WaylandGamepadDelegate > handles all gamepad-specific events. > - Add Wayland protocol to support gamepad rumble. The zcr_gamepad_vibrator_v2 interface is created when the server calls > the vibrator_added event. The client can then trigger/disable vibration > events on a gamepad vibrator through the interface. > > BUG=b:158686809 > TEST=Add unit tests in gamepad_unittest. All tests pass in > exo_unittests. > > Change-Id: Ie4b1b3b5f9748f31846c54c97cb4f7c315d09a05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313976 > Commit-Queue: Merissa Tan <liyingtan@google.com> > Auto-Submit: Merissa Tan <liyingtan@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798253} TBR=oshima@chromium.org,xutan@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,liyingtan@google.com Change-Id: I39d80057e7bcfda6bbfab5d2ea99d0d94a743aaf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:158686809 Bug: 1116682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358690Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798400}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dca46604..7ffb9c58 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f7c74571668fa042591ae18fcba935d2c848b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358209Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798399}
-
Ajit Narayanan authored
This CL makes user-select:none property visible to accessibility features via a new boolean attribute, kNotUserSelectable. This is, for example, useful for select-to-speak, which we expect to skip non-user-selectable text. The property is default-false in order to be memory-efficient and backwards-compatible. Most nodes in the DOM will not have user:select none, so this property will be omitted from the tree unless the user explicitly marks user:select=none. Bug: 830106 Change-Id: I7c8ea7b994514c102389a23bfc5d372ea4737da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353127 Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798398}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/24b5971b84c0..f58009646845 2020-08-14 enga@chromium.org end2end_tests: Forward Windows debug messages to stderr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I14875ba990230317c267b44bdc1c74e0d6ecae14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357554Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02b64b9591b9..261894d3340d 2020-08-14 michael.liao@microsoft.com [CSSProperty]: Handle null value for css variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114181 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I975810852e919e5aa8c4d423a0688c4d24d3ae02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358090Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43f49b4d52a4..939cc7a63059 2020-08-14 jvanverth@google.com Some fixes for Flutter memory issues. 2020-08-14 jvanverth@google.com Check for work completion before purging resources. 2020-08-14 johnstiles@google.com Fix SkSL constant propagation within nested casts. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Id06fb1384e09ac8eddc37e922843bbc0e7a53111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357560Reviewed-by:
-
Jesse Schettler authored
Update the Document Scan API to use the LorgnetteScannerManager to get available scanners and perform scans. Bug: b:153541027 Change-Id: I57f70d0959a6a676a34e2956a3908ddb165ed84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318311 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798394}
-
Dominic Farolino authored
This CL introduces the PerfectHeuristics UKM event, along with a boolean metric for when a blink::ScriptRunner comes across an async script before the script element's node document has finished parsing. The PerfectHeuristics UKM event is logged in the UkmPageLoadMetricsObserver. See the Google-internal UKM privacy review: https://docs.google.com/document/d/1UqkpGXc4LEh5jzzVR8fCVVTuCuG2mwvhQTuCy36zT3g/edit# See the Perfect Heuristics [1] project document (currently Google-internal). [1]: https://docs.google.com/document/d/1Y7uF76Gq0VlJZky2j7x-lbD1_awH64eW0WRg1bNLuFs/edit R=falken@chromium.org, nhiroki@chromium.org, ryansturm@chromium.org, sophiechang@chromium.org Bug: 1086227 Change-Id: I71954491a1a559c2e1244a543092f1b8f38b8136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340845 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#798393}
-
Moe Ahmadi authored
Feature being launched in cr/326256148 - Enables ntp_features::kRealbox and omnibox::kZeroSuggestionsOnNTPRealbox which control the realbox and zero-suggest in realbox respectively. - Enables omnibox::kZeroSuggestionsOnNTP which should've been enabled in crrev.com/c/2175138. - Removes applicable fieldtrial_testing_config.json entries and adjusts test expectations. Change-Id: I1889e65c23e02624b85f0291600b26382e75f828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354993Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798392}
-
Becca Hughes authored
This CL moves the Kaleidoscope NTP module upstream into the Kaleidoscope repo. The public Kaleidoscope module is now responsible for loading the resources into the NTP page. Also adds the KaleidoscopeDataProvider to the NTP. BUG=1114862 Change-Id: Ibc255ea9d7fd05b10cb151d0f1e86b0f94b192cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354717 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798391}
-
Tarun Bansal authored
Change-Id: I46a7030d3444e57dc61b2663d79d9fc9217b2a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357467Reviewed-by:
-
Lei Zhang authored
This reverts commit 29499d24. Reason for revert: Broke the linux-chromeos-chrome bot. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7735 Original change's description: > Convert scanning app to system web app (SWA) > > The SWA uses a temporary icon and is hidden behind a feature flag that > is disabled by default. > > Bug: 1059779 > Change-Id: I9cee9b2de42a49285a8ee5ba2877d6394a7ca5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348539 > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798367} TBR=khorimoto@chromium.org,ortuno@chromium.org,jimmyxgong@chromium.org,jschettler@chromium.org Change-Id: I63c9b0497c709def532c052a8c6bdc4eb8f0a200 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358569Reviewed-by:
-
Daniel Rubery authored
This CL changes the DownloadFeedbackService to know about the profile it is performing feedback for, and to use that profile to get the appropriate URLLoaderFactory. Bug: 1049833 Change-Id: I63b958cbfbcec2129315c7a680ca25eb1221d8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347224 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#798388}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ic4c6561d5cdaf55b844dc96be9d9c50a96c08303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358031Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798387}
-
Thomas Guilbert authored
This CL adds the ability to clone a blink::VideoFrame. Doing so creates a new VideoFrame, with a new reference to the same underlying media::VideoFrame. This allows users that want to keep a frame alive to pass a clone to workers or objects which might destroy the frame. An example use case might be a user sending cloned reference to different workers, which can then call destroy() on the frames without impacting each other's work. A user could also send a clone to VideoEncoder, to keep using the frame after the VideoEncoder is done with the clone and calls destroy on it. Bug: 1108023 Change-Id: Ia4f22f1429e466474fb87ce9700a54b87428440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355092 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
This CL fixes VideoFrame constructor crash, when it is passed a closed ImageBitmap. This happens because the passed pointer is valid, but we use ImageBitmap::ImageBitmap() without checking its returns value. Change-Id: I04858a194026f3448e40a62d556153c32c8bdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357458 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
Always handle "avif" in FileExtensionToImageType(), whether the "AVIF" feature is enabled or not. The file-scope internal function FileExtensionToImageType() is only called on the return value of the virtual method ImageDecoder::FilenameExtension(). Therefore, the only way the image_extension argument is equal to "avif" is that AVIFImageDecoder::FilenameExtension() is called. So it does not need to check if the AVIF feature is enabled, because we still want to run AVIFImageDecoder unit tests when the AVIF feature is disabled. Test: blink_platform_unittests --enable-features=AVIF --gtest_filter=*AVIF* blink_platform_unittests --disable-features=AVIF --gtest_filter=*AVIF* Bug: 1116502 Change-Id: I17e0290fef25a508c4e87cbdc07a27ef0dac73b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357957Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#798384}
-
Lei Zhang authored
AutoplayMetricsBrowserTest.RecordAutoplayAttemptUkm is failing on non-Windows platforms as well. Bug: 1101841 Change-Id: I641bcbadd9e3ad52bcc4a5bc39bac08a4dbf34e5 Tbr: tommi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357619Reviewed-by:
-
Klaus Weidner authored
Propagate the "is_xr_overlay" fullscreen request type flag for OOPIF requests via mojo, and ensure that visibility is set correctly for out of process container iframe elements. Note for testing: Currently, Chrome on Android only enforces site isolation for sites with login active, and not on low memory devices. Run with the --site-per-process command line flag to override this. Bug: 1101193 Change-Id: Ic8736e90f28fbda2d6cb1f665cbd0804c3f38cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283968 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This adds enterprise policies to enable auto-denying access to the file system via the native file system API to certain URLs. No policy yet for auto-granting, as that seems more dangerous, and also probably would be better in the form of granting access to specific paths rather than blanket access. Bug: 977764 Change-Id: Ie6d9f8c6cdef84ce922a7b110ab1424499157820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321240Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#798381}
-
Yuke Liao authored
Bug: 1116180 Change-Id: Ida6cf332036dec7bcfa2b78efbfb19a278e59a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357680 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798380}
-
Stephen McGruer authored
On Windows, handlers are not inherited by default (unlike unix). This includes stdout and stderr, so by default a process launched via CreateProcess does not send output to the same place as its parent. When running ChromeDriver manually in a terminal this is fine, since all the output ends up in the terminal anyway, but if ChromeDriver is launched programmatically then the root process cannot see the output from the browser: my_runner.exe --> chromedriver.exe --> chrome.exe In the above example, without inherited handles my_runner.exe does not see chrome.exe's output. The solution is to set the stdout and stderr handles to be the same ones that ChromeDriver is using, and make them explicitly inherited. Bug: 1109233 Change-Id: Iac18beed5583ea7b7830015d765f3670c86b652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335355 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2a426bd66bc..df20c91466d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thestig@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099982 Tbr: thestig@google.com,juanmihd@google.com Change-Id: I011254c480ff501d0b818ce49d9e2380a4bbf68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798378}
-
Lei Zhang authored
DumpAccessibilityTreeTest.AccessibilityAriaMenuItemInGroup is failing. Bug: 1116627 Change-Id: I05ed4eba63137de5654a1652d45c5248df95fece Tbr: aleventhal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357463Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27391a090ec2..2e5647c8eede 2020-08-14 jmadill@chromium.org Vulkan: Switch buffer barrier check. 2020-08-14 nguyenmh@google.com Add unittests of ANGLE commit message format check 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 61bf3be73c1e to 527e67e9d933 (1 revision) 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6b0de7007af5 to 1980311465cf (2 revisions) 2020-08-14 msisov@igalia.com X11 and Ozone: fix compilation of tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1085700 Tbr: ynovikov@google.com Change-Id: Id892f2233392dd77a87dc74117e949ddbe61c2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357589 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
- 14 Aug, 2020 1 commit
-
-
Robert Ogden authored
The origin prober needs to support setting up a TLS connection, for which resolving DNS is the first step. This CL refactors the origin prober to make that first step possible. Bug: 1115731 Change-Id: I67cb45d707a608770954e56f7e3688c1e49a4372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356267 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
