- 14 Jul, 2017 40 commits
-
-
Lukasz Anforowicz authored
This CL introduces the following helpers for setting field trial params from test code: content/public/test/test_util.h: // Appends command line switches to |command_line| to enable the // |feature| and to set field trial params associated with the feature // as specified by |param_name| and |param_value|. void EnableFeatureWithParam(const base::Feature& feature, const std::string& param_name, const std::string& param_value, base::CommandLine* command_line); components/variations/variations_params_manager.h: // Appends command line switches to |command_line| in a way that // mimics SetVariationParams. static void AppendVariationParams( const std::string& trial_name, const std::string& trial_group_name, const std::map<std::string, std::string>& param_values, base::CommandLine* command_line); Change-Id: Ibdcd7931c2894b9d5d77334d286bf3142034591a Bug: 740701 Tbr: bauerb@chromium.org, bartfab@chromium.org, nparker@chromium.org Reviewed-on: https://chromium-review.googlesource.com/565224 Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Dan Sinclair <dsinclair@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Charlie Reis (OOO until July 19) <creis@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486814}
-
Quinten Yearsley authored
TBR in order to green up the waterfall TBR: fmalita Bug: 743068 Change-Id: Ic94118d288b7d1a4568e95df2538cef0542cb007 Reviewed-on: https://chromium-review.googlesource.com/572041Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486813}
-
ymalik authored
This CL adds VrFirstRunActivity which has the android:enableVrMode attribute which keeps us in VR mode when starting Chrome. We need this because VrCore doesn't allow non-active VR apps to call DOFF. Starting Chrome with a pure VR activity sets Chrome to be the active VR app in time for us to call DOFF. The new activity can be removed when VrCore allows transitioning activities to call DOFF without being the active VR app. BUG=721885 Review-Url: https://codereview.chromium.org/2980453002 Cr-Commit-Position: refs/heads/master@{#486812}
-
xdai authored
setup dialog. When setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery. However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers. BUG=735244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979903003 Cr-Commit-Position: refs/heads/master@{#486811}
-
Xida Chen authored
After this change: https://chromium-review.googlesource.com/c/570003/, two layout tests under css-paint-api/ starts failing. I found that the common thing with these two tests is that there is a repeat-x or repeat-y in the css style. Not sure why that causes the failure. Instead, this CL changes it to fill a rect, which will be less sensitive to AA changes. Bug: 742991 Change-Id: I16e4cddbcbd466852d43a07d658460f4e07e6a47 Reviewed-on: https://chromium-review.googlesource.com/571027Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486810}
-
Duc Bui authored
started_in_foreground in PageLoadMetricsObserver::OnStart() is false for foreground tabs in session restore. This patches fixes 2 things: 1. Correct the in_foreground variable in MetricsWebContentsObserver constructor. 2. Pass the correct visibility status of tabs in session_restore.cc. TBR=xiyuan@chromium.org BUG=740252 Change-Id: Ic8ab868bc850b20070813ec659d64c60345cc160 Reviewed-on: https://chromium-review.googlesource.com/569578 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486809}
-
Jonathan Ross authored
This reverts commit b18491dc. Reason for revert: Viz currently does not support the mash configuration. Due to this the compositor cannot be used in mash_browser_tests. The tests have been disabled on the waterfall. See crbug.com/742966 Original change's description: > Disable Compositor:DidFailToInitializeLayerTreeFrameSink NOTREACHED > > One third of CQ runs of mash_browser_tests are failing when hitting the > NOTREACHED in Compositor:DidFailToInitializeLayerTreeFrameSink so I'm disabling > it while the cause is researched. > > TBR=sadrul@chromium.org > > TEST: mash_browser_tests > Bug: 742966, 743028 > Change-Id: I9363ebfbdeac594d26696b5426004cbafcec9c9b > Reviewed-on: https://chromium-review.googlesource.com/571274 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486771} TBR=sadrul@chromium.org,jonross@chromium.org Change-Id: Ic7eb38c23b6330dc27d5fddb0e546b83ec08b6d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 742966, 743028 Reviewed-on: https://chromium-review.googlesource.com/572003Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#486808}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3921afc2..1115d872 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I7466e0a712700c182dcf7c1109abed839f832c47 Reviewed-on: https://chromium-review.googlesource.com/571276Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486807}
-
Matt Menke authored
Bug: 734870 Change-Id: I0e2eb546795892c9aef7c24b50e46696c42ff7ed Reviewed-on: https://chromium-review.googlesource.com/570501Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486806}
-
Dirk Pranke authored
It looks like they have several issues. This removes them from both the "Linux ChromiumOS Ozone Tests (1)" builder and the "Linux ChromiumOS Tests (1)" builder, so it should stop breaking the CQ builds. TBR=jonross@chromium.org, kbr@chromium.org, qyearsley@chromium.org NOTRY=true BUG=742966 Change-Id: Ie96885593e40b1ff62e76dc1b09aa01d15e20529 Reviewed-on: https://chromium-review.googlesource.com/572079Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486805}
-
Daniel Bratell authored
The files listed in core_generated jumbo exclusions have since been fixed so the exclusions are no longer necessary. R=fs@opera.com Bug: 713137 Change-Id: Ib9a9216147e9df7d8b196de761556d3f23997448 Reviewed-on: https://chromium-review.googlesource.com/571222 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#486804}
-
Becky Zhou authored
+ Set list item translation value to 0 when app menu is anchored at bottom Before: Bottom AppMenu list items translate y position while fade in Now: List items don't translate y position while fade in when app menu is at bottom, but still translate when at top. BUG=735272 Change-Id: I0f20647807916059c7c81613772f5881c85600da Reviewed-on: https://chromium-review.googlesource.com/566588Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486803}
-
Paul Miller authored
"android update sdk" is deprecated in the O SDK. Switch to "sdkmanager". BUG=742635 Change-Id: Ia8ae4b22ed579ffc097b14d5514a8dcc63bfaf2e Reviewed-on: https://chromium-review.googlesource.com/571441 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#486802}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/477d0efcf2d9..fc4ee229a653 $ git log 477d0efcf..fc4ee229a --date=short --no-merges --format='%ad %ae %s' 2017-07-14 scroggo Fix double delete in SkBmpCodec 2017-07-14 bsalomon Make ProcessorRefTests op be a non-legacy GrMeshDrawOp 2017-07-13 bsalomon Make PrimitiveProcessorTest's op be a non-legacy GrMeshDrawOp 2017-07-14 bsalomon Make convex poly effect GM use a non-legacy GrMeshDrawOp 2017-07-14 update-skps Update SKP version 2017-07-14 csmartdalton Add "findOrMakeStaticBuffer" to GrOnFlushResourceProvider Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I7ea7e215c0dd4d1201de50e9edfcbc6e62bb3744 Reviewed-on: https://chromium-review.googlesource.com/570736Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486801}
-
Sasha Perigo authored
either the Windows or ChromeOS IsEnterpriseManaged() flags are set. As of yet, we don't have similar heuristics for getting this info from other operating systems. Bug: 600840 Change-Id: I9c319d4c24ab74058b84b47e17c1d73b1cd28908 Reviewed-on: https://chromium-review.googlesource.com/565176Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Sasha Perigo <sperigo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486800}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b63abe05c654..ebf00ecf2e83 $ git log b63abe05c..ebf00ecf2 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 etienneb Fix incorrect computation of sections when symbolizing traces Created with: roll-dep src/third_party/catapult BUG=739783 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icd11d46ea973a4069910c3aacd742ed4e228124d Reviewed-on: https://chromium-review.googlesource.com/571173 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486799}
-
Tibor Goldschwendt authored
Bug: 727955 Change-Id: Ib68a97b0ff6a548155b9fa3db1c44a4ba24c7a94 Reviewed-on: https://chromium-review.googlesource.com/566318 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#486798}
-
Josh Karlin authored
Labels frames identified as ads by the SubresourceFilter as ads. Also adds an AdType to each frame tracked by AdsPageLoadMetrics. When it's time to record the metrics, the same logic is applied once to collect stats for each ad type. There is also an additional ad type, "All", which records stats on all of the identified ads, regardless of which detector discovered it. Bug: 708570 Change-Id: Ic0f1f1cfd7176ffdba459b607735a6aa6b4318ff Reviewed-on: https://chromium-review.googlesource.com/567324Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486797}
-
arthursonzogni authored
A bug has been introduced in: https://crrev.com/2834013002. The assumption that Content-ID URLs can't be loaded without an MHTMLArchive doesn't hold. It is possible for instance with the Yahoo Mail app. It embeds chrome as a Webview. The webview load attached image with the Content-ID scheme. This CL allows the load instead of blocking it. BUG=739658 TBR=japhet@chromium.org Review-Url: https://codereview.chromium.org/2975623002 Cr-Commit-Position: refs/heads/master@{#486796}
-
kylechar authored
Make the creation of CompositorFrameSinkSupport go through HostFrameSinkManager. This takes us one step closer to viz architecture without using Mojo anywhere. FrameSinkManager is injected into HostFrameSinkManager if we want this path to be available. Every callsite in the browser process that creates a CompositorFrameSinkSupport goes through HostFrameSinkManager, with the exception of Android webview which doesn't use HostFrameSinkManager at all. This requires adding a dep from //components/viz/host to //components/viz/service again. It also requires adding an interface for DirectLayerTreeFrameSink. Bug: 742374 Change-Id: I22b9fb855b7a16716dccd4d5233c72412f9b2259 Reviewed-on: https://chromium-review.googlesource.com/570504 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486795}
-
Daniel Bratell authored
There are two very small, identical, To16Bit functions in font shaping tests. Since they caused collisions in jumbo builds and I didn't want to exclude the files from jumbo files I've merged them into a utilities file. Bug: Change-Id: I0c7e7d4ee708431a6401de7a01790f78c4e75e08 Reviewed-on: https://chromium-review.googlesource.com/570426 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486794}
-
Dirk Pranke authored
This is a reland of patchset #1 of https://codereview.chromium.org/2936053003, except that we do not pass the flag when using the ChromeOS custom toolchains, either. TBR=hans@chromium.org, manojgupta@chromium.org, thakis@chromium.org BUG=712797 Change-Id: I14f56c9b29234dd693719b017828c6250202a9d0 Reviewed-on: https://chromium-review.googlesource.com/571440Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486793}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/57f228d75275..21dd189fe50d $ git log 57f228d75..21dd189fe --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Use CFX_MaybeOwned in CJBig2_TRDProc Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I372752bccfc8f5b290bf809a9fe3d75b9c835c27 Reviewed-on: https://chromium-review.googlesource.com/571172 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486792}
-
Regan Hsu authored
Allow tether notifications to display blue icons with varing signal strength. Bug: 740686 Change-Id: I2e3477b899ece0a511270c82f48d52d44bfaf608 Reviewed-on: https://chromium-review.googlesource.com/564199 Commit-Queue: Regan Hsu <hsuregan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486791}
-
Marc-Antoine Courteau authored
The titles for the PaymentRequestEditViewController and for the PaymentRequestSelectorViewController are now computed in the mediators instead of being set from the coordinators. R=mahmadi Bug: 602666 Change-Id: I6cabdd0920854db1f06a4d6b99952ce49f396b91 Reviewed-on: https://chromium-review.googlesource.com/568264 Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
-
Scott Violet authored
Specifically the following: . TestContextProvider now uses skia_bindings::GrContextForGLES2Interface, without this skia doesn't use the right context and produces ids that aren't expected. . Converts Ash to use TestLayerTreeFrameSinkClient vs FakeContextFactory. TestLayerTreeFrameSinkClient seems closer to what these tests need vs FakeContextFactory. BUG=734811 TEST=test only changes Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4f3d7a432d7f23a9e1e243d045846949b52c51fc Reviewed-on: https://chromium-review.googlesource.com/550587 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#486789}
-
Peng Huang authored
Having one LayerTreeFrameSink for every sub-surface causes synchronizing problem between sub-surfaces, so we decide to only have one LayerTreeFrameSink per toplevel window. Bug: 731742 Change-Id: I6f3e09c33f6f98aab281ce2fab032f9df29f1e7d Reviewed-on: https://chromium-review.googlesource.com/552719 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486788}
-
Mike Case authored
Installing Xcode 9 requires sudo so we are adding a wrapper script so that we will be able to do the installation securely on the bots. BUG=736060 Change-Id: I0bee7dcf9dfe58f27bc77d200d221458fad09a44 Reviewed-on: https://chromium-review.googlesource.com/568667Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Michael Case <mikecase@chromium.org> Cr-Commit-Position: refs/heads/master@{#486787}
-
Ramin Halavati authored
There was a possible race condition between IO and UI threads in this test. It is now prevented by adding an extra wait for task completion. Bug: 739433 Change-Id: If2060e859cfb001218cee909eafb6739a4e5d314 Reviewed-on: https://chromium-review.googlesource.com/568144Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486786}
-
Dominic Battre authored
The PasswordFormMetricsRecorder enforced that a single save/update bubble was shown to users. With manual fallbacks, this restriction is too strong. Therefore, this CL introduces an enum that tracks the currently displayed bubble, which is enough to attribute dismissal reasons to update/save bubbles. Bug: 732846 Change-Id: I84377c4416962dfd0ed1f3e4e601aaa9f87bd042 Reviewed-on: https://chromium-review.googlesource.com/571005 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486785}
-
proberge authored
Now that Chrome Cleanup has its own opt-in, the SBER/Scout state should not be passed to the Cleaner's command-line to make sure it isn't accidentally used. Bug: 690020 Change-Id: I6f1ecb60f2a9d0bdb5c3f4bbab728621082a2879 Reviewed-on: https://chromium-review.googlesource.com/570349Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#486784}
-
Yipeng Wang authored
This CL also deletes webview_licenses.py and related files. Bug: 734846 Change-Id: Ib1dcdbd10c8c97993811e0c977bfaa68d0562315 Reviewed-on: https://chromium-review.googlesource.com/569075Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
chrome://dinoEdward Jung authored
Remove top:0 in CSS and take into account the initial 35px top positioning in the translate calculation. Bug: Change-Id: I7634e2308fa8a18dff35ab9572e8e9f323741696 Reviewed-on: https://chromium-review.googlesource.com/571822Reviewed-by:
-
Matt Falkenhagen authored
This clears the bindings right when the filter is removed, instead of when the filter is destructed. Speculative fix for the bug where apparently Mojo messages arrive after the ServiceWorkerDispatcherHost has been destroyed. Bug: 736203 Change-Id: Ifae0db23a6a17cfa30b558f714916001d37f6571 Reviewed-on: https://chromium-review.googlesource.com/564746 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486781}
-
James Cook authored
session_state_delegate_chromeos.(h|cc) don't exist anymore. TBR=xiyuan@chromium.org Bug: none Test: checkdeps passes Change-Id: I9f258838cf3f5f6e966b53b8954973fa7403e117 Reviewed-on: https://chromium-review.googlesource.com/571963 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Theresa Wellington authored
Notify BottomSheet, BottomSheetContentController, and BottomSheetNewTabController about activity destruction and do appropriate clean up (including ending animations). BUG=741041 Change-Id: Iee2d185d87e520e99a865cb569cc14a006aba55f Reviewed-on: https://chromium-review.googlesource.com/570719 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cf79ee5626dd..477d0efcf2d9 $ git log cf79ee562..477d0efcf --date=short --no-merges --format='%ad %ae %s' 2017-07-14 bsalomon Make ops in bezier_effects GMs be non-Legacy GrMeshDrawOps 2017-07-14 liyuqian Remove SK_SUPPORT_LEGACY_RECT flag 2017-07-14 ethannicholas fixed sksl static ifs to work for CircleEffect 2017-07-13 bsalomon Make ops used in OnFlushCallbackTest be non-legacy GrMeshDrawOps. 2017-07-13 fmalita Purge cached SkPictureShader entries on shader deletion 2017-07-13 egdaniel Add metal config to tools 2017-07-14 bsalomon init GrDrawAtlasOp::fColor Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: If0d3a27e0068100aae09c4d6e3e0b0b3bc5198c6 Reviewed-on: https://chromium-review.googlesource.com/571509Reviewed-by:
-
mrefaat authored
Set the pendingItemIndex to the last committed item in case of page reload and on the case of application open/tab out of memory reopened. This doesn't solve the PendingItem being null problem entirely there are still couple cases when that can happen and they are not page reloads. CL 1/2 BUG=676129 Review-Url: https://codereview.chromium.org/2931833004 Cr-Commit-Position: refs/heads/master@{#486777}
-
Elly Fong-Jones authored
This code only works when USE_AURA, which is when gfx::NativeView is an aura::Window. BUG=None Change-Id: I6fd619acb4bcf854a111d43295ed20186d47f872 Reviewed-on: https://chromium-review.googlesource.com/565300 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#486776}
-
Emil A Eklund authored
In r484771 the painting logic for table cells and rows with a background image was inadvertently changed as a part of a refactoring. This in turn led to the wrong ImageClient being used in cases where the background is set on the table row as opposed to the cell. The bug was introduced between patch set 3 and 4 of the original change. This CL restores the original behavior by using the correct ImageClient. TEST=fast/table/backgr_on_table_row.html BUG=742053 R=pdr@chromium.org Change-Id: I7316ddf34698ba78d43067dd46610ece628ef7fe Reviewed-on: https://chromium-review.googlesource.com/571158 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486775}
-
