GitLab

This is in response to problems with loading.mobile on Android One/3G,
where almost all stories were timing out.

BUG=673461

Review-Url: https://codereview.chromium.org/2577243002
Cr-Commit-Position: refs/heads/master@{#438969}

When a Safe Browsing warning is showing, the Developer Tools Security
panel should show custom text in the summary area.

BUG=654600

Review-Url: https://codereview.chromium.org/2542533004
Cr-Commit-Position: refs/heads/master@{#438968}

Blink objects that implement (Active)ScriptWrappable have the ability
to keep their corresponding v8 wrapper object alive across GCs by
overriding and implementing ScriptWrappable::hasPendingActivity().

Once an ExecutionContext has become detached, we no longer want to
retain wrappers belonging to it, as that will lead to memory leaks.
With full bi-directional tracing of references across the v8 and Blink
heaps, it is possible to make the lifetime of objects "more accurate",
but not keeping a wrapper alive once in a detached setting, has proven
to work out well in practice.

Consequently, a ScriptWrappable in a detached ExecutionContext should
not be retained, even if hasPendingActivity() return |true|. That is,
we should simply ignore hasPendingActivity()'s result, freeing the
implementations of it from having to take care of this 'detached'
detail.

This behavior is already provided by the 'standard' Blink wrapper
visitors that v8 invokes during GC, but not with wrapper tracing,
which is what this CL brings.

It does so by extending ActiveScriptWrappable with a predicate for
checking if the object's ExecutionContext has signalled destruction.

(The natural(?) way to express that is to parameterize ActiveScriptWrappable<>
over the class that implements the interface. This makes for a CL
with a larger footprint.)

R=haraken, mlippautz
BUG=468240

Review-Url: https://codereview.chromium.org/2577053002
Cr-Commit-Position: refs/heads/master@{#438967}

BUG=622400

Review-Url: https://codereview.chromium.org/2574403002
Cr-Commit-Position: refs/heads/master@{#438966}

If the last tab is moved to the other window and the device has a home
page, the original activity closes, which leads to a weird, confusing
animation. There's not a strong use case for having two windows open
with only one tab.

BUG=674684

Review-Url: https://codereview.chromium.org/2575343003
Cr-Commit-Position: refs/heads/master@{#438965}

BUG=

Review-Url: https://codereview.chromium.org/2577193002
Cr-Commit-Position: refs/heads/master@{#438964}

Remove support for reading persisted settings with old values "npn-h2"
and "npn-spdy/3.1".

This CL is a follow-up of
https://codereview.chromium.org/2129973002/diff/1/net/http/http_server_properties.cc
and
https://codereview.chromium.org/2353333005/diff/1/net/http/http_server_properties.cc

Review-Url: https://codereview.chromium.org/2579543003
Cr-Commit-Position: refs/heads/master@{#438963}

because that would break the throttling logic which needs to know when the next delayed
task is due to be run.

BUG=671669

Review-Url: https://codereview.chromium.org/2572893002
Cr-Commit-Position: refs/heads/master@{#438962}

The text was weirdly vague, trying to be cross-platform but not succeeding, there were odd conditions that could cause leaks, and there was about twice the complexity built in than it actually ended up using.

BUG=555865

Review-Url: https://codereview.chromium.org/2440273002
Cr-Commit-Position: refs/heads/master@{#438961}

handler as an argument, rather than passing them as data members.

Eliminate the render_frame_message_source_, render_view_message_source_
data members. Eliminate the HasValidFrameSource() helper method.

Eliminate the combo version of OnMessageReceived that took both an RFH
or an RVH, and instead do the dispatch in the delegate
OnMessageRecieved methods. Use the _WITH_PARAM dispatch macro to
plumb the RenderFrameHostImpl into the dispatch methods.

Fix some bugs that became apparent after this refactoring:
  OnEndColorChooser: insist on rfh/rph match (via a ::Matches helper)
  OnSetSelectedColorInColorChooser: insist on rfh/rph match
  OnOpenDateTimeDialog: use |source| rather than GetRenderViewHost.
  OnEnumerateDirectory: Use the right process for permissions check
  OnRequestPpapiBrokerPermission: rename |routing_id| to reflect that
    it's not a frame or view route ID.
  SendPpapiBrokerPermissionResult: rename this from On... to
    Send..., since it's not a dispatcher. Parameterize by the
    RPH id, so that we send the response to the right process.

BUG=304341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563233002
Cr-Commit-Position: refs/heads/master@{#438960}

BUG=674367

Review-Url: https://codereview.chromium.org/2576293002
Cr-Commit-Position: refs/heads/master@{#438959}

This is recording how often the metadata are already available/needed
and the result of the lock attempt.

BUG=670455
R=asvitkine@chromium.org, zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2581603003
Cr-Commit-Position: refs/heads/master@{#438958}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/98f5b96b79b3..eb5390d22252

$ git log 98f5b96b7..eb5390d22 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 jessimb Fixes table formatting and changes unknown units labeling.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2584653003
Cr-Commit-Position: refs/heads/master@{#438957}

Make two presets: Basic and Advanced
Make two buttons: Record and Record Page Load

BUG=570441

Review-Url: https://codereview.chromium.org/2576303002
Cr-Commit-Position: refs/heads/master@{#438956}

When wrapping an invalid SharedMemoryHandle, we should always
just return a null ScopedSharedBufferHandle. Currently we return
a non-null ScopedSharedBufferHandle which wraps an invalid platform
handle. This will always fail to serialize and is generally bad.

Also fixes DiscardableSharedMemoryManager mojom to allow a null
shared buffer handle in the response to
AllocateLockedDiscardableSharedMemory. The existing client implementation
already handles the null case, so no additional code changes are required

BUG=674406

Review-Url: https://codereview.chromium.org/2583583002
Cr-Commit-Position: refs/heads/master@{#438955}

PngWriteStructDestroyer accesses info_ptr, so
info_ptr must have a wider lifetime scope. Otherwise,
the behavior of the problem is undefined.

The issue is found by AddressSanitizer with use-after-scope check enabled.

BUG=649897

Review-Url: https://codereview.chromium.org/2576823002
Cr-Commit-Position: refs/heads/master@{#438954}

https://skia.googlesource.com/skia.git/+log/344ec42f60fd..d85dd53e288e

$ git log 344ec42f6..d85dd53e2 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 brianosman Shrink the SkImageGenerator API
2016-12-14 stani Exclude complexclip4 GM tests from tile_rt config
2016-12-15 reed speedup dynamicwstream
2016-12-13 mtklein Port SkResourceCache to SkTHashTable
2016-12-15 reed remove unused dynamicwstream.snapshotAsData()
2016-12-15 kjlubick Update Pixel Cs -> NFM26H

BUG=429375

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2584513005
Cr-Commit-Position: refs/heads/master@{#438953}

This CL updates linux-sysroot-md to reflect the new steps required to
build and upload the sysroots after
https://crrev.com/4c8b67057de3ee3f6c4105a0dceebc0228d9832e.

R=dpranke@chromium.org,sbc@chromium.org

Review-Url: https://codereview.chromium.org/2579833004
Cr-Commit-Position: refs/heads/master@{#438952}

Also add a test.

BUG=673827

Review-Url: https://codereview.chromium.org/2577963004
Cr-Commit-Position: refs/heads/master@{#438951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/458e104e..2c88e4c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582633002
Cr-Commit-Position: refs/heads/master@{#438950}

animations/3d/transform-origin-vs-functions.html is failing on windows 7

BUG=674715
TBR=ajuma@chromium.org

Review-Url: https://codereview.chromium.org/2578283002
Cr-Commit-Position: refs/heads/master@{#438949}

Removed parameter that is always set to true.

Review-Url: https://codereview.chromium.org/2578093003
Cr-Commit-Position: refs/heads/master@{#438948}

BUG=674654
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2575323004
Cr-Commit-Position: refs/heads/master@{#438947}

Review-Url: https://codereview.chromium.org/2579833003
Cr-Commit-Position: refs/heads/master@{#438946}

This change adds plugin message in JingleMessage, which is an action indepenent
xml node, placed before or after other messages.

The plugin message will be used to send and receive host attributes and
experiment configuration.

This is part of host experiment framework.

BUG=650926

Review-Url: https://codereview.chromium.org/2567953002
Cr-Commit-Position: refs/heads/master@{#438945}

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Review-Url: https://codereview.chromium.org/2577903002
Cr-Commit-Position: refs/heads/master@{#438944}

This reverts https://codereview.chromium.org/2497373003, which caused
a significant crasher in canary builds (see crbug.com/674334).

TBR=edwardjung
BUG=635610, 674334

Review-Url: https://codereview.chromium.org/2579893002
Cr-Commit-Position: refs/heads/master@{#438943}

Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ )

Reason for revert:
Crashes.
BUG=674474

Original issue's description:
> [DevTools] Migrate ServiceWorker domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
> Cr-Commit-Position: refs/heads/master@{#438676}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2577233002
Cr-Commit-Position: refs/heads/master@{#438942}

http/tests/loading/preload-img-test.html is flaky on trusty

BUG=674720
TBR=alexclarke@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2576923004
Cr-Commit-Position: refs/heads/master@{#438941}

Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )

Reason for revert:
Speculative

Original issue's description:
> [DevTools] Migrate target domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> Cr-Commit-Position: refs/heads/master@{#438733}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2578303002
Cr-Commit-Position: refs/heads/master@{#438940}

BUG=654071

Review-Url: https://codereview.chromium.org/2571933002
Cr-Commit-Position: refs/heads/master@{#438939}

This CL moves filters and background filters from RenderPassDrawQuad to
RenderPass. Quads are stored in a ListContainer, which uses memcpy to
shift over elements when an element in the middle is deleted. Since
FilterOperations contain a vector, they're not safe to memcpy (and
this memcpy triggers crashes with http://crrev.com/2423483003).

BUG=664357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2543473004
Cr-Commit-Position: refs/heads/master@{#438938}

BUG=668341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2579433002
Cr-Commit-Position: refs/heads/master@{#438937}

This way you can run from the command line and it just works!

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2579863002
Cr-Commit-Position: refs/heads/master@{#438936}

This is a simple solution to avoid conflicting ILK filenames
generated by the linker, which apparently just strips the
output file extension.

BUG=673521
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2578183003
Cr-Commit-Position: refs/heads/master@{#438935}

BUG=653689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578813002
Cr-Commit-Position: refs/heads/master@{#438934}

https://skia-review.googlesource.com/c/6109/ (Add a deferred copy surface) rolled into Chrome at r438850 in https://codereview.chromium.org/2583513002 (Roll src/third_party/skia/ ebccb8268..625cd9e0c) so these layout tests can be rebaselined

BUG=674509

Review-Url: https://codereview.chromium.org/2585523002
Cr-Commit-Position: refs/heads/master@{#438933}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f87ce97ea1fa..98f5b96b79b3

$ git log f87ce97ea..98f5b96b7 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 fmeawad [TraceModel] Avoid duplicate cpuDuration for traces with an associated atrace and original thread times

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2585493002
Cr-Commit-Position: refs/heads/master@{#438932}

When the "Payment not secure" message is shown, the item below it should
be "Payment autofilling disabled" instead of the "Automatic credit card
filling is disabled..." message, and it should use the normal font
rather than the warning font.

This CL adds a new string and uses it for this warning
message when the form-not-secure experiment is enabled. See
https://bugs.chromium.org/p/chromium/issues/detail?id=672666#c2 for a
screenshot.

The new warning message is styled the same as the existing warning messge.
To match the form-not-secure mocks, for simplicity, I've removed the warning
font list and uses the normal font for the warning message, whether it is the
original or new wording.

BUG=672666

Review-Url: https://codereview.chromium.org/2576143002
Cr-Commit-Position: refs/heads/master@{#438931}

|needs_begin_frames| is a parameter that needs to be synchronized between the
browser and renderers. A logic mistake caused this parameter to be out of sync,
causing the browser to think that every extension required an infinite stream of
BeginFrame messages.

BUG=673021

Review-Url: https://codereview.chromium.org/2577953002
Cr-Commit-Position: refs/heads/master@{#438930}