- 10 Aug, 2020 40 commits
-
-
Ben Mason authored
TBR=dullweber@chromium.org Bug: 1112409 Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#796524}
-
Mario Bianucci authored
SetNeedsDisplay() was being called many times, when every other test limits it to a certain number of times. This test should only call it once, and doing so prevents it from running wildly and flaking on the single threaded versions. Bug: 1111302, 1112507 Change-Id: I2038c89e73b7b92b03133a4cf8487a9a54467fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343221Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796523}
-
Dan Sanders authored
This improves our alignment with the current draft spec, and exposes the APIs required to implement planar access. Bug: 1096717, 1096722, 897297 Change-Id: Ic9f33ce703e4492d61ad5784c849b8816a75b89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341836Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796522}
-
Jeff Yoon authored
Appending linux as a supproted platform for the update pgo script. Adding the linux.pgo.txt with the latest profile information. Bug: 1105530 Change-Id: I63ec40b915970d9ad8a06aaaf594dcbf96dad109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347070 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#796521}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b27f3f1980fd..c92cc9537f56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112335,chromium:1112941 Tbr: sky@google.com,eirage@google.com Change-Id: I921deb41683d7f7ae19c02ba73fcb24648e2a7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346877Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796520}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I56741401e5e24da0fb37448c109ec507925c8be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346912Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#796519}
-
behdad authored
- ActivateDuration is removed as it is covered by CompositorLatency.Activation - BeginMainFrameIntervalCritical is removed as it is no longer useful Bug: 1039311 Change-Id: Ic2b31c0835a6956b4ead0cbf4c1bc75a19c74088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342576 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#796518}
-
Nicolás Peña Moreno authored
This CL improves crossiframe.html by waiting for the load event (so it knows the iframe is ready), and makes it faster by awaiting for both the main frame and iframe observers at the same time. It also improves the buffered-and-duration test by considering cases in which the first event does actually get buffered due to machine slowness. Bug: 1074048 Change-Id: Ieb356a4a4bbcfca8454e8a76334df70867b4f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343487Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#796517}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597060771-94a7300bd1819f6d10eaf4c394bfbc10cebf8f71.profdata to chrome-mac-master-1597082402-653f85831e858c9a0c668621a5e4055f49c06c11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7d77310effe572ae55e7b5d836da5e437a47adc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796516}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This is the corresponding IA2 fix for the selection-iframe crash here: https://chromium-review.googlesource.com/c/chromium/src/+/2300266 The approach is different for IA2. Since IA2's setSelectionRanges requires actual nodes to be passed in, it doesn't make sense to move the selection range to different nodes than specified. Instead, this change simply returns E_INVALIDARG when two nodes are provided that exist in different trees. I generally don't like this approach, as it is reporting implementation limitations as a user-error, but I think it's the best approach for this particular scenario. A browser test was added that would crash without this fix in place. AX-Relnotes: n/a Bug: 1110522 Change-Id: Ifa8e9e7b43c52d611d0c77b134f5cb0ab3b86357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340291 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796515}
-
Jimmy Gong authored
- Introduce a "stopped" state when the printer is in an error state and is waiting for the user to fix the issue. - For example, if a user prints to a printer that is out of paper, the ongoing print job will now update to reflect that status. - Updated browser and unit tests to reflect this change. Screenshot (full view): https://screenshot.googleplex.com/YPR4R40jNeV Screenshot (collapsed view): https://screenshot.googleplex.com/A64F7TvHspR Bug: 1093527 Test: BrowserTest and UnitTest Change-Id: Ia72f23d67066d5640698163759ddf4151a59e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342309 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#796514}
-
Sammie Quon authored
It will be between the IME pod and palette pod. Will add a simple test and place it on the correct shelf in a latter CL. Test: manual Change-Id: If67b781f558643aa42c501dddb8ebaba1017f445 Fixed: 1113938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342117 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796513}
-
Yicheng Li authored
The password and PIN views are used to receive password or PIN from the user. The relationship between the password and PIN views (both visually and functionally) should be the same as in lock screen. Because the in-session auth dialog uses white background, the password and PIN views are set to other colors to be visible. A follow-up change will query whether the user has PIN set up and hide the PIN view if there's no PIN. Bug: b:156258540 Change-Id: I63ab51839ce913ee61f159e3e56861dd9f4f735f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342364 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796512}
-
Ella Ge authored
This reverts commit 8f92c37d. Reason for revert: causing build failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? Original change's description: > Fix Role::kButton name invalidation when descendant text is modified > > This CL addresses a bug where Role::kButton, and possibly other roles > that derive their name from descendant contents, were not firing > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > ax_object_cache_impl.cc : > - When firing a text changed event, also fire a text changed event for > the first ancestor that derives its name from descendant contents. > This ensures the nodes are invalidated, send appropriate text changed > events, and the changes are serialized to the browser process AXTree. > > browser_accessibility_manager_win.cc : > - FireUiaTextContainerEvent made it possible to fire text events more > than once for a given text provider so it has been removed. > - Instead, populate a set |text_changed_events_| which contains the > text providers via |GetUiaTextPatternProvider| and fire the UIA text > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > - |text_selection_changed_events_| could also potentially end up with > the same double-event problem, so it uses GetUiaTextPatternProvider > now as well. > - Removing usage of std::unordered_set based on the guidance in > base/containers/README.md. In general these sets shouldn't grow large > enough to benefit from being unordered. > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > Bug: 1105262 > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796464} TBR=nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com Change-Id: I0f08f5bccffe90464269207366411876f3d37d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346996Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796511}
-
John Delaney authored
What: Re-lower conversion database sequence task priorirty. Why: The priority was raised to USER_VISIBLE on https://crrev.comc/2225739 in an attempt to resolve test timeouts seen with the feature enabled. This change did not fix the flakes, and the flakes were later addressed separately. This returns the priority to the intended value, as conversion operations work fine with delays. Bug: 1080764 Change-Id: I5f5907bd5e7711b0a6ed1db45db9f3713acf4765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340714Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796510}
-
Morten Stenshorne authored
The list of parameters was getting too long. Change-Id: Ia42d102b9333dc37deed7ea8450e4ff42abc3f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346385Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796509}
-
Daniel Cheng authored
Currently, state synchronization between the browser and the renderer process is complicated and buggy for cross-process navigations. The renderer process is responsible for processing the commit IPC and then reporting success back up to the browser process, which then updates its state. However, it's unclear if this can lead to races. Instead, if it is possible to assume that one `CommitNavigation()` IPC from the browser always maps to one committed navigation in the renderer, the code can be simplified to remove multiphase navigation commits. This means the browser would be able to mark a provisional local frame as committed as soon as it sends a commit IPC to the renderer for that frame. As an initial step in this direction, this CL implements a renderer-side `CHECK()` that a request to commit a navigation from the browser always results in a committed navigation, with some initial exemptions for fallback content for embedded content, et cetera. However, this new `CHECK()` exposed some existing bugs in MHTMLx handling. The browser side navigation code does not know enough about an MHTML archive to determine if a commit will succeed or fail. Instead, the browser always assumes that a subframe navigation request will succeed and simply always calls `CommitNavigation()`. Unfortunately, the renderer silently ignores commit requests in subframes if the associated resource cannot be found in the MHTML archive, which triggers the new `CHECK()`. To fix this, committing a navigation to a non-existent MHTML resource will now simply commit a document constructed from an empty string with the text/html MIME type. This required updating the expectations for some existing MHTML tests that tested loading of non-existent MHTML resources. Before, the last committed URL would simply be empty, since the commit would silently be dropped. After, the last committed URL is now the URL of the non-existent resource. Finally, NavigationMhtmlBrowserTest.IframeAboutBlankNotFound exhibited a large number of complex interactions that still are not fully understood. It looks like the renderer now reports load completion *after* the about:blank fragment navigation completes, so update the test expectations accordingly... Bug: 999255 Change-Id: I2f9ac23b5668886b8b3bbbdcb7925f8784480c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335323 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796508}
-
Yuly Novikov authored
TBR=kbr Bug: 1114780 Change-Id: Ifa3282c1a9391003eedd878f34ec0ff34da05835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346991Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796507}
-
Rune Lillesveen authored
This is an alternative fix for issue 1104634 which should be equivalent to the behavior before the regression introduced in [1]. We now call UpdateActiveStyle() explicitly instead of relying on the UpdateActiveStyle() that was previously called via EnsureStyleResolver(). [1] https://crrev.com/dc63d9714044c5cc7825ed1d511d7810ba93a9a8 Bug: 1104634, 1113626 Change-Id: I4959ddf0a2efd237a04e29202d3432bbb7799eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346284Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#796506}
-
Nate Fischer authored
No change to logic. This generates AwSwitches.java from aw_switches.cc using java_cpp_strings. Fixed: 956803 Test: autoninja -C out/Default system_webview_google_apk Test: run_webview_instrumentation_test_apk -f=SafeBrowsingTest.* Change-Id: I1933e812e5206eb8ae087d30e1abf61d2695991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343951 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#796505}
-
Evan Stade authored
Bug: none Change-Id: I3a6df417b0bdbb105e0f22506ca764a2d328c818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347048Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#796504}
-
Himanshu Jaju authored
- Extract common set up for incoming connections - Extract common set up for accept / reject flows - Add a TODO for fetching certificate for outgoing share target based on parent CL Bug: 1085068 Change-Id: I3b3e322026c3cfe2fe86808f92bfd0b1d810f94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344604 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796503}
-
Liquan (Max) Gu authored
Change: 1. Before - CardEditor, PRImpl, CPRImpl all retain a reference to ObserverForTest. After - only CPRImpl retains a reference to ObserverForTest. Other classes accesses it from CPRImpl. 2. Before - ObserverForTest.onPaymentRequestCreated() took PRImpl as its parameter. After - it takes CPRImpl as its parameter. 3. Before - ObserverForTest.onPaymentRequestCreated() was called within the constructor ("this" was used before it finished construction). After - it is called outside the constructor. 4. Before - mSkipUiForNonUrlPaymentMethodIdentifiers lives in PRImpl. After - it lives in CPRImpl. This change is necessary because PRTestRule no longer references PRImpl after the #2 change, and PRImpl was only used to set mSkipUiForNonUrlPaymentMethodIdentifiers only. Acronym: CPRImpl = ComponentPaymentRequestImpl PRImpl = PaymentRequestImpl PRTestRule = PaymentRequestTestRule Bug: 1102522 Change-Id: Ib1897939d369f16d6f6a9752d5a894ee555feee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342261 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796502}
-
Jan Wilken Dörrie authored
This change adds conversion functions between base::StringPiece and absl::string_view. This is to aid the adoption of other Abseil features, that make use of the otherwise banned absl::string_view in their public API. Fixed: 1113880 Change-Id: Ib038a4e71fb0ce6470304e4151474a5d92809d22 Bug: 1113880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345306 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796501}
-
Yuwei Huang authored
This CL makes the iOS app use the newer Google account management library instead of the deprecated one, i.e. we no longer use the side menu and will use the circular profile button on the top-right corner of the screen. Code changes in this CL include: * Introduce an AccountManager as an abstraction layer to Google-internal account management UI components, also with an AccountManagerChromium implementation for the public build. * Deprecate AppViewController and remove AppViewControllerChromium as the new UI component doesn't act as the root view controller of the app. * Remove ToS and Privacy Policy from the side menu items, as the new UI already comes with these links in the footer. Internal change: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3202666 Demo: https://screencast.googleplex.com/cast/NDYyMzk5MDAzNzQxMzg4OHxkODBmNGI4OC01YQ Bug: 810097 Change-Id: I660e2aeef7337050e827f3a32b524deac7b0e462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343637 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#796500}
-
Matt Jones authored
This patch converts the toolbar's composited texture and logic into its own MVC component. The ToolbarSceneLayer has become the "view" of the new component and is now TopToolbarSceneLayer. All classes related to the component live in .../browser/compositor/overlays/toolbar. This patch also adds a small suite of unit tests. Bug: 1100332 Change-Id: If34fef9378a7b64524e6eb31e381c48b636a94aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302853 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#796499}
-
Caitlin Fischer authored
Also, make wychen the owner of this histogram. Bug: 1110301, 1110961, b/162309838 Change-Id: I8d0471a4a9fbb52b3f778a612bd617146cc175a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323501 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796498}
-
Himanshu Jaju authored
- Parses incoming advertisement and creates ShareTarget from it. - Inject CertificateManager from factory for mocking in tests. Bug: 1085068 Change-Id: I1b1ed2252baa59e68f4daa1e772a51e9cf32eff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332725 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#796497}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12bc13e26d28..7b17f160f76a 2020-08-10 aerotwist@chromium.org [global] Stage second impl of ThemeSupport If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I489f3af5dd80232574296ca89c1ae900ab790d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346875Reviewed-by:
-
Livvie Lin authored
Change-Id: Ia12de00773aca815151b4475e37152b524b21bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347045Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796495}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu uses kInProcessCommandBufferClientId as it's client id. Tell GrShaderCache to cache shaders from kInProcessCommandBufferClientId to disk. Bug: 1114763 Change-Id: I71d66b007abf76358b28937eae505198e7f882d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346986Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796494}
-
Ella Ge authored
Tbr: katie@chromium.org Tbr: ellyjones@chromium.org No-try: true Bug: 1054641 Change-Id: I0d5896afccb2012beea0edb9505ee620f263c318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346055Reviewed-by:
-
Xing Liu authored
This CL adds a flag to enable Chime push notification channel on canary. Bug: 1105693 Change-Id: I647a64743399f07c65652728345bdb7d96b0e153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346832Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796492}
-
Elly Fong-Jones authored
The way it's implemented is very non-obvious and hard to find via code search, so add a comment explaining it and an explicit xref to the involved PlatformStyle constant. Bug: None Change-Id: Ia1756752d403cffac434d6249897b2d5d35eeba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342572 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796491}
-
Joshua Bell authored
A follow-on to a previous fix[1] to handle the recursive case. A limit was imposed on key length to prevent OOMs as JS arrays are converted to IDB keys. Array keys were handled, but not nested arrays. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2304445 Bug: 1113505 Change-Id: I6eb184cf75e5b39eecfdb79f1d10536d68251452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346839 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796490}
-
Steven Bennetts authored
This addresses some inconsistencies with the 'Other' APN UI encountered when switching between carrier networks within a Cellular Service. It also adds support for 'Other' entries with accessPointName values matching an existing entry but with different username or password values. Additionally it fixes some instability in the UI while scanning (when the device properties become unavailable). This fixes that by postponing Cellular property updates until scanning completes. Bug: 986921 Change-Id: If5a012e38e5af32ffe4832c553396b94361b86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333536Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Jonah Chin authored
This CL splits GetRasterSkImage() into two explicit functions: GetSwSkImage() will always do a readback for texture backed images. GetAcceleratedSkImage() will return a texture backed SkImage and is limited to specific callers. PaintImage::readPixels() handles callers who previously used PaintImage::GetSkImage()->readPixels(). This is necessary for GetSkImage()'s deprecation. In the OOPR case, this new API is routed through the readback on RasterInterface via TextureBacking. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: Icdbb4941ba199e04bfc163f8638d8293131480c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316413Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796488}
-
Becca Hughes authored
Change-Id: Ib25fc8454cac9db5c17e0fd4c1952bbe7a2a4c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342388Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796487}
-
Sebastien Lalancette authored
Adding a new SharingCoordinator initializer and updating ActivityServiceCoordinator's initializers to enable triggering a URL sharing flow for URLs that aren't necessarily associated with a WebState. Some activities that depended on a WebState have been disabled for that flow (e.g. Print, Find in Page). Also, this CL makes ThumbnailGenerator optional for ChromeActivityURLSource, as no thumbnail can be generated without a WebState. This CL also modifies the initialization of ActivityServiceCoordinator to use a new ActivityParams object which will contain the properties used to configure the various sharing flows. Bug: 1102892 Change-Id: I0b28d5fcc7bae78e669dbfac33ba252165ce86bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319793 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796486}
-
adamta authored
When feed reloads and goes back to being one page (10 articles long), infinite feed would stop working because saved height was higher. We should only check if the saved height is different instead. Bug: 1085419 Change-Id: I89fe5a5c854bdf1b3b46c0b78aa012088bd0011f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342582Reviewed-by:
-
