- 17 Nov, 2017 40 commits
-
-
Yixin Wang authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If7404806548362af847a58283cd543ef57215a85 Reviewed-on: https://chromium-review.googlesource.com/773818Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#517592}
-
Tommy Nyquist authored
Up until now, there has been no way to ensure that no in-product help is displayed during important user journeys. It can conceptually pop up at any time. This CL therefore adds a way to acquire a display lock that locks all display of in-product help. It does not remove currently displaying in-product help, but it does ensure nothing new is displayed. When the protected user journey has finished, the lock must be released to ensure that other in-product help can be displayed. On most platforms, the lock is released simply by deleting the DisplayLockHandle, which is given out as an std::unique_ptr. On Android, there are two APIs, one in C++ (shared with the other platforms), and one in Java. Since Java does not support destructors, a particular release() method must be invoked on the DisplayLockHandle instead to ensure that the C++ object is deleted. These locks are tracked separately in UMA for why in-product help has not been displayed: TriggerHelpUIResult.FAILURE_DISPLAY_LOCK. BUG=776168 Change-Id: I388fe8d626a59c5128481d5758b3bb66821e0aa3 Reviewed-on: https://chromium-review.googlesource.com/758631 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#517591}
-
Lei Zhang authored
Change-Id: Ib32799d4f3f7a41615f92b271994ace68ea1df45 Reviewed-on: https://chromium-review.googlesource.com/776028Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517590}
-
Steven Bennetts authored
With WebUI we rely more on networkingPrivate events which are triggered by NetworkStateHandler. NetworkPropertiesUpdated is getting triggered more often than is necessary. In areas with a large number of visible WiFi networks this can generate significant extra work for the WebUI JS when scanning (i.e. when the WiFI subpage is open). This CL eliminates some uninteresting event notifications (most of which were already removed from the log but were still firing events). Bug: 784026 Change-Id: I7ccf7dc443d6ce59ea36cf425cec6e9a1c1f0222 Reviewed-on: https://chromium-review.googlesource.com/773507 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517589}
-
Xing Liu authored
There is a threading issue for ScopedFeatureList that it can't be called in SetupOnMainThread in content browser test. From thread santinizer log, it seems some early IO thread code is reading while main thread ScopedFeatureList is writing into FeatureList. This CL tries to write to FeatureList after the test started to run. There is some conflicting comment and DCHECK in ScopedFeatureList and ContentBrowserTest, that the comment in ScopedFeatureList suggests init in Setup, where ContentBrowserTest::Setup has a DCHECK to suggest to init in SetupOnMainThread. However, lots of tests do the init in test case and don't have the flaky issue. Bug: 782037 Change-Id: Ia6ca649b7df2b49f7e88de6a114d7d099290454b Reviewed-on: https://chromium-review.googlesource.com/769793Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Mike Baxley authored
Multiple tests were manually waiting for bookmarks to load. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id6ac5f242478119aaaee673f8ac8d671a3638ad3 Reviewed-on: https://chromium-review.googlesource.com/777393Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#517587}
-
Donn Denman authored
Updates Smart Text Selection to enable on WebView for O+ and for Chrome to be O_MR1+. This effectively reverts CL 773782 for WebView, but leaves Chrome unchanged. BUG=785033 Change-Id: Iccdb8a5a56d34cb5275a87260e95fa1974db8ce0 Reviewed-on: https://chromium-review.googlesource.com/776198 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517586}
-
Will Chen authored
This converts a batch of tests from the old test framework (html file) into the new test framework (js file). Most of it was done through an automated transformation script, with a small amount of manual clean-up. Bug: 667560 Change-Id: I16afeab5237e191519abb2aa8c959569df28b9cf Reviewed-on: https://chromium-review.googlesource.com/777389Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517585}
-
Jonathan authored
With --enable-viz FrameWatcher does not work. The signal is no longer there. A second test api MainThreadFrameObserver does work. This converts tests which are only using FrameWatcher to wait on frames. Not those which also are waiting on hit test regions, or metadata. TBR=sky@chromium.org TEST=CompositedScrollingBrowserTest, ScrollLatencyBrowserTest, RenderWidgetHostViewBrowserTestBase, WheelScrollLatchingBrowserTest, WheelScrollLatchingDisabledBrowserTest Bug: 785013 Change-Id: Ica8d780e81fb1a25ea0778af95381d042b112255 Reviewed-on: https://chromium-review.googlesource.com/775987 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#517584}
-
Francois Doray authored
With the upcoming TabManager refactor, each tab will be associated with a TabLifetimeUnit instance, which will expose a CanDiscard() method. To avoid the need for a pointer to TabManager in TabLifetimeUnit, this CL moves TabManager::minimum_protection_time_ to TabManager::kDiscardProtectionTime. This CL also prevents proactive discard of a tab that has already been discarded or that has been used recently on ChromeOS (previously, that was only the case on non-ChromeOS platforms - removing this protection on ChromeOS is only needed for urgent discard). Bug: 783309 Change-Id: Ife3698f9554dcfe705e43953eda74fdaefee60ca Reviewed-on: https://chromium-review.googlesource.com/771781 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517583}
-
Gary Liu authored
networkType has been added in WebRTC code and it will be merged to chromium. To make chromium pass the bot, it must be white listed Bug: 786166 Change-Id: Ic578edc3b1d724fcee994f94dd3a0b19f67323a4 Reviewed-on: https://chromium-review.googlesource.com/776057 Commit-Queue: Gary Liu <qinghualiu@google.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517582}
-
Ian Vollick authored
The rendering code was updated to sort elements in tree rather than depth order in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/727342 The hit testing code, however, was not similarly updated. Consequently, there can be discrepancies. This CL updates the hit testing code to use nearly the same stacking order as rendering. Note: it is not quite perfect because the ui renderer still summons swaths of elements from the scene explicitly. Eventually, the ui renderer will simply sort and render all elements in the tree and these will be truly identical. However, until then, this ensures we do use the same element sorting routines. This change was previously landed in the following CL https://chromium-review.googlesource.com/c/chromium/src/+/754554 It needed to be reverted because the content backplane intersected with the floor causing incorrect intersections (the backplane appeared after the floor in stacking order, so the reticle stayed on the backplane, the result being that the reticle would "descend" into the floor) Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If01202a58ed4a85426b57f5d7e65975ea9e75287 Reviewed-on: https://chromium-review.googlesource.com/777505Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517581}
-
Albert J. Wong authored
Previously, one report was triggered for each process over the memory threshold. However, it turns out the report sent data for all processes anyways so this was causing unnecessary sends. In addition, it tickled some undefined behavior in the tracing subsystem. This CL reduces it to only send one report if any process is over the limit. Bug: 782355 Change-Id: I174a6531fa890c5d7761b04d8662659fcccf7bb0 Reviewed-on: https://chromium-review.googlesource.com/775670Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517580}
-
Mike Dougherty authored
Bug: 750228 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0fa138e855d71ac256759d75f3e84d390cd2c896 Reviewed-on: https://chromium-review.googlesource.com/777468Reviewed-by:
-
Reilly Grant authored
This reduces the size of an official build of ChromePublic.apk by 403 KiB and the size of resources.pak on a Chrome OS build by 1.46 MiB. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f6502cc17136dd15a2b3e026bbe5c84e3fb337d Bug: 619091 Reviewed-on: https://chromium-review.googlesource.com/770550Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517578}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bbac322d. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5389 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I94eb8b2fdf16c62b380e4ceedeb5eb1bac1abf3e Reviewed-on: https://chromium-review.googlesource.com/775869 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517577}
-
Jayson Adams authored
https://chromium-review.googlesource.com/769238 adds a method that updates the favicon location and by default animates the change, but this causes the favicon to move when you release a tab after dragging it to a window. This cl adds a parameter specifying whether or not the favicon position change should animate. Bug: 786297 Change-Id: If5453ac27c9d0c6943389e22df66efa1a8fcd6b1 Reviewed-on: https://chromium-review.googlesource.com/777463 Commit-Queue: Jayson Adams <shrike@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517576}
-
Dmitry Skiba authored
ChromeActivity.onStart() sometimes crashes on null mSnackbarManager. That is weird because mSnackbarManager is set in a function called from onCreate(). The only way this can happen is if finish() called by AsyncInitializationActivity.abortLaunch() fails, and the activity continues its lifecycle. And indeed as analysis of finish() shows (crbug.com/781396#c13) there are cases when it can fail. This CL adds code to kill the process if abortLaunch() fails to finish the activity. The change only affects Android L, because that's where the crashes are happening. Bug: 781396 Change-Id: I3428245bd80ccd6b8c1b4ced2010e9be29f1a4c5 Reviewed-on: https://chromium-review.googlesource.com/777683Reviewed-by:
-
Xianzhu Wang authored
Cell's visibility affects painted result of collapsed borders (see CollapsedBorderPainter::PaintCollapsedBorders). We need to invalidate collapsed borders when cell's visibility changes. The solution is not optimal because the collapsed border values won't change (we just need to repaint), but it's a solution with minimal change. Bug: 784822 Change-Id: I1f5c533f0e44d8afb32d399c87efa04b9da05802 Reviewed-on: https://chromium-review.googlesource.com/773401Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517574}
-
David Jacobo authored
Original commit: I4f975ec105f84c3656861f3a7e0e4879405f9f4c Adding a way for the user to manage their app preferences via chrome://settings, this new entry is hosted on the Handlers section and it points to Settings->Apps->Configure apps->App links on ARC. settings. TBR=yusukes@chromium.org, khmel@chromium.org Bug: 678141 Test: Clicking "Manage Play app links" on chrome://settings opens ARC Change-Id: I207ece2c49f6acc6f60ee951377f1f5aed029dc2 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/776058Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517573}
-
Yuly Novikov authored
Restore the expectations to pre-rebaseline state BUG=785392 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad39cd20872f7640e666c66b44a59aef1d1b1c36 Reviewed-on: https://chromium-review.googlesource.com/777684 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517572}
-
Alex Moshchuk authored
Bug: 786539 Change-Id: I016358c8033c71d4475944881d105eb6e85fe46e NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/777839Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517571}
-
Yash Malik authored
Before this CL, events such as OnButtonDown, OnButtonUp, etc would always percolate up the parent chain. This CL changes this so that this only happens for element that have explicitly set event bubbling. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4e30d7b69655fdb6838ee8149639b2bbda5770e5 Reviewed-on: https://chromium-review.googlesource.com/777501 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#517570}
-
Scott Violet authored
The only ick in this patch is allowing circular deps on wayland and exo. This is necessary because WindowManagerService includes wayland, wayland includes ash... BUG=784945 TEST=no functional changes TBR=tsepez@chromium.org Change-Id: If62836861c7db7e0af62cea4a3b8c18fb2aa4675 Reviewed-on: https://chromium-review.googlesource.com/775579 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517569}
-
Karl Anders Oygard authored
Add NG support for the -webkit-center/right/left properties, and implicitly the ALIGN html attribute. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9c90e4ded306f2560dd82e4ed17b876a592e599e Reviewed-on: https://chromium-review.googlesource.com/763249 Commit-Queue: Karl Anders Øygard <karlo@opera.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517568}
-
Klaus Weidner authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If02c37be09132c81cce68e8e7e7d3821d67c8e83 Reviewed-on: https://chromium-review.googlesource.com/777481Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Ovidio Henriquez authored
This change updates the request-from-sandboxed-iframe.html test to be a promise_test as opposed to being an async_test. This will help us migrate the test to the wpt/ directory, since we use a wrapper around promise_test to dynamically load Chromium specific modules. BUG=769412 Change-Id: I7f057261eaa2346821ace3aa6800c7bf82e7d6e7 Reviewed-on: https://chromium-review.googlesource.com/769346Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@google.com> Cr-Commit-Position: refs/heads/master@{#517566}
-
Steven Holte authored
These will replace most of the existing APIs in follow up CLs. Bug: 761524 Change-Id: I605dcb30c74aa603faf97c4ddbf6871ff87d4c06 Reviewed-on: https://chromium-review.googlesource.com/776068 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517565}
-
Chandan Padhi authored
This CL modifies MSDH's OpenDevice method to take a callback and removes corresponding response methods from MSD. It enables clients to communicate directly with MSDH and handle the response themselves without relying on MSD. Bug: 742682 Change-Id: I885de11312098d7ff06c0a1a6cb153ebc408e6c3 Reviewed-on: https://chromium-review.googlesource.com/763152Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#517564}
-
Matthew Jones authored
This change adds several histograms for tracking the swipe velocity of sheet open events. Particularly, sheet open events that are proceeded by a URL navigation or change in sheet content are recorded. Other histograms record open success/failure related to the "chrome-home-swipe-logic" experiment. BUG=779615 Change-Id: If7b368c5aa7d3c4ed0f5c0df9c32a27157384075 Reviewed-on: https://chromium-review.googlesource.com/754341 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#517563}
-
Katie Dektar authored
The accessibility node has wordStarts and wordEnds that are more robust markers than using regular expressions to find starts/ends for highlighting. Some highlighting trouble is still found around special characters like quotes or parenthesis which throw off the tts event indexes, however this is a dramatic improvement. Bug: 676451 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4bb9c585e56459ad1326d2944830b64816435109 Reviewed-on: https://chromium-review.googlesource.com/773481 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517562}
-
Koji Ishii authored
Following bot results are included. 2170 2172 2173 2174 2176 2181 2183 2184 2193 2194 2196 35 lines were removed by consecutive passes since 2154. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ia76855815ba3b2abf85d16be12bd9044bb0d5a11 Reviewed-on: https://chromium-review.googlesource.com/777025 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#517561}
-
agrieve authored
This reverts commit 2d59ecc7. Reason for revert: Broke --split-projects Original change's description: > generate_gradle.py: Enable --all by default > > Seems to be fast enough now! > > Bug: 620034 > Change-Id: I8d47bb8dbd63bb60678bd55cb23696b7b2304f95 > Reviewed-on: https://chromium-review.googlesource.com/772432 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516879} NOTRY=true TBR=wnwen@chromium.org,agrieve@chromium.org Bug: 620034, webrtc:8547 Change-Id: Idb72a9d30bc038dcf20e5576bd9cb5615ac1a6de Reviewed-on: https://chromium-review.googlesource.com/777404 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517560}
-
Sophie Chang authored
Bug: 786154 Change-Id: Ifcc4c8a14004819dece6d5fa9b4da05a9ec49828 Reviewed-on: https://chromium-review.googlesource.com/775660 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#517559}
-
Katie Dektar authored
Children of elements with no size are offscreen still by virtue of being clipped. This fixes <br> tags (lineBreak) being labeled 'offscreen', as well as any size (0, 0) element that is on the screen. Bug: 773851 Change-Id: I3e2ed49d3b66b3eb3280f44fcf86315273cce485 Reviewed-on: https://chromium-review.googlesource.com/772900Reviewed-by:
-
Jose Dapena Paz authored
Original CL: https:/crrev.com/c/767427/ > As a first step towards moving all the ATK object implementation to > ui/accessibility, we will make AXPlatformNodeAuraLinux implement as much > as possible of the features implemented only in > BrowserAccessibilityAuraLinux ATK object. > > This patch prepares AtkPlatformNodeAuraLinux to load different Atk > interfaces. Changes: - Change initalization of AuraLinuxApplication so AXNodeData is initialized before AXPlatformNode accesses to it avoiding MSAN crash. Bug: 784583,785106 Change-Id: I59804d1e859dc95fae3af06747aaa21043aed05e Reviewed-on: https://chromium-review.googlesource.com/774888 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
-
Xiaohui Chen authored
Refactored assistant availability check to a central location. Also added a notification when policy is disabled. BUG=b:69167025 TEST=run with test domain account, see entry points disabled Change-Id: I18a3b47c4ffa8ce8cb3d18eb30315cbfec83f16d Reviewed-on: https://chromium-review.googlesource.com/776117 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517556}
-
Egor Pasko authored
Suggesting to have prefix 'experimental.' in the benchmark name until it reaches alert-level quality. Depends on the metric being introduced in catapult with this change: https://chromium-review.googlesource.com/763232 Bug: 760498 Change-Id: Iea10f3fcb646e8533c49244b721f93fe13dd5872 Reviewed-on: https://chromium-review.googlesource.com/768738Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517555}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48661839..4f332747 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I695f7e02f271dc2ce25adf4ea5ea1c6a0f532be6 Reviewed-on: https://chromium-review.googlesource.com/776081Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517554}
-
Xianzhu Wang authored
When one uses run-webkit-tests --reset-results <virtual test>, the intent is probably to rebaseline the virtual baseline instead of the existing non-virtual baseline in the fallback path. Now let it match this intent. This provides a convenient way to rebaseline a virtual test locally. Change-Id: Ibadcc51b3493582ef70027f6b5aea9550f5d510f Reviewed-on: https://chromium-review.googlesource.com/775784 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517553}
-
