- 08 Sep, 2020 40 commits
-
-
Andrew Grieve authored
We only support 21+, so we should build for it. Bug: 1116198 Change-Id: I552a946b245de0f54485ea985e08b53b92186bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367984Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804976}
-
Rouslan Solomakhin authored
This patch adds a test for JSON serialization of a very long fallbackUrl string being passed into PaymentRequest API. Bug: 1110324, 1115091 Change-Id: Iac3f0197038199451ebe5276e11c10e53cb62a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346973 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#804975}
-
Eric Robinson authored
This CL removes some of the AdsPageLoadMetricsObserver unit test functions that could be replaced by calling accessors and then functionality directly on those. Change-Id: I483baa317258b76ecc4a438774660799c791c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390875Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804974}
-
Rohit Agarwal authored
private. The IncognitoInterstitialDelegate methods should be used in conjunction with the IncognitoInterstitial MVC. Currently, it's possible to create instance of the IncognitoInterstitialDelegate and invoke its methods from outside of package scope. This CL changes the scope of these methods to package private and moves the IncognitoInterstitialDelegateTest to the same package. Bug: 1103262 Change-Id: Id0a87b386e4f0c3414c744e5bd51da6f61bc9922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398480Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804973}
-
Daniel Hosseinian authored
GetPDFDocInfo() and GetPDFPageSizeByIndex() call PDFium APIs underneath that use single precision, not double precision. Change their signatures to reflect that fact. Meanwhile, change the output of GetPDFPageSizeByIndex() from two pointer parameters to a base::Optional<gfx::SizeF> return value. Change-Id: I91e3645027f2345f930c6ee8ca886f84deed6897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393013Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#804972}
-
Tim Sergeant authored
This is necessary for mocking calls to `onGoogleAccountsRequest` in tests. Change-Id: Ia7a99ce052071b8728f30710491194d8da6a8b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396158 Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804971}
-
Liquan (Max) Gu authored
The PaymentHandler UI used to have a workaround to get the bottomsheet padding for content height computation. Now that CL[1] has fixed the bottom-sheet height computation issue, the workaround caused "overfix" and so need to be dropped. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2372811 Bug: 1125515, 1059269 Change-Id: I9fd7701c5cd658ebb9ea87fe0825e0ce050a49a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398959Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804970}
-
David Tseng authored
SA should handle reload (pref didn't change, but the profile changed). Similar to STS and ChromeVox. R=anastasi@google.com, dmazzoni@chromium.org AX-Relnotes: n/a Fixed: 1125211 Test: manual; on-device Change-Id: I0ab62e970d2cf948512bf49947a48bd1d7aacda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398939Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804969}
-
Fergus Dall authored
This target is used by the CQ to typecheck javascript Bug: none Change-Id: I7655a135ac9816dbbf7b84b9d5c0331fda5d0ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379441 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804968}
-
rajendrant authored
Fixed: 1124785 Change-Id: I88e275c933ec12ee1d8630797f2c1dd3462bcb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397535 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#804967}
-
Sebastien Marchand authored
Manual roll as we don't have the autoroller yet. Change-Id: Ia704ba1f057834f5e466b46fd60f0175db59fc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392960 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804966}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ia9e2925577e875262cf0ec6d84d789667a211700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804965}
-
Luke Zielinski authored
This rolls up to d7d965cb51cb8a87ff9f87668f00b242e597d499 Major change is support for using mojo JS in tests Change-Id: I0aea49dfc7c046a5a1d38accf029691548350e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392408Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804964}
-
Benoit Lize authored
LockImpl::Unlock() is inlined, but not LockImpl::Lock(). Separately, Lock() calls Try() before locking, to increase uncontended performance. This code is duplicated between POSIX and Windows. This commit: - Merges the two paths - Inlines Lock() and Try(), partly for symmetry, and partly for performance On a Linux Xeon "Haswell" workstation (E5-2690v4), this improves uncontended acquire/release pairs by 8%. These numbers are collected from a non-PGO build, and the impact on a PGO one is likely smaller. This was assessed by running the performance test 50 times with: $ out/Release-desktop/base_perftests \ --gtest_filter="LockPerfTest.Simple" --gtest_repeat=50 \ | grep RESULT | sed -e 's/.*= //;s/ .*//' Results are summarized below (numbers are runs/s, higher is better): trunk: Mean = 4.534e+07 Standard Deviation = 6.234e+05 This CL: Mean = 4.900e+07 Standard Deviation = 6.681e+05 That is, this patch makes it 8.08% faster, and given the standard deviation, the difference is likely significant. Bug: 1061437 Change-Id: Ibfb3f1f07598c22f1c9446c02e16a883bf328d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386738Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804963}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py d0abc757495349fd053beeaea81cd954c2e457e7`. Bug: 1123467 Change-Id: If7a73ab5897485e8ac991c56363ba560db882842 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394517 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#804962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..0e8358a4dead 2020-09-08 fmayer@google.com Merge "Support Windows in heap_profiling script." 2020-09-08 lalitm@google.com Merge "tp: temporarily disable duplicate proto check" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2afb60b0cb3ecf9a23c68c1307311e44cd849bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398804Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009080800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rUtprFyuBDz2yCzSepkGBxhzVtRer7AGDgUw2DZL4KgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/13961540,b/144538064,b/147395281,b/152803847,b/162270429,b/162696369,b/162704759,b/162791694,b/163921403,b/167638697,b/167642410,b/167643682,b/167933026,b/167945927 Tbr: media-app@grotations.appspotmail.com Change-Id: Id7d058343e491ad5077d0bfbc461e4ae734a1aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398803Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804960}
-
Chris Lu authored
This is a reland of 5f4895f5 Original change's description: > [ios] Turn on FullscreenControllerBrowserScoped by default > > Bug: 790886 > Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Auto-Submit: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800354} Bug: 790886 Change-Id: I24ea5c47f97e1060dc1c2dd4e83f4447595611b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380138 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#804959}
-
Sorin Jianu authored
This is an iteration to make the implementation of --install cross-platform. SplashScreen and AppInstallController are injected by MakeAppInstall implementation using two closures. The Windows code has working objects for the two, while the other platforms use do-nothing stubs. There is a small change in the integration test to invoke Wake for the Windows execution path. The tests pass without the change and removing this platform difference in the test execution seems useful. Change-Id: Ie3c75d52742aafc7f2f96e16cc64583f501018f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385896 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804958}
-
Alex Turner authored
Currently in FontMatchingMetrics, the check_type and is_loading_fallback flag are included as part of the output digest. However, these do not represent an output. Instead, they represent different kinds of lookup or a temporary state. By including them in the output digest, we cannot determine if two lookups at different points in the font matching process resulted in the same font or not. We remove check_type and instead split the IdentifiableSurface::Type to account for different kinds of lookup, including splitting lookups that can match only unique font names (i.e. src:local specifiers) and lookups that can also match family names (i.e. font-family specifiers). We adapt FontMatchingMetrics' HashMaps accordingly. We also ensure other lookup values are appropriate by: - including FontFallbackPriority for lookups by fallback character, - handling FontDescription::GenericFamilyType properly, - considering font names to be case-insensitive, and - ignoring any lookups where is_loading_fallback is true. Bug: 1121669 Change-Id: I398ad1359c5c6bae51b8bb8b4f236c1944c3e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376037 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#804957}
-
cfredric authored
SSLErrorAssistantComponentInstaller. Change-Id: Ie7de9cdc89acb05e8d9781d6da3d1706d921fef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392989 Commit-Queue: Chris Fredrickson <cfredric@google.com> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804956}
-
Abigail Klein authored
Screenshots: Chrome accessibility page: https://screenshot.googleplex.com/5vU2bhoKpJvoruY ChromeOS accessibility page: https://screenshot.googleplex.com/ALQB78FPBjvhEqD Captions settings page: https://screenshot.googleplex.com/3LUrCWPny6kv954 AX-Relnotes: Clarified the names of captions strings in settings Bug: 1055150 Change-Id: Ia645b35626b1e5a30e5115882362b7e0c632f60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398980Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#804955}
-
Matt Menke authored
Back in the days when humanity was yet young, and IE roamed the Earth, URLRequestJobManager had a global list of factory functions, one for each scheme. Through the mighty work of the intern shalev, most of these were converted into ProtocolHandlers, which were added to a URLRequestJobFactoryImpl, which sat at the bottom of a stack of URLRequestJobFactories used by various modules to to intercept requests. However, the zombie URLRequestJobManager remained. It called into the top URLRequestJobFactory to give it the first shot at creating a URLRequestJob, and it still had the factory functions for HTTP[S] and WS[S]. There were reasons for this, though I can't quite remember why - URLRequest::IsSupportedScheme (removed a while back) was likely one of those reasons. There may have been others. At this point, we've removed almost all ProtocolHandlers (only FTP and chrome (iOS only)) remain, and the intercepting URLRequestJobFactories that sat on top of it are also gone. This CL finally removes URLRequestJobManager and moves all of its logic down to URLRequestJobFactoryImpl. Fixed: 354158 Change-Id: Ic1f364bd6bf9c37ed6e139a668da1de2bb301bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392995Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804954}
-
Michael Crouse authored
The LiteVideoObserver observes media rebuffering events and sends a stop throttling message to the hints agent. This should only happen if LiteVideos were allowed and a hint sent in the first place. This also removes the dcheck in the hints agent as the design changed so the DCHECK is not needed. Bug: 1125922 Change-Id: I3b65a78acc54bd267ecbabd03e8fd23bea99aad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398958Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804953}
-
Sylvain Defresne authored
base::CancelableTaskTracker is sequence-affine. Since it is not possible to ensure that -dealloc is called at a specific point in time nor on a specific thread for an Objective-C instance, change _largeIconTaskTracker to be heap allocated and stored in a std::unique_ptr<> so that it can be destroyed from -shutdown. Add DCHECK that method accessing _largeIconTaskTracker are not called after -shutdown as been called (as they would otherwise try to dereference null which is Undefined Behaviour). Convert _pendingTasks to a std::set<URL> since the value are never used, and check that the scheduling of the task was a success before storing the object in _pendingTasks (failure probably mean that the sequence has been shutdown which only happen at app shutdown, so it is okay to do nothing in that case). Bug: 1122991 Change-Id: I9f312bf6b8ac844e6a28d4e10042e9b9c1a7b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388061 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804952}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599540720-2c8a746fd34db3cbe60ec0abca5753030633ccf0.profdata to chrome-win32-master-1599551854-84903541b1ee77a3a0a009f1d73fc84d0ed1091a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie4c1c9d42c93e53293a03cb3c0da0956dba107ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397673Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f67f6444. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes rego@igalia.com: external/wpt/css/css-ui external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ic7b77b71178bdf8a317a01096f528c9f58108420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398858Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804950}
-
Peter E Conn authored
Change-Id: Ifd8bec0b4db3f7ac540b070642250b48f712dacc Bug: 1126040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398680 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804949}
-
David Tseng authored
See go/chromevox-touch-gestures TBR=dtseng@chromium.org AX-Relnotes: Adds four finger swipe for ChromeVox to move among on-screen panes (launcher, status tray, web page, etc). Bug: none Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight* Change-Id: I62d4bd6f2b8e5c63e55c6143b68380ad0c137463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398842Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#804948}
-
Alice Wang authored
This CL batches profile data render tests with and without badges. Bug: 1120258 Change-Id: I779e62ee88efed5acf3d032189c27c36cbbb8e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398478 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0485634fe3f9..2d00262a1459 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from dc1b9762731e to 6a6e311d81dd (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from fd05605bef1c to 1ab52e54abfd (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 4a7362c2b223 to 45f2f18a69eb (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 2c793ba1d0e8 to 4ede8ee6e2ec (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I08740254adb8e845105c27054ca3d9e4cff23b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398801Reviewed-by:
-
Yue Li authored
Bug: 1124321, b/162780582 Test: Manual Test Change-Id: I5020cde15baec511782f26df21ea51a3a426ab89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397323 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Maksim Sisov authored
My observation showed that other bots that run this test suite also experience the flakiness. Bug: 1084469 Change-Id: I3b4262da60fe62e261029c4337c8d66c0494fc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398658Reviewed-by:
-
Chanyong Moon authored
When keydown event is triggered continuously, mousedown event cause keydown event as not repeating event. This change append check logic to exclude mouse button flags. Bug: 1114281 Change-Id: Ie967e34cbc13c2489ccba4945cb4ae0dcbce0deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368577Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#804943}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9eaf5ce5d81..7e3252b4439a 2020-09-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domDebuggerManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.isolateManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domModelUndoStack If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b15f2d77180d4f5e3d8cee30eac275e4bcda2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398800Reviewed-by:
-
Miriam Zimmerman authored
BUG=chromium:1125007 TEST=CQ Fixed: chromium:1125007 Change-Id: Ie0317463f0e0b4b5bb602a64229f5ce3486df459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398960 Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#804941}
-
Bruce Dawson authored
tools\win\setenv.bat is a mostly unknown but sometimes useful batch file that adds the VS tools to the path. It respects the value of DEPOT_TOOLS_WIN_TOOLCHAIN and the current toolchain hash. This change updates it to add support for VS 2019, and remove support for VS 2015. It also takes away support for selecting 32-bit versus 64-bit target toolchains because this feature was never used and was too much work to support (since the packaged toolchain and vcvarsall.bat flags are different). This change also fixes a bug where the name of the batch file would be retained in the command-prompt title after this script exits. Using the "call" command fixes that. The retained title is ultimately a Windows command prompt bug which is not going to get fixed. Adding the call command then requires quoting the command path in the Python script. Change-Id: I2b4943dc1e391d9fb4a9e76dd8b592223dc31fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392013 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#804940}
-
Sreeja Kamishetty authored
After enabling H264 which run WPT,the failing blink web_tests should be working with BackForwardCache enabled. Bug: 1103214 Change-Id: I5059bf682f0aa441fd9d5a8237e90057213796d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395236Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#804939}
-
Hiroki Nakagawa authored
This is a follow-up CL for the previous review comment: https://chromium-review.googlesource.com/c/chromium/src/+/2389380/comment/65b648df_f6299bcf/ Bug: 1112515 Change-Id: Ia7ba8b79cb0b60567616773c8240c4c5b446e8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397992Reviewed-by:
-
Laís Minchillo authored
Remove logging of Android.WebView.onReceivedSslError.ErrorCode and mark the enum and histogram as obsolete. Fixed: 1066115 Test: None Change-Id: Ia060aa6c07fad809085c15b037762278d380a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398718 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804937}
-
