- 08 Aug, 2018 21 commits
-
-
Rob Percival authored
These histograms can be compared to "AsyncDNS.Rcode" to determine whether there is an unusual distribution of rcodes relative to normal DNS lookups (i.e. A/AAAA lookups). I'm interested in particular to see what rcodes map to DNS_SERVER_FAILED (besides ServFail). Bug: 506227 Change-Id: I5bbdc6c52ef7b017f0d38c1329f450ed346f6e4a Reviewed-on: https://chromium-review.googlesource.com/1152972 Commit-Queue: Rob Percival <robpercival@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581419}
-
Anand K. Mistry authored
cros-disks provides this property, so there's no reason chrome should compute its own version. BUG=None Change-Id: Id94109ad68bf2a8479954d0a4d7c11f17629c995 Reviewed-on: https://chromium-review.googlesource.com/1159932 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581418}
-
Dave Tapuska authored
The current pull request against the HTML spec is here: https://github.com/whatwg/html/issues/3799 Add a PostMessgeOptions dictionary so that WindowPostMessageOptions is a subclass of that. BUG=861735 Change-Id: I66c6990de82b0d74efa7f31240b63d19d074945d Reviewed-on: https://chromium-review.googlesource.com/1165954Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#581417}
-
Nico Weber authored
Bug: 862581 Change-Id: I102a019b98b9fb4326bcb43d247cf20b4ee5e8a1 Reviewed-on: https://chromium-review.googlesource.com/1156858 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581416}
-
Nigel Tao authored
Change-Id: I1e6f8160890d614619e259ebabd5297159bcfd95 Reviewed-on: https://chromium-review.googlesource.com/1158096Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#581415}
-
Łukasz Anforowicz authored
This reverts commit 55273237. Reason for revert: Caused https://crbug.com/871704 and https://crbug.com/871730 Original change's description: > Show "hung renderer dialog" after a navigation commit timeout (10s). > > In addition to adding a content_browsertest, I've also manually tested > the changes using steps from https://crbug.com/810633#c14. > > Note that after this CL a "hang renderer dialog" will appear if a > navigation cannot commit because it tries to reuse a hung renderer. > This is definitely an improvement. But also note that after using the > dialog to kill the renderer, the navigation spinner will keep spinning - > there is additional work needed to fix this. > > Bug: 848821 > Change-Id: I9d6801dbd8b2532f2427509c938db5556a4fb133 > Reviewed-on: https://chromium-review.googlesource.com/1089797 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580945} TBR=avi@chromium.org,creis@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848821, 871730, 871704 Change-Id: I2dee152ba283fbba332437d5c470205604ea4691 Reviewed-on: https://chromium-review.googlesource.com/1165902 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581414}
-
Toshiki Kikuchi authored
Adding IME status observer to the IME button in the unified system tray. In previous implementation, the visibility of the button is not updated automatically when the IME status is changed. TEST=IMEFeaturePodControllerTest BUG=862574 Change-Id: I41d3ef6085b165bb1f3e3d165a0369779d424ad7 Reviewed-on: https://chromium-review.googlesource.com/1161703Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Cr-Commit-Position: refs/heads/master@{#581413}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01d9a344b575..faeef7837210 git log 01d9a344b575..faeef7837210 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 bsalomon@google.com Exclude compositing_images benchs from Chromecast 2018-08-07 bungeman@google.com Some iwyu for SkShaper_harfbuzz. 2018-08-07 jvanverth@google.com Revert "Intersection calc cleanup." 2018-08-07 herb@google.com Update text blob benchmark to reflect reality 2018-08-07 bungeman@google.com Add context to shaper. 2018-08-07 timliang@google.com fixed check for BGRA -> RGBA in CopySurfaceTest 2018-08-07 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 48908cb95504..d7622ffdd25e (1 commits) 2018-08-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 6ad455da9d42..5b1292eaeda5 (1 commits) 2018-08-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms e5dd04f43880..6ad455da9d42 (1 commits) 2018-08-07 jvanverth@google.com Improve touch support for iOS viewer 2018-08-07 kjlubick@google.com [PathKit] Made some APIs return null if things failed 2018-08-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 6f11cd0ed7d0..e5dd04f43880 (2 commits) 2018-08-07 jvanverth@google.com Intersection calc cleanup. 2018-08-07 fmalita@chromium.org [skottie] Use animator scratch storage to avoid vector reallocations 2018-08-07 mtklein@google.com link with --start-group/--end-group 2018-08-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 95d1987a561d..6f11cd0ed7d0 (1 commits) 2018-08-07 fmalita@chromium.org [skottie] Initial Fill layer effect support 2018-08-07 herb@google.com Simplify blob's appendGlyph interface 2018-08-07 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 02956e4cced0..48908cb95504 (1 commits) 2018-08-07 mtklein@google.com add Build-Mac-Clang-arm64-Debug-iOS to CQ 2018-08-07 herb@google.com Remove drawTextBlob from SkBaseDevice 2018-08-07 mtklein@google.com Add a bench for various single color xforms 2018-08-07 ethannicholas@google.com SkSL coordTransform argument is now optional 2018-08-07 bsalomon@google.com Reland "Move GrGeometryProcessor's textures out of classes and into" 2018-08-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 6ba9754f4a56..1bd4bfb0c2d8 (1 commits) 2018-08-07 caryclark@skia.org minor SkRegion include edits 2018-08-07 robertphillips@google.com Add shared --disableExplicitAlloc flag to tools 2018-08-07 robertphillips@google.com Add list of dependents to GrOpList class Created with: gclient setdep -r src/third_party/skia@faeef7837210 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/112244393 TBR=djsollen@chromium.org Change-Id: Ia1b2f7dd1fc7cce3a172d528cd030fb097a7de0d Reviewed-on: https://chromium-review.googlesource.com/1165923Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581412}
-
Takuto Ikuta authored
Change-Id: Ie56f6f5f44ed73c4ea7888984d8140b88a6ff9a8 Reviewed-on: https://chromium-review.googlesource.com/1165278 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581411}
-
Fredrik Hubinette authored
This test does too much and is flaky on some platforms. TBR=miu@chromium.org Bug: 871799 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If937a1736fcfdca4f004a8f4cf0660bac5f1f794 Reviewed-on: https://chromium-review.googlesource.com/1166283Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#581410}
-
Yuri Wiitala authored
Removed GetGLHelper() from ImageTransportFactory now that nothing is using it. Also, removed some gl_helper.h #includes from modules where it's not being used. Bug: 870036 Change-Id: Ie632ddfbf9e73fe00db6992499b9d54fe529f4af Reviewed-on: https://chromium-review.googlesource.com/1166219Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581409}
-
David Bokan authored
When implicitly promoting an element to be the root scroller, we first check if the main document has any overflow. If it does, we err on the side of not promoting since it is likely the main document's content is important and meant to be scrollable. This heuristic turns out to be too restrictive. For example, this makes it hard to build a root scrolling carousel. This CL loosens the restriction to allow horizontal overflow. Bug: 838683 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a Reviewed-on: https://chromium-review.googlesource.com/1165859 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#581408}
-
Shubhie Panicker authored
This includes 2 thread hops, 2 serialize, 2 deserialize: serialize + hop-to-worker + deserialize + serialize + hop-to-main + deserialize. Bug: 870041 Change-Id: I324ba46f09ab18522e51430c6d58c4f07001bc74 Reviewed-on: https://chromium-review.googlesource.com/1159321Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#581407}
-
Ted Choc authored
The issue is that this refactor: https://chromium-review.googlesource.com/1148680 updated all text updates to the URL bar from the location bar to be ignored for autocomplete purposes. But in the old code, there were cases where it used setText/setUrl directly and those would have triggered autocomplete. setUrlBarText did the current behavior in the old code, so those paths do not need updating. Instead of implicit triggers for autocomplete, this uses the consistent path of never triggering autocomplete implicitly, but instead makes it explicit in the cases we want. Also fixes a trivial case where "" text updates (i.e. from the NTP) were spamming the URL bar where it didn't need to. BUG=871130 Change-Id: I26664bf3aa065176830f60b250d57a64de1c10f9 Reviewed-on: https://chromium-review.googlesource.com/1163992 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581406}
-
jdoerrie authored
This change temporarily adds an "is_alive" flag to base::Value that should help in debugging use-after-free crashes. This change is intended to be reverted after a few days in Canary. Bug: 859477 Change-Id: I6ab51c37db18dd766677ef162fd42cc6832d1bab Reviewed-on: https://chromium-review.googlesource.com/1163244Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581405}
-
Manuel Rego Casasnovas authored
This patch simply uses DelayScrollOffsetClampScope to avoid resetting scroll position when the contents of a grid item are modified. BUG=833837 TEST=fast/css-grid-layout/grid-item-scroll-position.html Change-Id: I74dd5e67d432b7b86b756ed741c7ad24243e6b8e Reviewed-on: https://chromium-review.googlesource.com/1165983 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#581404}
-
Artur Khachatryan authored
Change-Id: I2917d3908af3ba7eba88477664ba5801c93f0de2 Reviewed-on: https://chromium-review.googlesource.com/1166040Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581403}
-
Xiaohui Chen authored
Bug: 111370621 Test: locally build and fake auth errors with bad tokens. Change-Id: Id8099ccd67add90fc4b593877bcfce44c2eff654 Reviewed-on: https://chromium-review.googlesource.com/1165857Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581402}
-
Vladislav Kaznacheev authored
Bug: None Test: compile locally Change-Id: Ie32578e191b09c1c1ba5e0f298bbd11dcc54ec76 Reviewed-on: https://chromium-review.googlesource.com/1150869 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581401}
-
Nico Weber authored
Getting bots for the builder is taking longer than expected, and having a perma-purple bot on the main waterfall isn't so great. I'll revert this again once hardware for the builder has been allocated and configured. Bug: 869973 Change-Id: I702c4694eb13cc39cc07bc01f19a6f7871e9f47c Reviewed-on: https://chromium-review.googlesource.com/1166170Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581400}
-
Dominik Laskowski authored
Clients without relative surface hierarchy are no longer in use. Bug: b:77972398 Test: exo_unittests Change-Id: Ief12aa0320747233853202389755ed816529971e Reviewed-on: https://chromium-review.googlesource.com/1164549 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581399}
-
- 07 Aug, 2018 19 commits
-
-
Muyuan Li authored
Bug: b/77916222 Test: Manual Change-Id: Id930abc94b68d74932b7f705b7de061ec83f949c Reviewed-on: https://chromium-review.googlesource.com/1139105 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581398}
-
Gabriel Charette authored
R=isherman@chromium.org Bug: 828242 Change-Id: Ide5e2358a17d115655ca255b57cfeda9a5cbb9be Reviewed-on: https://chromium-review.googlesource.com/1165307Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#581397}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/bc484c485277..7a76b645a08c $ git log bc484c485..7a76b645a --date=short --no-merges --format='%ad %ae %s' 2018-08-06 tomfinegan Move aom_read_obu_header from exports_test to exports_dec 2018-08-06 wtc Add a regression test for bug oss-fuzz:9720. 2018-08-06 tomfinegan av1_txfm_test: exclude from shared lib tests. 2018-08-03 mbonadei aomenc: replace uint16 with uint16_t 2018-08-06 ranjit.tulabandu Fix crash issue with monochrome content 2018-08-01 ranjit.tulabandu Fix issues in interpolation filter selection 2018-08-03 urvang Refactor code in setup_ref_mv_list. 2018-08-03 urvang Introduce read_delta_q_params() function. 2018-08-03 chiyotsai Remove repeated code in encode_rd_sb_row 2018-08-03 chiyotsai Replace is_single_inter_mode with is_inter_singleref_mode 2018-08-04 wtc read_tile_info: Validate context_update_tile_id. 2018-08-04 wtc Fix spelling mistake: partiton => partition. 2018-08-03 wtc Document get_partition_subsize and ss_size_lookup. 2018-08-03 debargha Make ss_size lookup same as the spec 2018-08-03 urvang Rename some intra mode functions for clarity. 2018-08-03 urvang Introduce write_intra_prediction_modes() func. 2018-08-03 sarahparker Clean up show_existing_frame decision 2018-08-03 urvang wiener_test: Dedup compute_stats_win* funcs. 2018-08-03 urvang Introduce write_delta_q_params() function. 2018-08-02 wtc Add comments for width/height lookup tables. (...) Created with: roll-dep src/third_party/libaom/source/libaom R=johannkoenig@google.com,urvang@chromium.org BUG=871928 BUG=oss-fuzz:9720 Change-Id: Ie58f1c92c5cac29d9a6b98de1871620f4467a567 Reviewed-on: https://chromium-review.googlesource.com/1166147Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#581396}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f3a3393a2f96..e1c2f6d7fe7a git log f3a3393a2f96..e1c2f6d7fe7a --date=short --no-merges --format='%ad %ae %s' 2018-08-07 tsepez@chromium.org Remove WideString::Format() from ThrowException() methods. 2018-08-07 tsepez@chromium.org Use wide string addition in place of some Format() calls. 2018-08-07 tsepez@chromium.org Add test for {Byte,Wide}String Operator+(). 2018-08-07 tsepez@chromium.org Combine redundant CJBig2_Image code. 2018-08-07 tsepez@chromium.org Speculative fix for null deref above ThrowNoDefaultPropertyException Created with: gclient setdep -r src/third_party/pdfium@e1c2f6d7fe7a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870952 TBR=dsinclair@chromium.org Change-Id: I10fe6cd6f0dd97baf6b7e2f3b774bab1558c9875 Reviewed-on: https://chromium-review.googlesource.com/1166042Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581395}
-
Reilly Grant authored
This reverts commit b624551f. Reason for revert: Reverting this change broke the tree because of a patch that depends on it. Since the test is only flaky fixing the tree is better than causing more disturbance by reverting more changes. Original change's description: > Revert "Port policy::UploadJobImpl to network::SimpleURLLoader" > > This reverts commit 581330a9. > > Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky > > Original change's description: > > Port policy::UploadJobImpl to network::SimpleURLLoader > > > > This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. > > > > Since this request does not make use of the response a new method has > > been added to SimpleURLLoader, DownloadToNull. This download mode still > > reads the response body from the network but does not save it anywhere. > > This is useful for requests which upload data and would otherwise have > > to specify an arbitrary |max_body_size|. A maximum may still be set if > > the caller wants to limit the amount of data transferred over the > > network. > > > > Bug: 773295 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f > > Reviewed-on: https://chromium-review.googlesource.com/1161551 > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581060} > > TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org > > Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 773295, 872023 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1166288 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581389} TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org Change-Id: I793ab6c8c22c5bec97ef853f520dc506809970cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 872023 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1166301Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581394}
-
Patrick Monette authored
Also render them valid to trigger an incompatible applications warning. Bug: 846953 Change-Id: I6fa9951043d19a44a820aeaf44cab1c0e9b981e2 Reviewed-on: https://chromium-review.googlesource.com/1158986Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#581393}
-
Quan Nguyen authored
This stops the shelf from updating its button visibility only to be deleted anyway due to a successful sign-in. Bug: 836172 Change-Id: I2a7f31610cd3317c87f06bce064cd0331a583d3c Reviewed-on: https://chromium-review.googlesource.com/1166156Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581392}
-
Xiaoqian Dai authored
already has a snapped window in place. Bug: None Change-Id: Ia8b43095e851b30f52814f65cb52d2349be25dbf Reviewed-on: https://chromium-review.googlesource.com/1162939 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581391}
-
Eric Willigers authored
overscroll-behavior shipped in M63 https://chromium-review.googlesource.com/797351 https://www.chromestatus.com/features/5734614437986304 BUG=789590 Change-Id: Ib5237ff2ccc2d2549aed6292520db0878658db45 Reviewed-on: https://chromium-review.googlesource.com/1165047Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581390}
-
Reilly Grant authored
This reverts commit 581330a9. Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky Original change's description: > Port policy::UploadJobImpl to network::SimpleURLLoader > > This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. > > Since this request does not make use of the response a new method has > been added to SimpleURLLoader, DownloadToNull. This download mode still > reads the response body from the network but does not save it anywhere. > This is useful for requests which upload data and would otherwise have > to specify an arbitrary |max_body_size|. A maximum may still be set if > the caller wants to limit the amount of data transferred over the > network. > > Bug: 773295 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f > Reviewed-on: https://chromium-review.googlesource.com/1161551 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581060} TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 872023 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1166288Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581389}
-
Joe Mason authored
Also add crash and logging deps to test_main.cc R=proberge Bug: 830892 Change-Id: I1fae62bfcff0beded07a1827cab1d58dab79f3ac Reviewed-on: https://chromium-review.googlesource.com/1163635 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581388}
-
Matt Falkenhagen authored
Replace vague RunUntilIdle() calls with FlushForTesting() and explicit events. Bug: 862294 Change-Id: I76e6cf9501b5d480960f431316e385bd7bf9941d Reviewed-on: https://chromium-review.googlesource.com/1164737 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#581387}
-
wutao authored
Trilinear filtering uses many memories which can cause tile missing in WindowCycleList view and Overview mode. Turn it off by default. Bug: 871984 Test: manual. Change-Id: Icbe758c2a2c707ca58aa0816a76436fb487144df Reviewed-on: https://chromium-review.googlesource.com/1166199Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#581386}
-
Daniel Murphy authored
This is the first component of LevelDB Scopes. The lock manager is a basic leveled lock system with shared and exclusive locks. This change contains an implementation which requires disjoint lock ranges, which is what the IndexedDB system will be using. This also includes a README with the implementation plan. This will be updated as more code is submitted. Bug: 862456 Change-Id: Ib4300ae8c59035c06772625323b3de0cc9ef3f6a Reviewed-on: https://chromium-review.googlesource.com/1134407 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581385}
-
Wan-Teh Chang authored
Add a space between the bullet point '-' and the package name. R=johannkoenig@google.com Change-Id: Iec44d755cc2540375dadfd6324dbe0c633c0db28 Reviewed-on: https://chromium-review.googlesource.com/1166160 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#581384}
-
Philip Rogers authored
On platforms that need preferred content size updates (MacOS and Android), an additional blink lifecycle update is issued if layout changes because ContentsPreferredMinimumSize is called after layout. In most cases this is unnecessary because layout is already up-to-date. On platforms that use PreferredSizeChangedMode (e.g, MacOS), the preferred size is updated after layout (RVI::DidUpdateMainFrameLayout) and when the PreferredSizeChangedMode setting is enabled. When called from DidUpdateMainFrameLayout, no lifecycle update is needed. When the setting is first enabled, this patch now explicitly updates the lifecycle before updating the preferred size. On Android (AwRenderViewExt), the preferred size update does not appear to need to force a lifecycle update because the common path in AwRenderViewExt::UpdateContentsSize uses DocumentSize which does not force a layout update. This patch removes the forced lifecycle update from ContentsPreferredMinimumSize and adds a DCHECK that is is only called with up-to-date layout. An integration test has been added that ensures no extra lifecycle updates occur. This would have caught https://crbug.com/866981. This patch changes the expectations for media/video-zoom-controls.html which was different on MacOS compared to Windows and Linux. The media controls code is racy with layout and will put up a bad frame (see: MediaControlsImpl::NotifyElementSizeChanged). Before this patch, the preferred content size layout timer would occur before the media controls layout timer and cause different controls to show up on MacOS. With this patch, the expectation on MacOS now matches other platforms. Bug: 868983 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I80098edd844bb88e3c64a54cc42b54063ec1c583 Reviewed-on: https://chromium-review.googlesource.com/1153972Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581383}
-
Becca Hughes authored
The autoplay policy should follow the kBlockAutoplayEnabled pref if the kAutoplaySoundSettings feature is enabled. If the pref is true we will use document-user-activation otherwise we will use no-user-gesture-required. The only exception is if the user has overridden the autoplay policy in which case we will use the autoplay policy command line switch. BUG=865548 Change-Id: I79ba3bbf5542ba17af9ab96baef80cd89d5b5326 Reviewed-on: https://chromium-review.googlesource.com/1157199 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#581382}
-
Jacob Dufault authored
Bug: 839604 Change-Id: I7a9048afb50151a6c3eab2a0a2ca09cd5f5ec2ae Reviewed-on: https://chromium-review.googlesource.com/1166185Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#581381}
-
Eric Willigers authored
Web payments modifiers shipped in M62 https://chromium-review.googlesource.com/632597 https://www.chromestatus.com/feature/6636936064139264 BUG=660926 Change-Id: Id0ab64582180f3cba875618efe3b31177d9ce9b8 Reviewed-on: https://chromium-review.googlesource.com/1164973Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581380}
-