GitLab

Per discussion, allows kInfiniteDuration() for the front DiscardPadding
value.  When there's no decoder delay, this ensures accuracy when
discarding.  If decoder delay is present, the code falls back to using
the duration as an estimation.

BUG=371633
TEST=new unittests
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/293053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271928 0039d316-1c4b-4281-b951-d872f2087c98

Changes in preparation for upcoming preroll_buffer() method.

BUG=none
TEST=none
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/294043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271927 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Unload all apps / extensions when deleting a profile. (https://codereview.chromium.org/266343002/)

Reason for revert:
Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open

BUG=374683
TBR=kalman, sky

Original issue's description:
> Unload all apps / extensions immediately when deleting a profile.
>
> Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
>
> Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.
>
> [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
> [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
> [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362
>
> BUG=368684
> TEST=Manual testing as described on http://crbug.com/368684#c1
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890

Review URL: https://codereview.chromium.org/289283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271926 0039d316-1c4b-4281-b951-d872f2087c98

Crashes on various platforms. See bug.

TBR=haitaol@chromium.org
BUG=375856

Review URL: https://codereview.chromium.org/295093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271924 0039d316-1c4b-4281-b951-d872f2087c98

Caused canvas test failures on all platforms.

BUG=375851

> Skia roll 14765:14816
> 
> https://code.google.com/p/skia/source/list?num=50&start=14816
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/284413006

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/294183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271923 0039d316-1c4b-4281-b951-d872f2087c98

Times out on Android Tests Dbg flakily. See bug for details.

BUG=375840
TBR=haitaol@chromium.org

Review URL: https://codereview.chromium.org/299833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271922 0039d316-1c4b-4281-b951-d872f2087c98

https://src.chromium.org/viewvc/chrome?view=rev&revision=271919 fixes the
compiler crash, http://src.chromium.org/viewvc/chrome?view=rev&revision=271780
fixes the bug in landmines that didn't allow the initial land/revert to
go smoothly.

Should be A-OK this time.

> Revert 271721 "VS2013 Update 2"
> 
> static_library build ICEing on some builders on mini_installer.
> 
> > VS2013 Update 2
> > 
> > As discussed in the linked bug, the toolchain2013.py script in
> > depot_tools is no longer workable (because the update for Update 2 is
> > supplied as a .msp that must be applied against a system-installed
> > VS2013).
> > 
> > As such, the Express hash here is not updated.
> > 
> > The hash zip referenced here was built as follows:
> > - Install VS2013 Update 2 on a clean VM
> > - Copy DIA SDK\, VC\
> > - Copy DLLs from VC\redist to sys32\ and sys64\
> > - Copy win8sdk unchanged from previous .zip.
> > - Delete various unused arm\ subdirectories
> > - Delete the IDE-only Snippets, etc. subdirectories in VC\
> > - Patch VC\include\xtree to disable warning 4702 per request in
> >   http://crbug.com/346399 .
> > 
> > A followup change will be to write a script that does these steps
> > semi-automatically, hopefully for Express too, though there is the
> > added complication of the WDK/ATL/MFC hacking required there. In
> > particular, this script will not be useful for a dev to actually run
> > as part of runhooks, but will be a bit useful for deployment/
> > documentation of the above process.
> > 
> > In the interim there are no extremely-pressing reasons for Express
> > users to update to Update2 that I'm aware of, so they get non-Update2
> > for now.
> > 
> > R=iannucci@chromium.org
> > BUG=372451,346399,371847,339215,350639
> > 
> > Review URL: https://codereview.chromium.org/284663003
> 
> TBR=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/297753002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/295093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375808,245025,373542
TBR=rsleevi

Review URL: https://codereview.chromium.org/299623007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271920 0039d316-1c4b-4281-b951-d872f2087c98

The previous code is causing:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\mini_installer\mini_installer.mini_installer.obj.rsp /c ..\..\chrome\installer\mini_installer\mini_installer.cc /Foobj\chrome\installer\mini_installer\mini_installer.mini_installer.obj /Fdobj\chrome\installer\mini_installer.cc.pdb
c:\b\build\slave\win-latest-rel\build\src\chrome\installer\mini_installer\mini_installer.cc(857) : fatalerror C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 228)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information
INTERNAL COMPILER ERROR in 'C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information

after Update 2. The CRT's implementation looks like the simple char
loop, so simplify here too.

In practice, I think this will only rarely get used, as the compiler
is allowed to "know" what memset does and replace it with an optimized
version.

There's an upstream bug filed here: https://connect.microsoft.com/VisualStudio/feedback/details/878340/ice-on-memset-implementation-at-o2

R=grt@chromium.org
BUG=372451

Review URL: https://codereview.chromium.org/294943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271919 0039d316-1c4b-4281-b951-d872f2087c98

This is part of an effort to get rid of use of DescWrapper/NaClDesc for nexe
module loading. This is anticipation of moving nexe loading away from SRPC to
Chrome IPC.

Note that this tightens up some permissions for converting file descriptors;
I'm not sure why some were originally opened with _O_RDWR.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/291973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271918 0039d316-1c4b-4281-b951-d872f2087c98

The Decode function should not require the plugin to
maintain its buffer when it completes asynchronously.

BUG=281689
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/291083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271917 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/284313010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271916 0039d316-1c4b-4281-b951-d872f2087c98

Add regression tests to ensure that IPC::Listener::OnBadMessageReceived is always called for all cases, i.e.
1) using IPC::Channel directly
2) using IPC::ChannelProxy and the IPC is dispatched on the IO thread
2) using IPC::ChannelProxy and the IPC is dispatched on the listener thread

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/282303014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271915 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271914 0039d316-1c4b-4281-b951-d872f2087c98

This is to get a GN build update on ARM

R=rsleevi@chromium.org
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/297773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271913 0039d316-1c4b-4281-b951-d872f2087c98

This is so these file lists can be shared with the GN build. There should be no change for the GYP build.

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/291093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271912 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271911 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13200: (mseaborn) Unsandboxed IRT: Implement more of the irt_dev_filename interface
r13201: (dschuff) Use cygwin targets instead of mingw in list of uploadable targets for PNaCl builders
r13202: (mseaborn) symlink()/link() tests: Fix error handling
r13203: (noelallen) Roll bionic.
r13204: (noelallen) Roll bionic.
r13205: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13206: (kschimpf) Update revision for PNaCl r13166->r13199
r13207: (dschuff) Convert paths in temp upload packages file
r13208: (mseaborn) Remove unused support for SysV shared memory
r13209: (mark) [Windows] Don't run an impossible test case from nacl_host_desc_big_file_test.
r13210: (bradnelson) Pass --revision to runtest.py
r13211: (mseaborn) Non-SFI Mode: Add ability to build newlib-based Linux static executables
r13212: (sehr) Enable the gyp android build
r13213: (dschuff) Remove test of pinned toolchain from toolchain bots
r13214: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13215: (dyen) Git repositories syncing through repo_tools can be validated.
r13216: (dschuff) Pin toolchain_build_pnacl toolchain into NaCl

BUG=none
TEST=browser_tests and nacl_integration
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/292603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271910 0039d316-1c4b-4281-b951-d872f2087c98

First step for renaming ui::ScaleFactor to ui::ResourceScaleFactor

BUG=372212
R=pkotwicz@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/291733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271909 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271908 0039d316-1c4b-4281-b951-d872f2087c98

> Roll pdfium to get fixes for build warnings.
> 
> a3f590b  Add Matt Giuca to AUTHORS.
> 4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
> 2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
> 4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
> 6f9095f  Add my @chromium account in the AUTHORS file.
> 54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
> 5ce98f5  Fix warning on Mac.
> 41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.
> 
> R=thestig@chromium.org
> 
> Review URL: https://codereview.chromium.org/295983005

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/296913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271907 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271906 0039d316-1c4b-4281-b951-d872f2087c98

a3f590b  Add Matt Giuca to AUTHORS.
4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
6f9095f  Add my @chromium account in the AUTHORS file.
54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
5ce98f5  Fix warning on Mac.
41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/295983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373543,373542,245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/287133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true
R=merkulova@chromium.org

Review URL: https://codereview.chromium.org/297683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/265403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356183
TEST=manually
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/291233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374226
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/293013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271885 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271884 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/296003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271883 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271882 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=50&start=14816
TBR=
BUG=

Review URL: https://codereview.chromium.org/284413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=ager@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271880 0039d316-1c4b-4281-b951-d872f2087c98

where they're used.

BUG=372212
R=sky@chromium.org

Review URL: https://codereview.chromium.org/291073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271874 0039d316-1c4b-4281-b951-d872f2087c98

Pass MetricsServiceClient into MetricsService, and create a simple stubbed TestMetricsServiceClient class.

BUG=374237,374235
TEST=compiles
R=asvitkine@chromium.org, blundell@chromium.org

Review URL: https://codereview.chromium.org/290343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123750
TEST=None
NOTRY=True

Review URL: https://codereview.chromium.org/299753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271872 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step into getting this target running on
TS/CQ/Waterfall system.

BUG=348066
TEST=green trybots
R=yoz@chromium.org,stip@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/294483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271871 0039d316-1c4b-4281-b951-d872f2087c98

3 out of 4 existing owners have since left Chrome.

BUG=

Review URL: https://codereview.chromium.org/299623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271863 0039d316-1c4b-4281-b951-d872f2087c98