- 31 Aug, 2020 40 commits
-
-
Maxim Kolosovskiy authored
This reverts commit 57af2c42. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Reland "cros: Implement ClipboardImageModelFactory" > > This reverts commit 5822a03a. > > Reason for revert: > It turned out that the test is flaky regardless of this change. > Probably this just made it easier to reproduce the flakiness. > > Original change's description: > > Revert "cros: Implement ClipboardImageModelFactory" > > > > This reverts commit 056d2885. > > > > Reason for revert: > > This is a speculative revert for failures on > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382 > > > > This could fail the following test: > > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText > > > > Original change's description: > > > cros: Implement ClipboardImageModelFactory > > > > > > Implements ClipboardImageModelFactoryImpl. > > > Previous CL landed ClipboardImageModelFactory, and all > > > ash-side usages of the factory. > > > > > > This CL implements rendering of HTML via > > > ClipboardImageModelRequest. > > > > > > Bug: 1117230 > > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#802779} > > > > TBR=xiyuan@chromium.org,newcomer@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1117230 > > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532 > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803003} > > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1117230 > Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803027} TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org Change-Id: Iad7614b249091bfcce8a27f10ae4e67de86a2a29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382603Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803043}
-
Maxim Kolosovskiy authored
This reverts commit a0522042. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Roll DevTools Frontend from b6f22fe80638 to f36682af28e2 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6f22fe80638..f36682af28e2 > > 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I36dc0e3b5f615bdce8a95973f1fbfd7ac8c61611 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384520 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#803028} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f83210f4dba60997d57602d00694b50e02959e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382120Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 437b61ae. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > [Telemetry SWX] Add battery capacity routine > > Add implementation to chrome://. > > Add implementation to chrome-untrusted://. > > Add tests. > > Bug: b:162051831 > Change-Id: Ib2d618c4eacce43e6cd588c766e8d40af9ae318b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362933 > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Oleh Lamzin <lamzin@google.com> > Cr-Commit-Position: refs/heads/master@{#803030} TBR=tsepez@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com Change-Id: I675879ec1c65f834362901ba862923acadfa9551 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:162051831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383028Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 1edcb047. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Add Media Capture and Generic Sensors mojom.js files to mojojs.zip > > This is the first step before removing those files from WPT. > > Bug: 1119858 > Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> > Cr-Commit-Position: refs/heads/master@{#803031} TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,robertma@chromium.org,arnaud.mandy@intel.com Change-Id: I94a722412f3cd37ef6ad9ab15274f6951855e9c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383027Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598701830-094fa9b25781b44321eb93f9a4da522936ebbe2a.profdata to chrome-win64-master-1598853319-353b2ae72aeb030448b18cf22e3efb9470af52fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I6d08477818ba5c08a7042cdb6d7febfee202ee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803039}
-
Alice Wang authored
This CL cleans the checkCollapsedAccountList() method used in AccountPickerBottomSheetTest. Bug: 1121536 Change-Id: I1bf45237bb7a29d1a53baf82629bfaa805c0de81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377498Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803038}
-
Maxim Kolosovskiy authored
This reverts commit 0426308f. Reason for revert: I suspect it caused compilation failures https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190? Original change's description: > [WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes > > The feature policy to enable WebAuthn get requests in cross-origin > iframes shipped in M84 but did not include a use counter. This CL adds > one. > > Change-Id: Ie404ab62de3cfe665a1927883a31d7f17c329c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384651 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#803026} TBR=kenrb@chromium.org,martinkr@google.com Change-Id: I07e8edb0aeed3c53118f69bb4c7304cb6f34342f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383026Reviewed-by:
-
Guido Urdaneta authored
This prevents potential cross-origin mid-stream redirects from braking the cross-origin restrictions. Bug: 1111149 Change-Id: I18d05a5836b9a390dec50e10c43d3d2b9ec5915a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377811 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#803036}
-
Yusuke Sato authored
This CL depends on the following CLs: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806 https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221 BUG=b:166314117 TEST=arc.Boot.vm still passes, arcvm-adbd runs Change-Id: I385a807d84a98b4a97dcc66daf6bef5881eef2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380733 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803035}
-
Andrey Zaytsev authored
This prevents users from only enabling the #safety-check-android flag and getting a crash on the Safety check screen because the required #password-check flag is disabled. Note: this is only possible if the user changes the flags manually; the Finch config never has the Safety check flag without the Password check one. Bug: 1070620, 1120824, 1122473 Change-Id: I9720a5fcee845648fb7d617926395c1f855356d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379898Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#803034}
-
Glen Robertson authored
Fixes a `gn check` error. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I4739841f3c2fe9f80d21bb11ca44d00102650ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383514 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#803033}
-
Fredrik Söderqvist authored
Hoist the check for 'by' animations out of IsAdditive() and leave it to only check the 'additive' attribute value. The SVGAnimateElement::IsAdditive() override can be removed since the additional check for non-additive types is handled during the animation value calculation, and non-additive types are rejected while validating the animation parameters. While at it, randomly add some comments for additive handling, and add more comments in OverwritesUnderlyingAnimationValue(). Also make IsAdditive(), IsAccumulated(), GetAnimationMode() and GetCalcMode() non-public as appropriate. Bug: 1017723 Change-Id: I0907742ca1e568ba6faee1b08199bccad683a5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379919Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#803032}
-
Arnaud Mandy authored
This is the first step before removing those files from WPT. Bug: 1119858 Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#803031}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: Ib2d618c4eacce43e6cd588c766e8d40af9ae318b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362933 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#803030}
-
Takashi Toyoshima authored
This patch removes network::features::kOutOfBlinkCors and network::features::ShouldEnableOutOfBlinkCorsForTesting() references from existing tests as now BlinkCors was deprecated, and we already turned down CORS fyi bots. This is part of the work to remove the kOutOfBlinkCors feature. Bug: 1053866 Change-Id: I4ba14005fd3fb310cbd246e6c0bd6cc18bd005d8 TBR: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377633 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#803029}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6f22fe80638..f36682af28e2 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36dc0e3b5f615bdce8a95973f1fbfd7ac8c61611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384520Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 5822a03a. Reason for revert: It turned out that the test is flaky regardless of this change. Probably this just made it easier to reproduce the flakiness. Original change's description: > Revert "cros: Implement ClipboardImageModelFactory" > > This reverts commit 056d2885. > > Reason for revert: > This is a speculative revert for failures on > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382 > > This could fail the following test: > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText > > Original change's description: > > cros: Implement ClipboardImageModelFactory > > > > Implements ClipboardImageModelFactoryImpl. > > Previous CL landed ClipboardImageModelFactory, and all > > ash-side usages of the factory. > > > > This CL implements rendering of HTML via > > ClipboardImageModelRequest. > > > > Bug: 1117230 > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802779} > > TBR=xiyuan@chromium.org,newcomer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1117230 > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803003} TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1117230 Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#803027}
-
Ken Buchanan authored
The feature policy to enable WebAuthn get requests in cross-origin iframes shipped in M84 but did not include a use counter. This CL adds one. Change-Id: Ie404ab62de3cfe665a1927883a31d7f17c329c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384651 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803026}
-
Giovanni Ortuño Urquidi authored
The browser test no longer requires us to update it every time we add a new app. Change-Id: If6e932b72fd03184ae901b69f8129edf44421fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383403 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#803025}
-
Melissa Zhang authored
This CL adds a Profile getter in SharesheetController for ShareActions to use to get the Profile. Bug: 1097623 Change-Id: I4af0c095d453b87d826d2ac029b1e35dd02c3f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384711Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803024}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I00e6f700c11819bee92cd48b2e48a91306e20730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384518Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/85f51b2a409c..c23eeb8c78ec 2020-08-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ec3650f56ca2 to a2e6c1a149f4 (4 revisions) 2020-08-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d3eba1db0a14 to 2f291c0bd181 (29 revisions) 2020-08-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 15c4ec7c to b89144a4 (499 revisions) 2020-08-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 900bd341a3c6 to 0b89b27263b1 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1122718 Tbr: michaelludwig@google.com Test: Test: Test: Manhattan MEC works again Change-Id: I6f648f719304b87f8892b6eb8022177255852119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384517Reviewed-by:
-
Yunke Zhou authored
Fix back button behavior on gaia screen to go back to user creation screen only when it was shown before. Back button should close the oobe dialog for managed device or in re-auth case. Bug: 1121574, 1122596 Change-Id: I3a3ad0c982369b61c3cf67c04c9081fed01ea93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374445 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803021}
-
Yoshisato Yanagisawa authored
This reverts commit d6407546. Reason for revert: broke all builders at gclient runhook Original change's description: > infra/config Use Goma's task service account. > > For ease of distinguishing Goma's builder, let me specify special > service accounts for them. > > Bug: b/166712857 > Change-Id: I45317d787e2b3f8bbf9e1cb15d588ba661fad4fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384450 > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802998} TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,yekuang@google.com Change-Id: I5e9bf7044ca1e9a23455e89e99533a42cb18883c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/166712857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384573Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803020}
-
Hiroki Nakagawa authored
This reverts commit b89144a4. Reason for revert: AccessibilityFocusHighlightBrowserTest.FocusAppearance is constantly failing on the "Mac10.11 Tests" bot. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/54112 Original change's description: > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > AX-Relnotes: n/a > > Bug: 1114959 > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803007} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,aboxhall@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I61f57468a6f4172dc73cb72fb601855e4ab99484 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383376Reviewed-by:
-
Zhuoyu Qian authored
This CL renames Web IDL |LenientThis| to |LegacyLenientThis| to make its usage more clear. Bug: 1072773 Change-Id: I2f4ad082cad0b2598dcf36cd50247923b40a0ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371146Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#803018}
-
Wei Lee authored
Since currently there is no general way to file a feedback report, we implement it through Mojo just as HelpApp, MediaApp do. Bug: 980846 Test: Manually Change-Id: Ibfd923c2e8510de4cc22a956631ccb53cff457d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131545 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#803017}
-
Eric Willigers authored
Requiring and consuming transient activation prevents a page from repeatedly requesting permission to open a connection, without prior engagement with the page by the user. Not yet done: We should not consume or detect transient activation during re-connection attempts. Bug: 1119600 Change-Id: I3cbfea09bbdeebe30be2f56bee57459eef07f198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384229 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#803016}
-
Darren Shen authored
|setCompositionRange| takes in relative offsets, which causes several bugs. Deprecate |setCompositionRange| and replace with |setComposingRange| which takes in absolute offsets. Bug: 1035248 Change-Id: Ic82eaad58f18f727ac682853def7076aaf70310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371444 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803015}
-
Adam Rice authored
The transferable streams implementation would crash when it received a chunk that wasn't deserializable, because it failed to enter a ScriptScope before creating a V8 object. Fix it. Also fix the message on the DOMException that is created when deserialization fails. Add a test for deserialization failure. This is hard to trigger in a cross-browser fashion. In this test, we use a WASM module, which can't be transferred to a different site. BUG=1122725 Change-Id: I6e49c69978388357a3c6006cc02dce8f0a949954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379417 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#803014}
-
Alan Cutter authored
This CL is a mechanical change that renames launch_url to start_url in the WebApp class. This is to make "start_url" more closely match the app manifest field and to make room for a separate "launch_url" in a follow up CL that includes additional query params added to the start_url. Bug: 1045537 Change-Id: I040e62b8fb79e36427720609bcc50911cdc2aaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376936 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#803013}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598806680-ea8cbf643223574fcb349af48fd14418e961fcb1.profdata to chrome-win32-master-1598834860-65570273a8a9241ebf147440a3fd9be058e3b8e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae335235a36197be95ef1be7981e6dfaa4076e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384510Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/809a6d42384e..b6f22fe80638 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab876098571c0c948cd53ec15e2cc33b56797690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384512Reviewed-by:
-
David Black authored
Following this CL, there will be one delegate left to add to move download manager logic out of `HoldingSpaceKeyedService`. Bug: 1119496 Change-Id: Ida9e3df4f45386f977ac0ce4d2a7b9f96e4cf6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383191 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a0d048a4023f..2f291c0bd181 2020-08-31 syoussefi@chromium.org Vulkan: Re-enable fixed dEQP tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I919463a31a4ef5518f2323086131ee1a02a38266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384511Reviewed-by:
-
Yusuke Sato authored
This makes the code simpler and shorter. This is a follow-up CL for chromium:2380733. BUG=None TEST=components_unittests Change-Id: I7e3a607f001824df9e57f821df46fc515e221d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380442 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Alice Boxhall authored
AX-Relnotes: n/a Bug: 1114959 Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#803007}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I0c3348b5efb93c0e08d4ca4acc76a0dbb204e0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384319Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803006}
-
Eric Willigers authored
DirectSocketsServiceImpl is now a WebContentsObserver. OpenTcpSocket() and OpenUdpSocket() now fail safely if they are called after the RenderFrameHost is destroyed. Bug: 1122917 Change-Id: I4a880c9aee73271cd5895818e0da3d85e32a8e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383531 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c484875cdcb..c73782c8d8ff 2020-08-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4469754998d3a012744744009e224672d8a6e29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384401Reviewed-by:
-
