GitLab

cachedImage->imageForLayoutObject() no longer returns
BitmapImages. The surrounding code is still correct since
cachedImage->imageForLayoutObject() may return a SVGImageForContainer
which does not propagate the correct filename extension.

NOTRY=true
BUG=128055

Review URL: https://codereview.chromium.org/1429803002

Cr-Commit-Position: refs/heads/master@{#357105}

Code location addresses printed by debuggerd in pre-M Android
are wrong where relocations are packed, because the libunwind
on these targets does not understand non-zero min vaddrs in
ELF LOAD segments.

Fix by searching the APK staging directory for libraries with
packed relocations, and adjusting the tombstone data on pre-
processing so that code addresses printed for these libraries
by debuggerd are offset by the min vaddr of the library that was
included in the APK.

This feature is hidden behind a new --packed-relocation-adjustments
flag, and defines a new --chrome-apk-dir flag that can be used
to indicate the location of the APK staging directory (defaults
to ../chrome_apk/ within the chrome-symbols-dir).

Uses the 'Build fingerprint' in the tombstone file to try to
auto-detect whether packed relocation adjustment should be
applied (that is, if the target is running pre-M Android).

BUG=536847

Committed: https://crrev.com/a0773c285a4a3a1a77df987a187d83096feb635f
Cr-Commit-Position: refs/heads/master@{#356858}

Review URL: https://codereview.chromium.org/1412223008

Cr-Commit-Position: refs/heads/master@{#357104}

If a consumer type is not supported, it is not added to
consumers_bitmask_ in AddConsumer. But in RemoveConsumer it is xored
into the mask, because fetcher_->Stop normally returns true for valid
consumer types; then this mask is passed into fetcher_->Fetch, and
e.g. on mac the fetcher crashes.

BUG=

Review URL: https://codereview.chromium.org/1428533003

Cr-Commit-Position: refs/heads/master@{#357103}

When offline pages are enabled, it updating NTP message
OLD: Any files you download or bookmarks you create will be kept.
NEW: Any downloaded files or saved pages will be kept.

BUG=491352

Review URL: https://codereview.chromium.org/1407903004

Cr-Commit-Position: refs/heads/master@{#357102}

We were not clipping the render surface content rect computed using
property trees with maximum supported texture size. That resulted in
property tree verification failures on some PictureLayerImplTests. This
CL fixes that.

BUG=538260
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1418663006

Cr-Commit-Position: refs/heads/master@{#357101}

Original CL: https://codereview.chromium.org/1315323006/
Revert: https://codereview.chromium.org/1418513016

Reason for revert:
Reverting to address webgl_conformance_tests break in:
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/3534

Reason for reland:
There is a bug in glCopySubTextureCHROMIUM extension. GLES2DecoderImpl::DoCopySubTextureCHROMIUM/DoCompressedCopySubTextureCHROMIUM
uses ValidForTexture to check dimensions of source texture. If the source
texture is backed by GL Image, the decoder can report false positive error.
This CL doesn't use Texture::ValidForTexture() for GL Image.

TEST=WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_*
BUG=349871, 504773, 549531

Review URL: https://codereview.chromium.org/1413833006

Cr-Commit-Position: refs/heads/master@{#357100}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2cbd59e3..b8500e4d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1404363006

Cr-Commit-Position: refs/heads/master@{#357099}

Gives information about files and sizes in an apk using zipfile.

BUG=546012

Review URL: https://codereview.chromium.org/1397553002

Cr-Commit-Position: refs/heads/master@{#357098}

https://chromium.googlesource.com/angle/angle.git/+log/8182049..a5f64de

BUG=525930,541550
TBR=geofflang@chromium.org
TEST=bots

Review URL: https://codereview.chromium.org/1426653006

Cr-Commit-Position: refs/heads/master@{#357097}

BUG=543583
R=hendrikw

Review URL: https://codereview.chromium.org/1410883008

Cr-Commit-Position: refs/heads/master@{#357096}

These fields will return later on in the form of a trait set as proposed
in the Task Traits proposal. The |AllocationContextTracker| will not
keep track of general-purpose fields.

BUG=524631

Review URL: https://codereview.chromium.org/1427953002

Cr-Commit-Position: refs/heads/master@{#357095}

BUG=539347

Review URL: https://codereview.chromium.org/1406923010

Cr-Commit-Position: refs/heads/master@{#357094}

Revert of Add new, unused methods to SpdyFramerVisitorInterface. (patchset #1 id:1 of https://codereview.chromium.org/1413683005/ )

Reason for revert:
This CL broke the tree:
https://build.chromium.org/p/chromium/builders/Linux/builds/68259/steps/compile/logs/stdio

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -m32 -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -o flip_in_mem_edsm_server -Wl,--start-group obj/net/tools/flip_server/flip_in_mem_edsm_server.flip_in_mem_edsm_server.o obj/base/libbase.a obj/net/libflip_in_mem_edsm_server_base.a obj/net/libnet.a obj/base/libbase_static.a obj/base/allocator/liballocator_extension_thunks.a obj/third_party/modp_b64/libmodp_b64.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a obj/base/libsymbolize.a obj/base/libxdg_mime.a obj/third_party/libevent/libevent.a obj/third_party/boringssl/libboringssl.a obj/net/libbalsa.a obj/base/libbase_i18n.a obj/third_party/icu/libicui18n.a obj/third_party/icu/libicuuc.a obj/third_party/protobuf/libprotobuf_lite.a obj/url/liburl_lib.a obj/net/libnet_quic_proto.a obj/base/libbase_prefs.a obj/crypto/libcrcrypto.a obj/sdch/libsdch.a obj/third_party/zlib/libchrome_zlib.a obj/third_party/zlib/libzlib_x86_simd.a obj/build/linux/libgio.a obj/net/libepoll_server.a -Wl,--end-group  -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lgio-2.0 -lresolv
obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable for net::SpdySM: error: undefined reference to 'net::SpdySM::OnHeaderFrameStart(unsigned int)'
obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable for net::SpdySM: error: undefined reference to 'net::SpdySM::OnHeaderFrameEnd(unsigned int, bool)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Original issue's description:
> Add new, unused methods to SpdyFramerVisitorInterface.
>
> The new methods will allow SpdyFramer to pass headers to visitors through a
> SpdyHeadersHandlerInterface.
>
> There are so many descendants of SpdyFramerVisitorInterface that I thought it
> was best to start with the interface change, and add an unused stub
> implementation everywhere.
>
> This CL lands server change 106411694 by birenroy.
>
> BUG=488484
>
> Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
> Cr-Commit-Position: refs/heads/master@{#357084}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488484

Review URL: https://codereview.chromium.org/1422623009

Cr-Commit-Position: refs/heads/master@{#357093}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8a3760f..13391dd

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Commits in this roll:
13391dd robertphillips@google.com Minor cleanup of clip mask manager

Review URL: https://codereview.chromium.org/1408033009

Cr-Commit-Position: refs/heads/master@{#357092}

Log.d() are stripped on non-debug builds. This is adding a few such logs to
find out which messages are sent/received. It is also moving some Log.d() to
Log.e() so these messages will still be printed on release builds.

BUG=None

Review URL: https://codereview.chromium.org/1419663009

Cr-Commit-Position: refs/heads/master@{#357091}

On iOS, BrowserState do not have names. The code to support names can be
removed.

Review URL: https://codereview.chromium.org/1411573009

Cr-Commit-Position: refs/heads/master@{#357090}

Follow-up CL to crrev.com/1425793002. Adds an extra |name|
argument to the memory-infra RegisterDumpProvider methods.
This allow to see the names of the dump providers in the trace
and diagnose dump providers getting stuck or taking more time
than usual.
No further behavioral change is introduced by this CL.

BUG=547764
TBR=xhwang@chromium.org,simonhatch@chromium.org,jochen@chromium.org,shess@chromium.org,piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1406213005

Cr-Commit-Position: refs/heads/master@{#357089}

The crash is caused by the fact that during the ash::Shell destruction the
SystemTrayDelegate object is destroyed before the child windows are closed -
but apparently the VPNListView destructor accesses SystemTrayDelegate's members
without any checks.

BUG=542146

TEST=manual testing

Review URL: https://codereview.chromium.org/1410033002

Cr-Commit-Position: refs/heads/master@{#357088}

Original issue: https://codereview.chromium.org/1107333002/

Original issue description:

Wake Lock API implementation (Chromium part)

This is Chromium part of Wake Lock API implementation as per specification:
http://www.w3.org/TR/wake-lock/

The corresponding Blink part is submitted in issue 1084923002

Design document: https://docs.google.com/document/d/1KbIENP0wgxtSXDQFn9PbHZ_tAKZfR1Y8u4Hst8LpeaA/edit?usp=sharing

R=tsepez@chromium.org
R=nasko@chromium.org
R=mlamouri@chromium.org
R=jochen@chromium.org

BUG=257511

Review URL: https://codereview.chromium.org/1393203004

Cr-Commit-Position: refs/heads/master@{#357087}

Revert of OOPIF: Route keyboard events to focused frame in the browser process. (patchset #11 id:200001 of https://codereview.chromium.org/1405293002/ )

Reason for revert:
SitePerProcessBrowserTest.SubframeKeyboardEventRouting is flaky on Windows 7.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessBrowserTest.SubframeKeyboardEventRouting

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/43548/steps/content_browsertests/logs/stdio

Original issue's description:
> OOPIF: Route keyboard events to focused frame in the browser process.
>
> Previously, keyboard events were always routed to the top frame's
> RenderWidgetHost.  With OOPIF, the top frame then forwarded the event
> to an appropriate subframe renderer if needed.  The extra hop is
> inefficient and leaks information; moreover, the forwarding broke when
> mouse event hit-testing in the browser process was introduced.
>
> This CL adds logic to send keyboard events directly to the right
> RenderWidgetHost in the browser process, using the currently focused
> frame which is already tracked in each FrameTree.  This should be
> supported for Aura, Mac, and Android.
>
> BUG=530663, 339659
>
> Committed: https://crrev.com/e2a1799925ea027bd71ea9367280ddfb4403987a
> Cr-Commit-Position: refs/heads/master@{#357011}

TBR=kenrb@chromium.org,creis@chromium.org,alexmos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=false
BUG=530663, 339659

Review URL: https://codereview.chromium.org/1407173005

Cr-Commit-Position: refs/heads/master@{#357086}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71a9d820..2cbd59e3

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1413833010

Cr-Commit-Position: refs/heads/master@{#357085}

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484

Review URL: https://codereview.chromium.org/1413683005

Cr-Commit-Position: refs/heads/master@{#357084}

This is a reland of https://codereview.chromium.org/1209243004

Depends on https://codereview.chromium.org/1430633002

TBR=piman, kbr

BUG=501604, 509883

Review URL: https://codereview.chromium.org/1418113010

Cr-Commit-Position: refs/heads/master@{#357083}

Remove |description| from class SpdyRstStreamIR and SpdyFramer::SerializeRstStream(),
because it is forbidden by HTTP/2 specs.

This CL lands server change 106512729 by bnc.

BUG=548674

Review URL: https://codereview.chromium.org/1402373005

Cr-Commit-Position: refs/heads/master@{#357082}

This CL removes test dependencies on the serial/deserialization of
CronetEngine.Builders, and removes the related public APIs.
Internally CronetEngine.Builders are still serial/deserialized during
CronetUrlRequestContext construction but at least this doesn't
complicate the public APIs.
Perhaps in the future the internal serial/deserialization can be removed
in exchange for directly passing configuration options; this is a
large change however as the options are passed across several functions
and a thread hop.
Perhaps in the future the use of command line arguments to
CronetTestFramework can also be removed; for now I'm removing the
CONFIG_KEY argument.

BUG=531538

Review URL: https://codereview.chromium.org/1424193003

Cr-Commit-Position: refs/heads/master@{#357081}

TBR=aiolos@chromium.org
BUG=549429

Review URL: https://codereview.chromium.org/1414193007

Cr-Commit-Position: refs/heads/master@{#357080}

COUNT_RESIDENT_BYTES_SUPPORTED is disabled on iOS as it causes memory
corruption on iOS 9.0+ devices. Note that this was only caught on bots
downstream as we cannot run real device bots upstream.

BUG=542671

Review URL: https://codereview.chromium.org/1425933002

Cr-Commit-Position: refs/heads/master@{#357079}

Reland of Add PassPaintVisualRectToCompositor feature flag. (patchset #1 id:1 of https://codereview.chromium.org/1424783004/ )

Reason for revert:
Reverting the revert.
It turns out ThreadedChannelTestCommit.RunMultiThread_DirectRenderer is flaky and have flaked before this cl.
Sorry for reverting and reverting the revert.

Original issue's description:
> Revert of Add PassPaintVisualRectToCompositor feature flag. (patchset #3 id:40001 of https://codereview.chromium.org/1410573008/ )
>
> Reason for revert:
> Tentative revert since it seems to break http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31016.
>
> cc_unittests
>
> ThreadedChannelTestCommit.RunMultiThread_DirectRenderer.
>
> Original issue's description:
> > Add PassPaintVisualRectToCompositor feature flag.
> >
> > BUG=529938
> >
> > Committed: https://crrev.com/e8cc107c99f8dea17c02c677270e4e8af3f943c7
> > Cr-Commit-Position: refs/heads/master@{#357052}
>
> TBR=chrishtr@chromium.org,pdr@chromium.org,vmpstr@chromium.org,wkorman@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=529938
>
> Committed: https://crrev.com/31fc911d634e465b22687e78195a494e5e62225c
> Cr-Commit-Position: refs/heads/master@{#357072}

TBR=chrishtr@chromium.org,pdr@chromium.org,vmpstr@chromium.org,wkorman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=529938

Review URL: https://codereview.chromium.org/1421873004

Cr-Commit-Position: refs/heads/master@{#357078}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/82fcf88a..71a9d820

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1412013007

Cr-Commit-Position: refs/heads/master@{#357077}

Latest WebRTC draft @ generateCertificate:
http://w3c.github.io/webrtc-pc/#widl-RTCPeerConnection-generateCertificate-Promise-RTCCertificate--AlgorithmIdentifier-keygenAlgorithm

Note the corrections that has since been made resolving WebRTC & WebCrypto spec discrepencies (https://github.com/w3c/webrtc-pc/issues/310, https://github.com/w3c/webrtc-pc/issues/322), the unstable github latest version looks slightly different:
https://github.com/w3c/webrtc-pc/blob/master/webrtc.html
(More readable version: http://htmlpreview.github.io/?https://github.com/w3c/webrtc-pc/blob/master/webrtc.html)

This implementation is using WebCrypto and supports the AlgorithmIdentifier values required by the github version of the WebRTC spec:
{ name: "RSASSA-PKCS1-v1_5", modulusLength: 2048, publicExponent: new Uint8Array([1, 0, 1]), hash: "SHA-256" }
{ name: "ECDSA", namedCurve: "P-256" }

NOPRESUBMIT=true
BUG=544917

Review URL: https://codereview.chromium.org/1418113002

Cr-Commit-Position: refs/heads/master@{#357076}

Fixes spacing in Material (Holo will come later).

BUG=541617

Review URL: https://codereview.chromium.org/1418453003

Cr-Commit-Position: refs/heads/master@{#357075}

* Tweak the spacing to be identical to the standard layout
* Tweak the ripple to look good

BUG=541617

Review URL: https://codereview.chromium.org/1418813010

Cr-Commit-Position: refs/heads/master@{#357074}

Because it is used to allocate collections on PartitionAlloc.

BUG=548582

Review URL: https://codereview.chromium.org/1425533005

Cr-Commit-Position: refs/heads/master@{#357073}

Revert of Add PassPaintVisualRectToCompositor feature flag. (patchset #3 id:40001 of https://codereview.chromium.org/1410573008/ )

Reason for revert:
Tentative revert since it seems to break http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31016.

cc_unittests

ThreadedChannelTestCommit.RunMultiThread_DirectRenderer.

Original issue's description:
> Add PassPaintVisualRectToCompositor feature flag.
>
> BUG=529938
>
> Committed: https://crrev.com/e8cc107c99f8dea17c02c677270e4e8af3f943c7
> Cr-Commit-Position: refs/heads/master@{#357052}

TBR=chrishtr@chromium.org,pdr@chromium.org,vmpstr@chromium.org,wkorman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=529938

Review URL: https://codereview.chromium.org/1424783004

Cr-Commit-Position: refs/heads/master@{#357072}

Clicking a track usually changes tracks but doesn't change the play state. (play / pause)
With this CL, clicking play icon which is shown on hover will force start playing the track.

BUG=488229
TEST=manually

Review URL: https://codereview.chromium.org/1431523003

Cr-Commit-Position: refs/heads/master@{#357071}

BUG=414787

Review URL: https://codereview.chromium.org/1409223005

Cr-Commit-Position: refs/heads/master@{#357070}

This CL includes:
- Custom volume slider is replaced with paper-slider, which is dynamically shown on the top of control panel when volume button is activated.

BUG=488229

Review URL: https://codereview.chromium.org/1425033006

Cr-Commit-Position: refs/heads/master@{#357069}

BUG=546411

Review URL: https://codereview.chromium.org/1412613004

Cr-Commit-Position: refs/heads/master@{#357068}

BUG=546596

Review URL: https://codereview.chromium.org/1423773003

Cr-Commit-Position: refs/heads/master@{#357067}

This CL finds the closest supported format in allocate() from the requested resolution, and uses that to open the camera. This is consistent with how VideoCaptureCamera and other camera capture devices work.

BUG=541232

Review URL: https://codereview.chromium.org/1416253005

Cr-Commit-Position: refs/heads/master@{#357066}