- 27 Dec, 2019 13 commits
-
-
Andrey Kosyakov authored
TBR=kvitekp@chromium.org Change-Id: I53da1f16c88d4a3c5c5bc203a9e036c6bb93e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982228Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727526}
-
Kurt Horimoto authored
Previously, each OverlayRequestCoordinator had an associated OverlayRequestMediator that also supported the same request type. However, with the introduction of infobar overlays, we will have a single OverlayRequestCoordinator managing the UI, but separate mediators that support only a specific request config type used to configure the shared consumer protocol. This CL adds class properties to the coordinator and mediator interfaces that return OverlayRequestSupports rather than keeping |+supportsRequest:|. This allows each class to specify its request support separately without the need to introduce an additional |+supportRequest:| to the mediator. Bug: none Change-Id: I990467855d6cd1193db9d70e68ce412866128f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981198 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727525}
-
Devlin Cronin authored
Refactor PageAction commands tests to be less reliant on waiting for success, and introduce a couple of helper methods. This allows us to exercise that the page action is *not* triggered in certain cases (whereas with the way the tests were structured before, there was no way to do so). Also add a new test that leverages to test that the page action is not triggered if the action is not visible on the given tab. This is also a precursor for getting overflowed page action keyboard commands to work properly. Bug: 1037685 Change-Id: I2e5bec90bf3a5f1aeb00e115b94a82863a68e092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981192Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727524}
-
Nate Fischer authored
This repopulates the Spinners in the Flags UI when the Activity is recreated, to ensure the Activity and Service/ContentProvider have consistent state. Without this change, the flags UI would have an empty map of flag overrides, and would clear most of the Service's flags when the user toggles the first Spinner. This moves some the ContentProvider communication logic to a separate bridge class to be shared by both the dev UI and the embedded WebView browser process. TBR=torne@chromium.org Fixed: 1036538 Test: Manual - toggle flags in the Activity, swipe away the Activity, \ Test: and relaunch to see the UI is restored correctly Change-Id: Ife42a0633707c9d59e5678483a95f4267fbbe739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980857Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727523}
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037958 Change-Id: If8cc58b0bacc1ed5b50dfd32c2b3638acf17d589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982176Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#727522}
-
Regan Hsu authored
In order to make a specific collection of wallpaper photos ("Anna's Garden") only available on "Made by Google" chromebooks, a new filtering label must be added to whitelist that collection to "Made by Google" chromebooks. Bug: 1009025 Change-Id: I1a253d9786e9294cb523158421cb32519be45182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849100 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727521}
-
Dan Beam authored
* Move X into middle of focus outline * Fix incorrect padding around X (it should be 4px top/bottom, 2px left/right) Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1036708#c6 Fixed: 1036708, 1001637 Change-Id: I9ab51b17487808d1891a98e446060a6375f6ac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982720 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79f46fe255a1..198da190b2a3 Created with: gclient setdep -r src-internal@198da190b2a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idac1f5d8bd046109473ce7667af7c7f3f5100c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982815Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727519}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I827501caa0f162ffbb5ffeb320b60555b35578ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727518}
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037949 Change-Id: I078b0dd5e7f3af777245683dd734b71fd4309f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982134Reviewed-by:
-
Kurt Horimoto authored
Many OverlayPresenterObservers for the infobar refactor will only need to observer OverlayRequests created with a specific config type. ADding an OverlayRequestSupport to OverlayPresenterObserver allows the observer callbacks to only be sent for these requests rather than requiring each observer subclass to check against the request's config type. Bug: none Change-Id: I5517f1e04431ec1639cdb790bf4058bb8dcb3c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981251 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Reid Kleckner authored
This reverts commit 0d406dbc. Reason for revert: - Fuchsia arm64 bug (crbug.com/1037700) - Android arm64 bug (crbug.com/1037912) - 10% perf regression (crbug.com/1036818) Original change's description: > Reland "Roll clang n332890-c2443155-1 : n333938-3a6da112-1." > > This is a reland of b21c79dc > > Original change's description: > > Roll clang n332890-c2443155-1 : n333938-3a6da112-1. > > > > Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. > > > > Bug: 1030664 > > Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 > > Auto-Submit: Reid Kleckner <rnk@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#727069} > > Bug: 1030664 > Change-Id: I7a7fdcf7b0c6bd22f4840748318f7180931ea468 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979068 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727096} TBR=thakis@chromium.org,ukai@chromium.org,hans@chromium.org,rnk@chromium.org Bug: 1030664, 1037700, 1037912, 1036818 Change-Id: If73d19f7f5a0febdd83087b0a6f257f8ad21a36f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982227 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727515}
-
Dana Fried authored
Resetting the starting layout loses context about views that are fading in our out, causing popping of layouts in some cases (especially during slide animations). Having a layout reset multiple times can happen when one view is hidden and another view shown within the same host view with an animating layout. Ensuring that only the final change "sticks" makes for a smooth transition from the pre-modification state. Bug: 1037947 Change-Id: Ibc1dbb2f249d1edfd21294202467d2292d0591a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981333 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#727514}
-
- 26 Dec, 2019 27 commits
-
-
Caleb Rouleau authored
For gtests, do the conversion to histograms in run_performance_tests.py. This is cleaner than doing it in process_perf_results.py and has the benefit that Pinpoint will use in in the same way as well. Bug: 923564 Change-Id: I8eddd2d0934f68d45b278494eb67990ae9a30414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981633Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727513}
-
Andrey Kosyakov authored
Bug: 1036627, 1036627, 1034954 TBR=gab@chromium.org, fdegans@chromium.org This re-enables multiple headless tests suppressed after https://crrev.com/c/1977741 following the latter being reverted. Change-Id: I074e9ba1c5fa752a0773301dc3881d3a34662cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982762 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f2d522a3f434..89bf1547f3aa git log f2d522a3f434..89bf1547f3aa --date=short --first-parent --format='%ad %ae %s' 2019-12-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 52dae168b48b..01dd6f6ca430 (3 commits) 2019-12-26 brianosman@google.com Actually update win_toolchain to 2019 (14.24.28314) 2019-12-26 herb@google.com Do vertex color adjustment before atlas calculations 2019-12-26 herb@google.com Move vertex translation into SubRun Created with: gclient setdep -r src/third_party/skia@89bf1547f3aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Iffcdaa01eac5a5f2d80953176df25a02b909f955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982688Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0edda42e7d3..79f46fe255a1 Created with: gclient setdep -r src-internal@79f46fe255a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1035074 Tbr: jbudorick@google.com Change-Id: I08dad6a2bded1d5244a1e4696ec8bb86870a0774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982685Reviewed-by:
-
Caleb Rouleau authored
1. Add backup reviewer John Chen. 2. Add Wenbin as non-committer owner. 3. Add component Speed>Benchmarks. 4. Remove John B since this isn't his responsibility anymore (unless he wants to stay on?) Change-Id: I4ec8ed9a406ab7be47bcf71c6961164c558be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982683Reviewed-by:
-
James Vecore authored
Some metrics were set to expire at M81 that we want to keep. Also vecore@ is taking ownership of the MultiDevice metrics. Fixed: 1037153,1037152,1037151 Change-Id: I5e19f3eadfc17a731acc6bc899f8ebef3dec5146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981109Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#727508}
-
Demetrios Papadopoulos authored
- Add missing |search_label| js_library target. - Make dependencies more accurate and stop relying on transitive dependencies. Bug: None Change-Id: I69a5421459011ec58bfbba2f7a7502983bd1b43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980180Reviewed-by:
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037650 Change-Id: I1172bf08c5de2ddc4ea06c1b22019015074aae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982224Reviewed-by:
-
Kurt Horimoto authored
Much of OverlayPresenter's public interface is based around OverlayRequest and OverlayResponse, whose interfaces are intentionally opaque and leverages C++ templates to provide special behavior. This was done in order to ensure type safety and prevent misuse of these objects. Despite the benefits of this approach, template code can become unwieldy to use. Already, there are several instances of templated c++ container objects that are used to associate objects with their supported request/response types. This CL adds OverlayRequestSupport in order to abstract away some of this shared functionality. Follow-up CLs will use these objects to help implement these objects without having to use additional templates in each case. Additionally, this CL adds an OverlayRequestConfig template that allows for easy creation of OverlayRequestSupports for each config type. Bug: none Change-Id: I54bd0361f4ca5de2ae17e2b859ad36b98ca24fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980859 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit 20cefba5. Reason for revert: suspected cause of crbug.com/1037652 BUG: 1037652, 1034954 Original change's description: > Headless: fix a crash in ~HeadlessWebContentsImpl > > ... due to reentrancy while waiting for a [sync] call to > FrameSink::DestroyCompositorFrameSink() from Compositor destructor. > > Bug: 1034954 > Change-Id: I8b47560d18bdab38e40e67e6506d30a2043f1474 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977741 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726858} TBR=caseq@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034954 Change-Id: I244a6d9a9e36b8edb1297e9a3aa523b133f764e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982223Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22a241986380..f2d522a3f434 git log 22a241986380..f2d522a3f434 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Update MSVC toolchain asset to 2019 Created with: gclient setdep -r src/third_party/skia@f2d522a3f434 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I27a7da0baae40d266b4b3b74e2470517c03117a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982231Reviewed-by:
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). The stricter checks actually revealed a small bug where parameters to a function were passed in the wrong order from destination_settings_test.js Bug: 720034 Change-Id: Ic74d92a89fa5d8e89379c5843636f08f45505c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978164 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Khushal authored
TBR=jonross@chromium.org Bug: 1037939 Change-Id: I7ebc15845b1c23e5972807f0a077a939e110eda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982225 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Dirk is out for few weeks, so the only owner available right now is John B. Seems like some redundancy here would be helpful. John and I have been doing some work in this area including work on test_env.py and xvfb.py so it seems like we would be reasonable OWNERS. R=jbudorick@chromium.org, johnchen@chromium.org Change-Id: Ia5a959a6ab96a6b31507432688b7eb62fbf60cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982222Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53366c4e..8c170824 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9035b69e2328b6c506c537335c1cf938f7ce716b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981091Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727499}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/533cb856c0c9..f0edda42e7d3 Created with: gclient setdep -r src-internal@f0edda42e7d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iee7fb607bd9e44e4348a6021575d24c87d10ceb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982719Reviewed-by:
-
meacer authored
The presubmit currently imports grd_reader on all presubmit invocations (i.e. git cl upload) even though it's only needed when the CL touches a .grd or .grdp file. This CL does not import if no .grd/grdp files are affected. Bug: 1031189 Change-Id: Ib63873771a2ba6d0e60da76a457d2c22b89791b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978939Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#727497}
-
Stefan Zager authored
TBR=chrishtr@chromium.org Change-Id: I0e2d68aecb6b20ecec5ec4a88e41b57a69b06341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982684Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#727496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e5672715a8f..22a241986380 git log 1e5672715a8f..22a241986380 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 brianosman@google.com Fix CMake build Created with: gclient setdep -r src/third_party/skia@22a241986380 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ic9a7cb6356ce1b720946c8d903fb1b5cfe0e058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982701Reviewed-by:
-
Archana Simha authored
Records user actions when a user cancels and accepts the extension uninstall dialog and if the user checks the report abuse box. Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: I477a5c03514feb2ea74d92d9c6067b91cc1638b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972584 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#727494}
-
Thomas Lukaszewicz authored
Changed menu scroll view container to have its bubble border use the color id for background color instead of the color id for border color when determining background color. Following the change made in patch https://chromium-review.googlesource.com/c/chromium/src/+/1949105 the color of context menus in ChromeOS shifted to a darker shade of grey. This is contrary to how the context menu should be colored according to UX guidance. The code path for the bubble border in the menu scroll view container is only exercised in the following ash components: - ash/app_list/views/search_result_tile_item_view.cc - ash/app_list/views/app_list_item_view.cc - ash/root_window_controller.cc - ash/shelf/shelf_view.cc The scope of this change is thus isolated to ChromeOS, restoring the context menu color to its intended values on the platform. Bug: 1035600 Change-Id: I115df0b2781cba696713d96ead77ad50888538a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980768Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727493}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/b93b64e6bec7..85240a12ed2b $ git log b93b64e6b..85240a12e --date=short --no-merges --format='%ad %ae %s' 2019-12-23 rch Rename HandshakerDelegate to HandshakerInterface in QuicCryptoServerStream and QuicCryptoClientStream to make it clear that this is an interface which defines the handshaker as opposed to a delegate of the handshaker (Which is defined by the similarly named HandshakerDelegateInterface). 2019-12-23 wub gfe-relnote: For QUIC BBR v1 and v2, only produce one bandwidth/rtt sample per congestion event. Protected by --gfe2_reloadable_flag_quic_one_bw_sample_per_ack_event. 2019-12-23 ianswett Deprecate gfe2_reloadable_flag_quic_stop_reading_when_level_triggered. 2019-12-20 nharper gfe-relnote: Create handshaker for QuicCryptoServerStream in constructor instead of later. Protected by reloadable flag quic_set_server_handshaker_in_constructor. 2019-12-20 danzh gfe-relnote: n/a(code clean up) Add default definition of copy assignment for QuicPacketHeader. 2019-12-20 rch gfe-relnote: Drop QUIC INITIAL packets which are less than 1200 bytes. Protected by --gfe2_reloadable_flag_quic_drop_small_initial_packets 2019-12-20 wub gfe-relnote: Change quic::SendTimeState.bytes_in_flight to include the bytes from the packet just sent. Protected by v2 flag --gfe2_reloadable_flag_quic_bw_sampler_remove_packets_once_per_congestion_event2. 2019-12-20 wub gfe-relnote: (n/a) Add a QUIC BBRv2 simulator test to make sure inflight_hi is cut gradually upon loss from PROBE_UP. Test only. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: Id400aee98f6e184794f27f4aac554dbaa760ebeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982621Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727492}
-
Caleb Rouleau authored
This prevents us from hitting builder timeouts. Bug: 1036447 Change-Id: Id1337b795aa61648ca7ca1a69a71263ad27f4eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977965 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a46fc1dcdc3d..189074525f47 git log a46fc1dcdc3d..189074525f47 --date=short --first-parent --format='%ad %ae %s' 2019-12-26 rmhasan@google.com [Typ] Fix indentation in code block in expectations_parser.py Created with: gclient setdep -r src/third_party/catapult@189074525f47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036130 Tbr: zhanliang@google.com Change-Id: I18dd26db5c8f2736c3ad4a322c9499ef8524eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982596Reviewed-by:
-
Dana Fried authored
Fixes a rare use-after-free crash that could occur when an animating layout manager was already fading out a view and then that view was removed from its parent. Also adds a DCHECK and two regression tests to prevent the problem from occurring again (the DCHECK covers ALL LayoutManagerBase-derived layouts, not just AnimatingLayoutManager). Bug: 1037625 Change-Id: I87f4611a081bad7bb4fcffa30ab60a81502aeb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981338Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#727489}
-
Renato Silva authored
Changes the contrast of the separator under the password field on the login/lock screen. When the password field receives focus, the separator will be highlighted. When it loses focus, the highlight is removed. TBR=xiyuan@chromium.org Fixed: 908967 Change-Id: I8e953497586b96e8836745a8e086d3adb36edeca Bug: 908967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969340 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#727488}
-
Matthew Mourgos authored
ShelfWidgetTest::ShelfEdgeOverlappingWindowHitTestMouse is broken when enabling the hotseat. It is caused by the CL (https://crrev.com/c/1966428) which fails to set window insets for hotseat widget. To accelerate the process of enabling the hotseat flag, only run this test with hotseat disabled. TBR=xiyuan@chromium.org Bug: 1032702 Change-Id: I0a6ee824f23ea8ae948f4b6db2f0f9b27d828fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981113Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727487}
-
