GitLab

Since some platforms are still using NSS for now, this change mirrors https://boringssl-review.googlesource.com/#/c/4813/ in NSS.

BUG=490240

Review URL: https://codereview.chromium.org/1143303002

Cr-Commit-Position: refs/heads/master@{#330791}

BUG=489756
TEST=Mojo media services still working in html_viewer and chrome browser.

Review URL: https://codereview.chromium.org/1134003009

Cr-Commit-Position: refs/heads/master@{#330790}

This CL is dedicated to fix above issue and achieve below behaviors:
1.  User Menu does not close during sign-in flow: Things can't steal focus; the user menu stays open while you're typing / in the signin flow.
2.  Sign-in confirmation is modal: The user menu is not closeable until the user interacts with the signin confirmation window.  Sync should be delayed until the user interacts with the dialogue.
3.  Blue information box: This shouldn't go away until the user explicitly interacts with it (not you, what's new, "x").  Doesn't affect modality/close-ability of the user menu.

BUG=341196

Review URL: https://codereview.chromium.org/1136693002

Cr-Commit-Position: refs/heads/master@{#330789}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1d565c2..6bd0043

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1143313002

Cr-Commit-Position: refs/heads/master@{#330788}

This patch removes some redundant code (fixing a bunch of TODOs). Also
ensures that we only call pending_visible_rect once per iterator (since
the function involves a virtual call).

R=enne
BUG=488636

Review URL: https://codereview.chromium.org/1144973005

Cr-Commit-Position: refs/heads/master@{#330787}

The "LocalDelta" version of ScrollLayer in LTHI takes a scroll delta in
viewport space and scrolls a layer in its local space. This means that
the delta is scaled so that the scroll appears to be the same distance
on the user's screen, regardless of the page scale factor (pinch-zoom).
This method returns the amount consumed so that the caller can determine
how much of the original scroll delta remains to bubble. However, the
returned consumed delta is in local space, meaning we were subtracting a
layer space delta from the viewport space delta.

The practical effect of this was that when the page was scaled up the
bubbling logic in the viewport would inappropriately bubble up scrolls to
the inner (visual) viewport since the local delta is divided by the page
scale factor. This caused position:fixed elements to "paralax" scroll
with the page, cool looking but incorrect.

BUG=488549

Review URL: https://codereview.chromium.org/1143233003

Cr-Commit-Position: refs/heads/master@{#330786}

Currently TabCapturePerformanceTest records the time between "Capture"
events to determine the rate of capture. These events are issued whenever
a capture is requested, even if it is later aborted, and doesn't represent
the actual capture framerate. This CL adds an event on capture
success which will provide a more accurate idea of capture framerate.

BUG=489796

Review URL: https://codereview.chromium.org/1143723003

Cr-Commit-Position: refs/heads/master@{#330785}

ChromeSRMDelegate should not be reading the WebContents* back from
  WebContentsObserver after it has explicitly set to observe nullptr
  WebContents.
This was introduced by my earlier CL: r330213, I never tested the
  feature from NTP.

BUG=489182, 489157
Test=1) From new tab page, click on the mic beside search box,
  feed it some search query, it should not crash chrome.
2) Similar to step #1, but before the query completes, close the
  tab, observe no crash.

Review URL: https://codereview.chromium.org/1134773004

Cr-Commit-Position: refs/heads/master@{#330784}

This removes boilerplate code that was used when we supported building libpeerconnection as a shared library.  We don't support that any longer, so it's safe to delete.

BUG=463660

Review URL: https://codereview.chromium.org/1146123002

Cr-Commit-Position: refs/heads/master@{#330783}

BUG=475633

Review URL: https://codereview.chromium.org/1132353003

Cr-Commit-Position: refs/heads/master@{#330782}

BUG=475219

Review URL: https://codereview.chromium.org/1143933002

Cr-Commit-Position: refs/heads/master@{#330781}

Revert of Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices. (patchset #3 id:80001 of https://codereview.chromium.org/1147563002/)

Reason for revert:
MSan and Valgrind failures (use-of-uninitialized memory).

Original issue's description:
> Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices.
>
> BUG=420315
> TEST=unit test
>
> Committed: https://crrev.com/27e044cfc5c2a43b6c575508aca64763bfa2deba
> Cr-Commit-Position: refs/heads/master@{#330713}

TBR=isherman@chromium.org,tengs@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420315

Review URL: https://codereview.chromium.org/1146193002

Cr-Commit-Position: refs/heads/master@{#330780}

R=reed@google.com,mtklein@google.com
BUG=490188

Review URL: https://codereview.chromium.org/1143923003

Cr-Commit-Position: refs/heads/master@{#330779}

Revert of Change WebContents::last_active_time_ to Time instead of Timeticks. (patchset #1 id:140001 of https://codereview.chromium.org/1140083004/)

Reason for revert:
Reverting for georgesak@ (his committer access hasn't propagated yet it looks like).

After discussion with sky@, decided to keep TimeTicks.

Original issue's description:
> Change WebContents::last_active_time_ to Time instead of Timeticks.
>
> For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003
>
> Notes:
> - In dev tools, replaced "activity" with "active" for consistency
> - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time).
>
> BUG=472772
>
> Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20
> Cr-Commit-Position: refs/heads/master@{#330029}

TBR=jamescook@chromium.org,jam@chromium.org,georgesak@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472772

Review URL: https://codereview.chromium.org/1145233002

Cr-Commit-Position: refs/heads/master@{#330778}

Currently filesystem and data URIs are downloadable from context menu
Blob urls should also be supported.
Context menu downloads are handled by Chrome's network stack.
So blob urls will be handled appropriately.

BUG=481497

Review URL: https://codereview.chromium.org/1126233011

Cr-Commit-Position: refs/heads/master@{#330777}

  [☺] User Name

nor

  user@example.com

in the top, right corner of chrome://apps[1].

It looks like clicking this should do something. It doesn't.

R=jlklein@chromium.org
BUG=none

[1] http://i.imgur.com/FYEggUl.png

Review URL: https://codereview.chromium.org/1145883002

Cr-Commit-Position: refs/heads/master@{#330776}

This CL removes the option to use the old avatar menu but doesn't fully
remove the associated code. That cleanup will happen as a follow up.

BUG=451920

Review URL: https://codereview.chromium.org/1124383004

Cr-Commit-Position: refs/heads/master@{#330775}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/da030f3..1d565c2

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1151593002

Cr-Commit-Position: refs/heads/master@{#330774}

BUG=484756

Review URL: https://codereview.chromium.org/1134303004

Cr-Commit-Position: refs/heads/master@{#330773}

"gn path" finds all unique paths. This can be slow because, for example,
//chrome/browser has 478 million unique paths through it's dependency tree
and running path from //chrome/browser to //chrome/renderer took about 6.5
seconds on my big desktop to analyze all of these (to find no results).

This patch keeps track of which targets have been eliminated from consideration
and avoids visiting them again. This improves the above qwuery to 0.78 seconds
while still being able to compute the total number of results.

Review URL: https://codereview.chromium.org/1143043004

Cr-Commit-Position: refs/heads/master@{#330772}

Add basic tests for compile.py: valid JS compiles and produces
expected output files; invalid JS does not produce output files;
multiple JS files compile; output wrapper compiles.

BUG=486100

Review URL: https://codereview.chromium.org/1128843007

Cr-Commit-Position: refs/heads/master@{#330771}

R=binji@chromium.org

Review URL: https://codereview.chromium.org/1142713009

Cr-Commit-Position: refs/heads/master@{#330770}

Review URL: https://codereview.chromium.org/1147893002

Cr-Commit-Position: refs/heads/master@{#330769}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d8b5771..22483d9

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1151653002

Cr-Commit-Position: refs/heads/master@{#330768}

BUG=452726

Review URL: https://codereview.chromium.org/1145723003

Cr-Commit-Position: refs/heads/master@{#330767}

This is part of a series of patches to implement an
initial version of a mechanism for a MessagePort to
outlive a service worker as described in
https://github.com/mkruisselbrink/navigator-connect/blob/gh-pages/docs/api-idea.md#persisted-messageports

[1/3] https://codereview.chromium.org/1008533005/, blink side implementation
[2/3] this patch, content side implementation
[3/3] https://codereview.chromium.org/1063533002/, layout tests

BUG=426458, 483108

Review URL: https://codereview.chromium.org/1110103003

Cr-Commit-Position: refs/heads/master@{#330766}

The type SIMPLE is for web notification and we should use the type BASE_FORMAT for normal type notifications.

BUG=489975
TEST=manually

Review URL: https://codereview.chromium.org/1145953002

Cr-Commit-Position: refs/heads/master@{#330765}

Note to sheriffs: we're expecting a ~400 kB size regression due to
a bug fix that causes more loop unrolling in this Clang version.

BUG=483026
NOPRESUBMIT=true
TBR=brettw

Review URL: https://codereview.chromium.org/1144933003

Cr-Commit-Position: refs/heads/master@{#330764}

This failure has been preventing blink from rolling for >12 hours.
Sample failure:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/66651

TBR=cevans@chromium.org,haraken@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1148873003

Cr-Commit-Position: refs/heads/master@{#330763}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d30001ae..88a27231

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1149683002

Cr-Commit-Position: refs/heads/master@{#330762}

Some of the documentation was unclear and out-of-date, and also didn't really list what to do instead.

Review URL: https://codereview.chromium.org/1125033004

Cr-Commit-Position: refs/heads/master@{#330761}

This CL removes all Invoke() calls and uses ACTION_TEMPLATE instead.
This makes the code easier to read as now the values passed to the callbacks are no
longer hidden inside other functions.

Also change the definition of GetDevices to call adapter->GetConstMockDevices directly.
This allows us to use the EmptyAdapter as a base adapter on which we can build
other adapters.

BUG=436284

Review URL: https://codereview.chromium.org/1138913006

Cr-Commit-Position: refs/heads/master@{#330760}

Building "mandoline" should build html_viewer and ui_test.pak.

Review URL: https://codereview.chromium.org/1128023007

Cr-Commit-Position: refs/heads/master@{#330759}

BUG=

Review URL: https://codereview.chromium.org/1130713004

Cr-Commit-Position: refs/heads/master@{#330758}

Revert of Fix a crash when views::HWNDMessageHandler::HandleTouchMessage (patchset #3 id:80001 of https://codereview.chromium.org/1147583002/)

Reason for revert:
We reverted the CL which needs to be fixed by this one, so we need to revert it one as well. We will recommit it once we fully fix and test it.

Original issue's description:
> Fix a crash when views::HWNDMessageHandler::HandleTouchMessage.
>
> There is a crash when calling views::HWNDMessageHandler::HandleTouchMessage,
> because there are missing touch presses. Remove the CHECK for missing touch press,
> and ignore when this happens.
>
> BUG=316085, 488473
>
> Committed: https://crrev.com/41065dad044cd3bbd3c9bcc24e59eeae27a6c6a9
> Cr-Commit-Position: refs/heads/master@{#330751}

TBR=sadrul@chromium.org,ananta@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=316085, 488473

Review URL: https://codereview.chromium.org/1148143002

Cr-Commit-Position: refs/heads/master@{#330757}

This patch pulls in recent Trace Viewer changes, almost half of which
are UI fixes and changes for memory-infra.

Summary of changes available at (79 patches):
https://chromium.googlesource.com/external/trace-viewer/+log/e2b5374..473c6c4

Size increase for resources.pak:
51889 bytes (17350965 -> 17402854)

BUG=458295

Review URL: https://codereview.chromium.org/1146143002

Cr-Commit-Position: refs/heads/master@{#330756}

This is CL 3/3 in a series; please see http://crrev.com/1138013008 for
more information. Storing references to AndroidSyncSettings is no
longer allowed

BUG=480604

Review URL: https://codereview.chromium.org/1145003002

Cr-Commit-Position: refs/heads/master@{#330755}

512MB is needed on desktop to not regress performance on
some important benchmarks but this limit is much more than
needed on Android. By reducing it to 128MB we can also
avoid using a different allocation size on Android. This
makes the discardable memory behavior more consistent
across platforms and improves the browser's ability to
purge memory on Android.

This change also reduces the amount of discardable memory
used on low end devices to 1/8th of the normal limit.

BUG=489174

Review URL: https://codereview.chromium.org/1013533002

Cr-Commit-Position: refs/heads/master@{#330754}

BUG=487372

Review URL: https://codereview.chromium.org/1150443002

Cr-Commit-Position: refs/heads/master@{#330753}

BUG=483596
TEST=Logging in with ChromeOS still results in the user logging into the content area.

Review URL: https://codereview.chromium.org/1129463004

Cr-Commit-Position: refs/heads/master@{#330752}