- 13 Nov, 2019 28 commits
-
-
Adam Rice authored
Add the use counter FetchBodyStreamInServiceWorker which is triggered when the body getter is accessed in the Response class. The purpose of the use counter is to evaluate the potential benefit of Response body stream optimisations. Change-Id: I625bb08712f6fc1996def8bdab52a449fc725f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909675Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#714764}
-
Dale Curtis authored
BUG=954850,1023844 R=mcasas, tmathmeyer Change-Id: I0f224070ccc179a2219690f063301359ef0197ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913575 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714763}
-
Dale Curtis authored
Similar to 90a508cd, these values may occur in the wild and should be avoided. R=tguilbert Change-Id: Id30a7175649c399ddb3f6c78e29c9beac55c00ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913600 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#714762}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3992f656421f..0bbd6ee7bb63 git log 3992f656421f..0bbd6ee7bb63 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bsheedy@chromium.org Add global artifact logger Created with: gclient setdep -r src/third_party/catapult@0bbd6ee7bb63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nuskos@google.com Bug: chromium:1008075 Change-Id: I8fda2952513b11c18c4af30e9b33feb53ef1f3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714761}
-
rbpotter authored
Remove unnecessary extraLibraries from ModelSettingsAvailabilityTest. These were accidentally left in when Print Preview was migrated to Polymer 3, and cause the test to throw JS exceptions. Bug: 1012574 Change-Id: Ifa3a3492231f14acd8d1b6b70fc26334d3dfbb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912827Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714760}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59fa599a2a59..88632cac30e1 git log 59fa599a2a59..88632cac30e1 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bclayton@google.com Regres: Don't treat non-zero error codes as crashes. Created with: gclient setdep -r src/third_party/swiftshader@88632cac30e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I30ce69833da59e782b8c1feb991fb875bda3ef2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913545Reviewed-by:
-
arthursonzogni authored
Replace: FrameHostMsg_DidAddContentSecurityPolicies (IPC) By: FrameHost.DidAddContentSecurityPolicies (mojo) This corresponds to step 1.e from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao The native struct are going to be converted in a series of follow-up. Bug: 1021462 Change-Id: Ie77c21206c5a40535383c5c318458545930d3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905689 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714758}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: I1683b06cc4fd46cdfa46c681cf725157c0fb07f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912884 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714757}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c1e0effbbe1..9501212cd058 git log 8c1e0effbbe1..9501212cd058 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-12 herb@google.com Force single glyph calls through bulk interface 2019-11-12 rosasco@google.com Reland fully delineate GL usage w/ skia_use_gl. 2019-11-12 csmartdalton@google.com Fix detection of when we will have mixed sampled coverage Created with: gclient setdep -r src/third_party/skia@9501212cd058 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I8f8ad7b3714fc3e0009b0a9a27800e508cbc179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913540Reviewed-by:
-
Yi Xu authored
TBR=danakj@chromium.org Change-Id: I1b99bd50cc3d78ede44f5b46ff2ffe10c7dfdadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907075 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714755}
-
Doug Arnett authored
Currently the blocklist checks hide other interesting EligibilityReasons from being logged to UKM (such as hint match and triggering ECT) that could prove helpful in knowing more about hint availability and also more clearly that when a preview would have been triggered except for the local blocklist. This refactor pushes the blocklist checks to after these other triggering checks (but still before the coinflip check). Bug: 1023611 Change-Id: Ica2e75f8099674a2767141e5234747fd10a7d4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912143Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#714754}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dcc910a2095d..f47c2ab889d9 git log dcc910a2095d..f47c2ab889d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org RTC_EXPORT webrtc::RTCNonStandardStatsMember<T>. 2019-11-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b0967fe..0717a4dc (714463:714607) 2019-11-12 thaloun@chromium.org Don't ask for the friendly name of a default device if we failed to enumerate it. Created with: gclient setdep -r src/third_party/webrtc@f47c2ab889d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/144233691 Change-Id: I59f911eecf553a37ac77ab448c49fd62475ef7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913542Reviewed-by:
-
Daniel Hosseinian authored
The user manager already has access to the cloud print interface, which contains information about whether cookie based printers are disabled due to app kiosk mode. Instead of passing the app kiosk information from the sidebar to the destination settings, allow the user manager to access the desired information through a getter added to the interface. Change-Id: I7669d99fcfa2c8228de6dff42fff0e11ce1fb0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904946 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714752}
-
David Benjamin authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935 and https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4 for the motivation for this change. network::mojom::CredentialMode::kOmit is equivalent to LOAD_DO_NOT_{SEND_COOKIES,SAVE_COOKIES,AUTH_DATA}. For features which did not include LOAD_DO_NOT_SEND_AUTH_DATA, this change has two implications: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Requests through the network service already deny HTTP auth challenges if not attached to a WebContents, so this should be a no-op for these features. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. TBR=mdjones@chromium.org, wutao@chromium.org Bug: 799935 Change-Id: I6036193c0be4fa8a177a9cb79b84ca963fe435b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893957 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714751}
-
Joe DeBlasio authored
This CL updates the minimum length of a domain that is considered for an edit distance match. Edit distance is used in some cases to trigger a Safety Tip warning. Bug: 1023820 Change-Id: Ie4a18369874dbb947a5e1b41f2bf8b189b60403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913468 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#714750}
-
Patrick Monette authored
This avoids having tests defining their own delegate implementation when they need one. Bug: 1021600 Change-Id: I12d84c647e17c3c476ce2dc19f5298a524cf98dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900346 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714749}
-
Aga Wronska authored
ChildUserService is a new KeyedService that will be a central point for child user related functionality. Existing KeyedServices will become members of ChildUserService. AppTimeController coordinates per-app time limits for child users similarly to ScreenTimeController. This class was added together with ChildUserService to demonstrate how other child features will be migrated. Bug: 1022231, 1015658 Test: AppTimeControllerTest Change-Id: Ica55931876f172df60b9af8a7b2887fb794f5845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910764 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Lily Chen authored
SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure were added to the set of features enabled with --enable-experimental-web-platform-features in https://crrev.com/c/1691522. This CL removes those features from the experimental web platform features but retains test coverage for them. Bug: 953306, 954551, 961439 Change-Id: Ia13753f8f89ff5e93371c3ec9932c9d0499cd9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904870Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#714747}
-
Aaron Colwell authored
Cleanup change to make the method parameter names match the names in the caller. The intent here is to make the code easier to understand. Bug: 1015882 Change-Id: I6dfe0ccf790a78abb6467c8fdbf13460a5aa8fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904686 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714746}
-
Min Qin authored
BUG=971366 Change-Id: Ic4f8880eec0a793c2e8a8585f3bf4d3bfda907a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912631Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714745}
-
Giovanni Ortuño Urquidi authored
The Closure version used in Chromium now supports bounded generic types. Bug: 1015726 Change-Id: I14c080b6e3cd67cbdf564312fc1c1686f3adb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906691 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#714744}
-
Kyle Horimoto authored
This CL also removes maybelle@, who has left Chrome. Change-Id: I39c3c9fea40eb3608ac29b74bfd6599a71bfc355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913560 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Sarthak Shah authored
Currently, trying to start selection autoscroll results in a crash if layout object does not exist or is deleted. This CL fixes this issue by adding a null check before trying to start autoscroll for selection. Bug: 1023249 Change-Id: I0bb81e865372077e2d34b95df4172c1283679201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912682Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714742}
-
Tommy Li authored
Query Refinements got removed from Android's about:flags accidentally. This CL restores it. Bug: 963173 Change-Id: I3072bc34cc556156205d89295e3c8016a24f222f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912915Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#714741}
-
Nate Fischer authored
No change to production behavior. This adds a UI for toggling flags (similar to chrome://flags), although nothing actually happens yet when toggling the UI. This CL only builds the visual component of the UI, and adds a single flag to the list to demonstrate how the UI will look. In follow up work, we'll plumb this toggled list of flags to the WebViews embedded in other applications. Bug: 981143 Test: Manual - open the DevUI, observe the flags UI works as intended Change-Id: I00e8e3c5472e71af3cdb3b70e7992d25a38a16b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910811Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714740}
-
Adam Ettenberger authored
This works is a continuation of improvements that Jacques Newman had recently merged with this CL : https://crrev.com/c/1810244 The problem with Paragraph navigation was that both the methods |AtStartOfParagraph| and |AtEndOfParagraph| allowed an AXPosition anchored to an Ignored node to be the start or end of a paragraph. Adding a browsertest to exercise paragraph navigation when there are Ignored nodes interleaved in the document which fails without this patch. The changes to |Create{Next|Previous}LeafTreePosition| does not change behavior, there's no reason to copy |const base::RepeatingCallback| or its bound parameters in this case. Bug: 928948 Change-Id: I2cfee5481ffbea9a9a821cae6bcfc8e4652e847c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885021 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714739}
-
Bailey Berro authored
Previously, each element in the barLabels div was its own navigation stop. With this change, we read all of the barLabels div as one navigation stop for the entire bar itself. When navigated to via ChromeVox, it will now speak "Storage Usage Overview, In use X GBs Available Y GBs, Progress indicator" Bug: 1007602 Change-Id: Ia458e3c90470c707fcabb25e4750a2e77f00ac61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910720 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0802bf500144..37becd02a08f git log 0802bf500144..37becd02a08f --date=short --no-merges --format='%ad %ae %s' 2019-11-12 hablich@chromium.org [Docs] Add description about design review guidelines Created with: gclient setdep -r src/third_party/devtools-frontend/src@37becd02a08f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I3878b7049e1d54b016d95e6b497d052a4267bfe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913385Reviewed-by:
-
- 12 Nov, 2019 12 commits
-
-
Mitsuru Oshima authored
This reverts commit b6f30c85. Reason for revert: crbug.com/1022397 Original change's description: > Relax NV12 format rejection for exo > > # This is reland of crrev.com/c/1775190. > # It has to use floored value instead of rounding to match what kernel expects. > > Applies the same restriction in other scenarios (web page/apps). > > * Reject iff > - the buffer is cropped hirozontally, and > - the cropped bounds' horizontal coordinates (x and width) doesn't > fall into even pixel boundary > > Bug: 997821, b/141202973 > Test: manually tested with netflix web/arc apps on eve. GtsYouTubeTestCases:com.google.android.youtube.gts.DecodePerformanceTest passed on octopus > Change-Id: I7ce9e41b55a1f3c87e55ed680e17f9842388db51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847676 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704153} TBR=oshima@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997821, b/141202973 Change-Id: I89a185e535a1747d863271e2cff5ef73ebab2528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913470Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714736}
-
Wez authored
This was most recently reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1906545 due to failures on some ChromeOS platforms, which lack the necessary tables to allow stack-trace unwinding. Bug: 999737, 706728 Change-Id: I7889416cd2ae9b6a09caf9eebb68a5ccf8bf4ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911680 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#714735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/92ac890fc48d..6d06b6613559 git log 92ac890fc48d..6d06b6613559 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 lamontjones@chromium.org Revert "cbuildbot: run PaygenStage after ArchiveStage finishes." Created with: gclient setdep -r src/third_party/chromite@6d06b6613559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic9f4edd5d746f481d8378a8eb8688a530cb26805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913383Reviewed-by:
-
Jonathan Backer authored
GLES2DecoderImpl hooks into GLStateRestorer for virtual context switching. These hooks work even without enabling virtual contexts and are used in DirectContextProvider::SetGLRendererCopierRequiredState. GLES2DecoderPassthroughImpl does not have any state restoration hooks. This CL explicitly sets state used by GLRendererCopier, GLScaler, and GLI420Converter. Bug: 1016833 Change-Id: I7ebead5148411677765b3d4635871873b7af0018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912907Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714733}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9577daf6673d..0db01f0fabd1 git log 9577daf6673d..0db01f0fabd1 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 ehmaldonado@chromium.org git-cl: Make tests run on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@0db01f0fabd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002209 Change-Id: I5bcd9f0a5f50cc67d63325d68b55860b9b98f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913384Reviewed-by:
-
Daniel Murphy authored
R=enne@chromium.org Change-Id: I2b072c2a0aaaad11d04839a0efe3ba577f828040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912652Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#714731}
-
Clark DuVall authored
WebLayer had a lot of presubmit warnings related to javadocs, which I think was causing people to forget to run "git cl format". This fixes all warnings, so we should no longer ignore presubmit findings. Change-Id: I68baa6f22c38fe54d65a3affc65117dbfd5ec1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913203 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714730}
-
Regan Hsu authored
Currently, the thumbnail image for the current wallpaper is distorted if the wallpaper image is the user's file (not provided by Google). Instead of resizing the image to a distorted state for the current wallpaper thumbnail, this CL ensures that the thumbnail image is scaled properly and center cropped. Before screenshot-- https://screenshot.googleplex.com/mBZziQFOf3W After screenshot-- https://screenshot.googleplex.com/OjYfOhyfFSK Fixed: 985542 Change-Id: Idf698141a7ac6b38e797d9bd91d256ce5ea02db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911229 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714729}
-
Wez authored
This reverts commit 0319eb27. Reason for revert: Rationale for this change was incorrect; browser-side DiscardableSharedMemory objects _always_ have their handles closed. Original change's description: > [base] Don't try to decommit pages if they're about to be unmapped. > > DiscardableSharedMemory::Purge() attempts to proactively discard pages > to prevent slow-to-respond clients from keeping the pages live longer. > > If the instance is in-process then these kernel calls are unnecessary > since the memory is about to be unmapped anyway. > > Bug: 1023693 > Change-Id: I2bc19eb64f3fdc009c5bf8c4ed6369b2b5081045 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911487 > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714684} TBR=dcheng@chromium.org,wez@chromium.org Change-Id: I2b451e314a1ee73757cad5c492d6fd550eb83a09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913599Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714728}
-
Rachel Carpenter authored
This allows our client code (coming) to load in a sandboxed iframe. Bug: 1012578, b/144121590 Change-Id: I0e3a1442a9d2959652a36737b8b22abd4d633de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904552 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#714727}
-
Etienne Bergeron authored
This CL is removing the unused method: void Canvas::DrawFadedString(...); Change-Id: I77c279ab1de9cf587b840142563501cb870fff79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902477Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714726}
-
W. James MacLean authored
TBR=pkotwicz@chromium.org Bug: 1023437 Change-Id: I79f0974609260af143d1956ab4ecc0ba437807c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913464Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714725}
-
