GitLab

[sync] 	Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeManagerOserver interface

As of today, DataTypeManager sends out notifications for various
configure events via NotificationService notifications. This is bad,
because other services that depend on these events need to have
knowledge of DataTypeManager, which is internal to the sync
implementation.

This patch does the following:

1) Creates a new DatTypeManagerObserver interface through which
   observers are made aware of configure events.
2) Has ProfileSyncService implement the interface.
3) Gets rid of unnecessary sync configure * notification types.
4) Has PSS send out notifications for SYNC_CONFIGURE_START and
   SYNC_CONFIGURE_DONE.
5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE
   notifications from the PSS, instead of from all sources, while
   waiting to populate the "other devices" section of the NTP.
6) Updates various mock and test classes and fixes unit tests.

TBR=estade@chromium.org, thakis@chromium.org
BUG=142984,124717,111676,142550

Review URL: https://chromiumcodereview.appspot.com/10834351

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98

Revert 152162 - Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> instead of std::vector<unsigned char>

Bug=138553
Test=Compiles

R=michaelbai
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10831341

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139442
TEST=CQ

Review URL: https://chromiumcodereview.appspot.com/10829396

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137247,142402,141500,139683
TEST=about:gpu page
Review URL: https://chromiumcodereview.appspot.com/10832356

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152167 0039d316-1c4b-4281-b951-d872f2087c98

Failing on all platforms.

TBR=krenaud@google.com
BUG=143506

Review URL: https://chromiumcodereview.appspot.com/10860026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152166 0039d316-1c4b-4281-b951-d872f2087c98

Tulip was incorrectly marked flaky on all platforms
due to an issue where #define and TEST_P don't interact
well (see issue 143151).

Also cleans up the disabled Flac test to use proper
DISABLED_ syntax instead of being commented out.

BUG=141020, 142896
TEST=media_browsertests.

Review URL: https://chromiumcodereview.appspot.com/10827384

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141157
TEST=Build and boot on daisy.


Review URL: https://chromiumcodereview.appspot.com/10830348

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152164 0039d316-1c4b-4281-b951-d872f2087c98

These tests fail on Linux redux, that uses OpenSSL, due to
ec_private_key_openssl.cc which is not implemented yet.

They were already disabled on Android through an entry in
build/android/gtest_filter/net_unittests_disabled.

TEST=net_unittests
BUG=142833,140991

Review URL: https://chromiumcodereview.appspot.com/10830354

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152163 0039d316-1c4b-4281-b951-d872f2087c98

Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> instead of std::vector<unsigned char>

Bug=138553
Test=Compiles

R=michaelbai
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10831341

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152162 0039d316-1c4b-4281-b951-d872f2087c98

to tell when the windows platform is 64-bit.

PNaCl needs to use 64-bit nexes in that case, even if
chrome is 32-bit.

Retry of: http://codereview.chromium.org/10834348/
but this time with baseurl...

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365
TBR=cpu@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10831374

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152161 0039d316-1c4b-4281-b951-d872f2087c98

Previously "continue" statement left renderer_type undefined.

BUG= 140305
TEST= open chrome://memory page if NaCl extension is opened.

Review URL: https://chromiumcodereview.appspot.com/10836313

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152160 0039d316-1c4b-4281-b951-d872f2087c98

Since these classes are small, they can be all be moved in one cl without it becoming overly large.

This one moves:
- AppShortcutManager
- AutoUpdateInterceptor
- ConvertWebApp
- ExtensionActivityLog (now extensions::ActivityLog)

BUG=117261
TBR=jam@chromium.org, willchan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98

Also add test.

BUG=142925

Review URL: https://chromiumcodereview.appspot.com/10831347

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152158 0039d316-1c4b-4281-b951-d872f2087c98

CredentialCacheService listens for initial sync configuration during
sign in by directly observing sync preferences in the pref store. This
is not good because sync preferences are not always re-written
during sign in, and we cannot rely on NOTIFICATION_PREF_CHANGED.

In addition, if during startup, we find an older version of a credential
cache with some fields missing (like the last_updated_time), we could
run into bugs due to the missing fields.

This patch does the following:

1) Makes CredentialCacheService listen to the notification
   NOTIFICATION_SYNC_CONFIGURE_START for sign-in, restart and
   reconfigure scenarios.
2) No longer relies on NOTIFICATION_PREF_CHANGED for detecting
   changes to sync datatype preferences.
2) Freshly writes any missing sync credentials during startup to
   auto-heal the cache in case chrome crashed during a previous run,
   or if a signed-in user upgraded chrome from an older version that
   didn't support credential caching or was missing some newer fields.
3) Adds caching support for both sync encryption tokens:
   kSyncEncryptionBootstrapToken and kSyncKeystoreEncryptionBootstrapToken,
   and makes the required logic changes to sign in / reconfigure with
   one or the other.
4) Modifies PackAndUpdateStringPref and UpdateBooleanPref to only
   update the cache if the new value being written is different from the
   existing value.
5) Other misc. changes to support the design described above.

BUG=142550, 143214
TEST=Sign in to sync, sign out, exit chrome, delete the credential cache from the profile directory or merely delete some fields, and sign in again. All sync preferences must get written to the credential cache.

Review URL: https://chromiumcodereview.appspot.com/10829310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152157 0039d316-1c4b-4281-b951-d872f2087c98

Add a regression test to verify this.

BUG=142872
TEST=Ensure that bug 142872 is no longer reproducible.

Review URL: https://chromiumcodereview.appspot.com/10831338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152156 0039d316-1c4b-4281-b951-d872f2087c98

This does not match Safari 6, Spotlight, or Chrome omnibox behavior on other
platforms.

BUG=142887


Review URL: https://chromiumcodereview.appspot.com/10836270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152155 0039d316-1c4b-4281-b951-d872f2087c98

The number of callers of FindEntryByPathAndRunSync() in GDataFileSystem
is reduced from 2 to 0, hence the function is finally removed from
GDataDirectoryService.

Along the way, GDataFileSystem::FindEntryByPathAsyncOnUIThread() is
simplified and renamed to LoadIfNeeded().

Remove GDataFileSystem::FindEntryByPathSyncOnUIThread() as well.

BUG=141196, 142420
TEST=file manager works as before

Review URL: https://chromiumcodereview.appspot.com/10831375

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152154 0039d316-1c4b-4281-b951-d872f2087c98

- Removed unnecessary List.redraw calls from
      -- network_list.js
      -- autofill_edit_address_overlay.js
      -- content_settings_exceptions_area.js
- Added an early return to List.redraw() for the case clientHeight == 0 (eg. if the list is not visible).
- Some small cleanup.

Overall there were about 68 expensive (ie. no early return) calls to redraw() which I could reduce to 26. The speedup is about 7% / 28ms for the "onload" event on my desktop machine.

BUG=chrome:143116


Review URL: https://chromiumcodereview.appspot.com/10824328

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141826
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10854160

TBR=serya@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152152 0039d316-1c4b-4281-b951-d872f2087c98

* GDataEntry must always be constructed with a valid directory_service ptr. Add a DCHECK for this, and remove runtime tests for null directory_service_ ptr in all methods.
* RemoveEntryFromResourceMap takes resource_id instead of GDataEntry*.
* RemoveEntryFromResourceMap ensures resource_id is non-empty and that an actual deletion occurs every time.
* AddEntryToResourceMap has a DCHECK to guard against multiple additions, or addition of empty resource_id.
* Remove accessors child_files() and child_directories() and make typedefs for GDataFileCollection and GDataDirectoryCollection private.
* Move GetChildDirectoryPaths from gdata_wapi_feed_processor.cc anon namespace to GDataDirectory.
* Fixes for unit tests that added entries with null resource ids, and duplicate resource ids.

BUG=137725
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10854199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152151 0039d316-1c4b-4281-b951-d872f2087c98

This script automates Chrome Endure setup process and
starts a local Http server to serve the results.

BUG=None
TEST=Ran the script on two Linux_x64 machines.
NOTRY=TRUE


Review URL: https://chromiumcodereview.appspot.com/10837114

TBR=fdeng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10860020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152150 0039d316-1c4b-4281-b951-d872f2087c98

Also updated me2me_virtual_host.py to use that signal to reload config (instead of restarting the host), and when requesting the currently running instance of the script to reload the config (instead of SIGUSR1).

BUG=120950

Review URL: https://chromiumcodereview.appspot.com/10825410

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142993


Review URL: https://chromiumcodereview.appspot.com/10836277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141779


Review URL: https://chromiumcodereview.appspot.com/10827386

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122753

Review URL: https://chromiumcodereview.appspot.com/10832358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152145 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
R=maruel@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10857004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152144 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129471


Review URL: https://chromiumcodereview.appspot.com/10829339

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825419

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152142 0039d316-1c4b-4281-b951-d872f2087c98

This should get rid of the spurious ERROR messages when closing tabs, and log backtraces when we need them.

BUG=141055


Review URL: https://chromiumcodereview.appspot.com/10834355

TBR=bauerb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152141 0039d316-1c4b-4281-b951-d872f2087c98

I'm hoping this will reduce CL review spam for me.

R=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828349

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=compiles on linux heap checker bots
Review URL: https://chromiumcodereview.appspot.com/10824356

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152137 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes UserManager::Get()(for ephemeral user check) out from
WallpaperManager::SaveUserWallpaperProperties(called when initializing UserManager).
It was creating a deadlock and make chrome hang on startup screen.

The ephemeral user check in SaveUserWallpaperProperties is not correct either.
We should not check if current logged in user is ephemeral user while we try
to save wallpaper properties for some other user specified by email.

BUG=142440

Review URL: https://chromiumcodereview.appspot.com/10829381

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152136 0039d316-1c4b-4281-b951-d872f2087c98

This makes the system tray the first child so that it is the first tray focused when the status area widget is selected via accessibility.

This depends on http://codereview.chromium.org/10823350/

BUG=142506
For ash/ash_strings.grd:
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825389

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152135 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bauerb@chromium.org
BUG=143431
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10825423

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152134 0039d316-1c4b-4281-b951-d872f2087c98

This script automates Chrome Endure setup process and
starts a local Http server to serve the results.

BUG=None
TEST=Ran the script on two Linux_x64 machines.
NOTRY=TRUE


Review URL: https://chromiumcodereview.appspot.com/10837114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152132 0039d316-1c4b-4281-b951-d872f2087c98

- My earlier CL
  https://chromiumcodereview.appspot.com/10823382
  is problematic.  This mostly reverts it and fixes the
  issue in a better way.

Review URL: https://chromiumcodereview.appspot.com/10827403

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152130 0039d316-1c4b-4281-b951-d872f2087c98

This is the cocoa version of the media galleries permission dialog. The dialog is implemented as an NSAlert displayed as a constrained window. The gallery checkboxes are added inside a accessory view.

The views and GTK versions are here:
http://codereview.chromium.org/10828166/
https://chromiumcodereview.appspot.com/10826129

Screenshots: http://i.imgur.com/fedm0.png

BUG=134929
TBR=mihaip@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10834242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152128 0039d316-1c4b-4281-b951-d872f2087c98

I reused LazyBackgroundTaskQueue so that this works for regular background
pages, which may not be fully loaded by the time this event is dispatched.

BUG=132328

Review URL: https://chromiumcodereview.appspot.com/10828218


Reason for revert: introduced a frequent crash

TBR=mpcomplete@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836317

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143255


Review URL: https://chromiumcodereview.appspot.com/10825402

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152126 0039d316-1c4b-4281-b951-d872f2087c98

This prevents Gyp from performing unnecessary build actions due to Ant
not updating the modification time of the output when Gyp believes the
output is stale.

BUG=143229


Review URL: https://chromiumcodereview.appspot.com/10825403

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152125 0039d316-1c4b-4281-b951-d872f2087c98