- 08 Aug, 2018 40 commits
-
-
Yoichi Osato authored
Bug: 789870 Change-Id: I9f76d046c393645e148151660cab1f6510a874f0 Reviewed-on: https://chromium-review.googlesource.com/1166563Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581582}
-
Simon Zünd authored
The CL https://crrev.com/c/1151199 will break this layout test. In preparation for landing the CL we mark it as Failure/Pass and rebaseline after the roll. Bug: chromium:855582 Change-Id: I57ce0dbdccf403a14a0d6021cdac9111a8a60ae6 Reviewed-on: https://chromium-review.googlesource.com/1166913Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#581581}
-
Rune Lillesveen authored
TBR=sahel@chromium.org Bug: 872242 Change-Id: If851174fe5e066d63ed3aa38f5a9bd4e414f177f Reviewed-on: https://chromium-review.googlesource.com/1167288Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581580}
-
gogerald authored
Bug: 806868 Change-Id: I1fe95fa3e310320fbb5c903c0ebe3cb2b7f0fb47 Reviewed-on: https://chromium-review.googlesource.com/1163922 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581579}
-
Bo Liu authored
Current behavior is to push browser's scroll state down to the new renderer and a renderer swap, but only under some sequence of events. Pushing from browser to renderer is probably wrong; navigating to a new page generally resets scroll back to top of the page. This CL changes the code to sync renderer scroll state to browser on renderer swap, and does this in all cases. Bug: 871538 Change-Id: Ia887695760b1cce4e3f75cb1ef7091a601e4a556 Reviewed-on: https://chromium-review.googlesource.com/1166150Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581578}
-
John Abd-El-Malek authored
Bug: 769401,865350,844915,773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie7c87877597686927a401b64120c444c79a8912c Reviewed-on: https://chromium-review.googlesource.com/1166593 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581577}
-
Tibor Goldschwendt authored
This CL does two things: - In order to move VR Java code into its own module move the code into a separate android_library target. - As a result of the separate library target we may miss making the VR JNI registrations (in case VR moves out of chrome_public_apk). Thus, separate the JNI registration generation for VR and register VR JNI calls in VR code. Bug: 862694 Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 Reviewed-on: https://chromium-review.googlesource.com/1158715 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#581576}
-
Xiaohui Chen authored
Bug: b:112279985 Test: locally build and run, settings disable/enable, hotword Test: notification Change-Id: I9d3ec86cf7186f77867386f7cbfeb4efd5a45e15 Reviewed-on: https://chromium-review.googlesource.com/1165798Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581575}
-
Charlene Yan authored
Simplifying the button padding calculation for the bookmark bar. Checks that it is appropriately centered in attached and detached state as well as with and without an info bar and tab switching. Bug: 865555, 864595, 863697 Change-Id: I4550c65af596d51ca41b7ac3be2c8f14825e304f Reviewed-on: https://chromium-review.googlesource.com/1155369Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581574}
-
Miguel Casas authored
This CL removes a superfluous DLOG, which is also not a WARNING, because it floods the pixel_tests (among others, probably). TBR=maxmorin@chromium.org Change-Id: Ib4f6803deae12b1ebe4624b596712b9f62c0edb3 Reviewed-on: https://chromium-review.googlesource.com/1167363 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#581573}
-
Camillo Bruni authored
Use IIFEs to limit potential leaks via the stack frame to trigger the gc callbacks. Bug: chromium:595672 Change-Id: I2565d5f7a46faf2e27618bc5b94c96365fd47584 Reviewed-on: https://chromium-review.googlesource.com/1167188Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#581572}
-
Bence Béky authored
Change-Id: I94ad245cfc42a4acebfc0f83a3ec9c30e75241dc Reviewed-on: https://chromium-review.googlesource.com/1167206Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581571}
-
Hugo Holgersson authored
This introduces assertFocusMoves() that helps us to write testharness.js-tests with the compact and declarative "step focus and check result"-syntax of the older snav*-tests. I've converted snav-div-scrollable-but-without-focusable-content.html and snav-radio.html so these do no longer need -expected.txt-files, asserts are now made through testharness.js instead. Other snav*-tests could be converted by following their example. Bug: 803086 Change-Id: I5310f16492b233f894eda7e3e6b9691926670b06 Reviewed-on: https://chromium-review.googlesource.com/998193Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#581570}
-
Tessa Nijssen authored
TextSuggestionsTouchBarController's browser tests were failing because WebContents::IsFocusedElementEditable() returned false even after a web page was loaded with an autofocused textfield. A WindowedNotificationObserver was added to observe a change in focus in a page. When the textfield is autofocused, this observer is notified. By waiting on this observer, the tests can guarantee that WebContents::IsFocusedElementEditable() is true and that the tests that rely on that condition will pass. Disabled tests were undisabled. Bug: 871740 Change-Id: I86ed07d8738fdc46f68e72b8c8ba8e9dc3f1d984 Reviewed-on: https://chromium-review.googlesource.com/1165782Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581569}
-
Scott Violet authored
This is to avoid using Env::GetInstance(), so that there can be multiple Envs created at once. BUG=847992 TEST=covered by tests Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840 Reviewed-on: https://chromium-review.googlesource.com/1165861 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#581568}
-
Ramin Halavati authored
Preferences related to ChromeOS Power are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I0b3bf1fb7d4863349a4a3e932965845f9aaf232a Reviewed-on: https://chromium-review.googlesource.com/1158066Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581567}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b4b8aa6ebe72..f8335664915c git log b4b8aa6ebe72..f8335664915c --date=short --no-merges --format='%ad %ae %s' 2018-08-08 fmayer@google.com libunwindstack: Address comments from aosp/727270 Created with: gclient setdep -r src/third_party/perfetto@f8335664915c The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1d649d9dee6a09d4c6317ec797f86e9ea0ba70e0 Reviewed-on: https://chromium-review.googlesource.com/1167242Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581566}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36315c26..0c298bd8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I758d14000cfb31292f97e32f485755a86a81df3d Reviewed-on: https://chromium-review.googlesource.com/1167104Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581565}
-
Avi Drissman authored
This reverts commit 725ceeda. Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg chromevox test: BackgroundTest.NavigationEscapesEdit interactive_ui_tests TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 LoggedInSpokenFeedbackTest.KeyboardShortcutViewer TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 GuestSpokenFeedbackTest.FocusToolbar Original change's description: > Always build ChromeVox as compressed js > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > Bug: 868579 > Test: clean build for > 1. prior to this patch > 2. after this patch > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > Reviewed-on: https://chromium-review.googlesource.com/1165787 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581325} TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1167442Reviewed-by:
-
Friedrich Horschig authored
With this CL, the accessory will be resized according to the last known height of the keyboard. This CL should (hopefully) not have any effect on how UiUtils work around the keyboard. It will publicize the approximation it uses to determine the keyboard height which I then use to resize the keyboard accessory. Bug: 856180 Change-Id: I0726ace04db8d4d095b899aab9354bae307215e7 Reviewed-on: https://chromium-review.googlesource.com/1158573 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581563}
-
Sky Malice authored
Specifics: +584,591 bytes normalized apk size +3 zip entries file count +29,136 bytes main lib size +374,964 bytes main dex size InstallSize: +209,627 bytes APK size +1,724,481.56 bytes Estimated installed size InstallBreakdown (+1,720,844.56 bytes): +1,531 bytes Non-compiled Android resources size +29,136 bytes Native code size +199 bytes Package metadata size +1,675,454.56 bytes Java code size +14,524 bytes Compiled Android resources size Dex: +1,869 entries fields +2,563 entries methods +603 entries types +1,260 entries strings Change-Id: I33e5d76f7386bd2d71f120020b57c4f4a2120c0d Reviewed-on: https://chromium-review.googlesource.com/1165801Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#581562}
-
Justin DeWitt authored
Change-Id: If4f63ff224765c2d2ce14938605216093fd8a6a0 Reviewed-on: https://chromium-review.googlesource.com/1166292 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#581561}
-
Sadrul Habib Chowdhury authored
The 'viz' category trace-events are not collected by default in telemetry tests. So add the 'benchmark' category so that these pipeline-events are visible in telemetry tests. BUG=855328 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I94a1d4a1046c0d89d2a25e1c5bfe6e01650fc212 Reviewed-on: https://chromium-review.googlesource.com/1165942Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#581560}
-
Rune Lillesveen authored
TBR=jamescook@chromium.org Bug: 872267 Change-Id: I8ff0cf1d3615bb73c04b5342a96c24f0c914fe75 Reviewed-on: https://chromium-review.googlesource.com/1167294Reviewed-by:
-
Rouslan Solomakhin authored
Roll libaddressinput dep from: d955c63ec7048d59dffd20af25eeec23da878d27 To: d7ed8e2f3f35ce9a3aafdfdc48745ceab66e7229 The new version of libaddressinput does not have the locality (e.g., city) field for JP, so the existing autofill profiles are being migrated to merge the existing locality field into the street address line. TBR=vitaliii Bug: 869942 Change-Id: I1e5859c49408490c9816840917c4b648b664a975 Reviewed-on: https://chromium-review.googlesource.com/1152068Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581558}
-
Takuto Ikuta authored
Directory dependency to pyproto/google seems not necessary for unit_tests and interactive_ui_tests Bug: 869348 Change-Id: I6380754639a8e4713bf8a380f2050a0422987dd4 Reviewed-on: https://chromium-review.googlesource.com/1167146Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581557}
-
Maks Orlovich authored
URLFetcher will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 865015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I248ff39534aeab11be4a60826edf7e89256ad2dc Reviewed-on: https://chromium-review.googlesource.com/1138795Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581556}
-
Joe Mason authored
Also add missing functions to chrome_cleaner/os needed by IPC unit tests. R=proberge Bug: 830892 Change-Id: Ibc9f4e919264d2e54cbc9808574639abb879b63e Reviewed-on: https://chromium-review.googlesource.com/1161283 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
-
Peter Wen authored
Removing gsennton@ as OWNERS since he's moved on to a new team. This makes it clear that some of these directories need more OWNERS. Bug: None Change-Id: I02f083aa9bb5597a65c8414d9d63150be77aeca8 Reviewed-on: https://chromium-review.googlesource.com/1160862Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581554}
-
Allen Bauer authored
TBR=estade@chromium.org Bug: 838152 Bug: 856492 Change-Id: Ie16b4fd47d3e0f614a0f793300539729c905e5a0 Reviewed-on: https://chromium-review.googlesource.com/1162664 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581553}
-
Majid Valipour authored
Remove "animation-worklet-' prefix from layout tests. The tests are inside AW directory so the prefix is just visual clutter. I kept it for tests that check something about the worklet itself. Note: There was a legacy unused animationworklet/visual-update-expected.html file that this patch replaces now. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad Reviewed-on: https://chromium-review.googlesource.com/1165271Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#581552}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c8b8e83632..c2342031f4d9 git log c1c8b8e83632..c2342031f4d9 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 kwiberg@webrtc.org Remove rtc::{Make,Wrap}Unique and their header file + unit tests 2018-08-08 nisse@webrtc.org Tolerate out of order samples to SendProcessingUsage2::FrameSent. 2018-08-08 sakal@webrtc.org Add unit tests for hardware video codecs. 2018-08-08 crodbro@webrtc.org In video_quality_test, maintain capturer startup within CPU timing interval. 2018-08-08 srte@webrtc.org Move SimulatedNetwork class to separate file. 2018-08-08 magjed@webrtc.org Make internal video decoder factory more resilient to incorrect usage 2018-08-08 nisse@webrtc.org Delete RTPReceiverStrategy::OnNewPayloadTypeCreated and related code. Created with: gclient setdep -r src/third_party/webrtc@c2342031f4d9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:842613,chromium:b/112299470 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I28e1ed26bb573b94df5a3643b6a095fdb2bffdb5 Reviewed-on: https://chromium-review.googlesource.com/1167124Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581551}
-
Ramin Halavati authored
Preferences related to Certificate Transparency are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I5971f1aa34f0a6f3b47f2a8ba0234e7d00d31738 Reviewed-on: https://chromium-review.googlesource.com/1166832Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581550}
-
Calder Kitagawa authored
pkotwicz@ pointed out that res/mipmap is actually an alias for res/mipmap-mdpi. This resulted in all icons being way too large and appear with some fidelity issues. In testing I believed these larger icons to be correct but in reality they should have been smaller. To fix this we could move the icons into the mipmap-nodpi folder. However, this prevents them from scaling even when aliased. i.e. if on an xxhdpi device all we have is an mdpi icon the following scenario occurs; drawable-*dpi/ has no valid splash_icon.xml so we fall back to the mipmap-*dpi/app_icon.xml here we find that only the mdpi icon is available. One would think this then scales up to an appropriate size on drawable-xxhdpi but instead Android refuses to scale it as it is in the mipmap-nodpi as the double lookup does not change the fact it is nodpi. pkotwicz@ then suggested we use Scale XML resources, these solve the problem but require the minting server to manually compute the scaling at mint time. Instead I propose the following solution: - Restore the state for app_icon.png files prior to CL https://chromium-review.googlesource.com/1128256 - Introduce a single splash_icon.xml in drawable-xxxhpdi. This will reference mipmap/app_icon and essentially be identical to the current behavior of just using the app_icon (this is just a placeholder). - Add a boolean to the metadata of the AndroidManifest.xml indicating whether we were able to package larger images on the server. (This is so xxhpdi can use these images rather than only using the slightly larger xxxhdpi icon). - Use ApiCompatibilityUtils#getDrawableForDensity(). This gives us the image for a specific density or scales the nearest available one if there isn't one available. This allows us to control which size of image we show. We can then impose the following lookup scheme based on the current device density. Tested on xhdpi, hdpi and xxhdpi running N, O, P | Current Density | App Icon Density for Splash Icon | | mdpi | xhdpi | | hdpi | xxhdpi | | xhdpi | xxxhdpi | | xxhdpi | xxxhdpi or larger if provided | | xxxhdpi | xxxhdpi or larger if provided | Bug: 819755 Change-Id: I40fe68375782b29d082193aae0ab1c1af0ae49f2 Reviewed-on: https://chromium-review.googlesource.com/1150297 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581549}
-
Boris Sazonov authored
This CL disables flaky testToolbarSwipeNextTabNone from org.chromium.chrome.browser.TabsTest on Android M arm64-v8a devices. The patch was created by donnd@ in https://crrev.com/c/1166300. TBR=yusufo@chromium.org Bug: 871554 Change-Id: I9d2844de9ce688013cbd985a060b5ef098cc0cff Reviewed-on: https://chromium-review.googlesource.com/1167189Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581548}
-
Owen Min authored
MachineLevelUserCloudPolicy enrollment is setup by platform policy. It's not trivial on Mac as it requires additional software. Add a secondary simple token setup way. When the MachineLevelUserCloudPolicyToken policy is not setup. Read the enrollment token from file. /Library/Google/Chrome/MachineLevelUserCloudPolicyToken on Chrome. /Library/Application Support/Chromium/MachineLevelUserCloudPolicyEnrollmentToken on Chromium TEST: 1) Open Chrome, make sure MachineLevelUserCloudPolicyToken is not set via via chrome://policy. Close Chrome. 2) Edit /Library/Google/Chrome/MachineLevelUserCloudPolicyEnrollmentToken to fill a random string. (For Chromium it's /Library/Application Support/Chromium/MachineLevelUserCloudPolicyEnrollmentToken) 3) Open Chrome, verify the error dialog displayed. 4) Replace the string in 2) with a valid enrollment token. 5) Click "Relaunch Chrome". Chrome is closed and opened with browser window. Bug: 871523 Change-Id: I51e111b1f40be2677b7820f0352d4be48c192c32 Reviewed-on: https://chromium-review.googlesource.com/1164387Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581547}
-
Gauthier Ambard authored
This CL updates the buttons used by the ConsentBump to have the same buttons as the other screens, taking example on the Infobars. It is also using two buttons for the secondary view as using one button create a visible flash. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5b17e3891c91399ec18da6054ce1951b4c2f13e9 Reviewed-on: https://chromium-review.googlesource.com/1165358 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581546}
-
Marc Treib authored
After sign-out, it's not meaningful to keep the last auth error or any access token (or requests for one) around. This was causing a UI glitch, where after signing out and signing in to a different account, we'd temporarily show an auth error the belonged to the previous account. Bug: 839834, 854579 Change-Id: I1dac8d5cef020555119e49dbfdf46fc26e5a8c85 Reviewed-on: https://chromium-review.googlesource.com/1164953 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581545}
-
Robert Ma authored
This CL skips all the testharness tests with the extra property "jsshell" set to true when parsing the WPT manifest. These tests are generated from .any.js files with the optional "jsshell" global scope. They are intended to run in a JavaScript shell; when running in a browser, they behave the same as the default variant (i.e. the window scope, .any.html). Besides, the generated test names for the jsshell variant have the same basenames as the default varaint (*.any.js and *.any.html respectively), which breaks our infra. Bug: 871950 Change-Id: I9f8e81251550399a5d6566b49998aa79209dcf34 Reviewed-on: https://chromium-review.googlesource.com/1166332 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
BackgroundTest.NavigationEscapesEdit fails on linux-chromeos-dbg. TBR=dtseng@chromium.org Bug: 872258 Change-Id: I4dc957a290bebb4cfa9d60c0a5240100de111240 Reviewed-on: https://chromium-review.googlesource.com/1167057Reviewed-by:
-
