GitLab

Skia's NullGL interface is deprecated, and this is the last piece of
code to use it. The Mock context is actually maintained (and simpler),
but is functionally a different backend.

With https://skia-review.googlesource.com/c/skia/+/204221, it supports
exporting textures as "GL", enough to allow CanvasResourceProvider to
work properly in tests. That, plus adding BGRA support (done here) gets
everything passing.

Change-Id: Id39101ed45f72e2294af9093e4610699936528ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542239Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646299}

Adding 'show_attribution' field to details proto and use it to control
if the modal dialog will show when user clicking on the image in
autobot details sections.

Change-Id: I8b5e05a124b88b85aba8579d079d6ef54e0bf9de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547197Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646298}

The base::Feature is not removed because it is used by tests due to
this bug: https://crbug.com/868082.

Bug: 947516
Change-Id: I234e6da2b089de0726a589c748948959b2fdec37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545400Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646297}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7a643808..6859f97f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I29708f6b612bb83b7fa3cec9bf9d645ce048ad56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547337Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646296}

As found in //base/android/jni_generator/README.md, the convention
of marking method with "native" is deprecated and instead the new
convention is to mark an interface with @NativeMethods. Convert
SigninManager.java to the new JNI invocation convention.

Also, use the opportunity to:
1. remove one JNI invocation in IsUserManaged() by moving the call
   to ShouldLoadPolicyForUser to C++
2. fix a possible use of uninitialized memory in IsUserManaged()
   implementation (base::Value::value should not be called if the
   base::Value has been initialized to base::nullopt).

Bug: none
Change-Id: I090a62935e5050e2475978c588e1e975c7a0e861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543775
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646295}

Removes CoreText-based AAT support. HarfBuzz starts using C++ 11.

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/ec2a5dc859b0..f3aca6aa267f

$ git log ec2a5dc85..f3aca6aa2 --date=short --no-merges --format='%ad %ae %s'
2019-03-31 behdad [serialize] Implement linking
2019-03-31 behdad Move BEInt to hb.hh
2019-03-31 behdad [iter] Fix up build, ouch
2019-03-31 jfkthame Don't skip setting the .end field of the first range
2019-03-31 behdad [iter] Adjust hb_copy() and use it
2019-03-31 ebrahim Remove coretext_aat shaper (#1581)
2019-03-30 behdad [serialize] Start implementing linking
2019-03-30 behdad [serializer] Implement dedup!
2019-03-30 behdad Implement hashing of objects
2019-03-30 behdad Fix hb_hash(pointer)
2019-03-30 behdad [serialize] Don't insert empty object into tree
2019-03-30 behdad [serialize] Towards maintaining hashmap
2019-03-30 behdad [serialize] Only pack main object if there are other objects
2019-03-30 behdad [serialize] Copy both sides of the buffer
2019-03-30 behdad [serialize] Simplify copy
2019-03-30 behdad [serializer] Unbreak for now
2019-03-30 behdad [map] Shuffle fini code
2019-03-30 behdad [vector] Add move semantics
2019-03-30 behdad [vector] Add some move and forwarding
2019-03-30 behdad [meta] Add hb_move and hb_forward ala std::
2019-03-30 behdad [serialize] Flesh out packing
2019-03-30 behdad [vector] Add copy constructor and assignment operator
2019-03-30 behdad [serialize] Minor
2019-03-30 behdad [serialize] Add packed_map
2019-03-30 behdad [serialize] Start fleshing out object stack
2019-03-30 behdad [serialize] Simplify propagate_error()
2019-03-30 behdad [serialize] Add object_t, link_t, and snapshot_t
2019-03-30 behdad [map] Add another TODO item
2019-03-30 behdad [map] Add TODO
2019-03-30 behdad [serialize] Add unused 'tail'
2019-03-30 behdad [serialize] Add ran_out_of_room
2019-03-30 behdad Split sanitize and dispatch into their own files
2019-03-30 behdad Move serializer to hb-serialize.hh
2019-03-30 behdad Whitespace
2019-03-30 behdad [map] Deref pointers before equality check
2019-03-30 behdad [map] Templatize hb_map_t
2019-03-30 behdad Add hb_deref_pointer()
2019-03-29 behdad [iter] Fix bug in hb_any() and hb_none()
2019-03-29 behdad [iter] Port remaining "for (auto" instances to daggers
2019-03-29 behdad [iter] One more dagger
2019-03-29 behdad [iter] Remove more wrong &&'s
2019-03-29 behdad [iter] More daggers
2019-03-29 behdad [iter] More daggers
2019-03-29 behdad [iter] One more dagger
2019-03-29 behdad Remove HB_DEBUG_WOULD_APPLY
2019-03-29 behdad [iter] Port more to daggers
2019-03-29 behdad Whitespace
2019-03-29 behdad Simplify code
2019-03-29 behdad [iter] Port one more function to dagger
2019-03-29 behdad [iter] Port more code to daggers
(...)
2018-12-30 behdad [meta] Move code around
2018-12-30 behdad [iter] WHitespace
2018-12-30 behdad [iter] Port Coverage::serialize to hb_is_iterator
2018-12-30 behdad [iter/meta] Match hb_is_iterator<> using SFINAE
2018-12-30 behdad Minor
2018-12-30 behdad Use C++11 when available
2018-12-30 behdad [ci] Remove unused config for gcc 4.2
2018-12-30 behdad [ci] Disable other gcc 4.2 bot
2018-12-30 behdad [iter] Add back operator +
2018-12-30 behdad [iter] Disable operator +
2018-12-28 behdad [iter] Revert back uses of C++11 auto type deduction
2018-12-28 behdad [iter] Rename
2018-12-28 behdad [iter] Remove friend operator +, hoping to fix some bots
2018-12-28 behdad Use Null() instead of declval(), hoping to fix some bots
2018-12-28 behdad [meta] Don't use template default arguments for functions
2018-12-28 behdad [meta] Fix unused-function-template warning
2018-12-28 behdad [iter/meta] Implement is_iterator
2018-12-28 behdad [meta] Minor
2018-12-28 behdad [meta] Move more code here
2018-12-28 behdad [iter/meta] Add hb_is_iterable
2018-12-27 behdad Don't use delegating constructors
2018-12-27 behdad [meta] Add enable_if
2018-12-27 behdad Add hb-meta.hh for meta-programming
2018-12-27 behdad [iter] Clarify readonly vs lvalue iterators
2018-12-27 behdad [iter] Test OT::Coverage iter
2018-12-27 behdad [iter] Streamline vector iterators
2018-12-27 behdad [iter] Make hb_sorted_array_t work as iter
2018-12-27 behdad Change hb_void_t implementation
2018-12-27 behdad [iter] Mark Coverage iterator sorted
2018-12-26 behdad [subset] Take iterator in ArrayOf serialize
2018-12-26 behdad [iter] Port Coverage iterator to hb_iter_t
2018-12-26 behdad Add hb_pair_t<> and hb_pair()
2018-12-26 behdad [Coverage] Ensure increasing coverage in iteration
2018-12-26 behdad [Coverage] Mark iterator methods const
2018-12-26 behdad [iter] Use operator bool in a few places
2018-12-26 behdad [iter] Remove redundant methods
2018-12-26 behdad [iter] Test default-constructability
2018-12-26 behdad [iter] Implement friend opeator + (int, iter)
2018-12-26 behdad [iter] Remove const_iter
2018-12-26 behdad [ci] Disable macos-llvm-gcc-4.2 again
2018-12-26 behdad [iter] Remove hack for older compilers
2018-12-26 behdad [iter] Minor
2018-12-26 behdad [iter] Rename random_access() to constexpr is_random_access()
2018-12-26 behdad [iter] Add operator ->
2018-12-26 behdad [iter] Make them work, mostly
2018-12-26 behdad [vector] Add iterator
2019-01-20 behdad Remove wrongly added files
2019-01-20 behdad Use enum for class constant
2019-01-20 behdad [CFF] Use enum for tableTag
2019-01-20 behdad Use static constexpr for large class constants

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Change-Id: I6bce8584621ec5e6e1de4a770d72e72819e76daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546103
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646294}

This test has been flaky. The additional assert may shed some light onto
what's going on.

TBR: yfriedman@chromium.org
Bug: 930174
Change-Id: Ifdc99b3c49f7d827818ca7ff8dbea12b856d2101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546107Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646293}

Bug: None
Change-Id: Ie15fc1320fcece87443d8606a03b8dfd3572fb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546290Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646292}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfe4cdc105a9..7ecd04321b1b


Created with:
  gclient setdep -r src-internal@7ecd04321b1b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org

Change-Id: I06f920056b0899e4cf696a6bf77d32ac835d9aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546937Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646291}

This reverts commit 142a9f63.

Reason for revert:
Speculative revert due to compile error that closed the tree, where this CL touches related files:
https://ci.chromium.org/p/chromium/builders/ci/linux-rel/22414?blamelist=1#blamelist-tab

The failure is:
In file included from ../../third_party/blink/renderer/platform/loader/fetch/raw_resource.cc:35:
../../third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h:36:10: fatal error: 'third_party/blink/public/mojom/service_worker/service_worker_object.mojom-blink.h' file not found
#include "third_party/blink/public/mojom/service_worker/service_worker_object.mojom-blink.h"

There could be something wrong with the build dependencies so that if you're unlucky the header has not been compiled yet, but maybe most of the time it has already been generated? I could compile locally, so revert is speculative.

Original change's description:
> [blink] Use body loader task runner in ScriptResource
> 
> The ResourceBodyLoader uses a per-request task runner (as of
> https://crrev.com/c/1539219). The manual datapipe reads in ScriptResource
> should therefore also use the same task runner.
> 
> Bug: 943059
> Change-Id: Ia99bd9403ac45cd4f71adb15ddf41c6e8752f892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545308
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646286}

TBR=yhirano@chromium.org,leszeks@chromium.org

Change-Id: I5ca51241c39b24503930aea5b410c5268030a3b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 943059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547693Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646290}

These tools are intended to be zero cost, hence the use of the
#if DCHECK_IS_ON() build flag.

The functionality is turned on via SequenceManager::Settings and it
covers logging for running and posting tasks, randomizing task
selection (within the current priority), and adding configurable delay
to same and cross thread PostTasks.

These options are useful for diagnosing bad assumptions on task ordering
and for flushing out scheduler policy induced races.

Bug: 863341
Change-Id: Ifc8015d3f97fdd5732662a068dd14f8257252a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541190
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646289}

Using wpt-import in Chromium be4f5920.
With Chromium commits locally applied on WPT:
0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2"
6f2e9bd4 "webrtc wpt: add test for ice disconnection"
be4bce5d "[WPT] Merge subresource scripts into common/security-features"
d1ac10ff "Revert "webrtc wpt: add test for ice disconnection""
e46d3296 "Revise tests for datachannel ID handling"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I16fdaa51afb3964ad98ca21156a9d186c0b3086d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547335Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646288}

Add portrait mode capture controller and new naming logic of saved file.
Also rewrite preview constrait-candidate finding and retry logic.

TEST=Toggle portrait mode programmically, see if photo capturing and
mode switching function normally on portrait mode enabled device.

Change-Id: Ifcc824a52b5f853aaa999d4e4cccb9671d8c24b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540836Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646287}

The ResourceBodyLoader uses a per-request task runner (as of
https://crrev.com/c/1539219). The manual datapipe reads in ScriptResource
should therefore also use the same task runner.

Bug: 943059
Change-Id: Ia99bd9403ac45cd4f71adb15ddf41c6e8752f892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545308Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646286}

Adding AdvancedSigninSettingsCoordinator with its view controller.
The goal is to present the sync settings to the user right after signing
in and before to start the sync.
This dialog is presented when the user taps on the setting link in the
sign-in consent.

Screenshots:
https://drive.google.com/open?id=1LA9A2iQR4n0QFhJO5EhBCf8BiAu4qk-5
https://drive.google.com/open?id=1rCawEHHLuzmNRU1EEm5IPBsDPqlv7pLV

Bug: 883075
Change-Id: I0ae187b65b032ff65e569b3568c043c3e7c164bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539036
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646285}

This patch verifies that incoming navigation requests from renderer processes
can only have `ui::PageTransition` values that meet the requirements of
`PageTransitionIsWebTriggerable()`. The process will be terminated if that
invariant is violated.

Bug: 946976
Change-Id: Ia1446964020455a05e824fbfb2456ea2d36cea6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543255Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646284}

BrowserUIThreadScheduler must be destroyed on the UI thread which in
these tests runs on a dedicated thread.

Bug: 863341
Change-Id: I130f2fcdac7c6ba8a4654c1813ade962af6fef02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543395
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646283}

70% improvement on contain-content-style-change:
https://pinpoint-dot-chromeperf.appspot.com/job/14e8b9b80c0000

Bug: 667370

Change-Id: I68327a741939632fa5d3508a03bceff7e6353611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546144Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646282}

NULL can be #define'd to nullptr (it is on FreeBSD, for example). In this
case, according to the C++ standard, we would be attempting to call
reinterpret_cast to convert nullptr into a pointer, which is forbidden. Just
use static_cast instead.

Change-Id: Ib8a42747e7031ee4df973deddf2b5b1d0f9f5b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545404
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646281}

https://webrtc.googlesource.com/src.git/+log/4cd433ed5f2c..8fcd6537f242


git log 4cd433ed5f2c..8fcd6537f242 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 alessiob@webrtc.org RNN VAD: Replace Ooura with PFFFT for the pitch auto correlation.


Created with:
  gclient setdep -r src/third_party/webrtc@8fcd6537f242

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifae3e9854313013417e2d55fd95c256d14ccb629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547418Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646280}

- Move counter/remover observer related logic from CBDCollectionViewController to CBDManager, so it can be reused by CBDTableViewController.
- Let CBDManager maintains browsing data counters upon construction.
- Let CBDManager be the browsing data remover observer.

Notes:
- A counter gathers info about its corresponding browsing data (history, cache, etc). A counter is constructed with a callback (typically to update UI).
- Two occasions when we want to restarts the counters so to keep UI updated: 1) When a CBD page is shown. 2) When a browsing data is cleared by a remover.

Bug: 935350
Change-Id: Idb060bb8af67f549534df7ad24721ba2a45977f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545407
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646279}

Unless the registry key "mdm_aca" is explicitly set to 1, always
fail sign in of consumer accounts when mdm enrollment is enabled.

Consumer accounts are defined as accounts with gmail.com or
googlemail.com domain.

Bug: 944049
Change-Id: Icb822f3737d90931de16a8d3317616dd2b159edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532903
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646278}

This makes shell UI elements follow the system night mode setting.

Test: Change the system night mode setting and observe UI elements
Bug: 947324
Change-Id: I849674462eac16aab8bcc64206dc8547f20b78c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545289Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646277}

https://chromium.googlesource.com/catapult.git/+log/0359d522b7e2..1ca62263a630


git log 0359d522b7e2..1ca62263a630 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 khokhlov@google.com Write telemetry traces in proto format: standalone verion; changes to existing files


Created with:
  gclient setdep -r src/third_party/catapult@1ca62263a630

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:944418
TBR=sadrul@chromium.org

Change-Id: Ie4338c434065950929f5602bba22dae193ab8b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646276}

Bug: 921006
Change-Id: I152740931412264a669836d13622bde19fce5ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547690Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646275}

Remove the toggle for unified heap. Without this flag there is no way to
run a GC using wrapper tracing anymore.

The removal just sets branches to false and removes immediate unused
code. Followup changes remove the rest of the wrapper tracing
infrastructure.

Bug: 843903, 943097
Change-Id: Id5ef09a7fff3b23c7963007587a78c745e682c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537104Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646274}

This is part of a larger effort to make
SyncableService::WaitUntilReadyToSync() pure and audit all datatypes.

PasswordSyncableService doesn't need to do anything because the
password store is guaranteed to be ready at all times.

This CL was uploaded by git cl split.

Change-Id: I2a13aa9f2a1c99eeb8002c88f83a2bcd7e51c99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545299
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646273}

The codepath is unreachable because we don't exercise it in the
old, directory-based architecture. This datatype hasn't been
integrated into pseudo-USS, so there's no need to implement the
wait.

This CL was uploaded by git cl split.

R=mamir@chromium.org

Change-Id: Iaf25494c7b0bad7d4a2e48670b501c9e2451e9d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545298
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646272}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I1be2ece7dd03a4b23412cd47843eed5fe46ed24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546180Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646271}

With unity, sync settings is replaced by google services settings view.

Bug: 939783
Change-Id: I88b0cffac014569a044642fd30d2baae44b5c409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545389Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646270}

With this change, AccountFetcherService is now constructed only when
creating an IdentityManager, eliminating the need for
AccountFetcherService factories.


Change-Id: I3da6ebb100706998884c5f77adc1a959e6ded1cb
Bug: 939372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538429Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646269}

Fixup URLs before checking them. This catches cases like "example.com",
where we should just add "http://" instead of rejecting them.

BUG=b:112186030,chromium:946485

Change-Id: I4f2e994c197aa69ceb30154f555af9199088cd4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545406
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646268}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b3d9b94e611..dfe4cdc105a9


Created with:
  gclient setdep -r src-internal@dfe4cdc105a9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org

Change-Id: Ifcb6389d5060270b533d77ffb415c86736d8d3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546936Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646267}

Tested on Mac, including with RTL UI. Screenshot attached to associated
bug.

Bug: 947187

Change-Id: I1950b1a3ad5db9f3aff1def140f992ee38236ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544242Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Edin Kadric <edinkadric@google.com>
Cr-Commit-Position: refs/heads/master@{#646266}

The codepath is unreachable because we don't exercise it in the
old, directory-based architecture. This datatype hasn't been
integrated into pseudo-USS, so there's no need to implement the
wait.

This CL was uploaded by git cl split.

R=melandory@chromium.org

Change-Id: Idd75a1dc27d097ea9620a1ea5dc9e6d9952f923f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545391
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646265}

Fix to land: https://webrtc-review.googlesource.com/c/src/+/130493

Bug: chromium:948055
Change-Id: Iba453bd1878fc194dac048fe7378087af120bb20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546303
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646264}

Prior to this CL, constraints processing treated the remote APM the same way
it treated the APM running on the renderer process.
This was incorrect because the audio stream provided by the remote APM has the
the same audio parameters as the underlying microphone/device, while the APM
running on the renderer process always uses channel count 1 and a predefined
sample rate.


Bug: 937294

Change-Id: I2e13514fa45af906658532a088bd158f15ee6ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496998
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646263}

Changes to PluginVm setup flow UI according to the spec provided:
* Layout with proper margin and insets
* Correct fonts
* Correct messages color
* Image of right size

Test: browser_tests --gtest_filter="PluginVm*"
Bug: 931703
Change-Id: Ia9c7d5c81e06e4525938bc5282c79b550cc1fcc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538504
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646262}

Even when there's no box, according to spec change
in https://github.com/w3c/csswg-drafts/issues/1436,
computed value of float with absolulte position should be "none".

Bug: 903275
Change-Id: I7df8eb39eb4c5f22cadbfdbe7a96227eb61a09b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546732Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: hyunjune kim <hyunjune.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#646261}

The test should pass now after crrev.com/c/1407596.

TBR=wjmaclean@chromium.org

Bug: 659750, 918784
Change-Id: Ic71e2524804fd01dc7ee7e93af988465db20c95f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547296Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646260}