- 14 Nov, 2020 37 commits
-
-
Javier Ernesto Flores Robles authored
Fixed: 1143328 Change-Id: I624e23cf4092a58eb61715ba3baa98a3c23186e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534781 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#827521}
-
Jiawei Shao authored
This patch adds the support of forcing enabling and disabling Dawn Toggles through command line parameters "--enable-dawn-features" and "--disable-dawn-features". Each toggles are separated by ",". e.g. --enable-dawn-features=use_d3d12_render_pass,disable_robustness --disable-dawn-features=lazy_clear_resource_on_first_use This patch also removes the support of the command line parameter "--disable-dawn-robustness" as now its functionality can be replaced by "--enable-dawn-features=disable_robustness". BUG=dawn:480 Change-Id: If8c4fcc7d29f83c5c583b285439e4df73e714764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529009Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#827520}
-
Caitlin Fischer authored
Change-Id: I68593bcfa600391e4cccbd26af5d471a2e48dddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533582 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#827519}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07569638a739..01909e016604 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sclittle@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106950,chromium:1138706 Tbr: sclittle@google.com Change-Id: I600c52a209a8d1ed79d0fe444de2a682bf729509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537126Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827518}
-
Garrett Beaty authored
Change-Id: Ic34794a5840051626ca81514c9ccf7bcef74d17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538422 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#827517}
-
Joon Ahn authored
http://screen/BZqwCuid794nPCD Bug: 1125150 Test: browser_tests --gtest_filter=DiagnostisApp* Change-Id: I39737c28cdb4c3f12dddcf31e29823fb15f187df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536931 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827516}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in uievents/order-of-events/focus-events/focus.html. This test now matches major browser implementations that "focus" preceeds "focusin", and "blur" preceeds "focusout". See: https://github.com/w3c/uievents/issues/276. Bug: 1145677 Change-Id: I9e5965c90a18560cce560b73a3df88d0e840473d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519193Reviewed-by:Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#827515}
-
Clark DuVall authored
This reverts commit c7a74ee0. Reason for revert: manifest entries missing for DFMs, see crbug.com/1149022 Original change's description: > Enable isolated splits in canary and dev > > All major crashes have been fixed and numbers look good. M88 branch was > just cut, so should be safe to enable now. > > Bug: 1126301 > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827387} TBR=agrieve@chromium.org,cduvall@chromium.org Change-Id: I44601726754ab4c7d46f35f0d21be9482dd058b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301, 1149022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538519Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827514}
-
Tomasz Wiszkowski authored
This class aligns the naming of the OmniboxSuggestion to match its native counterpart (AutocompleteMatch) and relocates both AutocompleteMatch and AutocompleteResult to the components/omnibox/browser package. The relocation is required so that we can call the java methods (eg. to create or update) from native code without introducing strange build dependency. This is part of the effort to reconcile the suggestion pools. Bug: 1138587 Change-Id: I27c0c991b47b22acca6d2de04e5e20dd34daea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533207 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827513}
-
Dan Harrington authored
We found that the clock exposed by TaskEnvironment differs from base::Time::Now(), leading to confusing results in tests. This CL removes injected clocks, preferring to use base::Time::Now() and base::TimeTicks::Now(). I found that precise time equality was difficult to get for some tests with this approach, so I opted to add a new EXPECT_TIME_EQ macro when testing time values. Change-Id: I554a9075ce8db4950bea1c4ba0f23195ad5b58ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538414 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827512}
-
Daniel Hosseinian authored
Store the GUID as a base::GUID instead of a std::string. Change the constructor of BookmarkNode to take a base::GUID. Modify the code around callers to make them compatible with the new API. BookmarkNode::guid() still returns a std::string(). It will be changed to return a base::GUID() in a follow-up. Bug: 1026195 Change-Id: I7837de1a641bf946065f9eca67f0646ee50ee6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522162Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827511}
-
Darwin Huang authored
Technically it was "whitelsited_url", but definitely still not inclusive. Bug: 842296 Change-Id: I559972553b49e09423f40f59492b9c43f0faa1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538269 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827510}
-
David Bienvenu authored
This is the list of directories excluded from presubmit checks for base::Bind, base::Closure, and base::Callback. Change-Id: I9e169427760a90ed06adb83b32a6a9cadc35bd88 Bug: 1007805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538038Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827509}
-
Thomas Guilbert authored
This CL adds a MediaLog to VideoEncoder and uses it to surface basic properties. For now, it uses the VideoDecoder MediaLog properties to surface encoder name, because changes to the Devtools code would and the creation of new properties would be required to surface it as an encoder. Bug: 1148576 Change-Id: Ib9b0188421b08071672f49aead4cc87bd7d55d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535561Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827508}
-
Liquan (Max) Gu authored
This CL splits CPRService#complete() into the common part and the chrome-specific part and it moves the common part into PRService#complete(). Bug: 1131059 Change-Id: Id861b023078e11da00ae80764d3d51475078d027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535651 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827507}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making USB a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.usb getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I4d13bf6948301b65663a48fd34d4410c9596b21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536387 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#827506}
-
Scott Little authored
Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." This reverts commit 114bc6ab. Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 Original change's description: > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > 4. Set `record_whole_document` to force the whole page to be rendered. > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > Screenshots: > > - Before: https://i.imgur.com/yt6WZRx.png > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > - Patchset #3: > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > * https://imgur.com/MXpgHOl > * https://imgur.com/haxemcr - not aligned with the node. > * https://imgur.com/RbdlYVT > - Patchset #18: > * https://imgur.com/EWUmn0O > * https://imgur.com/DUrQ1yF > * https://imgur.com/cT5oBSi - perfectly aligned. > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > Bug: 1003629 > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > Commit-Queue: Maksim Sadym <sadym@chromium.org> > Auto-Submit: Maksim Sadym <sadym@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827440} TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827505}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be466dc7ac2c..d347b31c0e2e 2020-11-13 alexrudenko@chromium.org Enable TypeScript for toolbox_bootstrap.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I080013fcfc6c41f2c96aa38924631ef01c68d030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827504}
-
Mason Freed authored
This sandbox flag was removed, so this is dead code. Fixed: 1145605 Change-Id: Ibb7fb072f57da918f80644ffc80ae15334b02c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537702 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827503}
-
Christopher Cameron authored
This is towards deleting StaticBitmapImage::CopyToByteArray and other helpers. The function ExtractImageData: - Allocates a temporary surface with SkSurface::MakeRaster. - Draws the image into that surface. - Allocates output ArrayBufferContents. - Make a copy of the SkSurface's contents using SkSurface::makeImageSnapshot. - Copy the aforementioned copy to the output ArrayBufferContents using StaticBitmapImage::CopyToByteArray, which may do some sort of color conversion during the copy. Change the function to: - Allocate output ArrayBufferContents and point a surface directly at those pixels using SkSurface::MakeRasterDirect. - Draw into the pixels, converting to the desired format on the fly. Bug: 1115317 Change-Id: I656c1ed701c7bafade694d7dfad38dbb0bc74564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533289Reviewed-by:
enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#827502}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making Serial a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.serial getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: If8bb50bdb9729b106be20f0ee228233560f09511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537920 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Mohamed Mansour authored
Narrator table with `Ctrl+Alt+(left/right/up/down)` was not supported in Views. According to UIA API, the `GetItem` was not implemented in Chromium. https://docs.microsoft.com/en-us/dotnet/api/system.windows.automation.provider.itableprovider Looking in the Chromium Accessibility Core, that gets translated to the cross-plat `GetTableCell` which requires `GetCellId` to be implemented. In this case the ViewAccessibility's platform node, wasn't. The approach taken was to reuse the existing internal method in `TableView::GetVirtualAccessibilityCell` to get the node id for the AXNode. AX-Relnotes: Cells in TableView are navigable in UIA. Bug: 1148097 Change-Id: I2257862bbe01d15fc7591bfeb9952ca2d8b143c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533837Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827500}
-
Alexey Baskakov authored
Previous cleanup CL: https://chromium-review.googlesource.com/c/chromium/src/+/2520476 - app_type() and app_type_ is always kExtension. - Exclude from_bookmark() extensions. Bug: 1065748 Change-Id: I39301a2537c2e77633ef85067f6bd81f9adacecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522831 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#827499}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605214676-c85e88d2c252aa731add321a6482c347ea572e8a.profdata to chrome-win32-master-1605278951-6acf5f1c81bf8e5b853d44ef9575d8aab067a4b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I80835c86d3b275e178faea1c9655453f3a6a6b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536991Reviewed-by:
-
Michael Thiessen authored
This test is broken and doesn't actually test what it intends to. See bug for details. Bug: 1148855 Change-Id: Ife41243c4beaf992543f817c693151f5821bf5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537136 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Sonny Sasaka authored
To prepare for enabling debug logs by default for Googlers, this shows the debug toggle by default. This does NOT enable the debug logs, but this only shows the debug log toggle which only Googlers can see and toggle the debug log on or off manually. Bug: b:172273364 Change-Id: I01461177fc75d556a5d0786dcd3eb3a5a7325215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536849Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#827496}
-
adoneria authored
CL to add tester to recipe: crrev.com/c/2536808 Bug: 1147595 Change-Id: I4a140af01a025e1455b71b7ac50b834e5f5bf68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538355Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827495}
-
Patrick Noland authored
This puts LocationBarCoordinator in charge of constructing and destroying UrlBarCoordinator, StatusCoordinator, and AutocompleteCoordinator. This allows us to wire a few more dependencies into constructors instead of via setters. The coordinators are still passed to LocationBarLayout for it to use via a new initialize() method that consolidates a few different setter methods on LocationBarLayout. initialize() helps avoid bugs that could arise when calling these setters out of order. There is an additional change to LocationBarLayoutTest that fixes a DCHECK when running tests on a debug build. Bug: 1146057, 1146062 Change-Id: Ie6c7e871d6cb0eb4bbffff0ab3ed275968d84e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495969 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827494}
-
Peter Boström authored
Fixes missing offset for non-zero bounds.x() for the icon area in TabIcon::MaybePaintFavicon. Bug: 1147408 Change-Id: I309c5074ee82c8a4ecc3cd14243c329088fb06a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538207 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#827493}
-
adoneria authored
1. Disable component build for mac builders on CI and try. 2. Enable use of goma for mac and win builders on CI. 3. Enable component build for win builders on try. Bug: 1148920 Change-Id: I690834b4b80812569bff2d8206b775cf05966f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538161Reviewed-by:
-
Sorin Jianu authored
The IDL file is split in three parts: public, internal, and legacy definitions. This is a fairly straightforward change, which consists of suffixing the path to the typelib in the executable file with a //<index> where the index matches one of the there source IDLs above. Further work is needed to properly generate the GUIDs depending on the which IDL the GUIDs belong to. Some of the GUIDs must depend on branding, and some of the GUIDs must depend on branding and version. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2527822 after the following fixes: diff --git a/chrome/updater/test/test_app/update_client_win.cc b/chrome/updater/test/test_app/update_client_win.cc index 13ffa873ce6c..71c8e4c090c6 100644 --- a/chrome/updater/test/test_app/update_client_win.cc +++ b/chrome/updater/test/test_app/update_client_win.cc @@ -28,11 +28,12 @@ #include "chrome/updater/update_service.h" namespace updater { + namespace { HRESULT CreateUpdaterInterface(Microsoft::WRL::ComPtr<IUpdater>* updater) { Microsoft::WRL::ComPtr<IUnknown> server; - HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass), nullptr, + HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass)], nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&server)); if (FAILED(hr)) { diff --git a/chrome/updater/test/test_app/update_client_win.h b/chrome/updater/test/test_app/update_client_win.h index 25e16c53cc09..e5496ec47828 100644 --- a/chrome/updater/test/test_app/update_client_win.h +++ b/chrome/updater/test/test_app/update_client_win.h @@ -10,7 +10,7 @@ #include <windows.h> #include <wrl/client.h> -struct IUpdater; +class IUpdater; namespace base { class SingleThreadTaskRunner; Bug: 1140562 Change-Id: Ibce69536e2816ab089f8851191af052ff7616565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538267Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827491}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e61ccc59a240..fd5c198347e1 2020-11-13 chanli@chromium.org [resultdb] Update rdb version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147548 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia7f7a6de01e7448b1c489c0697c9a2d5791d457d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537105Reviewed-by:
-
Robert Ogden authored
We expect that this duration will either be pretty short, in the case of loadshedding origins, or very long in the case of origins trying to use a 503 response to opt out of prefetches. Since the loadshedding case is not interesting from a product prespective, this histogram is scoped out to a week to catch the latter. Bug: 1146210 Change-Id: Ibeb1488206edbca7c8999a05def7e22d833772a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538133Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#827489}
-
Aleks Totic authored
Few more unit test fixes. Bug: 958381 Change-Id: I902fe45de917b06322e886b02c2b6fe495d08421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536254 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827488}
-
Adam Ettenberger authored
Items in single selection containers that have accessibility focus should get the selected state. Code to mirror focus to selection exists, but the selected state must be refreshed. Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper method in ax_role_properties, ui::IsSelectRequiredOrImplicit and including Role::kTreeItem [1] since the ARIA spec lists aria-selected as a required state. Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl) which provides a mostly conclusive answer for whether an element can support this behavior. During this investigation, I found there was a portion of the spec that was not implemented, so I created a crbug [2] for that. "If any DOM element in the widget is explicitly marked as selected, the user agent MUST NOT convey implicit selection for the widget." Also created a crbug [3] for followup to consider including more selectable roles for this behavior. Currently only roles that require or have an implicit value for aria-selected allow this behavior. It may be desirable to include roles columnheader, rowheader, gridcell and row, but felt that would be out of scope for this CL. [1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem [2]: https://crbug.com/1143451 (Not allowed with explicit selection) [3]: https://crbug.com/1143483 (Consider allowing more roles) AX-Relnotes:Notify the aria-selected state changed for items that have their selected state follow focus, and enable this behavior for role=treeitem elements inside single-selection containers. Bug: 1141579 Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56523dff6983..da1f66c8cee1 2020-11-13 enga@chromium.org Update DepthBiasTests to use WGSL 2020-11-13 enga@chromium.org Update CullingTests to use WGSL 2020-11-13 enga@chromium.org Update ComputeIndirectTests to use WGSL 2020-11-13 enga@chromium.org Update CompressedTextureFormatTests to use WGSL 2020-11-13 enga@chromium.org Update ColorStateTests to use WGSL 2020-11-13 enga@chromium.org Update ClipSpaceTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I69a38afae88fc367ea614a7575e07962f9ca7a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537142Reviewed-by:
-
Robin Lewis authored
Bug: 1148979 Change-Id: I971194186baef5f8a2b82ef8a826f491116a102e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538353 Commit-Queue: Robin Lewis <wrlewis@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#827485}
-
- 13 Nov, 2020 3 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I70d41037f2dfac71976d0156f19d16edb900e0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537102Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I37686da165a4ef9d352e39c25f875e80ee2da77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537934Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827483}
-
Gabriel Charette authored
This was missed in the original implementation because on Windows the pump always processes a native event before DoWork() and hence always kicks off the "ThreadController active" trace event prior to DoWork(). On platforms that don't do this, the tasks nested backwards (and the ends were out of order which messed up the trace layout). Also cover DidRunTask() now to cover microtasks and added extra brackets to make it extra clear what the scope of "things we do to run the task" are. R=altimin@chromium.org Bug: 899897, 1074019 Change-Id: I67a01853365e173ed924513592191d6098a4f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536998 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827482}
-
